Andrew Osmond
54d6f7e0c4
Bug 1258741 - Part 1. Remove dead/unused image decoder aborted flag. r=tnikkel
2016-09-21 07:13:08 -04:00
Andrew Osmond
be96e28a0f
Bug 1308289 - Hold strong reference to VectorImage when dispatching ProgressTracker::SyncNotifyProgress. r=tnikkel
2016-10-13 08:35:55 -04:00
Ehsan Akhgari
75d4b96af8
Bug 1306800 - Remove support for app theming; r=myk,baku
2016-10-13 13:23:03 -04:00
Tim Huang
aeffcdcbe2
Bug 1277803 - Part 3 : Make the image library uses the correct originAttributes and triggering principal when opening a image channel for favicon loading. r=tnikkel
2016-10-13 15:43:57 +08:00
Cameron McCormack
c1f0ee12ba
Bug 1309082 - Part 2: Rename some ImageTracker members. r=bholley
...
MozReview-Commit-ID: 6yOIKKl8npT
--HG--
extra : rebase_source : 247787a0e18640c878e461c4b600bc36a40bad6d
2016-10-13 15:04:19 +08:00
Cameron McCormack
58c32a9088
Bug 1309082 - Part 1: Extract image tracking from nsDocument into a separate, refcounted object. r=bholley
...
This is refcounted as we'll need to hold strong references to the ImageTracker
from style structs that load images.
MozReview-Commit-ID: 994gE9tOjAn
--HG--
extra : rebase_source : 2d50059e51b42251c89a92a954cef7b49720ceba
2016-10-13 15:04:15 +08:00
Wes Kocher
2142de26c1
Backed out 8 changesets (bug 1277803) for browser-chrome test failures a=backout
...
Backed out changeset 477890efdb88 (bug 1277803)
Backed out changeset 49da326bfe68 (bug 1277803)
Backed out changeset 2d17a40a9077 (bug 1277803)
Backed out changeset b1cb0a195ca1 (bug 1277803)
Backed out changeset c7d82459d152 (bug 1277803)
Backed out changeset 3be9a06248af (bug 1277803)
Backed out changeset 8d119ca96999 (bug 1277803)
Backed out changeset be767a6f7ecd (bug 1277803)
2016-10-12 14:26:00 -07:00
Tim Huang
91878c9769
Bug 1277803 - Part 3 : Make the image library uses the correct originAttributes and triggering principal when opening a image channel for favicon loading. r=tnikkel
2016-10-12 17:32:06 +08:00
Nathan Froyd
19607c3802
Bug 1306625 - fix wonky identation in imgFrame.cpp; r=tnikkel
...
DONTBUILD because whitespace-only fixes are always safe...right?
2016-09-30 23:11:59 -04:00
Andrew Osmond
31ad519348
Bug 1275464 - Part 1. Unregister from handling image memory reports when shutting down. r=njn
2016-09-19 13:29:59 -04:00
James Andreou
a47ce92ac2
Bug 1282124 - Remove nsILoadInfo.usePrivateBrowsing and the SEC_FORCE_PRIVATE_BROWSING flag; r=smaug,jryans
2016-09-27 16:56:44 -04:00
Kate McKinley
c57d400961
Bug 1246540 - HSTS Priming Proof of Concept. r=ckerschb, r=mayhemer, r=jld, r=smaug, r=dkeeler, r=jmaher, p=ally
...
HSTS priming changes the order of mixed-content blocking and HSTS
upgrades, and adds a priming request to check if a mixed-content load is
accesible over HTTPS and the server supports upgrading via the
Strict-Transport-Security header.
Every call site that uses AsyncOpen2 passes through the mixed-content
blocker, and has a LoadInfo. If the mixed-content blocker marks the load as
needing HSTS priming, nsHttpChannel will build and send an HSTS priming
request on the same URI with the scheme upgraded to HTTPS. If the server
allows the upgrade, then channel performs an internal redirect to the HTTPS URI,
otherwise use the result of mixed-content blocker to allow or block the
load.
nsISiteSecurityService adds an optional boolean out parameter to
determine if the HSTS state is already cached for negative assertions.
If the host has been probed within the previous 24 hours, no HSTS
priming check will be sent.
MozReview-Commit-ID: ES1JruCtDdX
--HG--
extra : rebase_source : 2ac6c93c49f2862fc0b9e595eb0598cd1ea4bedf
2016-09-27 11:27:00 -04:00
Andrew Osmond
1d4866a48f
Bug 1120279 - Always check if the next frame is available before advancing an animation.
2016-09-21 12:55:26 -04:00
Andrew Osmond
1286146b81
Bug 1303427 - Continue parsing buffered LZW codes in GIFs even if input stream is complete. r=tn
2016-09-19 09:16:28 -04:00
Manish Goregaokar
fe560e754d
Bug 1303920 - Update stylo reftest list; r=heycam
...
MozReview-Commit-ID: 6fKFLbTL2gW
--HG--
extra : rebase_source : bf87e02799dc530b7d26b2040071ecd8213d36df
2016-09-19 20:20:03 +05:30
Manish Goregaokar
63e75ca24b
Bug 1302993 - Mark more expectations for stylo tests, make reftest-stylo green; r=heycam
...
MozReview-Commit-ID: 9rKqASXgKZH
--HG--
extra : rebase_source : ea4d2cdc5623673827676e52d255c8b6fa34f7dd
2016-09-12 19:18:10 +05:30
Shing Lyu
74414dd285
Bug 1302993 - Update some stylo reftest expectations; r=heycam
...
MozReview-Commit-ID: 5UUDlAUfBYP
--HG--
extra : rebase_source : c8aff1382e492bc07c59becc697abfb4f7bd8f95
2016-09-12 11:05:21 +05:30
Phil Ringnalda
c58d0d6900
Merge m-i to m-c, a=merge
2016-09-17 13:44:34 -07:00
Phil Ringnalda
ac5e0632ed
Backed out changeset c0021d576b3a (bug 1120279) for multiple reftest failures
2016-09-17 09:54:25 -07:00
Andrew Osmond
834a37825b
Bug 1120279 - Ensure the animated image state is consistent if redecoding fails or is asynchronous. r=edwin
2016-09-15 15:13:48 -04:00
Nicolas Silva
79bb9f5c0e
Bug 1284837 - Disallow implicit conversions from float to integer when creating. r=botond
2016-09-16 17:49:39 +02:00
Bas Schouten
77e2a32f4a
Bug 1296657: Attempt to create an mOptSurface of the correct type for the DT we're drawing to. r=tnikkel
...
MozReview-Commit-ID: 2LIQWUPAuaF
2016-09-15 13:53:12 +02:00
Carsten "Tomcat" Book
0f2c669a48
merge mozilla-inbound to mozilla-central a=merge
2016-09-09 12:02:43 +02:00
Shing Lyu
db11558e50
Bug 1288350 - Temporary reftest list for Stylo vs Gecko test r=heycam,manishearth
...
--HG--
extra : rebase_source : 4772418bd2813d4e79643a833eb09e47fe893d84
2016-09-05 11:45:39 +08:00
Nicholas Nethercote
3ac8aee67f
Bug 1297300 - Add missing checks to GetSpec() calls in image/. r=tnikkel.
2016-08-29 15:34:32 +10:00
Glenn Randers-Pehrson
d0f907ce9b
Bug 1297907 - Wrap long lines in nsPNGDecoder.cpp. r=tn
...
--HG--
extra : rebase_source : 01aba31d91a42a3afe30ea2ddc21118ae779ef79
2016-09-07 09:03:00 -04:00
Michael Layzell
36e08437d0
Bug 1018486 - Part 8: Various other changes, r=smaug
...
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Glenn Randers-Pehrson
7cd996e732
Bug 1295671 - Detect use of system libpng in nsPNGDecoder.cpp. r=tn
...
--HG--
extra : histedit_source : d6ce06bff319953f2abfa9b3d3acad3386b0a654
2016-08-27 01:23:00 -04:00
cku
5963e84e5a
Bug 1190881 - Part 3. mochitest for svg css animation. r=dholbert
...
MozReview-Commit-ID: JchZk3FrZce
--HG--
extra : rebase_source : 3344b0d77537bf315784a452983b3440c1c385e6
2016-08-25 23:15:04 +08:00
cku
48f9993c70
Bug 1190881 - Part 2. Trigger pending animation for SVG-as-image docs. r=birtles
...
MozReview-Commit-ID: BOrdKoIDCGX
--HG--
extra : rebase_source : 92f41aae5b9f70e5bfd6760f80302e90d148bd93
2016-08-25 22:58:50 +08:00
cku
4395bfbe1c
Bug 1190881 - Part 1. Create and pass a navigation timing object to the wrapped SVG document. r=dholbert
...
MozReview-Commit-ID: DTtTudlJ52d
--HG--
extra : rebase_source : b0a9c8e79e290f51bf433d0f94b1de7db99e933a
2016-09-02 18:53:36 +08:00
Nicholas Nethercote
742fc7eb48
Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley.
...
This function is an infallible alternative to nsIURI::GetSpec(). It's useful
when it's appropriate to handle a GetSpec() failure with a failure string, e.g.
for log/warning/error messages. It allows code like this:
nsAutoCString spec;
uri->GetSpec(spec);
printf("uri: %s", spec.get());
to be changed to this:
printf("uri: %s", uri->GetSpecOrDefault().get());
This introduces a slight behavioural change. Previously, if GetSpec() failed,
an empty string would be used here. Now, "[nsIURI::GetSpec failed]" will be
produced instead. In most cases this failure string will make for a clearer
log/warning/error message than the empty string.
* * *
Bug 1297961 (part 1b) - More GetSpecOrDefault() additions. r=hurley.
I will fold this into part 1 before landing.
--HG--
extra : rebase_source : ddc19a5624354ac098be019ca13cc24b99b80ddc
2016-08-26 16:02:31 +10:00
Nicholas Nethercote
819433bae0
Bug 1299389 - Replace some raw pointers in nsThreadManager. r=froydnj.
...
nsThreadManager::get() can return a reference. This lets us remove some
redundant assertions.
nsThreadArray elements can be NotNull<>s.
--HG--
extra : rebase_source : fd49010167101bc15f7f6d01bf95fd63b81d60fb
2016-06-10 16:04:49 +10:00
Benjamin Smedberg
d5f9ba36f4
Bug 1299545 - stop exporting imgLoader::SupportImageWithMimeType, r=tnikkel
...
MozReview-Commit-ID: CFmUXAGeFIO
--HG--
extra : rebase_source : 9008a537fce0d2d649a00b04b07e9873024edafc
2016-08-30 13:28:16 -04:00
Lee Salzman
642347dba7
Bug 725119 - fuzz for reftests with Skia content on Android. r=mchang
...
MozReview-Commit-ID: 9p8ntO7YLQ4
2016-08-31 15:53:33 -04:00
Seth Fowler
a5b5245612
Bug 1298551 - Respect CachedSurface::SetLocked() even if the underlying ISurfaceProvider is always locked. r=dholbert
2016-08-26 17:03:25 -07:00
Seth Fowler
f8818933fa
Bug 1296828
(Part 3) - Update SurfaceCache API to rely on ImageKeys and SurfaceKeys stored on ISurfaceProviders. r=dholbert
2016-08-26 17:03:19 -07:00
Seth Fowler
f9e85bafb2
Bug 1296828
(Part 2) - Store ImageKeys and SurfaceKeys directly on ISurfaceProviders. r=dholbert,edwin
2016-08-26 17:03:17 -07:00
Seth Fowler
8f4ebfcf90
Bug 1296828
(Part 1) - Use ImageKey consistently in SurfaceCache. r=dholbert
2016-08-26 17:03:15 -07:00
Mason Chang
43e77092c9
Bug 1007702. Enable skia on unaccelerated windows. r=lsalzman
2016-08-25 12:35:41 -07:00
Seth Fowler
fd83d4ee88
Bug 1296762 (Part 3) - Use NotNull for all CachedSurfaces in SurfaceCache. r=dholbert
2016-08-25 11:42:00 -07:00
Seth Fowler
6006fb4945
Bug 1296762 (Part 2) - Forbid null ISurfaceProviders in SurfaceCache. r=dholbert
2016-08-25 11:41:58 -07:00
Seth Fowler
dda03690ef
Bug 1296762 (Part 1) - Remove SurfaceCache::InsertPlaceholder(). r=dholbert
2016-08-25 11:41:57 -07:00
Nicholas Nethercote
c2306345d5
Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
...
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.
The patch also does some associated clean-up.
- Replaces some uses of nsIMemoryReporterCallback with the preferred
nsIHandleReportCallback typedef.
- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
parameter names, for consistency.
- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.
- Uses the MOZ_COLLECT_REPORT macro in all suitable places.
Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.
--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
Kan-Ru Chen
b6d880aca1
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Timothy Nikkel
05dc5b9ede
Bug 1260324. Don't draw garbage to the screen if an image doesn't happen to be decoded. r=seth
...
Layout has been using imgIContainer::IsOpaque to determine if the image will draw opaquely to all pixels it covers, and doing culling based on this.
However imgIContainer::IsOpaque doesn't guarantee anything. It only describes if the image, when in a decoded state, has all opaque pixels. So if the image doesn't have fully decoded frames around (because they got discarded) it may not draw opaquely to all of its pixels.
So we create a new function that first checks if there is a fully decoded frame.
2016-08-22 21:15:38 -05:00
Phil Ringnalda
62d1bf1089
Merge m-c to a CLOSED TREE m-i
2016-08-23 22:57:10 -07:00
Wes Kocher
3de1ea925a
Backed out changeset 54933b5b96f1 (bug 1260324) for frequent windows reftest failures a=backout CLOSED TREE
2016-08-23 13:50:14 -07:00
Timothy Nikkel
9e89a17b91
Bug 1260324. Don't draw garbage to the screen if an image doesn't happen to be decoded. r=seth
...
Layout has been using imgIContainer::IsOpaque to determine if the image will draw opaquely to all pixels it covers, and doing culling based on this.
However imgIContainer::IsOpaque doesn't guarantee anything. It only describes if the image, when in a decoded state, has all opaque pixels. So if the image doesn't have fully decoded frames around (because they got discarded) it may not draw opaquely to all of its pixels.
So we create a new function that first checks if there is a fully decoded frame.
2016-08-22 21:15:38 -05:00
GuanWen-Chen
2b403c0acf
Bug 1264809 - (Part 4) Add comment for FLAG_FORCE_UNIFORM_SCALING. r=dholbert
2016-08-22 05:04:00 -04:00
Seth Fowler
90008b4d20
Bug 1293472
(Part 4) - Test that single-frame and animated decodes can coexist for the same image. r=edwin
2016-08-18 15:42:49 -07:00
Seth Fowler
1f92f3a7b9
Bug 1293472
(Part 3) - Store animated images in the surface cache as a sequence of frames, rather than each frame getting its own cache entry. r=dholbert,edwin,njn
2016-08-18 15:42:48 -07:00
Seth Fowler
367e148297
Bug 1293472
(Part 2) - Add AnimationSurfaceProvider. r=dholbert,edwin
2016-08-18 15:39:43 -07:00
Seth Fowler
aef6675e11
Bug 1293472
(Part 1) - Make it possible to seek DecodedSurfaces. r=dholbert
2016-08-18 15:39:40 -07:00
Seth Fowler
ad816b4313
Bug 1296172 - Make VectorImage's interaction with the surface cache cleaner. r=dholbert
2016-08-18 13:03:51 -07:00
Seth Fowler
2977081713
Bug 1296147 (Part 2) - Rename imgFrame::GetSurface() to imgFrame::GetSourceSurface() for clarity. r=edwin
2016-08-18 13:03:49 -07:00
Seth Fowler
8d183cc877
Bug 1296147 (Part 1) - Add a DrawableSurface smart pointer type to allow lazy surface generation. r=dholbert,edwin
2016-08-18 13:03:44 -07:00
Andrew Osmond
e80df3e463
Bug 1293577 - Part 2. Add mutex to MetadataDecodingTask to protect from decoding races. r=seth
2016-08-18 10:23:42 -04:00
Dragana Damjanovic
67635a6600
Bug 1295636 - SetHostPort should reset the port if the host parameter does not have a port number. r=valentin, r=smaug
...
--HG--
extra : rebase_source : 2e63afd5708c55810206f9bc47b6f078a0824400
2016-08-17 23:25:00 -04:00
Seth Fowler
e527c3b511
Bug 1295506 - Don't yield hidden frames in the PNG decoder. r=edwin
2016-08-17 22:19:42 -07:00
Timothy Nikkel
d7a0b010ae
Backed out changeset 37340346a89e (Bug 1289628 - Return ISurfaceProvider objects from SurfaceCache lookup functions. r=dholbert,edwin) for causing bug 1292290.
2016-08-15 19:58:35 -05:00
Seth Fowler
21f89abe61
Bug 1293449 - Stop exposing SurfaceCache implementation code outside of ImageLib. r=dholbert
2016-08-15 18:19:39 -07:00
Seth Fowler
7a29534fe8
Bug 1293794 - Allow imgFrame volatile buffers to be freed on all platforms. r=jrmuizel
2016-08-15 17:42:30 -07:00
Wes Kocher
d602abb016
Merge inbound to central, a=merge
2016-08-15 14:20:38 -07:00
Igor
175543fda8
Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj
2016-08-14 23:43:21 -07:00
Igor
a57972337d
Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj
2016-08-14 23:44:00 -07:00
Ryan Hunt
92206266e3
Bug 1294586 - Remove dependency on gfxPlatform from CreateDrawTargetFromData. r=dvander
...
MozReview-Commit-ID: A355fBJKWP6
--HG--
extra : rebase_source : 85ffd4b9d5f9708a1666bbc8e229ba576cc97680
2016-08-11 14:54:08 -07:00
Nicholas Nethercote
3b0485fcdb
Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj.
...
Slightly less than half (93 / 210) of the NS_METHOD instances in the codebase
are because of the use of NS_CALLBACK in
nsI{Input,Output,UnicharInput},Stream.idl. The use of __stdcall on Win32 isn't
important for these callbacks because they are only used as arguments to
[noscript] methods.
This patch converts them to vanilla |nsresult| functions. It increases the size
of xul.dll by about ~600 bytes, which is about 0.001%.
--HG--
extra : rebase_source : c15d85298e0975fd030cd8f8f8e54501f453959b
2016-08-12 17:36:22 +10:00
Glenn Randers-Pehrson
dc0ab41166
Bug 1288588 - Exit on bad CRC in fcTL or fdAT chunk in an APNG file. r=jrmuizel
2016-08-12 21:31:31 -04:00
Christoph Kerschbaumer
045a838e10
Bug 1292869 - Fix null deref in imgRequestProxy::GetImagePrincipal. r=jmuizelaar
2016-08-10 10:12:30 +02:00
Marcos Caceres
4b42312a6f
Bug 1160200 - APNG can't be used with type switching. r=mcaceres, r=jrmuizel, r=johns
2016-08-09 22:15:00 +02:00
Andrew Osmond
9d456f9fe3
Bug 1293577 - Protect the image decoding task path with a mutex to avoid race conditions. r=seth
2016-08-10 07:35:07 -04:00
Nicholas Nethercote
e7f10a07fd
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Seth Fowler
ba8bb5de9d
Bug 1292747 (Part 3) - Clean up some comments in imgFrame related to Optimize()'s behavior. r=edwin
2016-08-08 16:25:50 -07:00
Seth Fowler
ad2f26e773
Bug 1292747 (Part 2) - Remove the 565 optimization from imgFrame. r=edwin
2016-08-08 16:25:48 -07:00
Seth Fowler
55d13bdddf
Bug 1292747 (Part 1) - Remove 565 optimization telemetry. r=edwin
2016-08-08 16:25:46 -07:00
Jonathan Hao
ea61afe035
Bug 1270680 - Part 1: Double-key the image cache by origin attribute. r=jdm
2016-08-04 20:22:00 +02:00
Seth Fowler
ec7c520520
Bug 1291071 (Part 6) - Stop passing a decoder to FinalizeDecoder() and rename it NotifyDecodeComplete(). r=edwin
2016-08-05 18:50:32 -07:00
Seth Fowler
0403b4baba
Bug 1291071 (Part 5) - Pass the decoder's final status explicitly to FinalizeDecoder(). r=edwin
2016-08-05 18:50:31 -07:00
Seth Fowler
98a9fd7db6
Bug 1291071 (Part 4) - Clean up Decoder::SpeedHistogram() and related code. r=edwin
2016-08-05 18:50:29 -07:00
Seth Fowler
baf4983cd8
Bug 1291071 (Part 3) - Pass telemetry explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:27 -07:00
Seth Fowler
e3510bdeff
Bug 1291071 (Part 2) - Pass decoder progress explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:25 -07:00
Seth Fowler
b765419db3
Bug 1291071 (Part 1) - Pass ImageMetadata explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:24 -07:00
Seth Fowler
5eeda4dad6
Bug 1291071 (Part 1) - Move an assertion from RasterImage::FinalizeDecoder() to IDecodingTask::NotifyDecodeComplete(). r=edwin
2016-08-05 18:50:22 -07:00
Seth Fowler
f5495f0fd1
Bug 1291045 (Part 7) - Replace DecodingTask with DecodedSurfaceProvider. r=dholbert,edwin
2016-08-05 18:46:24 -07:00
Seth Fowler
1cd0225e12
Bug 1291045 (Part 6) - Add DecodedSurfaceProvider to handle both decoding and surface ownership for single-frame images. r=dholbert,edwin
2016-08-05 18:46:22 -07:00
Seth Fowler
1324b84fef
Bug 1291045 (Part 5) - Expose the IDecodingTask notification helpers for use in other files. r=edwin
2016-08-05 18:46:19 -07:00
Seth Fowler
981466ae1a
Bug 1291045 (Part 4) - Remove IDecodingTask::GetDecoder(). r=edwin
2016-08-05 18:46:16 -07:00
Seth Fowler
694b00bcd2
Bug 1291045 (Part 3) - Handle interactions with the SurfaceCache in DecodingTask. r=dholbert,edwin
2016-08-05 18:46:13 -07:00
Seth Fowler
ba6bdbca1c
Bug 1291045 (Part 2) - Pass the image into NotifyProgress() and NotifyDecodeComplete() explicitly. r=edwin
2016-08-05 18:46:12 -07:00
Seth Fowler
a604246bfc
Bug 1291045 (Part 1) - Use a different IDecodingTask for animated images. r=dholbert,edwin
2016-08-05 18:46:10 -07:00
Daniel Holbert
2e355bc011
Bug 1292632 part 3: Include <algorithm> in image/SourceBuffer.h, to provide std::min. r=seth
...
MozReview-Commit-ID: DJvb7Sz4efF
2016-08-05 17:09:48 -07:00
Daniel Holbert
19d78aab9b
Bug 1292632 part 2: Add missing "using" decl for IntRect in IDecodingTask.cpp. r=seth
...
MozReview-Commit-ID: 6OeckqKu7k7
2016-08-05 17:09:47 -07:00
Daniel Holbert
ac90698e93
Bug 1292632 part 1: Remove a stale/unused #include from SurfaceCache.cpp. r=seth
...
MozReview-Commit-ID: feZgLQ1R7u
2016-08-05 17:09:45 -07:00
Seth Fowler
cf5f340405
Bug 1292505 (Followup) - Add an assert that we don't create a decoder for an ICO resource during a metadata decode. r=me
2016-08-05 15:04:20 -07:00
Seth Fowler
19dc4aba32
Bug 1292505 (Part 2) - Remove remaining references to Downscaler in the SurfacePipe decoders. r=edwin
2016-08-05 13:44:52 -07:00
Seth Fowler
6a44833af8
Bug 1292505 (Part 1c) - Use ExplicitOutputSize() instead of Downscaler::TargetSize() in nsICODecoder. r=edwin
2016-08-05 13:44:48 -07:00
Seth Fowler
1e04c585b2
Bug 1292505 (Part 1b) - Update DecoderFactory to use SetOutputSize(), and propagate the changes to RasterImage. r=edwin
2016-08-05 13:44:46 -07:00
Seth Fowler
f2c6e25053
Bug 1292505 (Part 1a) - Replace Decoder::SetTargetSize() with Decoder::SetOutputSize(). r=edwin
2016-08-05 13:44:44 -07:00
Igor
4efade90d4
Bug 1197331 - remove PR_snprintf calls in miscellaneous directories. r=nfroyd
...
--HG--
extra : rebase_source : a19f77db06e68bd3d69faf56b8bbdc1825f13249
2016-08-04 16:41:00 +02:00
Yoshi Huang
a520e75a4d
Bug 1264231 - Part 3: remove loadInfo work-around. r=sicking
2016-08-05 19:44:57 +08:00
Seth Fowler
2b78b14657
Bug 1291033 (Part 2) - Ensure atomicity of ISurfaceProvider locking changes. r=dholbert
2016-08-04 18:47:43 -07:00
Seth Fowler
df8d9955b6
Bug 1291033 (Part 1) - Ensure atomicity of ISurfaceProvider availability changes. r=dholbert
2016-08-04 18:47:41 -07:00
Carsten "Tomcat" Book
389a3e0817
merge mozilla-inbound to mozilla-central a=merge
...
--HG--
rename : mobile/android/base/java/org/mozilla/gecko/GeckoAppShell.java => mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
rename : mobile/android/base/java/org/mozilla/gecko/gfx/GeckoLayerClient.java => mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoLayerClient.java
rename : mobile/android/base/java/org/mozilla/gecko/gfx/LayerRenderer.java => mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/LayerRenderer.java
rename : mobile/android/base/java/org/mozilla/gecko/gfx/PanningPerfAPI.java => mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/PanningPerfAPI.java
2016-08-04 15:55:50 +02:00
Alexandre Lissy
0af5b943b6
Bug 1284674 - Remove NUWA r=cyu
...
MozReview-Commit-ID: GyMRNzOBKw6
--HG--
extra : rebase_source : 293af1cd55f2035ce6a99f4ebf144059c32a2b8f
2016-08-02 14:54:00 +02:00
Seth Fowler
9f0a5862e4
Bug 1291059 - Yield in the GIF decoder at the beginning of a new frame, not at the end of the previous frame. r=edwin
2016-08-02 04:10:59 -07:00
Seth Fowler
bef1e68a73
Bug 1291054 (Part 5) - Remove Decoder::AllocateBasicFrame(), which is dead code. r=edwin
2016-08-02 04:10:56 -07:00
Seth Fowler
6ce660afb2
Bug 1291054 (Part 4) - Add Decoder convenience methods for the common case of frame rects that cover the whole image. r=edwin
2016-08-02 04:10:52 -07:00
Seth Fowler
3cca5ff418
Bug 1291054 (Part 3) - Rename Decoder::GetSize() to Decoder::Size() to be consistent with the style guide. r=edwin
2016-08-02 04:10:51 -07:00
Seth Fowler
881c87ebec
Bug 1291054 (Part 2) - Add a Decoder::OutputSize() getter and use it in the decoders. r=edwin
2016-08-02 04:10:49 -07:00
Seth Fowler
1d1a71d4bc
Bug 1291054 (Part 1) - Clean up Decoder's size getters a little bit. r=edwin
2016-08-02 04:10:47 -07:00
Glenn Randers-Pehrson
a5af07b18b
Bug 1240665 - Log all error returns from the PNG decoder. r=tnikkel
...
--HG--
extra : rebase_source : 373eef390fe03a2559e336539ddc6a546d6ec2d7
2016-07-29 05:11:00 +02:00
Seth Fowler
2799864a33
Bug 1290682 (Part 3) - Remove RasterImage::CopyFrame(). r=edwin
2016-08-01 17:51:20 -07:00
Seth Fowler
f09a1b3d95
Bug 1290682 (Part 2) - Clean up imgFrame::Draw() and related code now that we know no non-trivial frame rects will occur. r=edwin
2016-08-01 17:51:18 -07:00
Seth Fowler
94cd474a67
Bug 1290682 (Part 1) - Explicitly forbid non-trivial frame rects in imgFrame::Draw() except for paletted frames. r=edwin
2016-08-01 17:51:16 -07:00
Seth Fowler
e36fc95869
Bug 1290681 (Part 2) - Remove the single color optimization from imgFrame. r=edwin
2016-08-01 17:51:13 -07:00
Seth Fowler
b704f1ab3d
Bug 1290681 (Part 1) - Remove telemetry for the single color optimization. r=edwin
2016-08-01 17:51:11 -07:00
Seth Fowler
4d73b5b868
(No bug) - Improve comment in IDecodingTask.cpp. r=me
2016-08-01 17:51:04 -07:00
Seth Fowler
16cff1aefa
Bug 1290759 - Convert frame number check in Decoder::AllocateFrame() into an assert. r=edwin
2016-08-01 17:40:05 -07:00
Seth Fowler
9371310b88
Bug 1290747 - Fix bad assert in RasterImage::NotifyProgress(). r=edwin
2016-08-01 17:40:03 -07:00
Glenn Randers-Pehrson
e2b623ebe9
Bug 1283961 - Part 2: Remove limits on PNG image dimensions (nsPNGDecoder). r=seth
...
--HG--
extra : rebase_source : 8c138a12011233e320d4e55e95348c4c961b95b6
2016-07-28 07:37:00 -04:00
Seth Fowler
97b4a5d8c7
Bug 1289957 (Part 2) - Notify RasterImage about new frames in NotifyProgress() and remove OnAddedFrame(). r=edwin
2016-07-28 00:12:50 -07:00
Seth Fowler
eb5bac10fc
Bug 1289957 (Part 1) - Fix minor style issues in RasterImage::NotifyProgress. r=edwin
2016-07-28 00:12:49 -07:00
Andrew Osmond
0dc52b5140
Bug 1283462 - Fix race condition when notifying on image decoding progress. r=seth
2016-07-22 11:04:09 -04:00
Seth Fowler
77c1dbccdb
Bug 1289628 - Return ISurfaceProvider objects from SurfaceCache lookup functions. r=dholbert,edwin
2016-07-27 13:54:23 -07:00
Gijs Kruitbosch
61094e5a36
Bug 1280584 - implement cloneWithNewRef and thereby make hash/ref links use a simple unified codepath in the IO service, r=valentin
...
MozReview-Commit-ID: 8FIyclkJPDp
--HG--
extra : rebase_source : 49fb2b12488bd57a5417c7c3bff2211d651c5de7
extra : amend_source : d9940a1d9009930dc2f499417a7e1446d4601c20
2016-07-26 23:38:46 +01:00
Nicolas Silva
48805c9b3e
Bug 1284837 - Disallow implicit conversions from float to integer when creating IntPoint and IntSize objects. r=botond
2016-07-26 16:48:30 +02:00
Carsten "Tomcat" Book
336105a0de
merge mozilla-inbound to mozilla-central a=merge
2016-07-22 11:58:02 +02:00
Seth Fowler
0f56cc072c
(No bug) - Fix a trivial formatting issue in ImageMetadata.h. r=me
2016-07-21 16:42:29 -07:00
Tom Tromey
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson
b175c9fdd5
Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo
2016-07-20 22:03:25 -07:00
Seth Fowler
dc9bddc5cd
Bug 1288040 (Part 12) - Use Moz2D types in FrameAnimator code. r=edwin
2016-07-20 16:30:44 -07:00
Seth Fowler
8bb93146a8
Bug 1288040 (Part 11) - Clean up RefreshResult. r=edwin
2016-07-20 16:30:41 -07:00
Seth Fowler
3e8d8d790f
Bug 1288040 (Part 10) - Determine the first frame refresh area of animated images while decoding them. r=edwin
2016-07-20 16:30:39 -07:00
Seth Fowler
642c28d837
Bug 1288040 (Part 9) - Determine the loop length of animated images while decoding them. r=edwin
2016-07-20 16:30:36 -07:00
Seth Fowler
049339870a
Bug 1288040 (Part 8) - Return a FrameTimeout value from FrameAnimator::GetSingleLoopTime(). r=edwin
2016-07-20 16:30:34 -07:00
Seth Fowler
930f26424f
Bug 1288040 (Part 7) - Make FrameAnimator::GetTimeoutForFrame() a private method that doesn't rely on AnimationState. r=edwin
2016-07-20 16:30:32 -07:00
Seth Fowler
aa9b084d09
Bug 1288040 (Part 6) - Don't call GetTimeoutForFrame() in RasterImage. r=edwin
2016-07-20 16:30:30 -07:00
Seth Fowler
78ccdc2e84
Bug 1288040 (Part 5) - Wrap frame timeout values in a FrameTimeout type that ensures they're normalized. r=edwin
2016-07-20 16:30:28 -07:00
Seth Fowler
fc0b1f8b27
Bug 1288040 (Part 4) - We only need to check for infinitely long frames in StartAnimation() for the first frame. r=edwin
2016-07-20 16:30:26 -07:00
Seth Fowler
4306ec9de5
Bug 1288040 (Part 3) - Get rid of RefreshResult.error, a field which nothing cares about. r=edwin
2016-07-20 16:30:24 -07:00
Seth Fowler
4af805ced1
Bug 1288040 (Part 2) - Don't reset the last composited frame index when we reset animation. r=edwin
2016-07-20 16:30:21 -07:00
Seth Fowler
34caf5552c
Bug 1288040 (Part 1) - Separate FrameAnimator's state into a separate class, AnimationState. r=edwin
2016-07-20 16:30:19 -07:00
Seth Fowler
a0b0263e26
Bug 1287691 (Part 4) - Leave notifying decoding progress for each frame to DecodingTask. r=edwin
2016-07-20 02:30:39 -07:00
Seth Fowler
62bf80f260
Bug 1287691 (Part 3) - Yield after each frame in the PNG decoder. r=edwin
2016-07-20 02:30:37 -07:00
Seth Fowler
6d790d3506
Bug 1287691 (Part 2) - Yield after each frame in the GIF decoder. r=edwin
2016-07-20 02:30:35 -07:00
Seth Fowler
7edd4cdb0d
Bug 1287691 (Part 1) - Expose yielding to decoding tasks. r=edwin
2016-07-20 02:30:33 -07:00
Makoto Kato
1cb4228397
Backed out 4 changesets (bug 1287691) due to Windows build failure
...
MozReview-Commit-ID: KgV3nU9a64F
2016-07-20 11:03:59 +09:00
Seth Fowler
c4e69d01bb
Bug 1287691 (Part 4) - Leave notifying decoding progress for each frame to DecodingTask. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
78f3ee9ee6
Bug 1287691 (Part 3) - Yield after each frame in the PNG decoder. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
014dc44721
Bug 1287691 (Part 2) - Yield after each frame in the GIF decoder. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
966d0547b7
Bug 1287691 (Part 1) - Expose yielding to decoding tasks. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
666fc943cb
Bug 1287367 - Allow users of StreamingLexer to detect and handle truncation. r=njn
2016-07-18 23:41:20 -07:00
Seth Fowler
b4d3a89f33
Bug 1287246 (Part 5) - Add GTests for StreamingLexer's support for yielding. r=njn
2016-07-18 01:25:45 -07:00
Seth Fowler
fabd6521fe
Bug 1287246 (Part 4) - Make the data checking in TestStreamingLexer more discerning. r=njn
2016-07-18 01:25:43 -07:00
Seth Fowler
d2fa2b335c
Bug 1287246 (Part 3) - Add support for yielding to StreamingLexer. r=njn
2016-07-18 01:25:41 -07:00
Seth Fowler
f5ecac110e
Bug 1287246 (Part 2) - Store the state for unbuffered reads in a separate structure in StreamingLexer. r=njn
2016-07-18 01:25:39 -07:00
Seth Fowler
938a963f7f
Bug 1287246 (Part 1) - Expose LexerResult from the StreamingLexer API and add an explicit Yield type. r=njn
2016-07-18 01:25:37 -07:00
Seth Fowler
342a16f1a3
Bug 1284031 (Part 3) - Remove the FromSourceBuffer suffix from StreamingLexer test names. r=njn
2016-07-16 00:37:06 -07:00
Seth Fowler
71a5e7a304
Bug 1284031 (Part 2) - Add new StreamingLexer tests for zero-length states. r=njn
2016-07-16 00:37:04 -07:00
Seth Fowler
269c03d80e
Bug 1284031 (Part 1) - Advance SourceBufferIterator in Lex() per-state. r=njn
2016-07-16 00:37:02 -07:00
Seth Fowler
6fbb8890f0
Bug 1286161 (Part 2) - Add a GTest suite for SourceBuffer. r=edwin
2016-07-16 00:37:00 -07:00
Seth Fowler
6b52f4548a
Bug 1286161 (Part 1) - Expose SourceBuffer and SurfaceCache constants which are useful for testing. r=edwin
2016-07-16 00:36:58 -07:00
Seth Fowler
af70a29095
Bug 1286175 - Allow SourceBufferIterator users to specify how many bytes to advance. r=edwin
2016-07-16 00:36:56 -07:00
Seth Fowler
8e2ea1af00
Bug 1286165 (Part 3) - Add StreamingLexer tests for the SourceBufferIterator version of Lex(). r=njn
2016-07-15 17:48:57 -07:00
Seth Fowler
4c2a4667a7
Bug 1286165 (Part 2) - Advance decoders' SourceBufferIterator directly in StreamingLexer. r=edwin,njn
2016-07-15 17:48:57 -07:00
Seth Fowler
d1bd597704
Bug 1286165 (Part 1) - Allow advancing a SourceBufferIterator without an IResumable. r=edwin
2016-07-15 17:48:57 -07:00
Seth Fowler
da8a36ae22
Bug 1286170 - Handle move-assignment of SourceBufferIterators correctly. r=edwin
2016-07-15 17:48:57 -07:00
Seth Fowler
a92a8b9e06
Bug 1286168 - Add a RAII class to initialize ImageLib services in GTests. r=njn
2016-07-15 17:48:57 -07:00
Seth Fowler
4be29e46b3
Bug 1285867 (Part 7) - Clean up remaining references to decoder 'data errors' and refer to them as just 'errors'. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
905634be2b
Bug 1285867 (Part 6) - Record Decoder telemetry outside of the loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
063f83b278
Bug 1285867 (Part 5) - Replace Decoder::mDataDone with Decoder::mReachedTerminalState. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
396c016b13
Bug 1285867 (Part 4) - Decide whether we're done decoding by checking if we've reached a terminal state. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
b1af28a2d7
Bug 1285867 (Part 3f) - Only call PostDataError() outside the loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
0d49568090
Bug 1285867 (Part 3e) - Use TerminalState to exit the Decode() loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
87c5e4a570
Bug 1285867 (Part 3d) - Rely on TerminalState to decide when to post errors inside the loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
1204600670
Bug 1285867 (Part 3c) - Replace the Decode() |while| loop with a |do| loop. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
e8aa76cc0d
Bug 1285867 (Part 3b) - Replace the series of |if| statements in the Decode() loop with a |switch|. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
f5b3f999dd
Bug 1285867 (Part 3a) - Don't attempt to keep decoding if we're already done. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
0872ad00cb
Bug 1285867 (Part 2) - Don't call Decoder::PostDataError() from Decoder subclasses. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
3c38000891
Bug 1285867 (Part 1) - Remove Decoder's notion of decoder errors. r=edwin
2016-07-15 16:41:11 -07:00
Chris H-C
c12eb572dd
Bug 1285006 - Remove IMAGE_MAX_DECODE_COUNT Telemetry r=gfritzsche, seth
...
It clears a histogram on the child process which is no longer allowed
(see bug 1218576)
MozReview-Commit-ID: GXWN7qpalAc
2016-07-13 11:53:00 +02:00
Lee Salzman
16ca3223d9
Bug 1286317 - part 1 - remove Qt widget usage from gfx. r=jrmuizel
2016-07-12 20:27:57 -04:00
Seth Fowler
ddf805118b
No bug - Add an NS_WARNING to report when we hit the SurfaceCache-size heuristic limit for SourceBuffer. r=me DONTBUILD
2016-07-12 00:31:59 -07:00
Seth Fowler
bd9732ac1b
Bug 1285865 (Part 6) - Pass a SourceBufferIterator to Decoder::DoDecode(). r=edwin
2016-07-11 12:13:13 -07:00
Seth Fowler
e80fff4085
Bug 1285865 (Part 5) - Return a Maybe<TerminalState> from Decoder::DoDecode(). r=edwin
2016-07-11 12:13:11 -07:00
Seth Fowler
a9f24e8308
Bug 1285865 (Part 4) - Rename Decoder::WriteInternal() to Decoder::DoDecode() and fix its argument types. r=edwin
2016-07-11 12:13:09 -07:00
Seth Fowler
9ef391acb2
Bug 1285865 (Part 3) - Inline Decoder::Write() into Decoder::Decode(). r=edwin
2016-07-11 12:13:07 -07:00
Seth Fowler
b9c1cec011
Bug 1285865 (Part 2) - Add a RAII class to record decoder telemetry. r=edwin
2016-07-11 12:13:05 -07:00
Seth Fowler
a50b8d5f3e
Bug 1285865 (Part 1) - Remove Decoder::Write() checks that are redundant with Decoder::Decode(). r=edwin
2016-07-11 12:13:02 -07:00
Seth Fowler
e4439cf3bc
Bug 1185799 (Part 3) - Make nsICODecoder use only the public Decoder interface for writing to its contained decoder. r=edwin
2016-07-07 15:50:49 -07:00
Seth Fowler
d6de2d01f5
Bug 1185799 (Part 2) - Make nsBMPDecoder and nsPNGDecoder no longer friends with nsICODecoder. r=edwin
2016-07-07 15:50:46 -07:00
Seth Fowler
6361b2adb8
Bug 1185799 (Part 1) - Use DecoderFactory to construct nsICODecoder's contained decoder. r=edwin
2016-07-07 15:50:44 -07:00
Seth Fowler
b06ccacbf4
Bug 1284032 - Fix an assertion in SourceBuffer::Compact() when we have non-zero capacity but zero length. r=edwin
2016-07-07 15:50:42 -07:00
Benjamin Smedberg
bf05496a83
Bug 1282866 - remove widget/qt and other supporting QT code, r=dougt. This patch does not remove all of the checks for MOZ_WIDGET_QT (which are dead code), but that will be a followup mentored bug.
...
MozReview-Commit-ID: EGqHHhCD7vD
--HG--
extra : rebase_source : a4b9593959dd3ba80189db47eabb056ea207490f
extra : amend_source : a744d833693f0fe7adbea961c00bb5fb55a91580
2016-07-07 12:14:25 -04:00
Kevin Chen
f90480e301
Bug 1264809 - (Part 2) Preserve scale ratio if SVG dosen't have viewport size and viewBox. r=dholbert
2016-07-01 02:27:00 +02:00
Seth Fowler
8220b27059
Bug 1282354 - Move code for SurfaceCache placeholder insertion from RasterImage to DecoderFactory. r=dholbert
2016-07-02 18:47:49 -06:00
Seth Fowler
d7bb652cf1
Bug 1283967 - Remove unused function SurfaceCache::RemoveEntry(). r=dholbert
2016-07-02 18:47:47 -06:00
Seth Fowler
86430c09c8
Bug 1282327 (Part 2) - Update SurfaceCache documentation and method names to reflect the fact that cache entries are now ISurfaceProviders. r=dholbert
2016-07-02 18:47:45 -06:00