09996cc685
Bug 1709067 - CACHE: Remove module specific QM_TRY macros; r=dom-storage-reviewers,jstutte
...
Depends on D114080
Differential Revision: https://phabricator.services.mozilla.com/D114081
2021-05-03 19:44:39 +00:00
fbf7a1dad4
Bug 1686191 - Remove module argument from LogError. r=dom-workers-and-storage-reviewers,janv
...
The module argument in LogError is redundant: the module information can
already be determined from the source file path. Indeed, reporting the module
separately in the telemetry events seems unnecessary. Instead, the relative
path is now reported. This is what the analysis of the telemetry data did
reconstruct anyway.
As a consequence, it's no longer necessary to define module-specific
HandleError functions, and therefore it's also unnecessary to define
module-specific TRY macros. These are retained as simple aliases for now,
but can be removed in a later patch entirely.
This also avoids misuses of a TRY macros in the wrong module, which were
happening a few times before, resulting in confusing output or telemetry
events.
Since Bug 1686191 will add some more TRY macro variants that warn, so
simplifying the module-specific aspects will simplify that task. Furthermore,
this is in preparation of moving the TRY macro extensions to MFBT.
Differential Revision: https://phabricator.services.mozilla.com/D102767
2021-03-12 15:01:21 +00:00
976d8082ca
Bug 1671118 - Rename remaining QM_TRY_VAR occurrences to QM_TRY_ASSIGN/QM_TRY_UNWRAP/QM_TRY_INSPECT (including quota client equivalents); r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D93477
2020-10-14 12:14:14 +00:00
a1b49eac52
Bug 1671109 - Remove QM_DEBUG_TRY/QM_DEBUG_TRY_UNWRAP/QM_DEBUG_TRY_RETURN/QM_DEBUG_FAIL macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D93474
2020-10-14 10:01:20 +00:00
20a9b720d4
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-02 13:23:49 +00:00
ae5e3a0d7c
Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
...
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
8598a731fc
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 15:37:50 +00:00
104db9798f
Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
...
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
4c5b983d6f
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 12:02:26 +00:00
c711008a61
Bug 1666219 - Introduce QM_TRY_INSPECT to avoid unwrapping Result objects where not necessary. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90843
2020-09-29 10:57:14 +00:00
f0debef582
Bug 1663565 - Introduce QM_TRY_RETURN/QM_TRY_DEBUG_RETURN macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D89413
2020-09-17 14:01:01 +00:00
b26988fef6
Bug 1664412 - Mark some error handling functions as MOZ_COLD. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D89885
2020-09-14 12:14:17 +00:00
ec62d45a35
Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv
...
Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.
Differential Revision: https://phabricator.services.mozilla.com/D89148
2020-09-08 07:40:30 +00:00
ffb37d08c1
Bug 1660751 - Make HandleError function MOZ_NEVER_INLINE. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D89147
2020-09-02 15:03:06 +00:00
7e31de8547
Bug 1662004 - Add support for nested QM_TRY/QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88764
2020-09-07 18:00:00 +00:00
16aa57011b
Bug 1661988 - Introduce QM_DEBUG_TRY/QM_DEBUG_TRY_VAR/QM_DEBUG_FAIL macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88760
2020-09-07 10:05:13 +00:00
f2f47372af
Bug 1659959 - Introduce QM_FAIL macro and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87633
2020-08-27 11:10:10 +00:00
e2d6a2c2b3
Bug 1651016 - Introduce CACHE_TRY and CACHE_TRY_VAR macros; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D84316
2020-07-24 11:47:17 +00:00
Jan Varga
Simon Giesecke
Sebastian Hengst
Bogdan Tara