Граф коммитов

8373 Коммитов

Автор SHA1 Сообщение Дата
Simon Giesecke 3fef818588 Bug 1645339 - Use range-based for with nsTObserverArray in accessible. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D79494
2020-06-16 10:14:32 +00:00
Morgan Reschenberg 10236aef18 Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Differential Revision: https://phabricator.services.mozilla.com/D72184
2020-06-12 17:02:45 +00:00
James Teh c384807ed4 Bug 1645067: Set the top level DocAccessibleChild as early as possible. r=MarcoZ
Otherwise, if we're replacing a previous top level doc, we might refer to the old top level doc during initialization.

Differential Revision: https://phabricator.services.mozilla.com/D79398
2020-06-12 07:11:02 +00:00
Emilio Cobos Álvarez ef3d21048d Bug 1640623 - Use enum classes for LookAndFeel int and float IDs. r=jmathies,geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D76694
2020-06-11 11:27:43 +00:00
Eitan Isaacson 31b2dc735d Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D78160
2020-06-10 17:34:30 +00:00
Bogdan Tara 2c49516739 Backed out changeset b1ea583f8cb8 (bug 1630391) for browser_HCM_telemetry.js failures CLOSED TREE 2020-06-11 01:06:00 +03:00
Morgan Reschenberg ea3409c4f8 Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Differential Revision: https://phabricator.services.mozilla.com/D72184
2020-06-10 20:40:33 +00:00
James Teh 0b42799e46 Bug 1644323: For in-process iframes in content processes, use the emulated window set on the top level DocAccessibleChild (if any). r=MarcoZ
When window emulation is enabled, the emulated window is set on the top level DocAccessibleChild.
However, it isn't set on child documents (in-process iframes).
Therefore, when querying the window handle, we need to check for an emulated window handle on the top level document and return that if present.
This fixes the window handle returned by IAccessible2::get_windowHandle.

Note that the window handle used when firing events was already correct, as that is determined in the parent process.
In the parent process, the emulated window was already being propagated down to child DocAccessibleParents by BrowserParent::RecvPDocAccessibleConstructor.

Differential Revision: https://phabricator.services.mozilla.com/D79035
2020-06-10 07:11:31 +00:00
James Teh 26c591b2c1 Bug 1573630: Remove usage of nsIDocShellTreeItem in nsCoreUtils::IsTopLevelContentDocInProcess. r=MarcoZ
This usage of nsIDocShellTreeItem is safe, but nsIDocShellTreeItem is going away and it's trivial to convert this to use BrowsingContext.
As a bonus, the code is also shorter and more readable.

Differential Revision: https://phabricator.services.mozilla.com/D79022
2020-06-10 05:03:07 +00:00
James Teh 97cb27b85a Bug 1634591: Rename nsCoreUtils::IsTabDocument to IsTopLevelContentDocInProcess. Rename DocAccessible::eTabDocument to eTopLevelContentDocInProcess. r=MarcoZ
This also adds some assertions where these are used in the Windows code, as it would be bad if that code ran in an OOP iframe document.

Differential Revision: https://phabricator.services.mozilla.com/D79021
2020-06-10 05:03:05 +00:00
James Teh 26861090f2 Bug 1644319: Move code specific to DocAccessibles out of AccessibleWrap::get_accParent and into DocAccessibleWrap::get_accParent. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D79020
2020-06-10 05:02:58 +00:00
Csoregi Natalia 81b315c91b Backed out changeset c15ccd143f32 (bug 1630391) for failures on browser_HCM_telemetry.js. CLOSED TREE 2020-06-10 03:07:24 +03:00
Morgan Reschenberg 564e7c4295 Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Differential Revision: https://phabricator.services.mozilla.com/D72184
2020-06-09 21:56:01 +00:00
Dorel Luca 31ee7a3080 Backed out changeset 498dee65dcf8 (bug 1643168) for Browser-chrome failures browser/mac/browser_focus.js. CLOSED TREE 2020-06-08 20:28:05 +03:00
Eitan Isaacson 97fb862d37 Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D78160
2020-06-08 15:47:11 +00:00
Simon Giesecke 0011473324 Bug 1644079 - Fix invalid array index access in ia2Accessible::get_selectionRanges. r=MarcoZ
Since loops that modify the array are error-prone, this is changed to use
nsTArray::RemoveElementsBy instead.

Differential Revision: https://phabricator.services.mozilla.com/D78641
2020-06-08 09:14:56 +00:00
Simon Giesecke ebbc7ae838 Bug 1642989 - Use RemoveLastElements instead of RemoveElementsAt where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78049
2020-06-08 08:50:15 +00:00
Simon Giesecke 13502cf27c Bug 1642991 - Use RemoveElementsBy where easily possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78055
2020-06-08 09:01:48 +00:00
James Teh b1c5fca60f Bug 1547657: Null check frame in HyperTextAccessible::TextBounds. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D78631
2020-06-08 05:11:23 +00:00
James Teh 58a574a9c2 Bug 1642568: accessible/tests/mochitest/role/test_aria.html: Wait for a11y load when opening the chrome window. r=MarcoZ
Even though we previously waited for the DOM load event, the a11y tree probably wasn't ready yet.

Differential Revision: https://phabricator.services.mozilla.com/D78630
2020-06-08 05:06:39 +00:00
Morgan Reschenberg 3083026d43 Bug 1641932: Add Mac subroles to role map. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D77500
2020-06-05 03:45:44 +00:00
James Teh c45ca37cf4 Bug 1151648: Construct accessible objects for SVG elements which have title or desc. r=MarcoZ,yzen
According to SVG Accessibility API Mappings, an SVG element which has title or desc element must be exposed.
https://w3c.github.io/svg-aam/#include_elements
Previously, we didn't expose <g> elements at all even if they had a title/desc, and we unconditionally exposed some other SVG elements even when they didn't.

This removes the Dev Tools A11y Panel code which explicitly allowed unlabelled descendants of role="img" <svg> elements, since we don't create descendants if they don't have a label now anyway.
The associated tests had to be tweaked as well, since now we don't create unlabelled descendants.

Original patch by Takeshi Kurosawa.

Differential Revision: https://phabricator.services.mozilla.com/D77763
2020-06-03 13:18:38 +00:00
Eitan Isaacson add69c1749 Bug 1642033 - Refactor mozTextAccessible to use MOX api. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77564
2020-06-03 21:15:43 +00:00
Zeke Medley 533e723a19 Bug 1642448 - Replace remaining NSAssert statements in accessible/mac/ with MOZ_ASSERT's. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77874
2020-06-02 20:40:37 +00:00
Eitan Isaacson ccfae4a0f0 Bug 1642030 - Support testing of parameterized attributes in Mac mochitests. r=morgan
Depends on D77559

Differential Revision: https://phabricator.services.mozilla.com/D77562
2020-06-02 04:20:38 +00:00
Eitan Isaacson 4523f18d89 Bug 1642024 - Remove method-based NSAccessibility support from XPCOM mac a11y interface. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77559
2020-06-01 19:48:43 +00:00
Eitan Isaacson c3aa4bdf8c Bug 1641984 - Implement MOX parameterized attribute getters. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77563
2020-06-02 04:57:14 +00:00
Csoregi Natalia 88d27d2500 Backed out changeset f2da1b325e97 (bug 1151648) for failures on browser_accessibility_text_label_audit.js. CLOSED TREE 2020-06-02 13:17:30 +03:00
James Teh bfaf8c5057 Bug 1151648: Construct accessible objects for SVG elements which have title or desc. r=MarcoZ
According to SVG Accessibility API Mappings, an SVG element which has title or desc element must be exposed.
https://w3c.github.io/svg-aam/#include_elements
Previously, we didn't expose <g> elements at all even if they had a title/desc, and we unconditionally exposed some other SVG elements even when they didn't.

Original patch by Takeshi Kurosawa.

Differential Revision: https://phabricator.services.mozilla.com/D77763
2020-06-02 06:59:31 +00:00
James Teh 0003a43cd3 Bug 1642480: Null check content in nsAccUtils::IsARIALive. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D77748
2020-06-02 05:56:22 +00:00
James Teh d82ab85438 Bug 1642258: Allow role="alert" on the body of chrome documents (but not content documents). r=MarcoZ
Also fixes a typo in an existing test that meant we weren't actually testing as intended.

Differential Revision: https://phabricator.services.mozilla.com/D77628
2020-06-02 05:53:52 +00:00
Razvan Maries a36bb7751f Backed out 3 changesets (bug 1638153) for perma failures on cross-origin-objects.html. CLOSED TREE
Backed out changeset f7aedc92d396 (bug 1638153)
Backed out changeset 07ec713926c6 (bug 1638153)
Backed out changeset 5a656842e241 (bug 1638153)
2020-06-01 23:51:35 +03:00
Kris Maglione b3fcd970ec Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-01 17:59:01 +00:00
Ricky Stewart 0bbaac721b Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj
Also update documentation to suggest using the `GeneratedFile` template rather than directly referencing `GENERATED_FILES` where possible.

Differential Revision: https://phabricator.services.mozilla.com/D77496
2020-06-01 16:00:28 +00:00
James Teh 8da3be47f5 Bug 1642141: When clearing the AccessibleHandlerControl Accessible cache, swap it into a temporary map first to avoid re-entry into the main map while clearing. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D77623
2020-06-01 05:45:44 +00:00
James Teh eb93cd44c2 Bug 1427304: Return the oleacc window accessible for the outer HWND of windows created with popup=yes. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D77442
2020-05-29 14:16:14 +00:00
Eitan Isaacson 6d5ab04a9d Bug 1641960 - Introduce some Mac selection tests for inputs. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77531
2020-05-29 22:58:54 +00:00
Eitan Isaacson d5c9522fec Bug 1641960 - Support NSRange getting and setting in XPCOM mac a11y interface. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77530
2020-05-29 22:58:44 +00:00
Morgan Reschenberg d93dd3ccbb Bug 1624909: Create and maintain radio siblings array for position information. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D72751
2020-05-29 17:37:46 +00:00
Eitan Isaacson 9aa6dd6524 Bug 1641665 - Remove NSAccessibility methods from mozTableAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77345
2020-05-28 23:06:42 +00:00
Eitan Isaacson 4a8cd9c1f8 Bug 1641659 - Remove NSAccessibility methods from mozActionElements. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77344
2020-05-28 23:02:52 +00:00
Eitan Isaacson a3ca2295dc Bug 1641657 - Remove NSAccessibility methods from mozRootAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D77343
2020-05-28 22:41:30 +00:00
Eitan Isaacson d0f0c96f5e Bug 1641655 - Remove NSAccessibility methods from mozSelectableElements. r=morgan
A casualty of this is the "switch" action description for pressing tabs. That code
goes way back to our first Mac a11y support. WebKit and Chromium don't have it.

I tried to figure out when other browsers or apps had that with no luck.
Anyway, removing that description gives us the same behavior in VO as
WebKit and Chromium where there are no custom action description strings.

Differential Revision: https://phabricator.services.mozilla.com/D77342
2020-05-28 22:41:23 +00:00
Eitan Isaacson 11a255caf4 Bug 1641654 - Remove NSAccessibility methods from mozHTMLAccessible classes. r=morgan
A casualty of this is the ability to change listed attribute names on the fly.
I think this is the right choice in general and doesn't seem to affect VO.
If we run into a case where it does we should reconsider.

Differential Revision: https://phabricator.services.mozilla.com/D77341
2020-05-28 22:41:21 +00:00
Eitan Isaacson d13bf79114 Bug 1641644 - Remove most NSAccessibility methods from mozAccessible. r=morgan
Keeping accessibilityAttributeNames because it calls additionalAccessibilityAttributeNames
which is used by subclasses.

Differential Revision: https://phabricator.services.mozilla.com/D77335
2020-05-28 22:41:13 +00:00
Eitan Isaacson 9d2ffbbfee Bug 1641644 - Create MOXSummaryAccessible for summary element. r=morgan
This will make it easier to generalize mozAccessible.

Differential Revision: https://phabricator.services.mozilla.com/D77334
2020-05-28 22:41:06 +00:00
Eitan Isaacson 4970260cc9 Bug 1635521 - Create dedicated MathML MOX accessibles. r=morgan
This patch uses the new file/class naming convention.
Hopefully we will convert all of it in time.

Differential Revision: https://phabricator.services.mozilla.com/D77333
2020-05-28 22:41:04 +00:00
Narcis Beleuzu 0bb36c9ac1 Backed out changeset d2b10235d8ac (bug 1624909) for bustages on Pivot.h . CLOSED TREE 2020-05-29 07:05:21 +03:00
Morgan Reschenberg d013e0b775 Bug 1624909: Create and maintain radio siblings array for position information. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D72751
2020-05-28 15:53:01 +00:00
Razvan Maries 0b581d46a0 Backed out changeset 156d42f01488 (bug 1624909) for build bustages on Pivot.h. CLOSED TREE 2020-05-27 22:49:22 +03:00