parseInt accepts any value and coerces it to a number. isNaN allows
floats, and the specification says we should only have integers.
MozReview-Commit-ID: HeZ1eA0duWe
--HG--
extra : rebase_source : b582c0afe1889e8058d32d39314694b3556c4352
The WebDriver specification mandates that the page loading timeout must
be five minutes, and the script timeout 30 seconds.
MozReview-Commit-ID: E82jGXCb2ch
--HG--
extra : rebase_source : e1015cbf1cb01b7b48948592be9a022b87670118
The `get` function in testing/marionette/listener.js used an evaluated
if-condition test to determine if a page timeout was given. This would
fail if passed 0 because 0 evaluates to false in JavaScript.
This patch fixes the incorrect type check by looking at whether the
variable has been defined or not.
MozReview-Commit-ID: 39vDZRjKAFb
--HG--
extra : rebase_source : f8100e05f9b1165e20b5aaab6e89b09fd110b3d2
The input type for the `ms` field when passing the old JSON schema that
puts Marionette into the backwards compatible behaviour, accepts string
types that are `parseInt`ed into an integer. This change adds a test
for this.
MozReview-Commit-ID: GJ3ibit7tyG
--HG--
extra : rebase_source : f8ddc6fa46f8917afd650eeabdaf2916c5a3bc04
Move packaging for Marionette from make to test_archiver by using root manifest files.
MozReview-Commit-ID: 1cxEBYQeJ2Z
**
--HG--
extra : rebase_source : 372a407d9207bfbccbfb88c689df60b8cc1abcaf
marionette_test.py is a bloated module which contains everything around the Marionette testcase classes.
We should split this up into distinct modules, so each new module covers specific code. The two new modules
introduced are errors, and decorators. This split would also be aligned to the structure of the driver.
To not loose backward compatibility we have to keep the import from marionette_test. It means the new
modules have to live in a sub folder named like that.
MozReview-Commit-ID: DQg55M258ST
--HG--
extra : rebase_source : 2c4150e56b4489518bd1c87b4c3f7cc25e0c5133
Because execute_async_script() has it's own timeout value, there shouldn't be another timeout
check inside the script. Even with this check we return immediately now, which can cause test
failures if setting the permission is delayed.
MozReview-Commit-ID: Aqsbfc6Ayy6
--HG--
extra : rebase_source : c1107a48644129d9e55ed07e049a60ad809d2ed0
Add tests to ensure that the arguments passed to the call to
`manifest.active_tests` from within `runner.add_test` are correct,
based on the runner's settings for e.g. e10s and test tags.
Add helper function for setup for these tests to avoid duplication.
MozReview-Commit-ID: CsaDm7cSyZf
--HG--
extra : rebase_source : fe3687aea4d342962074bfef7f5c43385710f8fa
Move the ManifestFixture class out of the `manifest_fixture` function,
and rename that function to `manifest_with_tests`. Create a new,
simpler manifest fixture without parametrization, called `manifest`.
This allows us to use the mocking-out done in the ManifestFixture class
in tests where we don't actually need the parametrization of the
`active_tests` attribute.
MozReview-Commit-ID: xuBn4QxApf
--HG--
extra : rebase_source : c570086a6ec4556fc634f7e18f998a5fca042a01
I noticed that if you request a loaner for a non-e10s job then run mach, it will be run with e10s
enabled. The mach command should accurately reflect the type of job that got requested. This patch
grabs the 'e10s' argument from the mozharness localconfig.json and uses that.
MozReview-Commit-ID: 4lsKGpizfH7
--HG--
extra : rebase_source : 6f7b45146bb7f3431c242d92b4206d41f7217c03
You can set attributes on a mach context by using the 'key' argument to the context_handler. Basically,
whatever gets returned by the handler when <key> is passed in, will get set (i.e cached) on the context
object for fast retrieval next time. This is a way to lazy load these attributes.
Previously I was setting functions like 'find_firefox()' on the context object, and then having the
mach_commands call that directly. But this way is much cleaner.
Now, the loaded 'mozharness_config' can be stored as an attribute on the context. Also 'find_firefox()'
is now an attribute called 'firefox_bin'.
MozReview-Commit-ID: 4lsKGpizfH7
--HG--
extra : rebase_source : af5e32e05a29b8e91d4cd0005689baa8079ec137
Ehsan Akhgari
Gijs Kruitbosch
Michelangelo De Simone
Francesco Pischedda
Andreas Tolfsen
Phil Ringnalda
Carsten "Tomcat" Book
Aaron Klotz
Henrik Skupin
CuriousLearner
bhuvi96
Milan Sreckovic
Anjana Vakil
Wes Kocher
Andrew Halberstadt
Eric Rahm
Ryan VanderMeulen
Kartikaya Gupta