This serves two purposes:
1) It makes web-platform-tests pref downloading/handling a little more robust. When
run externally, it now downloads the entire testing/profiles directory. When loading
prefs it will look for both prefs_general.js (to support older versions of Firefox)
and profiles.json (for support moving forward).
This way we can add/remove/rename pref files under these directories without needing
to worry about breaking upstream wpt.
2) It provides developers an overview of which harnesses are using which base profiles.
Instead of hunting through test harness code to find this information, they can glance
at profiles.json.
MozReview-Commit-ID: AMzdnD8aGA2
--HG--
extra : rebase_source : 6fa0a802680417e49fcef99f3d03de7458a8fcba
With the fix on bug 1449538 the shutdown hangs which have caused the
timeout errors are gone. So we can safely re-enable the tests.
MozReview-Commit-ID: 4XTRQtwwRZd
--HG--
extra : rebase_source : 6b94222198922f6c85a36b3bc3e70bb8b7b0f461
NPAPI may handle a 307 redirect across different origins, while they
should only happen on same origin requests. Have the browser check
this before forwarding to NPAPI.
MozReview-Commit-ID: 5vxMooygI4g
--HG--
extra : rebase_source : 36ab35b389c1746bbfd3482ff68b81bac34e4de1
- Remove outdated appChanged logic from test helper function to start
the AddonManager
- Avoid calling to the AddonManager in webextension tests that don't
otherwise require the AddonManager
MozReview-Commit-ID: Fx4o1TzXTCd
--HG--
extra : rebase_source : a81a09a6ab25eac5ae00b5d80b91509448c95748
extra : histedit_source : 5bb2abe1f6c4f4ee2feced32930c417771752478
This makes debugging failures extremely difficult, and tends to confuse
developers who add debugging logs and can't understand why they're not showing
up.
MozReview-Commit-ID: Wajt2JczuY
--HG--
extra : rebase_source : 497d78a915ad92707ba5f7d5b437ec1dfbc5b8f8
None of the C++ callers of RemoveSelectionListener care about whether the
listener was already-added, and the only JS caller is in a test and knows the
listener was added. So the behavior change to no-op instead of throwing when
trying to remove a nonexistent listener is OK. Furthermore, the removal is
null-safe, so there's no point to explicitly failing if null is passed (which
it never is).
Since content can't directly add selection listeners, we can just use an
infallible append instead of returning errors callers don't check for anyway.
Also, no one passes null to AddSelectionListener, so we don't have to worry
about that part.
This way we don't have to deal with QI to get a Selection out of a weakref.
mfbt weakrefs don't have a SizeOfOnlyThis. In any case, the memory used by the
weakref itself is pretty minor...
Jonathan Kew
Randell Jesup
Jason Laster
Andrew Halberstadt
Henrik Skupin
Kyle Machulis
Sylvestre Ledru
Kris Maglione
Roman
Ryan VanderMeulen
James Willcox
Ben Kelly
Andrew Swan
Boris Zbarsky
André Bargull
Marco Castelluccio