157338c776
Backed out 9 changesets (bug 888784) for failing mochitest-bc browser_426329.js on Linux and on Android chrome's test_ext_browsingData_formdata.html and robocop's testFormHistory. r=backout on a CLOSED TREE
...
Backed out changeset 98722ab8c2f6 (bug 888784)
Backed out changeset d92599272745 (bug 888784)
Backed out changeset 67c58cb32ac9 (bug 888784)
Backed out changeset 46fb8f82f2bf (bug 888784)
Backed out changeset 73ad820d09ec (bug 888784)
Backed out changeset 18d185fa362e (bug 888784)
Backed out changeset 10c472d10264 (bug 888784)
Backed out changeset 51fb50c1ea68 (bug 888784)
Backed out changeset 80a207ed79ec (bug 888784)
2018-01-09 20:18:55 +02:00
fb6f18615e
Bug 888784 - Get rid of dead mozIStorageService code in FormHistory.jsm. r=mak
...
MozReview-Commit-ID: XLOFLpMsPv
--HG--
extra : rebase_source : e25875eed9c190ba9d5b1bd2c9e435f431bf1db5
2017-12-01 14:55:24 -05:00
9bc8273562
Bug 888784 - Make FormHistory.expireOldEntries use new Sqlite.jsm database backend. r=mak
...
MozReview-Commit-ID: KSaWz0s6hF1
--HG--
extra : rebase_source : 178156594da605c4891bf00fa331f30711426410
2017-12-01 14:54:02 -05:00
daff78e9e9
Bug 888784 - Make FormHistory.getAutoCompleteResults use Sqlite.jsm backend. r=mak
...
MozReview-Commit-ID: 7rYj1lMosLW
--HG--
extra : rebase_source : e9918b512514d5a402dafb5e359a4c494f4bbc74
2017-12-01 10:53:32 -05:00
83cde6cdb4
Bug 888784 - Get rid of FormHistory.shutdown. r=mak
...
FormHistory.shutdown was called via FormHistoryStartup.js's profile-before-change
observer to close the database synchronously.
Now FormHistory uses AsyncShutdown and closes the database asynchronously, so
FormHistory.shutdown is no longer required.
MozReview-Commit-ID: Lok5vx1dOTW
--HG--
extra : rebase_source : cdedad54e2ffbf378675648b4e56a0c2bbb21796
2017-11-30 18:11:18 -05:00
406b625f4a
Bug 888784 - Make FormHistory.update use Sqlite.jsm database backend. r=mak
...
MozReview-Commit-ID: 7Ku1kFtTYZK
--HG--
extra : rebase_source : 542232704182b64ba0c6da330c443dc11068e8cf
2017-11-30 18:09:54 -05:00
b2dbfe8731
Bug 888784 - Remove FormHistory.getSchemaVersion and update some tests that used it to use add_task. r=mak
...
MozReview-Commit-ID: EQBksMqeNm2
--HG--
extra : rebase_source : 68892eb791b2001532f2089f1f7fb277517a5027
2017-11-30 17:00:07 -05:00
9870ba6719
Bug 888784 - Make FormHistory.search use Sqlite.jsm database backend. r=mak
...
MozReview-Commit-ID: J1ElTJpWHza
--HG--
extra : rebase_source : 17eeffa8724f08ee7ca33c8c6087d2b0c07116c2
2017-11-30 15:15:10 -05:00
ae1245f1dc
Bug 888784 - Make FormHistory.count use Sqlite.jsm database backend. r=mak
...
MozReview-Commit-ID: 53gec0qQL1y
--HG--
extra : rebase_source : d1d1f46b1dc8e76a28a8fb96b0b2fc6696a2064d
2017-11-30 14:28:13 -05:00
f517a315fc
Bug 888784 - Add a new Sqlite.jsm based database connector to FormHistory.jsm. r=mak
...
MozReview-Commit-ID: JADYzdAokVJ
--HG--
extra : rebase_source : 481a6e8e787dc1419ebaa67f0f1d41e6d324c663
2017-11-30 14:03:04 -05:00
39088f038f
Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
...
MozReview-Commit-ID: H7AmIBtFUOr
--HG--
extra : rebase_source : 5a33c4da86051bf3dfec56d878330a8d68b70870
2017-11-06 15:50:28 -05:00
f7f473b678
Backed out 1 changesets (bug 1404427) for browser failures in browser_sanitize-timespans.js at some times of the day. r=backout a=backout on a CLOSED TREE
...
Backed out changeset e02d99be7eb0 (bug 1404427)
2017-11-11 05:48:15 +02:00
4f9b7d04fa
Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
...
MozReview-Commit-ID: H7AmIBtFUOr
--HG--
extra : rebase_source : 596e4470b64e9406432c4d54f7ef90138a032e62
2017-11-06 15:50:28 -05:00
e26417e1b1
Backed out changeset d9a7e2fba868 (bug 1404427) on suspicion of causing failures in browser_sanitize-timespans.js at some times of the day. r=backout a=backout on a CLOSED TREE
2017-11-10 15:28:16 +02:00
8ca003f520
Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
...
MozReview-Commit-ID: H7AmIBtFUOr
--HG--
extra : rebase_source : 9d85cc401123eb915f640586e722c8275753066e
2017-11-06 15:50:28 -05:00
1f2b7dccb6
Backed out changeset 6aa22b862a45 (bug 1404427) for failing browser-chrome browser/components/search/test/browser_426329.js r=backout on a CLOSED TREE
2017-11-09 21:26:40 +02:00
6af91eacb2
Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
...
MozReview-Commit-ID: H7AmIBtFUOr
--HG--
extra : rebase_source : 8c232e95bb5849a60002f4572c113d814da4a193
2017-11-06 15:50:28 -05:00
60aea23a2c
Bug 1395427 p3 - Allow form history items to be created with a specific guid. r=markh
...
This allows us to have the same form history GUIDs across devices, which is mandatory
if we want tombstones to actually do something.
MozReview-Commit-ID: Hw6ahbVA5lB
--HG--
extra : rebase_source : 5289322dea430f364790026470ff844f754dd570
2017-09-22 15:08:48 -04:00
8cb437aed8
Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
...
MozReview-Commit-ID: Je0rV277d7
--HG--
extra : rebase_source : 0557db8a84c98b0fa55b6a4f23fa8001876d559b
2017-09-22 15:19:56 -04:00
dace60c516
Backed out changeset 553d26ab8ee8 (bug 1395427)
2017-09-27 17:10:26 +02:00
6cbbf769ee
Backed out changeset d7876bfd8bfc (bug 1395427)
2017-09-27 17:10:21 +02:00
8dcfa9de4f
Bug 1395427 p3 - Allow form history items to be created with a specific guid. r=markh
...
This allows us to have the same form history GUIDs across devices, which is mandatory
if we want tombstones to actually do something.
MozReview-Commit-ID: Hw6ahbVA5lB
--HG--
extra : rebase_source : 39f9cc5553f44f149abc0ed9715268c538fc27ba
2017-09-22 15:08:48 -04:00
a532988296
Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
...
MozReview-Commit-ID: Je0rV277d7
--HG--
extra : rebase_source : f2b03b68567a8d075dfbe3921d14bcc86c755d66
2017-09-22 15:19:56 -04:00
8b415f700f
Bug 1394556: Part 1 - Fix strict mode errors in JSM scripts. r=Mossop
...
MozReview-Commit-ID: 4LmJQql7Y2c
--HG--
extra : rebase_source : f18b5547a5a57db4e8b990bfc34f06690ac9da7a
extra : histedit_source : 7281bafbde4bf231752d9d868ec8ca1d2f55a2f9
2017-08-30 01:50:27 -07:00
1d9f369492
Bug 1372427 - enforce no spacing before semi-colons, but spacing after. r=MattN
...
auto --fix
MozReview-Commit-ID: 8QLHNfXlwBQ
--HG--
extra : rebase_source : 198937fc68701b09e8af568ec2c7802a0cc46886
2017-06-14 18:13:15 -07:00
f264f8503e
Bug 1372427 - enforce dot-notation over square-bracket-notation when possible. r=MattN
...
auto --fix
MozReview-Commit-ID: LDwtCje2Sb0
--HG--
extra : rebase_source : 0ba00836aef84c537fc361f40bca1371ffd1266e
2017-06-14 17:50:48 -07:00
d99dbdf74f
Bug 1372427 - enforce "comma-dangle". r=MattN
...
auto --fix
MozReview-Commit-ID: KKmDI0Pt43K
--HG--
extra : rebase_source : 4917dbfc35a03dc0f8171006273b1e555f7b4c9b
2017-06-14 17:46:42 -07:00
098de3bdc2
Bug 1372427 - add rule to not put spacing inside arrays. r=MattN
...
auto --fix
MozReview-Commit-ID: BiEzl4OawuU
--HG--
extra : rebase_source : fe425f8840414ee289415e9b7775b698ee3b6b9a
2017-06-14 17:35:30 -07:00
59345808a2
Bug 1372427 - limit lines to a maximum of 100 chars. r=MattN
...
MozReview-Commit-ID: 3OSKaTMMBot
--HG--
extra : rebase_source : f6d9c00352003674c643089f158a8d116ae36a20
2017-06-13 16:48:31 -07:00
f4d5635b00
Bug 1372427 - add "dot-location" rule so that dots are on the same line as properties. r=MattN
...
MozReview-Commit-ID: A6IKfSiVXAN
--HG--
extra : rebase_source : 63be6025fee7a141e3169e2dffd7321e697edcc0
2017-06-13 16:34:54 -07:00
cc4c1778c4
Bug 1372427 - add "no-use-before-define" rule. r=MattN
...
MozReview-Commit-ID: BRhwhnxzlpG
--HG--
extra : rebase_source : 45f74a002a90f9a9869fbd14516cb73d19ce6d84
2017-06-13 14:34:12 -07:00
92bcf669ee
Bug 1372427 - add js-doc rule. r=MattN
...
MozReview-Commit-ID: YgDBHM88PW
--HG--
extra : rebase_source : 449ab51180fdebf2fa6e0b9b6c1ee659a15355dc
2017-06-13 10:48:52 -07:00
13ec30c445
Bug 1372427 - add semi-colon rule. r=MattN
...
auto --fix
MozReview-Commit-ID: F9GvxcghPkt
--HG--
extra : rebase_source : f88445b573583d50333249570aa80c3e2314b0c3
2017-06-13 09:51:07 -07:00
669e2f0d5e
Bug 1372427 - Add indentation rules. r=MattN
...
MozReview-Commit-ID: 62a7RvVlcco
--HG--
extra : rebase_source : 6f2f81af33e14850ab72d64f9b2973f9f06bcfb6
2017-06-12 15:45:00 -07:00
03ac334e31
Bug 1372427 - Add "curly" eslint rule to fix missing curly braces. r=MattN.
...
MozReview-Commit-ID: LwVEPezNiCx
--HG--
extra : rebase_source : 69aa18e0e90dcf7559f0509dd40e746add0845ff
2017-06-09 15:56:08 -07:00
3935be31a9
Bug 1374427 - remove redundant function names in js-doc. r=MattN
...
MozReview-Commit-ID: 3EBT7CDl3pC
--HG--
extra : rebase_source : 74fafb71abb6b09f003c87e691f3a050c744c535
2017-06-19 14:11:21 -07:00
27c58cf89f
Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian
2017-06-21 12:59:28 -04:00
4eb32a2872
Bug 1365068 - import with destructuring, switch to shorthand function declarations and use array.includes. r=MattN
...
MozReview-Commit-ID: IfmePvN8WnA
--HG--
extra : rebase_source : 9f7d272ae66bbfde81d777cff9a17eebb1ec98b8
2017-05-16 18:23:56 -07:00
969046c009
Bug 1365068 - Added missing brackets & refactored some conditional statements. r=MattN
...
MozReview-Commit-ID: 1eOkjI06RCJ
--HG--
extra : rebase_source : 18068d1483d9127c06b858ce917f53dc41f4c58f
2017-05-16 15:56:28 -07:00
a54eda04ca
Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
...
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
9141469edf
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
c5bb304fd9
Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
...
MozReview-Commit-ID: FGFwg6TYkvm
--HG--
extra : rebase_source : 4073cebbef1694393efe312aaafbdb803adbd304
2016-11-11 15:22:34 -08:00
0a2c8f9b78
Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
...
MozReview-Commit-ID: HBpjT2uHJaZ
--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
7d81bfea9f
Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop
...
MozReview-Commit-ID: 8svkCKZHxsq
--HG--
extra : rebase_source : 01552e8214f02490aad3cf704757f52a9c3b3959
2016-11-08 12:49:32 +00:00
d3e296107e
Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
...
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
41b0a29fd2
Bug 976940 - FormHistory.update() should call handleError if form history is disabled and the operation is not a removal. r=markh
...
MozReview-Commit-ID: 94FRqGofGsP
--HG--
extra : rebase_source : 331405028ece42f48a8d160edbbe308e4353bc98
2016-02-22 18:17:43 +01:00
Sebastian Hengst
Mike Conley
Edouard Oger
Narcis Beleuzu
Andreea Pavel
Kris Maglione
Jonathan Guillotte-Blouin
Nathan Froyd
Jared Wein
Wes Kocher
Dave Townsend
Mark Banner
Marco Bonardo