54f7be0077
Bug 1858912 - Refine popover focusing steps to follow the specs. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D190917
2023-10-27 13:02:17 +00:00
d0f6c7fc66
Bug 1856795 - Remove redundant member init r=emilio
...
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html
Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-15 15:29:02 +00:00
6a90f5eded
Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE
...
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
2023-10-14 21:42:14 +03:00
cc8a0ee742
Bug 1856795 - Remove redundant member init r=emilio
...
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html
Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-14 17:34:26 +00:00
f3b3e86c4b
Bug 1843477, non-virtual AddRef/Release for EventTarget and common subclasses, r=mccr8
...
We might want to consider changing the setup for RefPtrTraits, so that it could work well with certain types of classes,
but this patch is taking the approach where one needs to explicitly opt-in classes.
Also, see the patch changing nsCOMPtr which makes also that to use same AddRef/Release mechanism.
That doesn't not only give consistent behavior, but also helps with performance.
Depends on D187147
Differential Revision: https://phabricator.services.mozilla.com/D187148
2023-09-26 12:36:21 +00:00
baf8a5cf23
Backed out 6 changesets (bug 1843477) for causing hazards failures. CLOSED TREE
...
Backed out changeset 64b093aa12a9 (bug 1843477)
Backed out changeset bdcd84c938d1 (bug 1843477)
Backed out changeset 05c882dd0d9a (bug 1843477)
Backed out changeset 1de814e5820d (bug 1843477)
Backed out changeset 6a0e19a60a5d (bug 1843477)
Backed out changeset 48942aff586f (bug 1843477)
2023-09-26 05:32:28 +03:00
d909004fa0
Bug 1843477, non-virtual AddRef/Release for EventTarget and common subclasses, r=mccr8
...
We might want to consider changing the setup for RefPtrTraits, so that it could work well with certain types of classes,
but this patch is taking the approach where one needs to explicitly opt-in classes.
Also, see the patch changing nsCOMPtr which makes also that to use same AddRef/Release mechanism.
That doesn't not only give consistent behavior, but also helps with performance.
Depends on D187147
Differential Revision: https://phabricator.services.mozilla.com/D187148
2023-09-25 21:09:01 +00:00
2b53f8d322
Backed out 3 changesets (bug 1843477) for causing hazards failures on TelemetryFixture.cpp. CLOSED TREE
...
Backed out changeset 4dd5d8ac600c (bug 1843477)
Backed out changeset e7bc0b63286a (bug 1843477)
Backed out changeset 4f45f40beaf7 (bug 1843477)
2023-09-08 20:21:46 +03:00
0833d699e3
Bug 1843477, non-virtual AddRef/Release for EventTarget, r=mccr8
...
And convert some nsCOMPtr<EventTarget> to RefPtr<EventTarget>
Depends on D187147
Differential Revision: https://phabricator.services.mozilla.com/D187148
2023-09-08 14:51:48 +00:00
0f41a21230
Bug 1851039 - Investigate if it is possible to reuse the text node when setting element.textContent, r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D187231
2023-09-04 09:38:09 +00:00
956a7783df
Backed out changeset 3451691c483d (bug 1851039) for causing mochitest failures in accessible/tests/browser/e10s/browser_caching_description.js CLOSED TREE
2023-09-04 05:48:44 +03:00
3903cddb4a
Bug 1851039 - Investigate if it is possible to reuse the text node when setting element.textContent, r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D187231
2023-09-03 17:57:31 +00:00
639f69e43f
Backed out changeset e6370dc41077 (bug 1851039) for causing wpt failures in dynamic-mtext-like-001.html CLOSED TREE
2023-09-01 12:33:37 -04:00
ce54004465
Bug 1851039 - Investigate if it is possible to reuse the text node when setting element.textContent, r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D187231
2023-09-01 14:08:32 +00:00
0c07916b28
Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D174115
2023-06-28 04:31:22 +00:00
527ef4f7e5
Backed out changeset 9fb58fa7b8b6 (bug 1556358) for causing wpt failures on ElementInternals-setFormValue.html. CLOSED TREE
2023-06-20 08:16:50 +03:00
31e82aa9be
Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D174115
2023-06-20 01:29:58 +00:00
ddf6d6b447
Backed out changeset 08f12e7fa5f0 (bug 1556358) for causing bustage on ElementInternals.cpp. CLOSED TREE
2023-06-19 21:15:17 +03:00
264a268d3b
Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D174115
2023-06-19 17:22:01 +00:00
6f6032c8fd
Backed out changeset 1680323680fe (bug 1556358) for causing Bb bustages on ElementInternals.cpp CLOSED TREE
2023-06-19 18:33:35 +03:00
d6f990f53a
Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar
...
Depends on D175542
Differential Revision: https://phabricator.services.mozilla.com/D174115
2023-06-19 13:44:15 +00:00
cb33cee97e
Backed out 3 changesets (bug 1556358) for causing Bb build bustages in ElementInternals.cpp. CLOSED TREE
...
Backed out changeset f7e94ea82252 (bug 1556358)
Backed out changeset c80f29a9cefc (bug 1556358)
Backed out changeset 413225d91666 (bug 1556358)
2023-06-16 19:46:02 +03:00
401c77f4ac
Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar
...
Depends on D175542
Differential Revision: https://phabricator.services.mozilla.com/D174115
2023-06-16 15:02:11 +00:00
c9a78e6659
Backed out 3 changesets (bug 1556358) for causing bustages in ElementInternals.cpp CLOSED TREE
...
Backed out changeset 0ebda393786b (bug 1556358)
Backed out changeset c41794eef66a (bug 1556358)
Backed out changeset a07e3e226569 (bug 1556358)
2023-06-15 01:32:38 +03:00
b0f2ac85c7
Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar
...
Depends on D175542
Differential Revision: https://phabricator.services.mozilla.com/D174115
2023-06-14 20:59:29 +00:00
9ac32645f7
Bug 1837382 - Remove nsIContent::IsDoneAddingChildren. r=smaug
...
It's only called once for a place where it knows it's a select element.
Differential Revision: https://phabricator.services.mozilla.com/D180312
2023-06-08 14:59:31 +00:00
5aa57269ec
Bug 1825825 - Simplify inspector node walking. r=smaug
...
This doesn't change behavior but it's simpler. I found it while
debugging a failure with the previous patches.
Depends on D174316
Differential Revision: https://phabricator.services.mozilla.com/D174365
2023-04-03 09:21:35 +00:00
a551a009d3
Bug 1823897 - Implement popover focusing steps, r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D173714
2023-03-28 16:01:25 +00:00
21d3624930
Bug 1816312, try to avoid creating Range objects in some common cases when spellchecker is disabled for contentEditable, r=masayuki
...
This is not very optimimal, but tracking spellchecking state in DOM tree is tricky because of multiple contentEditables and possibility to set spellcheck true/false anywhere etc.
At least this helps with the testcase quite a bit.
Differential Revision: https://phabricator.services.mozilla.com/D169870
2023-02-16 11:48:13 +00:00
6c32b964cd
Bug 1807003 - Centralize animation data in slots. r=smaug,firefox-animation-reviewers,boris
...
This should both be faster and simpler. Also will allow us in the future
to animate more pseudos without having to add a gazillion properties.
I think we should try to clear more stuff (maybe the whole animation
data) on unbind, but that's a bit tangential.
Differential Revision: https://phabricator.services.mozilla.com/D169860
2023-02-15 14:12:33 +00:00
c6d5b35934
Bug 1741936 - Implement focus delegate algorithm r=emilio
...
Spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-delegate
Differential Revision: https://phabricator.services.mozilla.com/D153689
2022-10-14 01:20:08 +00:00
bd09497378
Bug 1372276 - Remove HTML menuitem. r=smaug,mconley,agi
...
This removes HTMLMenuItemElement and all the code and tests preffed off
by dom.menuitem.enabled.
The HTML parser changes are the result of applying the previous patch.
Differential Revision: https://phabricator.services.mozilla.com/D149979
2022-06-22 22:31:42 +00:00
cac491e1fd
Bug 1477524 - Update quotes and counters to work trough the flattened tree r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D146693
2022-05-26 16:12:46 +00:00
28db98ade1
Backed out changeset ce66cc2cbb95 (bug 1477524) for causing build bustages on nsCounterManager.cpp CLOSED TREE
2022-05-26 15:24:40 +03:00
786890b5c4
Bug 1477524 - Update quotes and counters to work trough the flattened tree r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D146693
2022-05-26 11:15:16 +00:00
1ce0975b8e
Bug 1761493 - Make Gecko internally consistent wrt what a link is. r=smaug
...
This is mostly edge-casey, but see bug 1757156 for an example where it's
causing some issues (granted, they could use `href="#"` or something
instead of an empty href).
It feels weird if a link looks like a link (because the CSS definition
of a link matches, which is "has an href") but then mostly doesn't
behave as a link.
We can't navigate anywhere if we don't have a valid URI but maybe JS
handles the relevant events as in bug 1757156.
Use the CSS definition (has href) since that's interoperable across
browsers. This should also make some stuff much faster (since checking
'is link' is now just a bit check instead of a virtual call).
(Awaiting try results, if no tests need adjustments then I need to write
some)
Differential Revision: https://phabricator.services.mozilla.com/D142107
2022-03-30 17:34:31 +00:00
ebd53300c5
Bug 1707448 - Remove unused eAllButXBL flag. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D127539
2021-10-05 14:54:47 +00:00
8d7ad39477
Bug 1730022 - Improve debuggability of nsIContent. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D125192
2021-09-10 16:39:15 +00:00
2aa145db40
Bug 1705141 - Implement imperative slotting API r=smaug,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D119444
2021-07-20 18:06:25 +00:00
a5befa8e27
Bug 1702862. Allow nsICotent::List and friends in --enable-dump-painting builds. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D110743
2021-04-05 10:49:40 +00:00
e9b983560d
Bug 1699755 - Part 2: Move nsIContent::PerformAccesskey to Element; r=smaug
...
As it is called only on Element.
Differential Revision: https://phabricator.services.mozilla.com/D109170
2021-03-21 23:15:08 +00:00
e2c6f319f3
Bug 1694393 - Make it easy to enable nsIContent::List() in opt builds. r=smaug
...
By using a separate define than DEBUG.
Differential Revision: https://phabricator.services.mozilla.com/D106137
2021-02-23 20:08:13 +00:00
27e5bcae00
Bug 1688925 - Make nsLinkState an enum class, and make it smaller. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D103061
2021-01-27 04:48:51 +00:00
d27602eee6
Bug 1683226 - part 1: Make `IMEState::Enabled` an enum class r=m_kato,geckoview-reviewers
...
Before deleting `IMEState::Enabled::PLUGIN`, let's make it an enum class
for making the change safer. Almost all of this change is done by
"replace" of VSCode.
Differential Revision: https://phabricator.services.mozilla.com/D100100
2020-12-21 05:52:03 +00:00
1e9bd44120
Bug 1680167 - Part 2: MOZ_CAN_RUN_SCRIPT in dom/html r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D98625
2020-12-03 22:15:56 +00:00
4d226e1175
Bug 1652020 - Remove unnecessary includes from nsIContent.h. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D83109
2020-07-15 12:48:28 +00:00
89958b377a
Bug 1640605 - Remove IsInAnonymousSubtree / IsRootOfAnonymousSubtree. r=edgar
...
In favor of the NativeAnonymous versions which they forward to.
Done automatically with:
rg -l 'IsInAnonymousSubtree' | xargs sed -i 's/IsInAnonymousSubtree/IsInNativeAnonymousSubtree/g'
And removing the function definitions afterwards.
Differential Revision: https://phabricator.services.mozilla.com/D76681
2020-05-25 11:43:51 +00:00
c477d38a70
Bug 1623858: part 2) Declare `nsIContent::HasIndependentSelection` `const`. r=smaug
...
Depends on D67599
Differential Revision: https://phabricator.services.mozilla.com/D67600
--HG--
extra : moz-landing-system : lando
2020-03-20 13:23:00 +00:00
053f3e648d
Bug 1377999 - Make nsIContent to declare a final DeleteCycleCollectable r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D63263
--HG--
extra : moz-landing-system : lando
2020-03-17 14:53:00 +00:00
d94419173b
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/base. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D63102
--HG--
extra : moz-landing-system : lando
2020-02-21 10:41:47 +00:00
Ziran Sun
Sylvestre Ledru
Cristina Horotan
Olli Pettay
Cosmin Sabou
Sandor Molnar
Cristian Tuns
avandolder
Iulian Moraru
Natalia Csoregi
Norisz Fay
Stanca Serban
Noemi Erli
Emilio Cobos Álvarez
Cathie Chen
Sean Feng
Martin Robinson
Timothy Nikkel
Edgar Chen
Masayuki Nakano
Kagami Sascha Rosylight
Simon Giesecke
Mirko Brodesser