2023-10-02 Natalia Kulatova <nkulatova@mozilla.com>
* doc/rst/releases/nss_3_94.rst:
Documentation: Release notes for NSS 3.94
[8c67d6c2d718] [NSS_3_94_RTM] <NSS_3_94_BRANCH>
* .hgtags:
Added tag NSS_3_94_RTM for changeset a4d8f6ff9c3b
[18307440cfb0] <NSS_3_94_BRANCH>
* doc/rst/releases/index.rst:
Release notes for NSS 3.94
[a4d8f6ff9c3b] <NSS_3_94_BRANCH>
* lib/nss/nss.h, lib/softoken/softkver.h, lib/util/nssutil.h:
Set version numbers to 3.94 final
[0af23c222caf] <NSS_3_94_BRANCH>
2023-09-21 Benjamin Beurdouche <beurdouche@mozilla.com>
* .hgtags:
Removed tag NSS_3_94_BETA1
[1a3ea35e31a2]
2023-09-20 Karthikeyan Bhargavan <karthik.bhargavan@gmail.com>
* automation/taskcluster/scripts/run_hacl.sh,
lib/freebl/verified/Hacl_Hash_SHA3.c,
lib/freebl/verified/Hacl_IntTypes_Intrinsics.h,
lib/freebl/verified/Hacl_IntTypes_Intrinsics_128.h,
lib/freebl/verified/Hacl_Krmllib.h, lib/freebl/verified/Hacl_P256.c,
lib/freebl/verified/internal/Hacl_Bignum_Base.h,
lib/freebl/verified/internal/Hacl_Hash_SHA1.h,
lib/freebl/verified/internal/Hacl_Hash_SHA2.h,
lib/freebl/verified/internal/Hacl_IntTypes_Intrinsics.h,
lib/freebl/verified/internal/Hacl_IntTypes_Intrinsics_128.h,
lib/freebl/verified/internal/Hacl_Krmllib.h,
lib/freebl/verified/internal/Hacl_P256.h,
lib/freebl/verified/internal/lib_intrinsics.h,
lib/freebl/verified/karamel/include/krml/internal/target.h, lib/free
bl/verified/karamel/krmllib/dist/minimal/FStar_UInt_8_16_32_64.h,
lib/freebl/verified/karamel/krmllib/dist/minimal/Makefile.basic,
lib/freebl/verified/lib_intrinsics.h:
Bug 1853737 - Updated code and commit ID for HACL*. r=jschanck
[3501ba1860c3]
2023-09-20 Iaroslav Gridin <iaroslav.gridin@tuni.fi>
* tests/acvp/fuzzed/ecdsa.json:
Bug 1840510: update ACVP fuzzed test vector: refuzzed with current
NSS r=jschanck
[da1cde22e844]
2023-09-15 Robert Relyea <rrelyea@redhat.com>
* automation/abi-check/expected-report-libnssutil3.so.txt,
lib/freebl/nsslowhash.c, lib/freebl/stubs.c, lib/freebl/stubs.h,
lib/pk11wrap/pk11util.c, lib/softoken/pkcs11.c,
lib/util/nssutil.def, lib/util/secport.c, lib/util/secport.h:
Bug 1827303 Softoken C_ calls should use system FIPS setting to
select NSC_ or FC_ variants.
NSS softoken presents a PKCS #11 API to the NSS low level crypto.
This allows NSS to have native support for replacement PKCS #11
libraries, and is also the FIPS boundary, allowing the rest of NSS
to change without affecting any FIPS validations.
Some applications that need crypto, but have their own higher level
implementations of SSL or S/MIME use NSS softoken. Softoken has 2
general APIs: NSC_xxxx calls which implement the normal NSS
interface, but does not include any FIPS restrictions, The FC_xxx
interfaces which implements FIPS restrictions on the semantics of
the calls and additional FIPS requirements (like self-tests and
software integrity checks). The official PKCS #11 APIs are C_xxx
interfaces, and NSS exports those as aliases for NSC_xxxx calls.
Right now applications that use softoken have to know the NSS names
if they want to access the FIPS api. This bugs removes this
restriction and causes calls to C_xxxx to alias to FC_xxxxx if the
system is in FIPS mode. If the system has no system FIPS indicator,
or the that indicator is off, the C_xxxx will continue to call
NSC_xxxxx. NSS itself will continue to use NSC_xxxx or FC_xxxx
according to the NSS internal FIPS settings.
---------------- Currently there are 3 layers in NSS with code that
identifies the whether the system is in NSS: nss proper (which is
also exported to applications), and freebl for the Freebl hash
direct case. This code would add a 3rd (in softoken). Rather than
adding a third, this patch relocates the main function to nssutil
where softoken, nss, and freebl can all access it. The exception is
when building freebl with 'NODEPEND' (freebl can provide hashing
without dependencies on NSPR or NSSUTIL), there needs to be a stub
implementation. In most platforms and cases this stub is never
compiled.
[762cb673ca8c]
* .hgignore, automation/taskcluster/scripts/split.sh, cmd/Makefile,
cmd/dbtool/Makefile, cmd/dbtool/dbtool.c, cmd/dbtool/dbtool.gyp,
cmd/dbtool/manifest.mn, cmd/manifest.mn, lib/softoken/sdb.h,
nss.gyp:
Bug 1774659 NSS needs a database tool that can dump the low level
representation of the database. r=jschanck
When debugging the database, it would be helpful to know what is in
the database is a nicely formated way. certutil dumps a high level
view of the certs and keys, sqlite3 can dump the low level tables
and raw entries. It would be useful to dump the database as softoken
sees the database.
This code grabs a copy of the latest sdb.c from softoken and uses it
to fetch the database entries, then parses them as necessary. It
uses the pkcs11 table in libsec to format the result data into human
readable strings.
[e52240a4bc62]
2023-09-08 John Schanck <jschanck@mozilla.com>
* gtests/mozpkix_gtest/pkixnames_tests.cpp:
Bug 1852179 - declare string literals using char in
pkixnames_tests.cpp. r=nss-reviewers,nkulatova
[dbed9fc0522a]
Differential Revision: https://phabricator.services.mozilla.com/D189815
This patch enables PSM and Firefox to use TLS 1.3 Encrypted Client Hello (draft -08). Specifically:
- Compile NSS with NSS_ENABLE_DRAFT_HPKE=1
- Add ECH "public_name" handling in SSLServerCertVerification.cpp (see: https://tools.ietf.org/html/draft-ietf-tls-esni-08#section-6.3.2)
- Adds `mIsAcceptedEch` to TransportSecurityInfo, and xpcshell tests for ECH use cases
- Adds EncryptedClientHelloServer to facilitate the xpcshell tests
- Un-ifdef Set/GetEchConfigs code in nsNSSIOLayer.cpp. Also reverted the Base64 encoding and decoding, as the data returned from DNS is already decoded (wire-format).
Differential Revision: https://phabricator.services.mozilla.com/D92651
This patch enables PSM and Firefox to use TLS 1.3 Encrypted Client Hello (draft -08). Specifically:
- Compile NSS with NSS_ENABLE_DRAFT_HPKE=1
- Add ECH "public_name" handling in SSLServerCertVerification.cpp (see: https://tools.ietf.org/html/draft-ietf-tls-esni-08#section-6.3.2)
- Adds `mIsAcceptedEch` to TransportSecurityInfo, and xpcshell tests for ECH use cases
- Adds EncryptedClientHelloServer to facilitate the xpcshell tests
- Un-ifdef Set/GetEchConfigs code in nsNSSIOLayer.cpp. Also reverted the Base64 encoding and decoding, as the data returned from DNS is already decoded (wire-format).
Differential Revision: https://phabricator.services.mozilla.com/D92651
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
CHECK_FORK_GETPID was useful back when Android didn't support pthread_atfork, which it has since at least ICS (API 14 or 15), and Fennec has required API 16 for a while now.
Moreover, softoken.h also defines CHECK_FORK_PTHREAD on its own, and pkcs11.c initialization code prioritizes CHECK_FORK_PTHREAD, while the finalization code prioritizes CHECK_FORK_GETPID, such that reinitialization was never possible.
Differential Revision: https://phabricator.services.mozilla.com/D67940
This change modifies all tests that use key3/cert8 to use the new files. It
removes test_sdr_upgraded_with_password, as without the upgrade part that is now
the same test as test_sdr_preexisting_with_password.
Differential Revision: https://phabricator.services.mozilla.com/D55708
--HG--
rename : security/manager/ssl/tests/unit/test_sdr_preexisting/key4.db => security/manager/ssl/tests/unit/test_broken_fips/key4.db
extra : moz-landing-system : lando
This change modifies all tests that use key3/cert8 to use the new files. It
removes test_sdr_upgraded_with_password, as without the upgrade part that is now
the same test as test_sdr_preexisting_with_password.
Differential Revision: https://phabricator.services.mozilla.com/D55708
--HG--
rename : security/manager/ssl/tests/unit/test_sdr_preexisting/key4.db => security/manager/ssl/tests/unit/test_broken_fips/key4.db
extra : moz-landing-system : lando
This change removes the legacy libnssdbm database that we migrated away from since Firefox 60.
This change modifies all tests that use key3/cert8 to use the new files. It
removes test_sdr_upgraded_with_password, as without the upgrade part that is now
the same test as test_sdr_preexisting_with_password. It otherwise removes support for libnssdbm everywhere in Gecko.
Differential Revision: https://phabricator.services.mozilla.com/D55708
--HG--
rename : security/manager/ssl/tests/unit/test_sdr_preexisting/key4.db => security/manager/ssl/tests/unit/test_broken_fips/key4.db
extra : moz-landing-system : lando
The definitions can't be entirely removed yet because NSS still needs them.
Differential Revision: https://phabricator.services.mozilla.com/D23454
--HG--
extra : moz-landing-system : lando
NSS 3.42 added a new build flag, enable_sslkeylogfile, to toggle the
availability of the SSLKEYLOGFILE variable (see Bug 1515236 and Bug 1519209).
Differential Revision: https://phabricator.services.mozilla.com/D17588
--HG--
extra : moz-landing-system : lando
Natalia Kulatova
Mike Hommey
John Schanck
Bob Owen
Marian-Vasile Laza
Benjamin Beurdouche
Dorel Luca
Benjamin Beurdouche
Butkovits Atila
smolnar
Masatoshi Kimura
Kevin Jacobs
Razvan Maries
Ricky Stewart
Bogdan Tara
J.C. Jones
Csoregi Natalia
Andreea Pavel
Nicholas Nethercote
Kai Engert
Franziskus Kiefer
Sebastian Hengst
Sylvestre Ledru
Chris Manchester
Tom Ritter
Joel Maher
Benjamin Smedberg