Граф коммитов

5472 Коммитов

Автор SHA1 Сообщение Дата
Mihai Alexandru Michis 37ef8a125d Backed out changeset a845717e4d10 (bug 1482279) for causing multiple failures.
CLOSED TREE
2020-05-23 02:22:20 +03:00
Masatoshi Kimura 0701e89b7e Bug 1482279 - Stop using Cu.forcePermissiveCOWs() in SpecialPowers. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D74641
2020-05-22 21:46:25 +00:00
Jon Coppeard d12ca3002f Bug 1632439 - Make CallbackObject methods return JSObject pointers rather than handles r=peterv
This turned out to be simpler than expected. Apart from generated bindings, a lot of the callers didn't make use of the fact that the return value was a handle.

Differential Revision: https://phabricator.services.mozilla.com/D72120
2020-05-21 14:09:02 +00:00
Peter Van der Beken ef6ec7de76 Bug 1639310 - Simplify implicitJSContext support. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D76021
2020-05-19 20:48:29 +00:00
Peter Van der Beken af82496fc7 Bug 1639310 - Remove unnecessary implicitJSContext annotations. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D76020
2020-05-19 20:48:21 +00:00
Simon Giesecke 35ff93b006 Bug 1638151 - Add support for nullable sequence types in Event classes. r=fabrice
Differential Revision: https://phabricator.services.mozilla.com/D75491
2020-05-15 18:33:45 +00:00
Tom Schuster a5a57442ed Bug 1636590 - Expose isPromiseRejection on nsIScriptError. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D74549
2020-05-15 20:18:34 +00:00
Nico Grunbaum 3ad9a07524 Bug 1279153 - Add support for rtcp-rsize;r=bwc,dminor
Differential Revision: https://phabricator.services.mozilla.com/D72807
2020-05-15 01:54:34 +00:00
Ricky Stewart 8ca753b2d7 Bug 1637409 - Fix stray SyntaxWarning in dom/bindings/Codegen.py r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D74954
2020-05-12 23:30:27 +00:00
Tom Schuster ccaf2b2dac Bug 1635582 - Use DOMIfaceAndProtoJSClass::mToString only for interface objects. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D74445
2020-05-12 10:37:35 +00:00
Simon Giesecke 007d920362 Bug 1626570 - Improve handling of copying arrays in dom/bindings/. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D72341
2020-05-11 08:22:37 +00:00
Sylvestre Ledru 1929dd1ab3 Bug 1519636 - Reformat recent changes to the Google coding style r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D73347
2020-05-09 14:51:53 +00:00
Tom Schuster 4f64f475f2 Bug 1595046 - Make it possible to inspect every exception value in the web console. r=jonco,baku,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D64437
2020-05-08 20:54:17 +00:00
Erik Nordin f10166a614 Bug 1635584 - Make BackdropFilter's Availability Depend on WebRender r=emilio
- Enable BackdropFilter pref by default
  - Add function IsBackdropFilterAavailable()
  - Use IsBackdropFilterAvailable for relevant WebIDL instead of pref
  - Add test for BackdropFilter availability

Differential Revision: https://phabricator.services.mozilla.com/D73967
2020-05-08 05:54:26 +00:00
Razvan Maries d52f7a898c Backed out 2 changesets (bug 1635584) for build bustages. CLOSED TREE
Backed out changeset 059ed60f23bf (bug 1635584)
Backed out changeset 876b8f443cca (bug 1635584)
2020-05-08 00:47:31 +03:00
Erik Nordin 3cd3cc6820 Bug 1635584 - Make BackdropFilter's Availability Depend on WebRender r=emilio
- Enable BackdropFilter pref by default
  - Add function IsBackdropFilterAavailable()
  - Use IsBackdropFilterAvailable for relevant WebIDL instead of pref
  - Add test for BackdropFilter availability

Differential Revision: https://phabricator.services.mozilla.com/D73967
2020-05-06 23:47:06 +00:00
Ricky Stewart 933b3522b8 Bug 1633156 - Don't emit cached table files from ply r=glandium
`ply`, [by design](https://github.com/dabeaz/ply/issues/79), does not produce reproducible table files; hence bug 1633156. (Note that this was *always* true, but only became a problem once we switched to Python 3, which has more unpredictable dict iteration order than Python 2.7, at least prior to [3.7](https://docs.python.org/3/whatsnew/3.7.html#summary-release-highlights).)

In any other circumstance I would consider submitting a patch to `ply` to fix this, but as of the [in-progress version 4.0 of the library](https://github.com/dabeaz/ply/blob/master/CHANGES), it doesn't even emit this cached data any more, and indeed the [latest version of the code](1fac9fed64/ply) doesn't even call `open()` at all except to do logging or to read the text data to be parsed from `stdin`. So if we were going to pin our future on `ply` and upgrade to later versions of the library in the future, we would have to live in a world where `ply` doesn't generate cached table files for us anyway.

Emitting the cached table files so later build steps can consume them is an "optimization", but it's not clear exactly how much actual value that optimization provides overall. Quoth the `CHANGES` file from that repository:

```
PLY no longer writes cached table files.  Honestly, the use of
the cached files made more sense when I was developing PLY on
my 200Mhz PC in 2001. It's not as much as an issue now. For small
to medium sized grammars, PLY should be almost instantaneous.
```

In practice, I have found this to be true; namely, `./mach build pre-export export` takes just about as long on my machine after this patch as it did before, and in a try push I performed, there's no noticeable performance regression from applying this patch. In local testing I also found that generating the LALR tables in calls to `yacc()` takes about 0.01s on my machine generally, and we generate these tables a couple dozen times total over the course of the `export` tier now. This isn't *nothing*, but in my opinion it's also not nearly long enough where it would be a concern given how long `export` already takes.

That `CHANGES` file also stresses that if caching this data is important, we have the option of doing so via `pickle`. If and when we decide that re-enabling this optimization is valuable for us, we should take control of this process and perform the generation in such a way that we can guarantee reproducibility.

Differential Revision: https://phabricator.services.mozilla.com/D73484
2020-05-07 00:39:28 +00:00
Ricky Stewart 4d4b22b3de Bug 1599658 - Delete previous definition of py_action in Makefiles. Now py_action calls into Python 3 and py3_action doesn't exist. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72487
2020-05-05 20:04:30 +00:00
Ian Moody 85f9392bc8 Bug 1536556 - Add custom no-throw-cr-literal ESLint rule, and enable it by default. r=Standard8
This rule is based on the ESLint built-in no-throw-literal. Cr.ERRORs are also
literals since they are just integers and so have all the same disadvantages of
no stack info.

TestInterfaceJS.js is explicitly testing handling of throwing raw Cr.ERRORs and
thus needs to stay.

Differential Revision: https://phabricator.services.mozilla.com/D28072
2020-05-05 15:00:50 +00:00
Tom Schuster f77a3af47a Bug 1277799 - Define @@toStringTag on all DOM interface prototype objects. r=peterv
Instead of manually defining toStringTag we now add the toStringTag symbol to the list of properties.
This is also how we usually define toStringTag in the JS engine.
Even though this changes more code I like this approach better. Everything is centralized in the generated bindings file.

Differential Revision: https://phabricator.services.mozilla.com/D72179
2020-05-05 17:54:51 +00:00
Peter Van der Beken 6c885dbb71 Bug 1629390 - Don't crash when throwing exception with invalid UTF-8. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D73203
2020-04-30 10:25:58 +00:00
Jon Coppeard f76ace3dcd Bug 1634435 - Rename AutoValueArray to RootedValueArray everywhere for consistency with other rooted things r=jandem,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D73295
2020-05-04 16:50:59 +00:00
Bogdan Tara f137fa0613 Backed out 6 changesets (bug 1632916, bug 1599658, bug 1633037, bug 1633039, bug 1633016, bug 1632920) for SA bustages CLOSED TREE
Backed out changeset 332ce0963b4e (bug 1633039)
Backed out changeset a9904cbc40d9 (bug 1633037)
Backed out changeset d06b0ec349f8 (bug 1599658)
Backed out changeset 8fd300cad80f (bug 1633016)
Backed out changeset f8820941c703 (bug 1632916)
Backed out changeset ac9c2c8746ed (bug 1632920)
2020-05-02 01:49:29 +03:00
Ricky Stewart 0daacc12c3 Bug 1599658 - Delete previous definition of py_action in Makefiles. Now py_action calls into Python 3 and py3_action doesn't exist. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D72487
2020-04-30 15:27:13 +00:00
Tom Schuster 16e34d88a9 Bug 1633145 - Replace NON_INTEGER_ATOM_TO_JSID. r=jandem
This also allows us to remove JSID_FROM_BITS and gives us stronger assertions everywhere for the whack integer-string case.

Differential Revision: https://phabricator.services.mozilla.com/D72564
2020-04-30 18:18:35 +00:00
Tom Schuster bd161088e3 Bug 1633145 - Replace INTERNED_STRING_TO_JSID. r=jandem
I am honstely still not convinced that this function should actually exists.
It seems like a convulted way of saying AtomToId, while also asserting that the atom is pinned.

Differential Revision: https://phabricator.services.mozilla.com/D72563
2020-04-30 18:18:12 +00:00
Simon Giesecke 3d350bb101 Bug 1628692 - Make Sequence infallibly copyable for now. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D71574
2020-04-29 08:50:23 +00:00
Jon Coppeard 4452987eb3 Bug 1633468 - Make dom/bindings/Codegen.py compare against JSID_VOID to detect uninitialized jsid members r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D72701
2020-04-28 18:12:12 +00:00
Tom Schuster 037471de0d Bug 1633145 - Add PropertyKey::isWellKnownSymbol. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D72537
2020-04-26 17:01:57 +00:00
Tom Schuster 708481e981 Bug 1633145 - Hide internal flags in JSPropertySpec. r=arai
Consumers should not have to care about JSPROP_INTERNAL_USE_BIT.

Differential Revision: https://phabricator.services.mozilla.com/D72528
2020-04-25 14:06:40 +00:00
Ricky Stewart 38f4d8fa39 Bug 1621361 - Convert webidl to py3_action r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D71803
2020-04-24 16:17:26 +00:00
Jon Coppeard 7cf55278e0 Bug 1425450 - Ensure that we call Drop/HoldJSObjects when a preserved wrapper is changed for one in a different zone r=mccr8
So that we can update the holders table correctly we will need to remove the wrapper from its original vector and add it to the one associated with the new zone.

I tried to make SetPreservingWrapper private but there's still a use in layout/style/Rule.cpp that I couldn't see an obvious fix for.

Differential Revision: https://phabricator.services.mozilla.com/D68521
2020-04-20 17:08:14 +00:00
Andrea Marchesini 3a6775ecf7 Bug 1630947 - Update Reporting API - part 1 - ReportingObserver in workers, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D71317
2020-04-18 12:25:57 +00:00
Cosmin Sabou 948e626a26 Backed out 2 changesets (bug 1630947) for causing build bustages on ReportingObserver.cpp. CLOSED TREE
Backed out changeset 18c357daf0f7 (bug 1630947)
Backed out changeset 6bfed9f2487d (bug 1630947)
2020-04-17 23:16:58 +03:00
Andrea Marchesini aaa72f6ebb Bug 1630947 - Update Reporting API - part 1 - ReportingObserver in workers, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D71317
2020-04-17 19:55:28 +00:00
Nika Layzell 1840f4505c Bug 1630361 - Remove [NeedsWindowsUndef] attribute from webidl, r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D69450
2020-04-16 23:40:57 +00:00
Ricky Stewart cb6b22fac9 Bug 1628954 - Don't use 'is' and 'is not' to perform comparison against strings in Python r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D71059

--HG--
extra : moz-landing-system : lando
2020-04-15 17:03:05 +00:00
Zibi Braniecki fcdb32de94 Bug 1621674 - Unify Localization.jsm, mozILocalization and Localization WebIDL. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D66531

--HG--
extra : moz-landing-system : lando
2020-04-10 23:35:03 +00:00
Stefan Hindli 37b364e264 Backed out 3 changesets (bug 1621674) for causing xpcshell permafailures in browser/extensions/formautofill/test/unit/test_createRecords.js CLOSED TREE
Backed out changeset f45de944f20a (bug 1621674)
Backed out changeset 0b2fdf331bce (bug 1621674)
Backed out changeset 2f7e9c807020 (bug 1621674)
2020-04-08 00:49:16 +03:00
Zibi Braniecki 7510f5c207 Bug 1621674 - Unify Localization.jsm, mozILocalization and Localization WebIDL. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D66531

--HG--
extra : moz-landing-system : lando
2020-04-07 18:03:46 +00:00
Razvan Maries 24116686ba Backed out 3 changesets (bug 1621674) for newtab perma failures. CLOSED TREE
Backed out changeset f197d83fd8a1 (bug 1621674)
Backed out changeset 939beec809c1 (bug 1621674)
Backed out changeset a657cda5467e (bug 1621674)
2020-04-07 21:00:15 +03:00
Zibi Braniecki 804246b7c6 Bug 1621674 - Unify Localization.jsm, mozILocalization and Localization WebIDL. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D66531

--HG--
extra : moz-landing-system : lando
2020-04-07 16:28:12 +00:00
Mike Hommey 1899edeb67 Bug 1627163 - Don't use binary mode to read/write json files in mozwebidlcodegen. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D69530

--HG--
extra : moz-landing-system : lando
2020-04-05 08:51:20 +00:00
Kearwood Gilbert 9136ce65cf Bug 1614496 - Implement WebXR Core Module DOM Interfaces r=jgilbert,daoshengmu,webidl,smaug,baku,imanol
Implement DOM interfaces for the WebXR Core Module. Additional work to implement the WebXR Core Module are marked with TODO (Bug #) comments within the patch and must be landed before enabling the dom.vr.webxr.enabled flag.

Differential Revision: https://phabricator.services.mozilla.com/D62369

--HG--
extra : moz-landing-system : lando
2020-04-06 19:33:32 +00:00
Bogdan Tara 40fdcf8307 Backed out 2 changesets (bug 1621726) for web platform test failures CLOSED TREE
Backed out changeset ebe18133a194 (bug 1621726)
Backed out changeset c43c38de33b2 (bug 1621726)
2020-04-06 22:03:02 +03:00
Bogdan Tara eddea671e7 Backed out 6 changesets (bug 1425450) for hazard failure complaining about nsWrapperCacheInlines CLOSED TREE
Backed out changeset c57ac2e125e8 (bug 1425450)
Backed out changeset 4238c59af7bb (bug 1425450)
Backed out changeset 2a00272e72ba (bug 1425450)
Backed out changeset 3e4a52d596bb (bug 1425450)
Backed out changeset 5da68de67491 (bug 1425450)
Backed out changeset efac091a3ba4 (bug 1425450)
2020-04-06 21:22:51 +03:00
Jon Coppeard eff4a09dd5 Bug 1425450 - Ensure that we call Drop/HoldJSObjects when a preserved wrapper is changed for one in a different zone r=mccr8
So that we can update the holders table correctly we will need to remove the wrapper from its original vector and add it to the one associated with the new zone.

I tried to make SetPreservingWrapper private but there's still a use in layout/style/Rule.cpp that I couldn't see an obvious fix for.

Differential Revision: https://phabricator.services.mozilla.com/D68521

--HG--
extra : moz-landing-system : lando
2020-04-06 16:13:51 +00:00
Nika Layzell 0113f6578d Bug 1621726 - Part 2: Remove [NeedsWindowsUndef] attribute from webidl, r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D69450

--HG--
extra : moz-landing-system : lando
2020-04-06 15:06:32 +00:00
Andi-Bogdan Postelnicu 8d7ba435cf Bug 1626584 - Make `dom/bindings` buildable outside of `unified-build` environment. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D69185

--HG--
extra : moz-landing-system : lando
2020-04-01 14:24:09 +00:00
Tom Schuster 97d9a753fc Bug 1170775 - Rename DOM Xray DefineProperty parameter from *defined to *done. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D68721

--HG--
extra : moz-landing-system : lando
2020-04-02 05:44:22 +00:00
André Bargull 14ca007916 Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.

Differential Revision: https://phabricator.services.mozilla.com/D68561

--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
André Bargull 73a498ec0c Bug 1625138 - Part 38: Replace mozilla::IsSame with std::is_same in dom/. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68557

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
André Bargull 9de017ffb8 Bug 1625138 - Part 33: Replace mozilla::IntegralConstant with std::integral_constant. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68552

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull cae4e1fdbc Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D68401

--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
André Bargull 1be056677a Bug 1625138 - Part 26: Replace mozilla::Conditional with std::conditional. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68381

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
Andrew Sutherland 940bf90242 Bug 1545345 - Improve worker shutdown. r=baku,smaug
Differential Revision: https://phabricator.services.mozilla.com/D65132

--HG--
extra : moz-landing-system : lando
2020-03-27 22:40:58 +00:00
Ciure Andrei 2c62d81ee6 Backed out changeset 1911a0d1e751 (bug 1545345) for causing CallbackObject.cpp bustages CLOSED TREE 2020-03-27 21:47:15 +02:00
Andrew Sutherland 40755c31a8 Bug 1545345 - Improve worker shutdown. r=baku,smaug
Differential Revision: https://phabricator.services.mozilla.com/D65132

--HG--
extra : moz-landing-system : lando
2020-03-27 17:36:20 +00:00
Csoregi Natalia cb7b1f507b Backed out changeset e608cbaf20d4 (bug 1545345) for assertion failures on WorkerPrivate.cpp. CLOSED TREE 2020-03-27 07:55:21 +02:00
Andrew Sutherland 2c52fdcd48 Bug 1545345 - Improve worker shutdown. r=baku,smaug
Differential Revision: https://phabricator.services.mozilla.com/D65132

--HG--
extra : moz-landing-system : lando
2020-03-13 18:22:37 +00:00
Jon Coppeard c1e3671c97 Bug 1624810 - Set the multi-zone JS holder flag on appropriate cycle collected classes r=mccr8
Set the flag on the affected classes, which are:
 - CallbackTimeoutHandler
 - nsJSArgArray
 - CallbackObject
 - Console
 - MessageEvent
 - IDBIndexCursor
 - ExtendableMessageEvent
 - JSPurpleBuffer

Differential Revision: https://phabricator.services.mozilla.com/D68196

--HG--
extra : moz-landing-system : lando
2020-03-26 10:49:06 +00:00
Byron Campen [:bwc] a36e252242 Bug 1620308: Move RTCDTMFSender logic to a single c++ class. r=smaug,jib,mjf
Differential Revision: https://phabricator.services.mozilla.com/D67513

--HG--
extra : moz-landing-system : lando
2020-03-25 18:46:37 +00:00
Tom Schuster d65152a788 Bug 1622562 - Remove ErrorReport flags everywhere. r=mccr8
Depends on D67143

Differential Revision: https://phabricator.services.mozilla.com/D67783

--HG--
extra : moz-landing-system : lando
2020-03-24 10:13:15 +00:00
Jeff Walden 361725476a Bug 1624473 - Use #include <type_traits> in Codegen.py instead of #include "mozilla/TypeTraits.h", as a step toward removing the latter now that it's no longer needed. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67951

--HG--
extra : moz-landing-system : lando
2020-03-23 23:05:55 +00:00
Andrea Marchesini 6e5bd2d254 Bug 1402784 - Use nsIContentPolicy::TYPE_INTERNAL_AUDIOWORKLET and nsIContentPolicy::TYPE_INTERNAL_PAINTWORKLET in Worklet code, r=smaug
Depends on D67105

Differential Revision: https://phabricator.services.mozilla.com/D67106

--HG--
extra : moz-landing-system : lando
2020-03-17 22:24:39 +00:00
David Teller c781dd8809 Bug 1580447 - Expose Content{Parent, Child} to JS;r=nika
Differential Revision: https://phabricator.services.mozilla.com/D65344

--HG--
extra : moz-landing-system : lando
2020-03-20 09:11:32 +00:00
Byron Campen [:bwc] 1898507132 Bug 1616875: Create RTCRtpReceiver in c++, and move code into it from both JSImpl and other places in c++. Also, move some code from JSImpl to PeerConnectionImpl. r=jib,smaug
Differential Revision: https://phabricator.services.mozilla.com/D64235

--HG--
extra : moz-landing-system : lando
2020-03-20 15:33:24 +00:00
Bogdan Tara 2b0b0d8b79 Backed out 9 changesets (bug 1616875) for bustages complaining about RTCRtpReceiver.h CLOSED TREE
Backed out changeset 92ed87a5add4 (bug 1616875)
Backed out changeset 96b3a322e605 (bug 1616875)
Backed out changeset a301ce4e5571 (bug 1616875)
Backed out changeset ac73b2ce3e20 (bug 1616875)
Backed out changeset f5a201261e83 (bug 1616875)
Backed out changeset 36892aed2a94 (bug 1616875)
Backed out changeset 2c21627f3678 (bug 1616875)
Backed out changeset ebdad7b7b632 (bug 1616875)
Backed out changeset 3bad18c7a567 (bug 1616875)
2020-03-20 16:38:30 +02:00
Byron Campen [:bwc] fc5f5e381e Bug 1616875: Create RTCRtpReceiver in c++, and move code into it from both JSImpl and other places in c++. Also, move some code from JSImpl to PeerConnectionImpl. r=jib,smaug
Differential Revision: https://phabricator.services.mozilla.com/D64235

--HG--
extra : moz-landing-system : lando
2020-03-19 18:41:58 +00:00
Tom Schuster 5eb9932e47 Bug 1621813 - Remove nsIScriptError.exceptionFlag. r=mccr8
I made some changes in preparation for removing nsIScriptError.flags in favor
of nsIConsoleMessage.logLevel.

Differential Revision: https://phabricator.services.mozilla.com/D66878

--HG--
extra : moz-landing-system : lando
2020-03-19 21:31:44 +00:00
Arthur Iakab 768dcd08ae Backed out changeset 0b8ffd5fed51 (bug 1580447) for causing build bustages.
CLOSED TREE
2020-03-19 14:53:26 +02:00
David Teller 96c856d32a Bug 1580447 - Expose Content{Parent, Child} to JS;r=nika
Differential Revision: https://phabricator.services.mozilla.com/D65344

--HG--
extra : moz-landing-system : lando
2020-03-19 09:13:48 +00:00
Anthony Ramine bb80ccaa01 Bug 1623061 - Fix a couple of syntax mistakes in WebIDL.py; r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D67145

--HG--
extra : moz-landing-system : lando
2020-03-17 13:36:10 +00:00
Marco Bonardo 2dc20c6432 Bug 1621328 - Move CreateExposableURI into nsIOService. r=Gijs,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D66269

--HG--
extra : moz-landing-system : lando
2020-03-13 12:44:36 +00:00
Tom Schuster ff852cea9c Bug 1621817 - Remove nsIScriptError.strictFlag. r=remote-protocol-reviewers,mccr8,whimboo
I am not sure if you are okay with reviewing all those test changes.
Sadly it's not that easy to search through our huge JavaScript code
base for some generic name like 'isStrict'.

Differential Revision: https://phabricator.services.mozilla.com/D66573

--HG--
extra : moz-landing-system : lando
2020-03-13 16:12:16 +00:00
Ricky Stewart 13aa77e4a5 Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3 produce consistent results r=dmajor
Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.)

Differential Revision: https://phabricator.services.mozilla.com/D66089

--HG--
extra : moz-landing-system : lando
2020-03-12 21:05:26 +00:00
Narcis Beleuzu 4437350f38 Backed out changeset 1f0cfca78242 (bug 1619460) perf regression in automation, req by rstewart. CLOSED TREE
--HG--
extra : rebase_source : ef3f1ce03bc9fdedb81d33ede68f9925f447ba32
2020-03-12 19:37:27 +02:00
Boris Chiou 014b6a5b9e Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug
We should throw a DOMException SyntaxError when setting pseudoElement a
syntactically invalid string or an unsupported pseudo.

Differential Revision: https://phabricator.services.mozilla.com/D66321

--HG--
extra : moz-landing-system : lando
2020-03-12 00:34:46 +00:00
Zibi Braniecki 4cf04c19e6 Bug 1560038 - Add FluentBundle. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D54325

--HG--
extra : moz-landing-system : lando
2020-03-11 15:37:39 +00:00
Zibi Braniecki 312c9d7359 Bug 1560038 - Add FluentMessage and FluentPattern. r=emilio,smaug
Differential Revision: https://phabricator.services.mozilla.com/D54324

--HG--
extra : moz-landing-system : lando
2020-03-11 15:36:56 +00:00
Zibi Braniecki 51c9856f7e Bug 1560038 - Add FluentResource. r=emilio,smaug
Differential Revision: https://phabricator.services.mozilla.com/D54323

--HG--
extra : moz-landing-system : lando
2020-03-11 15:42:33 +00:00
Daniel Varga a2cbf61a81 Backed out 9 changesets (bug 1560038) for causing build bustage
CLOSED TREE

Backed out changeset 12069dae9b8d (bug 1560038)
Backed out changeset a0845cf79487 (bug 1560038)
Backed out changeset dc2406d01a63 (bug 1560038)
Backed out changeset 1b11616a5ee5 (bug 1560038)
Backed out changeset 06cdc27a39a7 (bug 1560038)
Backed out changeset a390456d9d26 (bug 1560038)
Backed out changeset 7e3d839a3e9d (bug 1560038)
Backed out changeset 0678db762fed (bug 1560038)
Backed out changeset 3b9b16532bf3 (bug 1560038)
2020-03-11 04:53:10 +02:00
Zibi Braniecki 0114269ceb Bug 1560038 - Add FluentBundle.
Differential Revision: https://phabricator.services.mozilla.com/D54325

Depends on D54324

--HG--
extra : rebase_source : 1e5118fcdaba1121b775c9afdee8264212c3a5e3
2020-03-10 14:16:07 +02:00
Zibi Braniecki 3d02e9e6cf Bug 1560038 - Add FluentMessage and FluentPattern.
Differential Revision: https://phabricator.services.mozilla.com/D54324

Depends on D54323

--HG--
extra : rebase_source : 24e514ce2b188735a869584e140bc8334d4ab5a6
2020-03-10 14:15:33 +02:00
Zibi Braniecki 8b91a599a2 Bug 1560038 - Add FluentResource.
Differential Revision: https://phabricator.services.mozilla.com/D54323

Depends on D56641

--HG--
extra : rebase_source : 1087ad4b1f401d942f3be65a1a215b0ef7d1a10e
2020-03-10 20:05:06 +02:00
Daniel Varga 22ab1c2ce6 Backed out 9 changesets (bug 1560038) for causing build bustages.
CLOSED TREE

Backed out changeset 350df98095f8 (bug 1560038)
Backed out changeset 56dd15fbeced (bug 1560038)
Backed out changeset 570aa7aaceb5 (bug 1560038)
Backed out changeset fc4da4a1c192 (bug 1560038)
Backed out changeset 7c69b0e5fd93 (bug 1560038)
Backed out changeset 1caf41590caf (bug 1560038)
Backed out changeset b4bf28bec6a8 (bug 1560038)
Backed out changeset e923de659c2b (bug 1560038)
Backed out changeset 7f1be4424898 (bug 1560038)
2020-03-10 22:22:40 +02:00
Zibi Braniecki fed784dcef Bug 1560038 - Add FluentBundle. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D54325

--HG--
extra : moz-landing-system : lando
2020-03-10 12:16:07 +00:00
Zibi Braniecki 9cffa798e1 Bug 1560038 - Add FluentMessage and FluentPattern. r=emilio,smaug
Differential Revision: https://phabricator.services.mozilla.com/D54324

--HG--
extra : moz-landing-system : lando
2020-03-10 12:15:33 +00:00
Zibi Braniecki 288da34db6 Bug 1560038 - Add FluentResource. r=emilio,smaug
Differential Revision: https://phabricator.services.mozilla.com/D54323

--HG--
extra : moz-landing-system : lando
2020-03-10 18:05:06 +00:00
Boris Zbarsky a2c83198eb Bug 1619114. Convert ThrowErrorMessage to using JS_ReportErrorNumberUTF8Array. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D65350

--HG--
extra : moz-landing-system : lando
2020-03-10 15:13:49 +00:00
Ricky Stewart 5a39034089 Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3 produce consistent results r=dmajor
Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.)

Differential Revision: https://phabricator.services.mozilla.com/D66089

--HG--
extra : moz-landing-system : lando
2020-03-09 22:34:19 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Boris Zbarsky a48980ac8c Bug 1619112 part 6. Remove duplicated string array appender bits. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65544

--HG--
extra : moz-landing-system : lando
2020-03-06 21:08:17 +00:00
Boris Zbarsky 00cd5d4380 Bug 1619112 part 5. Stop accepting nsAString in ErrorResult error-throwing. r=smaug
Callers should pass in UTF-8, since that's what the JS engine ends up with in the end anyway.

The various URL changes are because NS_NewURI converts incoming nsAString to
UTF-8 anyway.  So we might as well do that up-front and then use the UTF-8
string for both the NS_NewURI call and the error-reporting if it fails.

Differential Revision: https://phabricator.services.mozilla.com/D65543

--HG--
extra : moz-landing-system : lando
2020-03-06 21:08:02 +00:00
Boris Zbarsky c878a8bb26 Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65538

--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
Boris Zbarsky 8015d8dbc8 Bug 1619112 part 1. Change the internal storage for ErrorResult errors-with-messages to UTF8 strings. r=smaug
CStringArrayAppender is just a copy of StringArrayAppender with the incoming
types expanded to accept both wide and narrow strings.  Later patches will
remove the wide-string variants incrementally.

Differential Revision: https://phabricator.services.mozilla.com/D65537

--HG--
extra : moz-landing-system : lando
2020-03-06 20:54:56 +00:00
Boris Zbarsky ddfdf6585a Bug 1618011 part 11. Don't expose method names like __namedsetter to the web. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D65204

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:17 +00:00
Boris Zbarsky 793a22384c Bug 1618011 part 9. Make error reporting for unions nicer. r=peterv
Instead of something like
"ByteStringSequenceSequenceOrByteStringByteStringRecord" we should have
"(sequence<sequence<ByteString>> or record<ByteString, Bytestring>)" in error
messages.

Please take a careful look at the resulting error messages (see attachment
in the bug) to see whether this makes sense.

Differential Revision: https://phabricator.services.mozilla.com/D64890

--HG--
extra : moz-landing-system : lando
2020-03-06 23:07:17 +00:00
Boris Zbarsky da6fb20d19 Bug 1618011 part 8. Switch ByteString conversions to having a method name prefix. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64889

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Boris Zbarsky 0082f55dee Bug 1618011 part 7. Switch most error messages used in bindings to having a method name prefix. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64888

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Boris Zbarsky 61e0515f43 Bug 1618011 part 6. Pass a BindingCallContext (if neded) and source description to primitive conversions. r=peterv
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").

Differential Revision: https://phabricator.services.mozilla.com/D64887

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Boris Zbarsky 8a18c1c3ae Bug 1618011 part 5. Use a BindingCallContext for Web IDL callback guts. r=peterv
We basically need this because some of the type conversions those guts need to
do may need a BindingCallContext.

We could probably do more optimization here to only generate the
BindingCallContext bits if we will really need them, more or less based on our
return type.  But for now that doesn't seem worthwhile.

Differential Revision: https://phabricator.services.mozilla.com/D64886

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Boris Zbarsky e322a9eb2f Bug 1618011 part 4. Pass a BindingCallContext to dictionary Init() methods. r=peterv
Dictionaries always need a BindingCallContext, because they can throw
MSG_NOT_DICTIONARY from Init().

We allow non-binding callsites to pass JSContext*, in which case they will not
get quite-as-nice error reporting.

Differential Revision: https://phabricator.services.mozilla.com/D64885

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:15 +00:00
Boris Zbarsky 1d77f0de96 Bug 1618011 part 3. Pass a BindingCallContext to union setters. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64884

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:15 +00:00
Boris Zbarsky f612519949 Bug 1618011 part 2. Add a BindingCallContext class. r=peterv
We instantiate this class in various binding methods.  Future patches will make
use of it to throw errors.

Differential Revision: https://phabricator.services.mozilla.com/D64883

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:15 +00:00
Boris Zbarsky 14b7f5071e Bug 1618011 part 1. Implement support for error context in ThrowErrorMessage. r=peterv
This does not change behavior at the moment, because the only callers of
ThrowErrorMessage that pass an error number that has a context pass an empty
string for the first (context) arg.  Both of those callers are changed to pass
nullptr for the context in this patch.

We want to support nullptr to mean "empty context", because that way at
callsites we can avoid having extra empty strings.

We could avoid putting this machinery in place if we hardcoded the trailing
": " at all the callsites, but that would reduce future flexibility in where the
context is placed in the message string (e.g. if we wanted to move it to the
end instead of the beginning) and increase the amount of string data we have to
cart around in the binary quite noticeably: we have a _lot_ of places in
bindings where we call ThrowErrorMessage.

Differential Revision: https://phabricator.services.mozilla.com/D64882

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:15 +00:00
Arthur Iakab 14247fb057 Backed out 11 changesets (bug 1618011)for Linting failure.
CLOSED TREE

Backed out changeset 8b11ddd8999f (bug 1618011)
Backed out changeset 11df2f359473 (bug 1618011)
Backed out changeset c50121035d50 (bug 1618011)
Backed out changeset 8b8c4c60c34b (bug 1618011)
Backed out changeset b01f8c66110b (bug 1618011)
Backed out changeset 433fdf04058c (bug 1618011)
Backed out changeset 29a9227d08ac (bug 1618011)
Backed out changeset b2dfa2e66d24 (bug 1618011)
Backed out changeset 85650ee945c4 (bug 1618011)
Backed out changeset 278a213e5304 (bug 1618011)
Backed out changeset 9119aeb72ea4 (bug 1618011)
2020-03-07 00:15:57 +02:00
Boris Zbarsky 2bec2783ba Bug 1618011 part 11. Don't expose method names like __namedsetter to the web. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D65204

--HG--
extra : moz-landing-system : lando
2020-03-06 20:40:03 +00:00
Boris Zbarsky 7eef692e9d Bug 1618011 part 9. Make error reporting for unions nicer. r=peterv
Instead of something like
"ByteStringSequenceSequenceOrByteStringByteStringRecord" we should have
"(sequence<sequence<ByteString>> or record<ByteString, Bytestring>)" in error
messages.

Please take a careful look at the resulting error messages (see attachment
in the bug) to see whether this makes sense.

Differential Revision: https://phabricator.services.mozilla.com/D64890

--HG--
extra : moz-landing-system : lando
2020-03-06 20:39:43 +00:00
Boris Zbarsky 2564974432 Bug 1618011 part 8. Switch ByteString conversions to having a method name prefix. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64889

--HG--
extra : moz-landing-system : lando
2020-03-06 20:39:23 +00:00
Boris Zbarsky bc068d0e54 Bug 1618011 part 7. Switch most error messages used in bindings to having a method name prefix. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64888

--HG--
extra : moz-landing-system : lando
2020-03-06 20:39:10 +00:00
Boris Zbarsky 0a681b4df5 Bug 1618011 part 6. Pass a BindingCallContext (if neded) and source description to primitive conversions. r=peterv
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").

Differential Revision: https://phabricator.services.mozilla.com/D64887

--HG--
extra : moz-landing-system : lando
2020-03-06 20:38:55 +00:00
Boris Zbarsky 539c585bfc Bug 1618011 part 5. Use a BindingCallContext for Web IDL callback guts. r=peterv
We basically need this because some of the type conversions those guts need to
do may need a BindingCallContext.

We could probably do more optimization here to only generate the
BindingCallContext bits if we will really need them, more or less based on our
return type.  But for now that doesn't seem worthwhile.

Differential Revision: https://phabricator.services.mozilla.com/D64886

--HG--
extra : moz-landing-system : lando
2020-03-06 20:38:11 +00:00
Boris Zbarsky 242fd385c0 Bug 1618011 part 4. Pass a BindingCallContext to dictionary Init() methods. r=peterv
Dictionaries always need a BindingCallContext, because they can throw
MSG_NOT_DICTIONARY from Init().

We allow non-binding callsites to pass JSContext*, in which case they will not
get quite-as-nice error reporting.

Differential Revision: https://phabricator.services.mozilla.com/D64885

--HG--
extra : moz-landing-system : lando
2020-03-06 20:30:52 +00:00
Boris Zbarsky 8cc6fcde91 Bug 1618011 part 3. Pass a BindingCallContext to union setters. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64884

--HG--
extra : moz-landing-system : lando
2020-03-06 20:30:40 +00:00
Boris Zbarsky 0dbc444246 Bug 1618011 part 2. Add a BindingCallContext class. r=peterv
We instantiate this class in various binding methods.  Future patches will make
use of it to throw errors.

Differential Revision: https://phabricator.services.mozilla.com/D64883

--HG--
extra : moz-landing-system : lando
2020-03-06 20:30:22 +00:00
Boris Zbarsky 7b42d528f1 Bug 1618011 part 1. Implement support for error context in ThrowErrorMessage. r=peterv
This does not change behavior at the moment, because the only callers of
ThrowErrorMessage that pass an error number that has a context pass an empty
string for the first (context) arg.  Both of those callers are changed to pass
nullptr for the context in this patch.

We want to support nullptr to mean "empty context", because that way at
callsites we can avoid having extra empty strings.

We could avoid putting this machinery in place if we hardcoded the trailing
": " at all the callsites, but that would reduce future flexibility in where the
context is placed in the message string (e.g. if we wanted to move it to the
end instead of the beginning) and increase the amount of string data we have to
cart around in the binary quite noticeably: we have a _lot_ of places in
bindings where we call ThrowErrorMessage.

Differential Revision: https://phabricator.services.mozilla.com/D64882

--HG--
extra : moz-landing-system : lando
2020-03-06 20:29:54 +00:00
Boris Zbarsky 0b8d2cf399 Bug 1617974. Simplify OOMReporter setup. r=peterv
We don't really need the OOMReporterInstantiator bit.  We can just use
FastErrorResult on the binding side, with casting to OOMReporter to ensure
callees take that, not an ErrorResult.

Differential Revision: https://phabricator.services.mozilla.com/D64184

--HG--
extra : moz-landing-system : lando
2020-03-04 16:52:13 +00:00
Boris Zbarsky 9d69c2d87d Bug 1617972. Add a table that stores the exception type of DOM errors. r=peterv
The callsite in DOMIntersectionObserver did end up throwing a RangeError, as the
spec requires, because in the end we just used the exception code to determine
the kind of exception to throw, but was misleading about what it was doing.

Differential Revision: https://phabricator.services.mozilla.com/D64175

--HG--
extra : moz-landing-system : lando
2020-03-03 15:47:22 +00:00
Andrew McCreight 4babb2b5ab Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
Patch by bhackett and jlaster. Also reviewed by mccr8.

Differential Revision: https://phabricator.services.mozilla.com/D60197

--HG--
extra : moz-landing-system : lando
2020-02-27 17:39:15 +00:00
Boris Zbarsky f6cdd2b50e Bug 911444 part 4. Expose a print method on PDF viewer windows. r=bholley
The method is exposed only if the consumer has the same principal as the PDF
would have if it were not getting the PDF viewer treatment.

The method just calls the print() method in the PDF viewer window.

It's enough to expose this on nsOuterWindowProxy, not RemoteOuterWindowProxy,
because PDF documents end up in the process they would have been in based on
their pre-PDF-viewer principal, since we do process determination in the parent
process but only run the pdfjs stream converter in the content process, once we
have decided which one to use.

Differential Revision: https://phabricator.services.mozilla.com/D63711

--HG--
extra : moz-landing-system : lando
2020-02-27 14:54:53 +00:00
Ciure Andrei 00dd87f6f4 Backed out changeset d407a28318e6 (bug 1609815) for causing windows ming bustages CLOSED TREE
--HG--
extra : histedit_source : b2c748e31e0f6ba8fcf9960a336e0bbd361b07e6
2020-02-27 07:05:19 +02:00
Andrew McCreight b197e1f783 Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
Patch by bhackett and jlaster. Also reviewed by mccr8.

Differential Revision: https://phabricator.services.mozilla.com/D60197

--HG--
extra : moz-landing-system : lando
2020-02-27 04:43:48 +00:00
Tetsuharu OHZEKI bc1492747e Bug 1496147 - part 1: Remove nsAutoPtr usages from dom/bindings. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D64057

--HG--
extra : moz-landing-system : lando
2020-02-25 17:20:34 +00:00
Tetsuharu OHZEKI 2a9b28c762 Bug 1496147 - part 0: Use alias template to define StrongPtrForMember<T>. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D64056

--HG--
extra : moz-landing-system : lando
2020-02-25 16:49:58 +00:00
Dorel Luca 1def5d818a Backed out 4 changesets (bug 911444) for Mochitest failures in dom/base/test/test_pdf_print.html. CLOSED TREE
Backed out changeset d156bbaabbd5 (bug 911444)
Backed out changeset a32592af0b11 (bug 911444)
Backed out changeset b96d0a37ed1a (bug 911444)
Backed out changeset fd2e3e8728d9 (bug 911444)
2020-02-25 00:11:50 +02:00
Boris Zbarsky b4ea855936 Bug 911444 part 4. Expose a print method on PDF viewer windows. r=bholley
The method is exposed only if the consumer has the same principal as the PDF
would have if it were not getting the PDF viewer treatment.

The method just calls the print() method in the PDF viewer window.

It's enough to expose this on nsOuterWindowProxy, not RemoteOuterWindowProxy,
because PDF documents end up in the process they would have been in based on
their pre-PDF-viewer principal, since we do process determination in the parent
process but only run the pdfjs stream converter in the content process, once we
have decided which one to use.

Differential Revision: https://phabricator.services.mozilla.com/D63711

--HG--
extra : moz-landing-system : lando
2020-02-22 05:25:35 +00:00
Mike Shal c8abdd68c2 Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D63438

--HG--
extra : moz-landing-system : lando
2020-02-21 00:05:17 +00:00
Csoregi Natalia 6360b24e80 Backed out 2 changesets (bug 1616630) for Android bustage. CLOSED TREE
Backed out changeset 15016546c954 (bug 1616630)
Backed out changeset dcb7dc51633b (bug 1616630)
2020-02-20 21:24:11 +02:00
Mike Shal 39492660f4 Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart
Depends on D63437

Differential Revision: https://phabricator.services.mozilla.com/D63438

--HG--
extra : moz-landing-system : lando
2020-02-20 16:21:55 +00:00
Simon Giesecke 8fc0c81644 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/bindings. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D63137

--HG--
extra : moz-landing-system : lando
2020-02-20 15:47:53 +00:00
Simon Giesecke 9350e6b741 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Dorel Luca d5f9df8ee1 Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke 59b23375c0 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
Boris Chiou 4f3959bfee Bug 1610981 - Eliminate usage of CSSPseudoElement from KeyframeEffect. r=birtles,smaug
Replace ElementOrCSSPseudoElement with Element and add PseudoElement (which is
a DOMString) into KeyframeAnimationOptions and KeyframeEffect.

Differential Revision: https://phabricator.services.mozilla.com/D62667

--HG--
extra : moz-landing-system : lando
2020-02-18 20:44:14 +00:00
Edgar Chen 960446a64e Bug 1615741 - Make converting a buffer source follow the spec when a shared buffer is passed in; r=bzbarsky
Converting a shared buffer source to buffer souce type should
always throw if the type isn't annotated with [AllowShared].

Differential Revision: https://phabricator.services.mozilla.com/D63047

--HG--
extra : moz-landing-system : lando
2020-02-18 21:03:17 +00:00
Mike Shal d8e4653d19 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-14 13:22:46 +00:00
Boris Zbarsky 6cef0413af Bug 1615719 followup to fix review comment.
Differential Revision: https://phabricator.services.mozilla.com/D62962

--HG--
extra : moz-landing-system : lando
2020-02-14 21:23:46 +00:00
Boris Zbarsky 8ed7224b37 Bug 1615719. Refactor how we get IDL method names for error reporting. r=peterv
The only behavior change here is that now we consistently use "Foo constructor"
to describe constructors.  Before this we used "Foo" for the argument count and
arguments up to the overload resolution distinguishing argument and "Foo
constructor" for later arguments.

Differential Revision: https://phabricator.services.mozilla.com/D62346

--HG--
extra : moz-landing-system : lando
2020-02-14 21:20:19 +00:00
Boris Zbarsky f781fa6569 Bug 1615022 part 3. Disallow conversion of CopyableErrorResult to ErrorResult&. r=farre
This keeps us from passing it to functions that are planning to throw on the
ErrorResult and might throw a JS exception on it.

Differential Revision: https://phabricator.services.mozilla.com/D62633

--HG--
extra : moz-landing-system : lando
2020-02-14 10:19:05 +00:00
Boris Zbarsky 6c66fa85a4 Bug 1615022 part 2. Require an rvalue reference to reject a Promise with an ErrorResult. r=farre,kvark
The rejection process consumes the ErrorResult, so an rvalue reference is the honest thing here.

Differential Revision: https://phabricator.services.mozilla.com/D62632

--HG--
extra : moz-landing-system : lando
2020-02-14 15:42:30 +00:00
Boris Zbarsky 7c42333b8a Bug 1615022 part 1. Allow move-constructing ErrorResult from CopyableErrorResult. r=farre
We need the explicit constructor because otherwise which conversion operator to
use when constructing an ErrorResult from a CopyableErrorResult&& is
ambiguous.  And we want the conversion operator to allow passing
CopyableErrorResult& to functions that expect ErrorResult&&.

Differential Revision: https://phabricator.services.mozilla.com/D62631

--HG--
extra : moz-landing-system : lando
2020-02-14 08:37:39 +00:00
Cosmin Sabou ff39f9206d Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing l10n langpack bustages. a=backout
Backed out changeset 77e54e76848a (bug 1611326)
Backed out changeset 36ba18ac3a68 (bug 1613263)
2020-02-14 15:02:21 +02:00
Mike Shal ad0c283ab2 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 23:07:04 +00:00
Brindusan Cristian e2fb6b8344 Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at update-1.xpi.stub. CLOSED TREE 2020-02-13 23:33:34 +02:00
Mike Shal e6464dd404 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 20:31:50 +00:00
Simon Giesecke b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
shindli 91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Dzmitry Malyshau bf6b5347b2 Bug 1611024 - Turn WebGPU programmable passes into interface mixins r=jgilbert,webidl,bzbarsky
this makes us closer to the upstream spec and removes a bunch of useless code

Differential Revision: https://phabricator.services.mozilla.com/D62377

--HG--
extra : moz-landing-system : lando
2020-02-11 03:03:47 +00:00
Boris Zbarsky 05327f8a52 Bug 1613978. Allow passing u"...", not just nsAStrings, to templated ThrowType/RangeError. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D62061

--HG--
extra : moz-landing-system : lando
2020-02-10 13:08:48 +00:00
Boris Zbarsky 1395be1f23 Bug 1613013 part 3. Annotate TypeErrors and RangeErrors from WebIDL implementations with the method they come from. r=peterv
Please review the changes to Errors.msg very carefully.  I caught a number of
mistakes there in self-review (e.g. not renumbering replacement markers
correctly when I added {0} to the beginnings of strings), and my confidence
that I caught them all is only middling.

A few lines (MSG_USELESS_SETTIMEOUT, MSG_TYPEDARRAY_IS_DETACHED,
MSG_NOT_SUBMIT_BUTTON) were removed from Errors.msg either because they were
already unused or because they either were single-user constant strings or
became such in the new setup and we could just use the string version of
ThrowTypeError.

Differential Revision: https://phabricator.services.mozilla.com/D61523

--HG--
extra : moz-landing-system : lando
2020-02-06 21:22:32 +00:00
Boris Zbarsky 09a1a6496e Bug 1613013 part 2. Change ThrowErrorMessage to be templated on the error number. r=peterv
This makes it easier to static_assert correct use.  It caught several bugs in
the next patch in this stack.

I had to disambiguate some calls to the templated ThrowDOMException that are
inside the binding_detail namespace, because otherwise they were trying to call
teh non-template function of the same name that's declared in binding_detail.

Differential Revision: https://phabricator.services.mozilla.com/D61522

--HG--
extra : moz-landing-system : lando
2020-02-06 20:40:36 +00:00
Boris Zbarsky 747a4d9f0a Bug 1613013 part 1. Annotate DOMExceptions from WebIDL implementations with the method they come from. r=peterv
This adds the name of the interface and method to the beginning of the exception
string when reporting the exception from Web IDL codegen, so it's clearer what
was called.

Some existing error messages are adjusted to not duplicate the information
about which method was called.

Differential Revision: https://phabricator.services.mozilla.com/D61521

--HG--
extra : moz-landing-system : lando
2020-02-06 21:16:10 +00:00
Boris Zbarsky 02b5075a4f Bug 1152078. Remove the const_cast<ErrorResult> bits from DOM cache code. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D61651

--HG--
extra : moz-landing-system : lando
2020-02-05 16:15:07 +00:00
Edgar Chen f2e63f3027 Bug 1543570 - Make CustomElementConstructor exceptions more consistent; r=smaug
See https://github.com/whatwg/html/pull/4525.

Differential Revision: https://phabricator.services.mozilla.com/D61247

--HG--
extra : moz-landing-system : lando
2020-02-04 23:47:18 +00:00
Emilio Cobos Álvarez 322cec0c5e Bug 1612510 - Remove IsChromeOrXBL*. r=bzbarsky
XBL is no longer a thing... Also, should we rename AllowContentXBLScope?

Differential Revision: https://phabricator.services.mozilla.com/D61359

--HG--
extra : moz-landing-system : lando
2020-02-04 21:28:57 +00:00
Boris Zbarsky 9b0b56bfc7 Bug 1612213 part 3. Switch Promise::RejectWithDOMException consumers to new convenience methods. r=smaug,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D61269

--HG--
extra : moz-landing-system : lando
2020-02-03 20:37:32 +00:00
Boris Zbarsky 7a16020858 Bug 1612213 part 2. Move the DOMException definitions from ErrorResult.h into a separate file. r=smaug
This way we can use the for Promise too.

Differential Revision: https://phabricator.services.mozilla.com/D61268

--HG--
extra : moz-landing-system : lando
2020-01-30 08:57:42 +00:00
Boris Zbarsky b88d5ac5a8 Bug 1612213 part 1. Switch most consumers of ThrowDOMException to the new methods. r=smaug,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D61267

--HG--
extra : moz-landing-system : lando
2020-02-03 20:19:11 +00:00
Boris Zbarsky a389959875 Bug 1412856 part 1. Change ClientOpPromise to use a CopyableErrorResult for its rejection type. r=dom-workers-and-storage-reviewers,sg?
Differential Revision: https://phabricator.services.mozilla.com/D61196

--HG--
extra : moz-landing-system : lando
2020-01-30 09:01:26 +00:00
Boris Zbarsky 5cd4320f78 Bug 1612007. Add convenience methods for throwing various spec-defined DOMExceptions on ErrorResult. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D61202

--HG--
extra : moz-landing-system : lando
2020-01-29 09:09:11 +00:00
Boris Zbarsky c9e8a8042b Bug 1611509 part 3. Remove the Date type from Web IDL. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D61054

--HG--
extra : moz-landing-system : lando
2020-01-27 08:50:35 +00:00
Boris Zbarsky e1ebd96a21 Bug 1611509 part 2. Stop using Date in Reporting.webidl. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D61053

--HG--
extra : moz-landing-system : lando
2020-01-25 05:57:04 +00:00
Boris Zbarsky 2f0e749001 Bug 1611505. Remove now-unnecessary null-checks. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D61007

--HG--
extra : moz-landing-system : lando
2020-01-26 14:10:26 +00:00
Edgar Chen 9e846bd48a bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D60514

--HG--
extra : moz-landing-system : lando
2020-01-23 03:22:06 +00:00
Edgar Chen c4e4fdbd64 Bug 1575425 - Part 5: Remove DataAllowShared and LengthAllowShared from TypedArray bindings; r=bzbarsky
There's no need for two explicit APIs as we get safety from the IDL layer. And
treating a SharedArrayBuffer as an empty buffer is wrong too.

Differential Revision: https://phabricator.services.mozilla.com/D60003

--HG--
extra : moz-landing-system : lando
2020-01-22 13:09:49 +00:00
Edgar Chen 57d1c9d779 Bug 1575425 - Part 3: Add support for [AllowShared]; r=bzbarsky,jwalden
Differential Revision: https://phabricator.services.mozilla.com/D59999

--HG--
extra : moz-landing-system : lando
2020-01-23 14:18:53 +00:00
Edgar Chen 7572e4a211 Bug 1575425 - Part 2: Merge ArrayBuffer and SharedArrayBuffer in DOM binding; r=bzbarsky,jwalden
We need this for upcoming change which supports having [AllowShared] on
ArrayBuffer type in WebIDL.

Differential Revision: https://phabricator.services.mozilla.com/D59989

--HG--
extra : moz-landing-system : lando
2020-01-23 13:48:02 +00:00
Edgar Chen 1ff24dddf7 Bug 1575425 - Part 1: Remove SharedArrayBuffer type in WebIDL parser; r=bzbarsky
There is no SharedArrayBuffer type defined in WebIDL spec.

Differential Revision: https://phabricator.services.mozilla.com/D59988

--HG--
extra : moz-landing-system : lando
2020-01-22 13:03:41 +00:00
Emilio Cobos Álvarez 256c124f94 Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
This was done by:

This was done by applying:

```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
         from subprocess import Popen, PIPE, check_output, CalledProcessError

         diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
-        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']

         if not output_file:
             args.append("-i")
```

Then running `./mach clang-format -c <commit-hash>`

Then undoing that patch.

Then running check_spidermonkey_style.py --fixup

Then running `./mach clang-format`

I had to fix four things:

 * I needed to move <utility> back down in GuardObjects.h because I was hitting
   obscure problems with our system include wrappers like this:

0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94              ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94     MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94                                ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)

   Which I really didn't feel like digging into.

 * I had to restore the order of TrustOverrideUtils.h and related files in nss
   because the .inc files depend on TrustOverrideUtils.h being included earlier.

 * I had to add a missing include to RollingNumber.h

 * Also had to partially restore include order in JsepSessionImpl.cpp to avoid
   some -WError issues due to some static inline functions being defined in a
   header but not used in the rest of the compilation unit.

Differential Revision: https://phabricator.services.mozilla.com/D60327

--HG--
extra : moz-landing-system : lando
2020-01-20 16:19:48 +00:00
Emilio Cobos Álvarez aa3a695712 Bug 1609996 - Remove mozilla/Move.h. r=froydnj
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'

Further manual fixups and cleanups to the include order incoming.

Differential Revision: https://phabricator.services.mozilla.com/D60323

--HG--
extra : moz-landing-system : lando
2020-01-20 16:18:20 +00:00
Andreas Farre 68ac0a2401 Bug 1583863 - Part 3: WindowContext using SyncedContext, r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D56743

--HG--
extra : moz-landing-system : lando
2020-01-20 14:58:52 +00:00
pbz 70e1dba79e Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D55811

--HG--
extra : moz-landing-system : lando
2020-01-16 14:38:40 +00:00
Andrea Marchesini a91dd40dff Bug 1024312 - Get rid of IDBDatabase.mozCreateFileHandle, r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D59499

--HG--
extra : moz-landing-system : lando
2020-01-14 15:09:02 +00:00
Tom Schuster 163e9d47af Bug 1565170 - Disable toSource/uneval in non-chrome code. r=jwalden,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D37689

--HG--
extra : moz-landing-system : lando
2020-01-09 11:48:58 +00:00
Sylvestre Ledru c521758c5e Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D58175

--HG--
extra : moz-landing-system : lando
2020-01-09 21:50:11 +00:00
Masatoshi Kimura ef626b5951 Bug 1448967 - Remove enablePrivilege. r=mccr8,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D57243

--HG--
rename : testing/firefox-ui/resources/security/enable_privilege.html => js/xpconnect/tests/mochitest/test_enable_privilege.html
extra : moz-landing-system : lando
2020-01-08 23:14:48 +00:00
Jeff Gilbert e1d0fe64bb Bug 1477756 - Client-side bindings mirror for precise CC, and merge similar codepaths. r=handyman
* Context loss using RAII
* Move Program reflection Client-side

Depends on D54018

Differential Revision: https://phabricator.services.mozilla.com/D54019

--HG--
extra : moz-landing-system : lando
2020-01-08 22:19:16 +00:00
David Parks 198fa063c2 Bug 1477756 - Initial out-of-process WebGL implementation. r=mccr8,handyman
Splits WebGLContext into ClientWebGLContext and HostWebGLContext.  The Client enables the JS-control of a WebGL context in a content procecss while the Host executes the WebGL graphics operations (via a WebGLContext that maintains much of the existing code) in the compositor process.  At this point, the cross-process behavior is disabled -- this series of patches is an incremental step toward that final goal.

Differential Revision: https://phabricator.services.mozilla.com/D54018

--HG--
extra : moz-landing-system : lando
2020-01-08 22:19:14 +00:00
Emilio Cobos Álvarez 3f5e15cdd8 Bug 1607796 - Simplify usage of std::enable_if with std::enable_if_t. r=bzbarsky
This one is manual.

Depends on D59145

Differential Revision: https://phabricator.services.mozilla.com/D59146

--HG--
extra : moz-landing-system : lando
2020-01-08 16:11:51 +00:00
Emilio Cobos Álvarez 80322da13a Bug 1607796 - Use <type_traits> in dom/bindings. r=bzbarsky
Automatic but manually checked via s/IsBaseOf</std::is_base_of</g and so on.

Differential Revision: https://phabricator.services.mozilla.com/D59145

--HG--
extra : moz-landing-system : lando
2020-01-08 16:40:12 +00:00
Emilio Cobos Álvarez f210527c4f Bug 1607595 - Manual fixups, and remove mozilla::IsBaseOf. r=froydnj
This is manual, but hopefully trivial.

Differential Revision: https://phabricator.services.mozilla.com/D59014

--HG--
extra : moz-landing-system : lando
2020-01-08 14:52:18 +00:00
Emilio Cobos Álvarez e363a41bd4 Bug 1607595 - Remove uses of mozilla::IsBaseOf. r=froydnj
Automatically generated by:

$ rg 'IsBaseOf<' | cut -d : -f 1 | xargs sed -i 's/mozilla::IsBaseOf</std::is_base_of</g'
$ rg 'IsBaseOf<' | cut -d : -f 1 | xargs sed -i 's/IsBaseOf</std::is_base_of</g

Differential Revision: https://phabricator.services.mozilla.com/D59013

--HG--
extra : moz-landing-system : lando
2020-01-08 14:52:10 +00:00
Emilio Cobos Álvarez 400567dcde Bug 1606958 - Use FakeString for UTF8String. r=bzbarsky,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D58683

--HG--
extra : moz-landing-system : lando
2020-01-07 21:37:12 +00:00
Boris Zbarsky 330b219787 Bug 1607347. Back out part of revision 3c1f509939f1 to fix null-dereference crashes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D58989

--HG--
extra : moz-landing-system : lando
2020-01-07 19:00:07 +00:00
Emilio Cobos Álvarez 4d059556c2 Bug 1607406 - Add TypedArray::Create(Span<T>) and remove an ugly cast in TextEncoder. r=bzbarsky
The bounds check becomes needed now, though it should hopefully be optimized
away too as all the involved calls that you need to know about to determine that
it can't happen are inline.

Differential Revision: https://phabricator.services.mozilla.com/D58909

--HG--
extra : moz-landing-system : lando
2020-01-07 15:42:19 +00:00
Arthur Iakab dbec32e5b0 Backed out changeset 05d084629569 (bug 1606958) for causing Valgrind bustages. 2020-01-07 03:07:00 +02:00
Emilio Cobos Álvarez ae30f1a7bb Bug 1606958 - Use FakeString for UTF8String. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D58683

--HG--
extra : moz-landing-system : lando
2020-01-06 21:24:10 +00:00
Boris Zbarsky 810b6b879b Bug 1601175. Make sure the mDoc of an inner window is set before we call SetScriptGlobalObject on the document. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D56218

--HG--
extra : moz-landing-system : lando
2020-01-06 14:53:00 +00:00
Emilio Cobos Álvarez 6bb42bfdf8 Bug 1449861 - Add codegen support for UTF8String. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D58629

--HG--
extra : moz-landing-system : lando
2020-01-04 10:36:49 +00:00
Emilio Cobos Álvarez b58f2e72e8 Bug 1449861 - Add UTF8String to the WebIDL parser. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D58628

--HG--
extra : moz-landing-system : lando
2020-01-04 10:35:21 +00:00
nordzilla 869949428a Bug 1604340 - Allow [Pref] for WebIDL constructor r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D57723

--HG--
extra : moz-landing-system : lando
2019-12-21 00:46:20 +00:00
Chris Peterson 406763af7f Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj
This changeset is a simple find and replace of `MOZ_FALLTHROUGH` and `[[fallthrough]]`.

Unfortunately, the MOZ_FALLTHROUGH_ASSERT macro (to assert on case fallthrough in debug builds) is still necessary after switching from [[clang::fallthrough]] to [[fallthrough]] because:

* MOZ_ASSERT(false) followed by [[fallthrough]] triggers a -Wunreachable-code warning in DEBUG builds
* but MOZ_ASSERT(false) without [[fallthrough]] triggers a -Wimplicit-fallthrough warning in NDEBUG builds.

Differential Revision: https://phabricator.services.mozilla.com/D56440

--HG--
extra : moz-landing-system : lando
2019-12-20 07:16:43 +00:00
Edgar Chen b1c69ce2d9 Bug 1603461 - Add support for extended attributes on nullable types; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D56954

--HG--
extra : moz-landing-system : lando
2019-12-17 09:29:35 +00:00
Oana Pop Rus 5f3c83c29f Backed out changeset f911e3de6e53 (bug 1603461) for eslint in test_attributes_on_types.html on a CLOSED TREE 2019-12-17 00:39:02 +02:00
Edgar Chen 88a6fd3ca7 Bug 1603461 - Add support for extended attributes on nullable types; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D56954

--HG--
extra : moz-landing-system : lando
2019-12-16 16:07:52 +00:00
Oana Pop Rus 661db3a39f Backed out 7 changesets (bug 1432856) for build bustages failures in nsWindow.h on a CLOSED TREE
Backed out changeset 3d08c3cce533 (bug 1432856)
Backed out changeset 49d03dd89b17 (bug 1432856)
Backed out changeset 62fc84c8ce99 (bug 1432856)
Backed out changeset a8a4fa63f5b2 (bug 1432856)
Backed out changeset c81f3d5b9bf3 (bug 1432856)
Backed out changeset 8351a8b1d96a (bug 1432856)
Backed out changeset a303b775a51b (bug 1432856)
2019-12-16 23:53:35 +02:00
pbz e03ecc2171 Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D55811

--HG--
extra : moz-landing-system : lando
2019-12-16 21:06:11 +00:00
Boris Zbarsky c4055059c2 Bug 1603289. Stop calling binding functions that take some T* via a pointer to a function type that takes void*. r=edgar
We can just take void* and then cast it explicitly, which avoids the undefined-behavior issue here.

Differential Revision: https://phabricator.services.mozilla.com/D57168

--HG--
extra : moz-landing-system : lando
2019-12-16 17:14:21 +00:00