First, we can split it with 3 parts:
1. preparation with current selection part.
2. handling deletion with collapsed selection part.
3. handling deletion with non-collapsed selection part.
The first should leave in `WillDeleteSelection()`, but the others should be
moved to independent methods.
With this change, we need to fix an odd case when there is no visible node
and `GetFirstSelectedTableCellElement()` returned error due to crossing
the method boundary. The method returns error only when there is no selection
ranges. In such case, we cannot handle deletion of current selection anyway.
So, it must not be a problem to handle the error immediately after calling
`GetFirstSelectedTableCellElement()`. Note that this shouldn't occur in
normal cases since `WillDoAction()` checks it before calling
`WillDeleteSelection()`.
Differential Revision: https://phabricator.services.mozilla.com/D44453
--HG--
extra : moz-landing-system : lando
Before moving the largest method in our tree, we should split it. This is
first preparation of that.
Differential Revision: https://phabricator.services.mozilla.com/D44451
--HG--
extra : moz-landing-system : lando
This splits marking of incoming CCWs from uncollected zones into two phases dependeing on the mark color of the source object. The targets of black or white wrappers are marked black (white means we don't know what color it should be), and targets of gray wrappers are marked gray. Where gray wrappers are later marked black by gray unmarking, we trigger a read barrier on the targed which will also have the effect of marking it black if it's in a zone we are marking.
I also added a shell function to dump information about cross compartment wrappers that was useful in debugging.
Differential Revision: https://phabricator.services.mozilla.com/D44666
--HG--
extra : moz-landing-system : lando
One less thing for configurations to vary is a good thing. This change
also means that when we do NDK bumps that introduce some kind of weird
incompatible change, configuration with a newly-pulled tree and an old
NDK halts at configure, rather than giving weird build errors.
Differential Revision: https://phabricator.services.mozilla.com/D44705
--HG--
extra : moz-landing-system : lando
And this patch makes the new method do not touch `Selection`, instead, return
new `StaticRange`. Although the creation cost may make damage to the
performance but let's keep using `StaticRange` for now. There should be
a stack only class which have 2 `RangeBoundaryBase` or `EditorDOMPointBase`.
Differential Revision: https://phabricator.services.mozilla.com/D44205
--HG--
extra : moz-landing-system : lando
Additionally, `WSRunObject::ScrabBlockBoundary()` and
`WSRunObject::PreparetToJoinBlocks()` are used only the it. Therefore, we
can clean them up.
Differential Revision: https://phabricator.services.mozilla.com/D44201
--HG--
extra : moz-landing-system : lando
The into button lacks the '-moz-appearance: none;' rule to disable the
system styling. Fix this by adding this.
Differential Revision: https://phabricator.services.mozilla.com/D44641
--HG--
extra : moz-landing-system : lando
We want the Browser Console and WebConsole to have
distinct preferences, so you might have one in
editor mode, and the other one in inline mode if
you want.
This is as simple as adding the preference, and
stripping the devtools.webconsole. prefix in
the constant we use for retrieving the preference
value.
Differential Revision: https://phabricator.services.mozilla.com/D44631
--HG--
extra : moz-landing-system : lando
A `popupnotification` could be reused, we should remove/reset optional attributes to avoid unexpected behavior.
Differential Revision: https://phabricator.services.mozilla.com/D44686
--HG--
extra : moz-landing-system : lando
This matches the requirement imposed by the Container concept that its iterator type
should be convertible to its const_iterator type.
Differential Revision: https://phabricator.services.mozilla.com/D44673
--HG--
extra : moz-landing-system : lando
In bug 1568320, we made it so that the PictureInPictureToggleChild attaches handlers to
the toggle, even on videos that have controls by default, so we don't need the
videocontrols UAWidget to call the method for firing the event anymore.
Differential Revision: https://phabricator.services.mozilla.com/D44270
--HG--
extra : moz-landing-system : lando
Jeff Muizelaar
Mihai Alexandru Michis
Masayuki Nakano
Thomas Wisniewski
Jason Laster
Andreea Pavel
Razvan Maries
Christian Holler
ffxbld
Jon Coppeard
harry
Dão Gottwald
Dorel Luca
Nathan Froyd
Marco Zehe
Sylvestre Ledru
Peter Van der Beken
Andrew Sutherland
Jan de Mooij
Tim Huang
Coroiu Cristina
Christoph Kerschbaumer
Nicolas Chevobbe
Bogdan Tara
Brindusan Cristian
Mark Banner
Liang-Heng Chen
Simon Giesecke
Mike Conley
Benjamin
Greg Tatum