This moves all the node-specific reporting to nsIDocument.
OrphanReporter delegates all the reporting to that and then returns the sum of
all sizes, which is not ideal but was pre-existing.
Also, I moved the main mStyleSheets size reporting to DocumentOrShadowRoot for
it to be shared between document and ShadowRoot.
I'll add memory reporting for the computed stylesheet maps and such in the
ShadowRoot in a followup.
I went through all the XBL bindings, though it seems I could just use
GetBindingWithContent(), since according to:
https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/dom/xbl/nsXBLBinding.cpp#615
We don't allow multiple bindings to contribute anon content. Anyway it was the
same amount of code...
Differential Revision: https://phabricator.services.mozilla.com/D4433
--HG--
extra : moz-landing-system : lando
For the time being, we do not want to expose struct types outside of
the module where they are defined, and so there must be restrictions
on how functions and global variables that traffic in struct types can
be used.
At the same time, intra-module uses of functions and globals that use
struct types must be allowed to the greatest extent possible.
Terminology: A function that takes a Ref parameter or returns a Ref
result is "exposed for Ref", as is a global of Ref type. Anyref is OK
though, in all cases.
To keep it simple we have the following restrictions that can all be
checked statically.
- Exported and imported functions cannot be exposed for Ref.
- If the module has an exported or imported table then no function
stored in that table by the module (by means of an element segment)
can be exposed for Ref.
- If the module has an exported or imported table then no
call_indirect via that table may reference a type that is exposed
for Ref.
- An exported or imported global cannot be exposed for Ref.
Conversely,
- If a module has a private table then it can contain private
functions that are exposed for Ref and it is possible to call those
functions via that table.
- If a module has a private global then it can be exposed for ref.
Note that code generators can work around the restrictions by instead
using functions and globals that use anyref, and by using downcasts to
check that the types are indeed correct. (Though the meaning of
downcast will change as the GC feature evolves.)
All the code implementing the restrictions is under an #ifdef so that
we can easily find it later; all the test cases testing the
restrictions are in a separate file. Few existing tests needed to be
adapted, and none substantially.
--HG--
extra : rebase_source : 89fbbf9524dc02f627018d11861df3ef91de851b
Previously we would unconditionally set the .external flag on a table
if it had an element segment, but we should only do this if the table
is initialized with an imported function and so may contain functions
from multiple instances.
--HG--
extra : rebase_source : b7712cedce26749768838f7213bf1574ef5baf48
And also fix a build issue with the pre-declaration of ReadOnlyCompileOptions
in vm/TraceLogging.h;
--HG--
extra : rebase_source : bb17c13f370c1cef50f09370f4a5b5055dced909
The 'x' prefix makes it clearer that these are infallible.
A couple of nsJSID methods are now also infallible.
--HG--
extra : rebase_source : fcce44a00212d6d341afbf3827b31bd4f7355ad5
There are surprisingly many of them.
(Plus a couple of unnecessary checks after `new` calls that were nearby.)
--HG--
extra : rebase_source : 47b6d5d7c5c99b1b50b396daf7a3b67abfd74fc1
BFD ld's --build-id means --build-id=sha1, but with lld it means
--build-id=fast. Both support the explicit --build-id=sha1, so use that.
Gold supports --build-id=sha1 too.
ld64, used for mac builds doesn't support neither --build-id=sha1 nor
--build-id.
This makes it much easier to update existing consumers of
XPCOMUtils.enumerateCategoryEntries to use the category manager directly.
It also, unfortunately, requires updating existing category manager consumers
to use the Services getter in order to avoid ESLint errors.
Differential Revision: https://phabricator.services.mozilla.com/D4278
--HG--
extra : rebase_source : fb9fd9b21db80af472ff6250a2e9a35e8d538147
This patch switches from GeneratorObject::finalSuspend to setClosed in order to
dodge an assertion in finalSuspend that the Generator state machine is
transitioning along an expected edge. The way the Debugger manipulates
Generator state is decidedly unexpected, from the perspective of the normal
rules, and we've decided to accept that.
Jesse Schwartzentruber
Gurzau Raul
Jon Coppeard
Myk Melez
Brian Hackett
Jan de Mooij
Ms2ger
arthur.iakab
Emilio Cobos Álvarez
Carl Corcoran
Cosmin Sabou
André Bargull
Benjamin Bouvier
Lars T Hansen
Nicholas Nethercote
Tooru Fujisawa
Jeff Walden
Mike Hommey
Kris Maglione
Dorel Luca
Ashley Hauck
Jan Beich
omersid
Jason Orendorff