Kris Maglione
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Andrew Park
b5ccd4ca2a
Bug 1412656 - Use array instead of joined string to load bookmarks. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D81431
2020-07-03 15:38:26 +00:00
Emma Malysz
9cc79d5e0c
Bug 1648613, remove bookmark and bookmarking tools panels from main view and place in template r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D81235
2020-07-01 15:14:18 +00:00
Emma Malysz
392c9ed354
Bug 1648175, remove history and library panel views from the main panel and place in template r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80306
2020-06-29 15:41:43 +00:00
Kris Maglione
e313713329
Bug 1645500: Part 2 - Remove inner-window-destroyed observer from process-content.js. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D79543
2020-06-12 21:53:14 +00:00
Gijs Kruitbosch
2090c54362
Bug 1640493 - stop including dropmarkers in all toolbarbuttons, r=mak
...
This makes dropmarkers 'optional extras', effectively, and opts the existing
consumers I could find (the places window on macOS, and the 'more engines'
item in the search field popup) into these dropmarkers.
This allows removing all the CSS that was hiding these items in various
places.
We deliberately do not support adding dropmarkers at runtime. I also noticed
that the 'more engines' item already adds the 'badged' attribute after
connecting the node to the DOM, which may result in it not applying properly,
and fixed this.
Differential Revision: https://phabricator.services.mozilla.com/D76382
2020-05-24 13:51:35 +00:00
Marco Bonardo
66e30e7da6
Bug 1627361 - Stop examining the clipboard data when updating Places commands. r=Standard8
...
We used to read the contents of the clipboard to tell if paste was enabled,
that unfortunately means updating commands was extremely slow for large
clipboard data.
After this change we only check the data flavors. This means paste will be
enabled more often, even for unsupported strings, but commands updating will
be much faster. Places updates commands often, so this is quite useful.
Differential Revision: https://phabricator.services.mozilla.com/D75202
2020-05-15 14:20:58 +00:00
Ian Moody
011b59d595
Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
...
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.
This was done automatically with a new eslint rule that will be introduced in
the next commit. One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS. The rule will be disabled for that instance.
Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Dão Gottwald
84553118c4
Bug 1634865 - Backed out bug 1625720 and bug 1625721. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D73542
2020-05-02 13:16:31 +00:00
Tim Nguyen
ebc0e940ae
Bug 1625720 - Scope popup.css to menupopup and panel custom elements. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D70343
2020-04-26 15:31:40 +00:00
Mihai Alexandru Michis
f71d7e6a52
Backed out changeset 9432b1bd3d98 (bug 1625720) for causing crashes in LayerComposite.
...
CLOSED TREE
2020-04-25 00:10:33 +03:00
Tim Nguyen
92e6364dec
Bug 1625720 - Scope popup.css to menupopup and panel custom elements. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D70343
2020-04-24 16:40:23 +00:00
Dorel Luca
bcfca7e237
Backed out changeset 64f788053239 (bug 1625720) for mochitest failures in ests/chrome/test_panel.xhtml. CLOSED TREE
2020-04-22 19:05:06 +03:00
Gijs Kruitbosch
0310c689ca
Bug 1632056 - correctly set the l10n id for the new folder button in the edit bookmarks pane, r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D71954
2020-04-22 14:32:43 +00:00
Tim Nguyen
edb3ed9de7
Bug 1625720 - Scope popup.css to menupopup and panel custom elements. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D70343
2020-04-22 13:48:05 +00:00
Tim Nguyen
2eeab7c5b4
Bug 1625721 - Split out arrow panel styles and load them as shadow DOM stylesheet. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D68713
2020-04-21 09:54:57 +00:00
Brindusan Cristian
aac7877663
Backed out changeset 6c312e49ee09 (bug 1625721) for build bustages at popup.css. CLOSED TREE
2020-04-21 12:46:28 +03:00
Tim Nguyen
61b493582b
Bug 1625721 - Split out arrow panel styles and load them as shadow DOM stylesheet. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D68713
2020-04-21 09:20:43 +00:00
Emma Malysz
aec6359182
Bug 1629376, Revert the fragment caching changes to ensure downloads are shown in Library menu. r=emilio
...
DownloadsSubview and DownloadsView do not inherit from custom elements and cannot rely on the static getFragment method.
The individual download list items all need to be cloned in order to display.
Differential Revision: https://phabricator.services.mozilla.com/D71204
2020-04-17 05:07:49 +00:00
Ciure Andrei
c95ead91a9
Backed out changeset c6490dad74ac (bug 1629376) for causing browser_toolbar_library_open_recent.js failures CLOSED TREE
2020-04-17 04:37:49 +03:00
Emma Malysz
e70835050a
Bug 1629376, Revert the fragment caching changes to ensure downloads are shown in Library menu. r=emilio
...
DownloadsSubview and DownloadsView do not inherit from custom elements and cannot rely on the static getFragment method.
The individual download list items all need to be cloned in order to display.
Differential Revision: https://phabricator.services.mozilla.com/D71204
2020-04-16 23:11:38 +00:00
Julian
ef534a1b06
Bug 1609557 - Migrate placesContextMenu.inc.xhtml to Fluent. r=fluent-reviewers,flod,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D68733
--HG--
extra : moz-landing-system : lando
2020-04-14 09:13:52 +00:00
Artem
bb5ca86820
Bug 1624713 - Convert editBookmarkOverlay.dtd to fluent r=Gijs,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D68118
--HG--
extra : moz-landing-system : lando
2020-04-10 10:56:49 +00:00
Mark Banner
88fb3a72de
Bug 1622243 - Implement the bookmark pages option in the library window. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D68776
--HG--
extra : moz-landing-system : lando
2020-04-07 12:56:19 +00:00
Mihai Alexandru Michis
af4ac5130b
Backed out changeset a32a1f5c2676 (bug 1609557) for causing bc failures.
...
CLOSED TREE
2020-04-07 12:39:37 +03:00
Julian
018ae5bc4a
Bug 1609557 - Migrate placesContextMenu.inc.xhtml to Fluent. r=fluent-reviewers,flod,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D68733
--HG--
extra : moz-landing-system : lando
2020-04-07 08:46:02 +00:00
Edgar Chen
ca012184ae
Bug 1615732 - Don't show menu on Mac when ctrl key is pressed; r=NeilDeakin
...
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66439
--HG--
extra : moz-landing-system : lando
2020-04-06 20:56:17 +00:00
Cosmin Sabou
3b3f1af25e
Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
...
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)
--HG--
extra : histedit_source : 16a05a43f3a9666c4fcf244062c28a5dc81061fd
2020-04-06 23:49:58 +03:00
Brian Grinstead
30b9da5519
Bug 1623992 - Automated rewrite from chrome://global/skin/ to chrome://global/skin/global.css in markup r=marionette-reviewers,perftest-reviewers,mossop,whimboo,sparky
...
This was generated with
```
cp .gitignore .rgignore
rg -l -g '*.{html,xhtml}' 'href="chrome://global/skin/"' | xargs sed -i "" 's/href\="chrome:\/\/global\/skin\/"/href\="chrome:\/\/global\/skin\/global.css"/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D67687
--HG--
extra : moz-landing-system : lando
2020-04-03 22:23:23 +00:00
Edgar Chen
002ef4c5f0
Bug 1615732 - Don't show menu on Mac when ctrl key is pressed; r=NeilDeakin
...
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66439
--HG--
extra : moz-landing-system : lando
2020-03-30 11:20:45 +00:00
Riley Byrd
aef12bf890
Bug 1608202 - downloads.dtd to Fluent r=mconley,Gijs,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D59634
--HG--
extra : moz-landing-system : lando
2020-04-03 14:47:28 +00:00
Emilio Cobos Álvarez
1540e2d542
Bug 1626198 - Test RTL bookmarks panels better. r=ntim
...
I can reproduce the same test failure if I add a flush after setting the
direction value in changeSidebarDirection.
This is arguably a XUL tree bug in a way, but it's a tough one to fix. But the
test is testing something else, and is testing it poorly. Make it test RTL
sidebars properly.
Differential Revision: https://phabricator.services.mozilla.com/D68993
--HG--
extra : moz-landing-system : lando
2020-03-31 14:33:49 +00:00
Dão Gottwald
1db19692be
Bug 1625636 - Remove support for buttonicon* attributes on <dialog>. r=bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D68686
--HG--
extra : moz-landing-system : lando
2020-03-28 17:11:10 +00:00
Dão Gottwald
5f75a69363
Bug 1625630 - Rename popup-internal-box to menupopup-arrowscrollbox. r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D68672
--HG--
extra : moz-landing-system : lando
2020-03-28 12:46:35 +00:00
Noemi Erli
0f8207e011
Backed out changeset 49509cff8c94 (bug 1624713) for causing bc failures in nsAtom.h CLOSED TREE
2020-03-26 20:46:07 +02:00
Artem
55666ff912
Bug 1624713 - Convert editBookmarkOverlay.dtd to fluent r=Gijs,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D68118
--HG--
extra : moz-landing-system : lando
2020-03-26 17:26:09 +00:00
Dão Gottwald
6e27e76318
Bug 1624598 - Rename MozPlacesPopup's popupbox shadow DOM part to arrowscrollbox. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D68202
--HG--
extra : moz-landing-system : lando
2020-03-25 17:06:30 +00:00
Dão Gottwald
a6cde0cee8
Bug 1623015 - Modernize scrollbox arrows. r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D67678
--HG--
rename : toolkit/themes/windows/global/scrollbox.css => toolkit/themes/shared/scrollbox.css
extra : moz-landing-system : lando
2020-03-25 13:38:44 +00:00
Noemi Erli
b4d7f44f77
Backed out changeset cdc5571c2d7c (bug 1623015) for causing mochitest failures CLOSED TREE
...
--HG--
rename : toolkit/themes/shared/scrollbox.css => toolkit/themes/windows/global/scrollbox.css
2020-03-24 17:31:35 +02:00
Dão Gottwald
913447fb35
Bug 1623015 - Modernize scrollbox arrows. r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D67678
--HG--
rename : toolkit/themes/windows/global/scrollbox.css => toolkit/themes/shared/scrollbox.css
extra : moz-landing-system : lando
2020-03-24 13:42:04 +00:00
Marco Bonardo
77b52c71ab
Bug 1622457 - Restore the Clear Downloads button position in the Library window. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D67332
--HG--
extra : moz-landing-system : lando
2020-03-23 13:05:35 +00:00
Ed Lee
acb960676c
Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
...
Differential Revision: https://phabricator.services.mozilla.com/D66128
--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Emma Malysz
039ee11a9d
Bug 1600228, lazy load the edit bookmark panel by storing in an HTML template r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D66143
--HG--
extra : moz-landing-system : lando
2020-03-13 02:22:42 +00:00
Cosmin Sabou
571c1e5045
Backed out changeset 2befc9d57826 (bug 1600228) for bc failures on browser_asrouter_bookmarkpanel.
...
CLOSED TREE
2020-03-13 02:47:45 +02:00
Emma Malysz
91c78bd4a6
Bug 1600228, lazy load the edit bookmark panel by storing in an HTML template r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D66143
--HG--
extra : moz-landing-system : lando
2020-03-12 22:01:01 +00:00
Brian Grinstead
1d2a8f18d0
Bug 1617673 - Give the root element in the bookmark properties window an id so that persistence works again r=mak
...
The ID was removed in Bug 1585482 and moved to the child dialog element which breaks xulstore persistence.
This gives the dialog a new id and uses the original "bookmarkproperties" for the window so any existing
xulstore values will work without a ui migration.
Differential Revision: https://phabricator.services.mozilla.com/D65829
--HG--
extra : moz-landing-system : lando
2020-03-09 09:49:12 +00:00
Mark Banner
2c4e35b0a6
Bug 1620218
- Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65509
--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Marco Bonardo
e02230cbe8
Bug 1616460 - Star panel tree view can move bookmarks even when it's not visible. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D64011
--HG--
extra : moz-landing-system : lando
2020-02-25 14:04:43 +00:00
egao
a3a95d7b94
Bug 1613983 - adjust test manifests for linux64 browser-chrome tests on ubuntu 1804, r=jmaher.
...
Depends on D63435
Differential Revision: https://phabricator.services.mozilla.com/D63436
--HG--
extra : moz-landing-system : lando
2020-02-20 13:50:30 +00:00
Zibi Braniecki
f3db980355
Bug 1608022 - Migrate browser-sets to Fluent. r=fluent-reviewers,Gijs,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D60068
--HG--
extra : moz-landing-system : lando
2020-01-30 21:07:20 +00:00