On Android, Windows and my local Linux machine, the height of
`.flexbox > label` in the reference is 0.5px shorter than its counterpart
in the test file, so I change `.flexbox > label` to
`display: inline-block` in the reference to fix its height since flex
items are blockified.
Also, remove unused styles.
Differential Revision: https://phabricator.services.mozilla.com/D121827
Most of them are straight-forward. Some fuzziness due to Skia around rounded
corners still. Some tests that already fail in other widgets as expected.
This is enough to green up reftests (but not WPT, yet) on Android, both with and
without WR enabled.
Nothing too concerning, all-in-all.
Differential Revision: https://phabricator.services.mozilla.com/D65667
--HG--
extra : moz-landing-system : lando
This patch adds fuzziness for three tests that have intermittent
fuzziness issues when DirectComposition virtual surfaces are enabled.
In each of the cases, there is a dashed border style, which has
occasional rasterizer accuracy issues. Each of the tests has a
max fuzziness of 0-1 value, with 0-10 pixels, so it's a minimal
amount of difference between the images.
Given this, we can add fuzziness to allow enabling the native
compositor mode, and investigate these as follow ups.
Differential Revision: https://phabricator.services.mozilla.com/D60788
--HG--
extra : moz-landing-system : lando
Support unprefixed min-content and max-content and treat the prefixed
version as aliases for
1. width, min-width, max-width if inline-axis is horizontal, and
2. height, min-height, max-height if inline-axis is vertical, and
3. inline-size, min-inline-size, max-inline-size, and
4. flex-basis.
Besides, update the test cases to use unprefixed max-content and
min-content.
Depends on D7535
Differential Revision: https://phabricator.services.mozilla.com/D7536
--HG--
extra : moz-landing-system : lando
Keywords on the sizing properties in the block axis should behave as
initial values in the flex frame. We store the keywords as enum, instead
of auto or none in nsStyleCoord, so we have to handle it explicitly.
Differential Revision: https://phabricator.services.mozilla.com/D9438
--HG--
extra : moz-landing-system : lando
Right now, when a flex item's intrinsic size is invalidated, we clear cached
flex measurements on all of its sibling flex items (indirectly, by virtue of
invalidating the flex container's intrinsic sizes, which does the dirty work of
clearing the measurements).
This is excessive. We do need to clear the measurements on any flex item
whose intrinsic sizes are invalidated, but we don't need to clear them on other
flex items whose intrinsic sizes are still valid. So: this patch changes our
implementation accordingly.
This patch isn't expected to change behavior - it should just be an
optimization.
Differential Revision: https://phabricator.services.mozilla.com/D5917
--HG--
extra : moz-landing-system : lando
These testcases now have virtually-identical copies called...
flexbox-justify-content-horiz-006.xhtml
flexbox-justify-content-vert-006.xhtml
...in our w3c-css/submitted/flexbox reftest directory. So these ones don't need
to exist anymore.
--HG--
extra : rebase_source : 4cc4601987d6678efd87966f94322446c7d00e98
extra : amend_source : 55186587084d49fdf786cd47bb01e2ff4ec0fb6f
This patch was written entirely by the following script:
#!/bin/bash
if [ ! -d "./.hg" ]
then
echo "Not in a source tree." 1>&2
exit 1
fi
find . -regex '.*\(ref\|crash\)test.*\.list' | while read FILENAME
do
echo "Processing ${FILENAME}."
# The following has four substitutions:
# * The first one replaces the *first* argument to fuzzy() when it doesn't
# have a - in it, by replacing it with an explicit 0-N range.
# * The second one does the same for the *second* argument to fuzzy().
# * The third does the same for the *second* argument to fuzzy-if().
# * The fourth does the same for the *third* argument to fuzzy-if().
#
# Note that this is using perl rather than sed because perl doesn't
# support non-greedy matching, which is needed for the first argument to
# fuzzy-if.
perl -pi -e 's/(fuzzy\()([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy\([^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,)([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,[^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g' "${FILENAME}"
done
Differential Revision: https://phabricator.services.mozilla.com/D2974
--HG--
extra : moz-landing-system : lando
This patch accomodates for the unfortunate fact that elements with
"table-layout:fixed" have a max-content size of nscoord_MAX (infinity,
effectively), which turns out to be an easy source of integer overflow during
flex layout.
Before this patch, a flex container with "table-layout:fixed" in several flex
items could end up triggering integer-overflow & making the wrong judgement on
its arithmetic to determine...
- whether a given flex item will fit on an existing flex line.
- whether we've got positive free space and need to grow our items, or have
negative free space and need to shrink our items.
This patch makes two changes to fix this issue.
(1) This patch makes us use CheckedInt when summing up flex item hypothetical
sizes, which prevents integer overflow from flipping the sign of our line's
total length.
(2) This patch makes us *directly* track the space reserved for flex item
margin/border/padding within a flex line. Previously, we tracked this
implicitly as the difference between two other quantities that we stored;
but with the other changes in this patch, those two other quantities can
*both* trigger overflow and get clamped, which would make us lose track of
how much space to reserve for margin/border/padding. So now we simply
track that space-to-reserve directly.
MozReview-Commit-ID: 9izhOnlS4F1
--HG--
extra : rebase_source : 185f2409dcb2f9c5bd0a2466a8e2233d7db3250a
This patch mostly[1] doesn't affect behavior. It just changes some ReflowInput
width/height-setting logic to use ISize/BSize setters instead of width/height
setters.
To help with this, I'm also adding some more getters to answer the question "is
this flex item's {inline,block} axis the same as the flex container's
{main,cross} axis", for convenience/readability at callsites. (All of these
getters are simply giving a different view of the same underlying single bit of
information.)
[1] One way this patch *kind of* affects behavior: it generalizes the
conditions under which we set the NS_FRAME_CONTAINS_RELATIVE_BSIZE flag on a
flex item. But that doesn't actually have any user-visible effects right now,
because that flag's only purpose is to determine whether we should reflow, and
currently we always reflow all flex items. If/when that changes, though
(i.e. when we start reflowing flex items more selectively), this patch is
adding a reftest that may test this generalized behavior. (The reftest actually
trivially passes right now, due to unrelated bug 1441348.)
MozReview-Commit-ID: 4NEKLBAjowh
--HG--
rename : layout/reftests/flexbox/flexbox-resizeviewport-1-helper.html => layout/reftests/flexbox/flexbox-resizeviewport-2-helper.html
rename : layout/reftests/flexbox/flexbox-resizeviewport-1-ref.xhtml => layout/reftests/flexbox/flexbox-resizeviewport-2-ref.xhtml
rename : layout/reftests/flexbox/flexbox-resizeviewport-1.xhtml => layout/reftests/flexbox/flexbox-resizeviewport-2.xhtml
extra : rebase_source : c6535e1cdcb1757a16cd02e0d485638827344c23
Skip tests that are expected to fail in both Stylo and Gecko modes. They would unexpectedly "pass" in styloVsGecko mode when comparing the two failures, which is not a useful result.
MozReview-Commit-ID: 3mOpjU225Q1
--HG--
extra : rebase_source : 22bb5d4e3c5138ef832995eaf5716824f4707ffe
extra : source : d40fb20c9a49d0797c0eeae613a04912b12a28f7
Skip tests that are expected to fail in both Stylo and Gecko modes. They would unexpectedly "pass" in styloVsGecko mode when comparing the two failures, which is not a useful result.
MozReview-Commit-ID: 3mOpjU225Q1
--HG--
extra : rebase_source : 0c307639c3626af3b6b43e05d3ee73d08b3f47ce
"random" is used where the bug is likely in the test, or the test was already
random on other platforms because the feature was not complete.
"fails" is used where it looks like the bug is in the product, so that we know
to re-enable the test with the product is fixed.
MozReview-Commit-ID: FenLhua7tm8
--HG--
extra : rebase_source : f93e5a67036174fcc20ef9209c731b311190f362
Emilio Cobos Álvarez
Ting-Yu Lin
Stephen A Pohl
Andrew Osmond
Daniel Holbert
Cosmin Sabou
Glenn Watson
Boris Chiou
L. David Baron
Mats Palmgren
Chris Peterson
Phil Ringnalda
Tooru Fujisawa
J. Ryan Stinnett
Cameron McCormack
Shing Lyu
Carsten "Tomcat" Book
Hiroyuki Ikezoe
Matt Brubeck
Sebastian Hengst
Mats Palmgren
Karl Tomlinson
Lee Salzman