Automatic update from web-platform-tests
[LayoutNG] Fix for incorrect Legacy containing block oof removal
When containing block changes from being an OOF container
to not being one, it needs to remove the positioned descendants
from its list of positioned objects.
If an OOF object remains in the positioned objects list,
it will cause NGOutOfLayoutPart::SweepLegacyDescendants
to go into an infinite loop and run out of memory. This
was fixed to just trigger a DCHECK in a recent CL.
LayoutInline::StyleDidChange did not perform OOF descendant
removal correctly. LayoutInline OOF descendants are stored in
first non-anonymous block on parent chain, (container's container)
which is not the same as ContainingBlock().
Added a method that computes container's container to
LayoutObject, and made LayoutInline call it.
This fix also works for fixed, because
fixed containers are always absolute containers.
Bug: 977930
Change-Id: I9f88fe676ec67d9d6751f3502507d773ed978dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680123
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673156}
--
wpt-commits: a8405825541d608fd26f28b0af36e6b5c42fd70a
wpt-pr: 17542
Automatic update from web-platform-tests
Test that font-family does not match against postscript names. (#17004)
The spec states "A font family name only specifies a name given to a set
of font faces, it does not specify an individual face." [1] however a
postscript name uniquely identifies a specific face rather than a family
and so should not be matched by font-family.
[1] https://drafts.csswg.org/css-fonts-3/#font-family-prop
--
wpt-commits: 79f8156a104bb55409d84b0f9ffedc13c55f26f4
wpt-pr: 17004
Automatic update from web-platform-tests
[css-ui] Test for appearance/-webkit-appearance and initial value
--
wpt-commits: 9d3498a34109f0a36c5f181c6f18d75607f9e566
wpt-pr: 14979
Automatic update from web-platform-tests
[LayoutNG] Fix hit-testing on floats in line box
This patch fixes hit-testing floats when they are included in
a line box, and extend the height of the line box.
LayoutNG places floats within a line box, and make its bounds
to include floats. Hit-testing code checks floating objects
only if foreground hit-testing did not succeeded.
This patch changes foreground hit-testing on line box to fail
if there's a float at the location. It should be ok because
line box does not have foreground objects, but this is not
the most efficient way to fix this problem. We might want to
revisit either where to put such floats, or how to hit-test
floats.
Bug: 977856
Change-Id: I687dd44ddfbf7ebcb25b38a9d90470ea939cb053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680074
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672911}
--
wpt-commits: 7baea31d05c76d6d37975bb08304088f7f50d480
wpt-pr: 17544
Automatic update from web-platform-tests
Revert "[PW] Fix paint worklet canvas clip bound calculation"
This reverts commit aa7c84555637cabd3fdb0c03d781cc6f72b9efa2.
Reason for revert: virtual/scalefactor200/external/wpt/css/css-paint-api/hidpi/canvas-transform.https.html test fails on WebKit Mac10.13 (retina).
This test consistently fails starting from https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/16135
Original change's description:
> [PW] Fix paint worklet canvas clip bound calculation
>
> Right now when we initialize the paint canvas for paint worklet with a
> scale factor or browser zoom, we do not record the zoom factor in the
> canvas transform. As a result, when computing the clip bound we will
> apply the wrong transformation matrix and thus sometimes the contents
> can be completely clipped out while it should not.
>
> This CL fixes the problem and adds a layout test.
>
> Bug: 970783
> Change-Id: Ie3709ea5845ca2b405245d4b36f9fe8f99052bad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678287
> Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#672722}
TBR=xidachen@chromium.org,smcgruer@chromium.org
Change-Id: I6c6710f76ba204c2db9d90be56845c04ff072a54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 970783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679696
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672870}
--
wpt-commits: 0804e0fcb5033df46553c9e245ffd4abbf122cf2
wpt-pr: 17553
Automatic update from web-platform-tests
[LayoutNG] Fixed crash issue when LI + zero height checkbox
List marker would resolve the bfc block_offset, but it didn't continue
to resolve its parent's. So it's possible that the bfc block_offset of
LI isn't resolved after layout list marker which will cause crash issue.
This patch make LI resolve it after layout list marker.
Bug: 969741
Change-Id: I1e1f2500217c51f24cb2633002d9a78ca1088d6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645135
Commit-Queue: cathie chen <cathiechen@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672853}
--
wpt-commits: 296089d51afdc8ee3c0c905d89d3ddebf7633af8
wpt-pr: 17183
Automatic update from web-platform-tests
Add Preload + SRI web platform tests for script + style destinations
More preload destinations will be added after this CL, as well as the
main Preload + SRI implementation, to keep the changes here minimal.
R=kouhei@chromium.org, yhirano@chromium.org, yoavweiss@chromium.org
Bug: 677022
Change-Id: I596ac006874fb02bcd330422bd6496a05d388d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669954
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672808}
--
wpt-commits: f0c2701197a8dc5682b0361698b73a0be9fd983c
wpt-pr: 17426
Automatic update from web-platform-tests
[PW] Fix paint worklet canvas clip bound calculation
Right now when we initialize the paint canvas for paint worklet with a
scale factor or browser zoom, we do not record the zoom factor in the
canvas transform. As a result, when computing the clip bound we will
apply the wrong transformation matrix and thus sometimes the contents
can be completely clipped out while it should not.
This CL fixes the problem and adds a layout test.
Bug: 970783
Change-Id: Ie3709ea5845ca2b405245d4b36f9fe8f99052bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678287
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672722}
--
wpt-commits: a5f7dc57600b83a47626507dd30216b0fa447b66
wpt-pr: 17533
Automatic update from web-platform-tests
Recalculate descendant styles when display changes to custom layout
Previously this only happened if the old display was custom layout,
but not when changing from a standard display to a custom one.
This was a typo, the same condition was checked twice for old_style,
but the second occurrence should check new_style instead.
The change matters when there are inline children that should be
blockified by the custom layout, without the patch they would remain
inline.
BUG=978990
TEST=external/wpt/css/css-layout-api/layout-child-inlines-dynamic.https.html
Change-Id: I73bcf679209dd4bc4a0d7a49f4345ee699bbf37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678484
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#672718}
--
wpt-commits: b26fcfbbc09d2fb3bfa1b9bbc643f7d4ffb971b0
wpt-pr: 17536
Automatic update from web-platform-tests
[LargestContentfulPaint] Fix flaky test observe-image.html
The timestamp captured at onload does not seem to always be smaller than
the render timestamp. This CL changes the lower bound so the test is no
longer flaky.
Bug: 978587
Change-Id: I48c058ac0abb684cb4406617500356d0aae019e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678836
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672691}
--
wpt-commits: 0a02aa2599f1914a56b8557f29ec579ca5e6e701
wpt-pr: 17528
Automatic update from web-platform-tests
Query WebMediaPlayer when checking for presence of video frame.
ReadyState has never been suficient to test whether a video frame is
actually present. Instead we need to know when the frame has actually
been delivered to the compositor.
This patch updates HTMLVideoElement to query a new WebMediaPlayer method
which exposes the compositor's knowledge of the video frame.
Note: This patch also fixes some spurious logs and HTMLVideoElement tests
that were silently doing nothing.
BUG=974012,974190
TEST=new unittest.
TBR=eae
Change-Id: I1df54491c1fd7c2246ce0f60bc6e794b8b84476a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659490
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672682}
--
wpt-commits: b6b0d9b33bd45d468f7835cb79b7de318123aead
wpt-pr: 17348
Automatic update from web-platform-tests
Web MIDI: reflect spec's [SecureContext] to relevant .idl files
This is a follow up to disallow Web MIDI uses on insecure origins.
After this change, the Web MIDI related interfaces won't appear
on insecure origins.
https://github.com/WebAudio/web-midi-api/issues/183https://github.com/WebAudio/web-midi-api/issues/199
Bug: 924471
Change-Id: I61d55d5ba192a6cbcea9e29f97c4bfe11ac4b983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673491
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672474}
--
wpt-commits: 12b6e03e14f991cc20a6b80dc7c4dc09d78ba9bf
wpt-pr: 17520
--HG--
rename : testing/web-platform/tests/feature-policy/reporting/midi-report-only.html => testing/web-platform/tests/feature-policy/reporting/midi-report-only.https.html
rename : testing/web-platform/tests/feature-policy/reporting/midi-report-only.html.headers => testing/web-platform/tests/feature-policy/reporting/midi-report-only.https.html.headers
rename : testing/web-platform/tests/feature-policy/reporting/midi-reporting.html => testing/web-platform/tests/feature-policy/reporting/midi-reporting.https.html
rename : testing/web-platform/tests/feature-policy/reporting/midi-reporting.html.headers => testing/web-platform/tests/feature-policy/reporting/midi-reporting.https.html.headers
Automatic update from web-platform-tests
[LayoutNG] Don't run the OOFLayoutPart if we have any adjoining floats.
If we have adjoining floats we'll revisit the node to correctly place
floats. During the first pass we may not have floats present within
lineboxes, causing NGContainerFragmentBuilder::GetChildOffset to fail.
This makes sure we don't run the OOFLayoutPart for this condition.
There is a followup cleanup patch I'll send out for review later which
speculatively places floats avoiding this condition also:
https://chromium-review.googlesource.com/c/chromium/src/+/1619047
Bug: 976397
Change-Id: I10db8207357572521fc9103134cb6fbf885c4a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676727
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672423}
--
wpt-commits: 5a42c001e74045dd9347ce9870fb7a8f17e6286a
wpt-pr: 17504
Automatic update from web-platform-tests
[WebUSB] Fix usage of WTF::Vector as a bit vector
When using WTF::Vector as a replacement for WTF::BitVector the bits
should be set using assignment rather than with insert() and EraseAt().
The latter changes the length of the bit vector as it is used.
Bug: 977638
Change-Id: I59390412013c97c7c06aa7239cab75a2557e8f07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673131
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672358}
--
wpt-commits: a18f55bcc133a4638fd77c67d0bc41e48c70d15d
wpt-pr: 17468
Automatic update from web-platform-tests
Set default font size for OffscreenCanvas to 10px
There's no hard standard on this, so we are matching the behavior
of detached canvas.
Bug: 977876
Change-Id: I84f8e32000f290d6826722863bb6fb16116e2f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675911
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672198}
--
wpt-commits: 79f12a79675c0b084737d43b1af2cb85f97bbff9
wpt-pr: 17496
Automatic update from web-platform-tests
Indexed DB: store/index keyPath property should return same instance
On IDBObjectStore and IDBIndex instances, the keyPath property says is
defined in the spec with: "if this attribute returns an object
(specifically an Array), it returns the same object instance every
time it is inspected". Web platform tests for this were missing.
Since the property is 'any' in Web IDL (since it could be a string or
Array) it can't use the [SameObject] extended attribute. And in the
Blink IDL, it can't use the [SaveSameObject] hint since that requires
[SameObject]. Instead, use the [CachedAttribute] hint and never dirty
the cache.
Bug: 977048
Change-Id: Ic4ede31a3a01e7a8a90c4f54eb8a989a673fcf22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674495
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672137}
--
wpt-commits: 1fd5380edd2390b2584c2c51754749d68916a525
wpt-pr: 17480
Automatic update from web-platform-tests
Individual WPT tests for each backdrop-filter
This CL adds a specific, individual WPT test for each type of
backdrop-filter effect.
If you find yourself here, looking for the test for blur() or
a multi-filter (combined) test, see crbug.com/978481.
Bug: 831485
Change-Id: I065fd94dbfe5ef0813ffe90f07878247147d3261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674708
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672131}
--
wpt-commits: d4a8ad3cb52de06a90b991dd0107f5ffbe206125
wpt-pr: 17501
Automatic update from web-platform-tests
Fetch: Origin outside of CORS
Ensure we have more coverage for how to set the Origin header outside of
CORS. And also how its value is impacted by Referrer Policy.
Fetch change: https://github.com/whatwg/fetch/pull/908.
Co-authored-by: Junior Hsu <cuveehsu@gmail.com>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
--
wpt-commits: ef44bff0adaa07f2e420a0cbc1bc493cd5786656
wpt-pr: 14260
Automatic update from web-platform-tests
math-script-level-004: Fix expectation for the font-size values. (#17534)
When the MATH table has scriptScriptPercentScaleDown the spec says 0.5041 = 0.71^2 should be used as the default value.
The scale80-0-scaleup test incorrectly uses a hardcoded value of 0.71 instead.
This patch fixes this issue and introduces new variables for the fallback values of scriptPercentScaleDown and scriptScriptPercentScaleDown
to clarify the expectation.
--
wpt-commits: 677e4ac410c6538a76c72d704768dc9c0e8bc0c5
wpt-pr: 17534
Automatic update from web-platform-tests
KV Storage: add timeout=long and reenable disabled test
Like several IndexedDB tests, KV Storage can cause timeouts unless given more time.
BUG=936615
Change-Id: I8069d77088625b32867a5ebcc9ce69c4810a18ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670621
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671576}
--
wpt-commits: 88bac6b712530867081709212b365a6a01feee04
wpt-pr: 17421
Automatic update from web-platform-tests
KV Storage: update to match IDL
Along with https://chromium-review.googlesource.com/c/chromium/src/+/1670572, this aligns the KV Storage implementation with https://github.com/WICG/kv-storage/pull/68, which uses Web IDL to define the API. The observable changes are to:
* Enumerability of methods
* Adding @@toStringTag (affecting Object.prototype.toString.call)
This includes web platform tests that abuse the current idlharness.js infrastructure, plus some ad-hoc hand-written tests that we expect to be generated by future versions of idlharness.js once the relevant Web IDL pull requests are merged. It removes the existing API surface tests and helpers in favor of idlharness.js.
Bug: 931263
Change-Id: I9205d1a8b3040617cbb6200f825ba9ad250e61c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672137
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671975}
--
wpt-commits: 72da3e36e3657a358c4e74b495e582262b40a016
wpt-pr: 17443
Automatic update from web-platform-tests
Fix font size expectation (#17524)
The local variable should match the actual font-size.
--
wpt-commits: 5fd60735ebebf21db46f272587052c360ebd7615
wpt-pr: 17524
Aleks Totic
moz-wptsync-bot
Jack Steinberg
Robert Flack
Simon Pieters
Luke Bjerring
Koji Ishii
Eric Willigers
Sergey Poromov
Dominic Farolino
Cathie Chen
Xida Chen
Oriol Brufau
Nicolás Peña Moreno
Dale Curtis
Mustaq Ahmed
Alice Boxhall
Eric Willigers
Takashi Toyoshima
Ian Kilpatrick
Reilly Grant
Fernando Serboncini
Joshua Bell
Mason Freed
Anne van Kesteren
Frédéric Wang
autofoolip
L. David Baron
Gérard Talbot
Domenic Denicola
Makoto Shimazu
Rob Buis