Граф коммитов

27 Коммитов

Автор SHA1 Сообщение Дата
Itiel 844a131a81 Bug 1590311 - Fix 'Copy All Changes' button styling for RTL. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D50115

--HG--
extra : moz-landing-system : lando
2019-10-23 12:17:45 +00:00
Razvan Caliman a850d96a7d Bug 1541824 - Make Copy All Changes button sticky in Changes panel. r=gl
Ensure the button to copy all changes remains in view even when the Changes panel is overflowing vertically.

Differential Revision: https://phabricator.services.mozilla.com/D28487

--HG--
extra : moz-landing-system : lando
2019-04-24 07:58:50 +00:00
Razvan Caliman da3aba33df Bug 1543045 - Break strings for long CSS property names and values. r=gl
Introduce `overflow-wrap: break-word` to CSS declarations in Rules view and Changes panel to prevent long strings from causing unwanted horizontal scroll

Differential Revision: https://phabricator.services.mozilla.com/D27120

--HG--
extra : moz-landing-system : lando
2019-04-12 08:58:09 +00:00
Florens Verschelde e248e2626b Bug 1543348 - Create generic button background variables; r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D26880

--HG--
extra : moz-landing-system : lando
2019-04-11 16:23:47 +00:00
Razvan Caliman 6200563298 Bug 1532511 - Update colors for buttons in Changes panel; r=pbro
Reflecting latest UI changes: https://mozilla.invisionapp.com/share/VFQC7MQSD9W#/screens

Differential Revision: https://phabricator.services.mozilla.com/D22099

--HG--
extra : moz-landing-system : lando
2019-03-05 15:28:47 +00:00
Razvan Caliman 0e24372fd4 Bug 1529599 - (Part 1) Add Copy Declaration to Changes panel context menu; r=gl
Adds a new option to the context menu which is visible only when it's invoked on a CSS declaration.
Builds a string with the property name and value and copies to the clipboard.
If the declaration is marked as removed, the string is wrapped in a comment block.

Differential Revision: https://phabricator.services.mozilla.com/D21526

--HG--
extra : moz-landing-system : lando
2019-02-28 17:30:02 +00:00
Razvan Caliman e757eeb931 Bug 1530662 - Add hover/active and dark theme colors for buttons in Changes panel. r=pbro
Adds button styles to conform to latest UI designs:
https://mozilla.invisionapp.com/share/VFQC7MQSD9W#/screens

Differential Revision: https://phabricator.services.mozilla.com/D21212

--HG--
extra : moz-landing-system : lando
2019-02-26 14:18:29 +00:00
Razvan Caliman def6b3e0fc Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl
Depends on D21007

Adds a Copy All Changes button to the toolbar of the Changes panel.
When pressed, this builds a stylesheet out of the changes for all sources tracked (stylesheets, element styles, etc)
The output format is the same as the now defunct Bug 1524548 with the added code comment as separator between the sources.

Differential Revision: https://phabricator.services.mozilla.com/D21008

--HG--
extra : moz-landing-system : lando
2019-02-25 22:37:02 +00:00
Razvan Caliman 0a37fab475 Bug 1529606 - Add Copy Rule button to Changes panel. r=pbro
Adds a button that shows up when hovering selectors in the Changes panel.
When clicked, it invokes the same Copy Rule behavior implemented for the context menu: copies the full content of the rule with changes applied.

The added/changed CSS class names use BEM notation. I intend to refactor the Changes panel stylesheet to BEM in a follow-up patch.

Differential Revision: https://phabricator.services.mozilla.com/D20808

--HG--
extra : moz-landing-system : lando
2019-02-25 22:20:53 +00:00
arthur.iakab 01800513e9 Backed out 3 changesets (bug 1530341, bug 1529606) for causing devtools failures on browser_parsable_css.js CLOSED TREE
Backed out changeset 8a760030e793 (bug 1530341)
Backed out changeset 2c74db63f9aa (bug 1530341)
Backed out changeset 96e76fdfd8b2 (bug 1529606)
2019-02-25 21:35:09 +02:00
Razvan Caliman 4597f8fe09 Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl
Depends on D20808

Adds a Copy All Changes button to the toolbar of the Changes panel.
When pressed, this builds a stylesheet out of the changes for all sources tracked (stylesheets, element styles, etc)
The output format is the same as the now defunct Bug 1524548 with the added code comment as separator between the sources.

Differential Revision: https://phabricator.services.mozilla.com/D21008

--HG--
extra : moz-landing-system : lando
2019-02-25 17:45:47 +00:00
Razvan Caliman 8b9ef36b98 Bug 1529606 - Add Copy Rule button to Changes panel. r=pbro
Adds a button that shows up when hovering selectors in the Changes panel.
When clicked, it invokes the same Copy Rule behavior implemented for the context menu: copies the full content of the rule with changes applied.

The added/changed CSS class names use BEM notation. I intend to refactor the Changes panel stylesheet to BEM in a follow-up patch.

Differential Revision: https://phabricator.services.mozilla.com/D20808

--HG--
extra : moz-landing-system : lando
2019-02-25 17:45:40 +00:00
Razvan Caliman 146fa6af12 Bug 1527924 - (Part 2) Show selector diffs in the Changes panel. r=pbro
Depends on D19828

Updates the React component of the Changes panel to show the diff of
a rule's selector if it has changed.

The previous implementation assumed that a selector rename meant a whole
rule removal (with the old selector) followed by a whole rule addition
(with the new selector).

This new implementation tracks the changes to the selector atomically.
The main benefit is that if the selector is renamed, the diff in the
Changes panel shows only this action and not the unchanged declarations.

The test was re-enabled and adjusted to account for this difference in behaviour.

This refactor was required in order to be compatible with Bug 1525238
which lays the ground work for matching rules from the client with rules
from the server. This is necessary in order to have consistent behaviour
for export options, like Copy Rule, which need to match the rule on the
server even if its selector was changed.

Differential Revision: https://phabricator.services.mozilla.com/D19830

--HG--
extra : moz-landing-system : lando
2019-02-18 13:14:29 +00:00
Razvan Caliman 7b68c89bf0 Bug 1518512 - (Part 2) Ensure all text in Changes panel can be copied. r=gl
Depends on D17255
Replaces CSS pseudo-elements for added/removed line markers with text
elements that can be copied with the rest of the content.

Differential Revision: https://phabricator.services.mozilla.com/D17256

--HG--
extra : moz-landing-system : lando
2019-01-25 15:50:35 +00:00
Csoregi Natalia 5c853a316a Backed out 2 changesets (bug 1518512) for devtools failures on devtools/client/inspector/changes/test/browser_changes_rule_selector.js. CLOSED TREE
Backed out changeset c8f0d19844f6 (bug 1518512)
Backed out changeset 3c03e2282b4f (bug 1518512)
2019-01-25 15:41:07 +02:00
Razvan Caliman 68c5929c0b Bug 1518512 - (Part 2) Ensure all text in Changes panel can be copied. r=gl
Depends on D17255
Replaces CSS pseudo-elements for added/removed line markers with text
elements that can be copied with the rest of the content.

Differential Revision: https://phabricator.services.mozilla.com/D17256

--HG--
extra : moz-landing-system : lando
2019-01-25 12:40:34 +00:00
Razvan Caliman 76567f7663 Bug 1506455 - Enforce LTR code on RTL layout in Changes panel r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D13617

--HG--
extra : moz-landing-system : lando
2018-12-03 09:17:38 +00:00
Razvan Caliman 76d7282cde Bug 1508338 - Add dark theme colors to Changes panel; r=gl
Differential Revision: https://phabricator.services.mozilla.com/D12770

--HG--
extra : moz-landing-system : lando
2018-11-28 21:58:22 +00:00
Razvan Caliman 5800899d90 Bug 1503924 - Mark style sources from iframes in the Changes panel. r=gl
Depends on D12590

Differential Revision: https://phabricator.services.mozilla.com/D12697

--HG--
extra : moz-landing-system : lando
2018-11-26 05:02:06 +00:00
Razvan Caliman c7340b7ac9 Bug 1503924 - Move level definition to CSS variable in DOM and reuse in Changes panel stylesheet. r=gl
Depends on D12588

Support indefinite nesting by declaring the --diff-level CSS custom property as an inline style on the element at its level of nesting.
This custom property will be used in the stylesheet to compute the appropriate padding-left to create the indentation necessary.

A minumum offset is used, --diff-level-min-offset, to account for the first level (zero-indexed) and to allow additional padding on added/removed lines to clear  the +/- icons.

Differential Revision: https://phabricator.services.mozilla.com/D12590

--HG--
extra : moz-landing-system : lando
2018-11-22 19:12:27 +00:00
Razvan Caliman eedbbcdc2c Bug 1503924 - Trim source URLs to filename in Changes panel. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D12588

--HG--
extra : moz-landing-system : lando
2018-11-23 16:25:18 +00:00
Razvan Caliman b476025c74 Bug 1503595 - Add empty state for Changes panel; r=gl
Design spec: https://mozilla.invisionapp.com/share/6MLNVPYGR97#/screens

- add localization file
- add strings to show when no CSS changes are available to show
- conditionally show empty state message or diff of changes in React component

MozReview-Commit-ID: 8xYJmg0yGAM

Differential Revision: https://phabricator.services.mozilla.com/D11468

--HG--
extra : moz-landing-system : lando
2018-11-15 12:18:45 +00:00
Razvan Caliman fc90c63836 Bug 1503896 - (Part 5) Add change type to change metadata and mark whole rules as added/removed; r=pbro
Depends on D10586

Adds a new `type` param to the `change` object passed from server to the client to describe the change type. For changes to rules, the client marks the whole rule as either added or removed and styles it accordingly in the Changes panel.

Change types for declarations are not used at this time, but are put in for consistency and future-proofing.

Differential Revision: https://phabricator.services.mozilla.com/D11116

--HG--
extra : moz-landing-system : lando
2018-11-07 10:00:31 +00:00
Razvan Caliman 7cf94dd9bc Bug 1499049 - (Part 5) Refactor Changes panel to render diff of nested CSS rule structures; r=pbro
Depends on D8721

- Externalize reusable CSSDeclaration React component;
- Introduce the ability to render rules with unlimited levels of nesting, but cap indentation in the UI at a reasonable level;
- Remove accordion behavior from rules, but keep for sources;
- Cleanup CSS styles for Changes panel.

Differential Revision: https://phabricator.services.mozilla.com/D8722

--HG--
extra : moz-landing-system : lando
2018-10-25 13:42:05 +00:00
Razvan Caliman f9e1b9b9aa Bug 1478448 - (Part 4) Render tracked style changes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D3329

--HG--
extra : moz-landing-system : lando
2018-09-18 08:56:08 +00:00
Csoregi Natalia 307e8e3012 Backed out 5 changesets (bug 1478448) for devtools failures on browser_parsable_css.js . CLOSED TREE
Backed out changeset 1ece57c66cc8 (bug 1478448)
Backed out changeset 8ecc1050fdfc (bug 1478448)
Backed out changeset 775ad6690aa8 (bug 1478448)
Backed out changeset cc33bc63f405 (bug 1478448)
Backed out changeset 57b2bb7a6565 (bug 1478448)
2018-09-17 19:22:38 +03:00
Razvan Caliman d5d2274e18 Bug 1478448 - (Part 4) Render tracked style changes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D3329

--HG--
extra : moz-landing-system : lando
2018-09-17 15:06:29 +00:00