Граф коммитов

3462 Коммитов

Автор SHA1 Сообщение Дата
Emilio Cobos Álvarez 69eeb9cb6c Bug 1738608 - Make autofill background configurable via system color prefs. r=mstange
And remove the autofill.background pref for 95 (or 96, depending on
when this lands) assuming nothing terrible causes us to turn it off on
94.

Differential Revision: https://phabricator.services.mozilla.com/D129988
2021-10-31 21:28:58 +00:00
Evgenia Kotovich 228e38a58c Bug 1576768 [eslint] Turn on JavaScript linting and formatting rules for .sjs files. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D128483
2021-10-25 11:12:41 +00:00
criss 152f71d4d3 Backed out changeset b60f98f26664 (bug 1576768) for causing mochitest failures. CLOSED TREE 2021-10-22 15:55:50 +03:00
Evgenia Kotovich e29e29aa5a Bug 1576768 [eslint] Turn on JavaScript linting and formatting rules for .sjs files. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D128483
2021-10-22 11:39:46 +00:00
Emilio Cobos Álvarez c5bcd4f00f Bug 1735533 - Don't reframe scrollframes to update whether they're a abspos containing-block. r=dholbert
(if they don't have any impacted abspos descendants, of course, just
like we do for regular blocks)

Differential Revision: https://phabricator.services.mozilla.com/D128877
2021-10-21 19:58:42 +00:00
Emilio Cobos Álvarez f317384568 Bug 1736518 - Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs
To more properly support Linux having a different default at runtime.

Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.

Differential Revision: https://phabricator.services.mozilla.com/D129004
2021-10-21 09:07:12 +00:00
Emilio Cobos Álvarez 2cdb78d6a6 Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky,desktop-theme-reviewers,dao
We always use alpha visual for WebRender, and appearance: none is
unnecessary (root element has no intrinsic appearance).

Differential Revision: https://phabricator.services.mozilla.com/D128682
2021-10-18 18:51:41 +00:00
Emilio Cobos Álvarez b742f680db Bug 1509931 - Expose titlebar radius as a chrome-only CSS environment variable. r=stransky
Mostly plumbing.

Differential Revision: https://phabricator.services.mozilla.com/D128680
2021-10-18 16:22:13 +00:00
Evgenia Kotovich 0d0980ee0d Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-18 09:26:33 +00:00
Noemi Erli 2bba3cec69 Backed out changeset 2ab6bb03dcc1 (bug 1576768) for causing failures in test_double_submit.html CLOSED TREE 2021-10-18 02:05:57 +03:00
Evgenia Kotovich 3e3dff109c Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-17 14:59:14 +00:00
Emilio Cobos Álvarez c4b7109fac Bug 1736038 - Remove -moz-toolbar-prefers-color-scheme. r=dao
By making prefers-color-scheme return the ColorSchemeForChrome(), which
accounts for the Firefox theme.

Differential Revision: https://phabricator.services.mozilla.com/D128611
2021-10-15 16:53:08 +00:00
Alexandru Michis dac6815201 Backed out changeset 7c08aa027893 (bug 1576768) for causing multiple failures.
CLOSED TREE
2021-10-15 16:52:43 +03:00
Evgenia Kotovich a8b32926fa Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-15 12:58:11 +00:00
Emilio Cobos Álvarez 7db332dc3d Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert
This prevents jank when switching from overflow: auto -> hidden or such.

Differential Revision: https://phabricator.services.mozilla.com/D128367
2021-10-14 21:19:14 +00:00
Butkovits Atila 13f18064b3 Backed out 2 changesets (bug 1590247) for causing failures at scrollbar-width-paint-001.html. CLOSED TREE
Backed out changeset 9b1d970ca9c2 (bug 1590247)
Backed out changeset 57193e853f39 (bug 1590247)
2021-10-14 23:02:38 +03:00
Emilio Cobos Álvarez 45a7260acb Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert
This prevents jank when switching from overflow: auto -> hidden or such.

Differential Revision: https://phabricator.services.mozilla.com/D128367
2021-10-14 15:42:06 +00:00
Geoff Brown 7e36862b61 Bug 1724296 - Remove many skip-if(verify) test annotations (mochitest pt 2); r=jmaher
This completes the review of skip-if(verify) in mochitest.ini.

Differential Revision: https://phabricator.services.mozilla.com/D127992
2021-10-09 16:07:32 +00:00
Emilio Cobos Álvarez 445c7b4297 Bug 1734455 - Remove support for -moz-system-color() as chrome code no longer uses it (in favor of color-scheme). r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D127802
2021-10-07 11:56:17 +00:00
Emilio Cobos Álvarez e50c80851e Bug 1734115 - Add basic support for dark form controls to nsNativeBasicTheme. r=mstange
For that:

 * Tweak the standin system colors to match the non-native theme.

 * Use those system colors for button and field backgrounds.

 * Rename the "should use system colors" bit to "is high contrast",
   which is what it really is (specially now that we use system colors
   also in non-high-contrast).

Border colors and other colors like the <input type=range> and such
might need some extra tweaking perhaps, but this is a decent start and
looks good in https://crisal.io/tmp/form-controls.html afaict (dark mode
toggle needs the color-scheme pref enabled of course).

Differential Revision: https://phabricator.services.mozilla.com/D127533
2021-10-05 14:40:52 +00:00
Emilio Cobos Alvarez 21a3f0049f Bug 1733565 - Clean up button active system colors. r=mstange,desktop-theme-reviewers,dao
This patch does three things:

 * Unifies mac and gtk's buttonactivetext system colors (unships mac's from
   content, but it was never meant to be exposed).

 * Simplifies the forms.css rules, since <input type=color>'s color property
   value doesn't affect its rendering in any meaningful way.

 * Adds a buttonactiveface color, which we'll use to provide dark backgrounds
   for buttons in Windows dark mode (and is good practice, since generally
   every text system color should have a corresponding background).

So as-is it shouldn't change content-exposed behavior (except we stop exposing
the -moz-mac-buttonactivetext to content), but it's a worthy cleanup.

Depends on D127246

Differential Revision: https://phabricator.services.mozilla.com/D127259
2021-10-01 19:42:16 +00:00
Boris Chiou ac12e63d6f Bug 1676784 - Part 2: Add animation-timeline into animation shorthand. r=emilio
We use the same rule as blink: serialize the animation-timeline if
it is not the default value.

Differential Revision: https://phabricator.services.mozilla.com/D126451
2021-10-01 00:38:55 +00:00
Boris Chiou 397e076032 Bug 1676784 - Part 1: Add animation-timeline longhand property in style system. r=emilio
This patch adds the animation-timeline longhand property. For
shorthand, we will do that in the next patch.

This patch includes the aut-generated code in
devtools/shared/css/generated/properties-db.js, by `./mach devtools-css-db`.

Note:
1. we will use this property in Bug 1676791. For now, only make sure
   we parse it and serialize it correctly.
2. The syntax of animation-timeline may be updated, based on the spec
   issue: https://github.com/w3c/csswg-drafts/issues/6674.
   However, it's not a big problem to update it later, so we still can
   prototype this property based on the current version of spec.

Differential Revision: https://phabricator.services.mozilla.com/D126450
2021-10-01 00:38:54 +00:00
Emilio Cobos Álvarez be3f619a3b Bug 1732759 - Test updates. r=dholbert
Mostly progressions, as expected, but there are two bits that deserve
some attention:

 * First there are two table tests that regress (because we were
   treating fit-content like auto). However Chromium fails the
   non-tentative one also, just in a different way, so I think it's
   worth punting on changing table layout and go to the CSSWG to figure
   out if "auto" is the desired behavior here.

 * Second, there's another test that regresses
   (position-absolute-replaced-minmax.html) for the same reason, we used
   to treat the size as "auto".

   The test that regresses comes from a Chromium crash
   (https://bugs.chromium.org/p/chromium/issues/detail?id=1010798) and
   the relevant behavior different also affects other intrinsic
   keywords, so I don't think we should address it here, and is unlikely
   to be a common case in the wild if we hadn't hit this before with
   other unprefixed keywords IMO.

   In any case I filed
   https://bugzilla.mozilla.org/show_bug.cgi?id=1732780 for this
   behavior difference to investigate later.

 * Third, I removed fit-content from min-{width,height}-invalid. They
   are valid sizing keywords in css-sizing-5, and they apply to these
   properties. Other browsers also parse it.

Differential Revision: https://phabricator.services.mozilla.com/D126726
2021-09-28 11:44:33 +00:00
Emilio Cobos Álvarez a2118a17fe Bug 1732267 - Make textarea::placeholder honor white-space. r=layout-reviewers,jfkthame
This comes from https://hg.mozilla.org/mozilla-central/rev/0f28fd24bdf3,
and was done because of implementation limitations which don't apply
anymore (https://bugzilla.mozilla.org/show_bug.cgi?id=737786#c33):

 * white-space changes don't reframe anymore, they only reflow.
 * We fixed reframing of native-anonymous content to do the right thing.

This aligns <textarea> and <input>, so I think it should be
uncontroversial.

See https://github.com/w3c/csswg-drafts/issues/6669 for the discussion
that prompted this.

Differential Revision: https://phabricator.services.mozilla.com/D126471
2021-09-24 05:45:33 +00:00
Jonathan Kew 371cbff302 Bug 1729861 - Add mochitest for the effect of dynamic changes to the resistFingerprinting pref on media queries. r=emilio
This is a cut-down version of the 418986-2 testcase, with an explicit check that changes to
the resistFingerprinting pref will cause media queries to be re-evaluated and the resulting
computed styles to be updated at runtime.

Differential Revision: https://phabricator.services.mozilla.com/D126230
2021-09-22 12:41:25 +00:00
Emilio Cobos Álvarez d7c4ff7412 Bug 1729861 - Fix test for bug 418986. r=jfkthame
The test was relying on media queries not being recomputed, because it
ran something like this:

  1. RFP off: add a bunch of images with class "testImage" to the
     document. Then test all images with class "testImage".

  2. RFP on: do the same.

Note that there's no "remove all images added in step 1" step between 1
and 2. So the test with rfp on was also testing the images from step 1.
This worked before because resistFingerprinting didn't trigger
recomputation of the previous images.

Differential Revision: https://phabricator.services.mozilla.com/D126152
2021-09-22 12:41:24 +00:00
Csoregi Natalia 5232f16dc4 Backed out changeset 5523334143d9 (bug 1719938) for failures on browser_parsable_css.js. CLOSED TREE 2021-09-21 02:39:55 +03:00
lamoure6 5c23ae0374 Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio
Differential Revision: https://phabricator.services.mozilla.com/D125328
2021-09-20 22:40:42 +00:00
Csoregi Natalia 592741b7e0 Backed out changeset 0711ae54877b (bug 1719938) for bustages on media_features.rs. CLOSED TREE 2021-09-20 23:29:05 +03:00
lamoure6 a4e720c69d Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio
Differential Revision: https://phabricator.services.mozilla.com/D125328
2021-09-20 19:21:50 +00:00
Daniel Holbert 5c8ea5d84b Bug 1731371: Remove REQUIRES_UNIFIED_BUILD declaration from layout subdirectories that don't need it. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D126014
2021-09-19 04:03:41 +00:00
Emilio Cobos Álvarez 9a40a6df47 Bug 1728187 - Avoid minor alpha serialization mismatches in macOS in test_dont_use_document_colors.html.
MANUAL PUSH: Test fix CLOSED TREE
2021-09-13 02:55:42 +02:00
Emilio Cobos Álvarez 4abd90b054 Bug 1728187 - Make the non-native theme not use standins for system colors if forcing colors. r=morgan
We allow using system colors when forcing colors so it makes sense to do this.

Differential Revision: https://phabricator.services.mozilla.com/D125271
2021-09-12 23:37:47 +00:00
Iulian Moraru ebdc13da8f Backed out 2 changesets (bug 1728187) for causing reftest failures on backplate-select-001.html. CLOSED TREE
Backed out changeset 3a8197599a5c (bug 1728187)
Backed out changeset d26328903485 (bug 1728187)
2021-09-11 04:08:21 +03:00
Emilio Cobos Álvarez 694fef2dcb Bug 1728187 - Make the non-native theme not use standins for system colors if forcing colors. r=morgan
We allow using system colors when forcing colors so it makes sense to do this.

Differential Revision: https://phabricator.services.mozilla.com/D125271
2021-09-10 23:10:52 +00:00
Emilio Cobos Álvarez ba14a8c91c Bug 1730098 - Don't consider system-ui valid for user font prioritization. r=jfkthame
Since the user can't configure it, at least from the UI (we could add UI
for it but it's unclear it'd be worth it).

Differential Revision: https://phabricator.services.mozilla.com/D125182
2021-09-10 12:08:19 +00:00
Emilio Cobos Álvarez 597b7bc37d Bug 1729330 - Add a simple CSSLayerRule implementation. r=smaug
The specifics of how this is going to work are still getting spec'd /
discussed in https://github.com/w3c/csswg-drafts/issues/6576, but this
allows DevTools to work fine and the feature to be complete enough for
Nightly experimentation (with the other in-flight patches).

Otherwise devtools crashes when trying to inspect pages that use them.

Differential Revision: https://phabricator.services.mozilla.com/D124656
2021-09-08 11:18:32 +00:00
Emilio Cobos Álvarez 70f53c85d4 Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr
Also, more directly go from StyleImageRendering to wr::ImageRendering.

 * image-rendering: smooth the non-deprecated version of
   OptimizeQuality, which maps to SamplingFilter::LINEAR /
   wr::ImageRendering::Auto (which uses gl::LINEAR).

 * image-rendering: pixelated maps to wr::ImageRendering::Pixelated /
   SamplingFilter::POINT which is the same crisp-edges does.

Note that this uncovers that we were mapping image-rendering:
crisp-edges to wr::ImageRendering::Pixelated.

I'm going to preserve behavior on this patch but we should consider
switching that to map to wr::ImageRendering::CrispEdges on a
follow-up (filed bug 1728831 for this).

Differential Revision: https://phabricator.services.mozilla.com/D124378
2021-09-03 08:56:43 +00:00
Noemi Erli f3a236c514 Backed out 2 changesets (bug 856337) for causing xpcshell failures in test_css-properties-db.js CLOSED TREE
Backed out changeset 7070c7cea8ec (bug 856337)
Backed out changeset edc12b36439f (bug 856337)
2021-09-03 01:36:17 +03:00
Emilio Cobos Álvarez 1602724fa9 Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr
Also, more directly go from StyleImageRendering to wr::ImageRendering.

 * image-rendering: smooth the non-deprecated version of
   OptimizeQuality, which maps to SamplingFilter::LINEAR /
   wr::ImageRendering::Auto (which uses gl::LINEAR).

 * image-rendering: pixelated maps to wr::ImageRendering::Pixelated /
   SamplingFilter::POINT which is the same crisp-edges does.

Note that this uncovers that we were mapping image-rendering:
crisp-edges to wr::ImageRendering::Pixelated.

I'm going to preserve behavior on this patch but we should consider
switching that to map to wr::ImageRendering::CrispEdges on a
follow-up (filed bug 1728831 for this).

Differential Revision: https://phabricator.services.mozilla.com/D124378
2021-09-02 20:28:39 +00:00
Emilio Cobos Álvarez ad799bfc54 Bug 1693222 - Remove highlighttext from property_database.js as it can legitimately be currentColor in some platforms.
MANUAL PUSH: Orange fix CLOSED TREE
2021-09-01 22:56:40 +02:00
Emilio Cobos Álvarez 075d4ba939 Bug 1727537 - Fix one extra instance of the pref that I missed.
MANUAL PUSH: Trivial test fix on a CLOSED TREE
2021-08-30 14:42:21 +02:00
Emilio Cobos Álvarez 01aa139f4a Bug 1727537 - Remove layout.css.is-and-where-better-error-recovery.enabled. r=hiro
We shipped this in 84

Differential Revision: https://phabricator.services.mozilla.com/D123623
2021-08-30 11:08:40 +00:00
Andi-Bogdan Postelnicu 2fc4f70e9b Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium
Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.

This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.

Differential Revision: https://phabricator.services.mozilla.com/D122345
2021-08-25 10:46:17 +00:00
Gijs Kruitbosch 5824c28923 Bug 1724718 - fake global.css for android reftests and crashtests, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D122663
2021-08-19 12:13:00 +00:00
Mats Palmgren 14c9063444 Bug 1706080 - [css-fonts] Implement 'font-synthesis: small-caps'. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D114313
2021-08-09 21:41:34 +00:00
Emilio Cobos Álvarez baf18c5198 Bug 1723921 - Throw on invalid pseudo-elements in getComputedStyle() as per spec. r=dholbert,layout-reviewers
I need to update tests, try incoming.

Depends on D121705

Differential Revision: https://phabricator.services.mozilla.com/D121706
2021-08-07 09:55:55 +00:00
Emilio Cobos Álvarez a4e7c9e510 Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin
break-before/after: page|column seem harder because you need to deal
with nested breaks, I think, but this should be straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D121206
2021-08-03 17:56:58 +00:00
Noemi Erli 89a565ea85 Backed out changeset 67c33ba5566e (bug 1722945) for causing bustage in nsContainerFrame.cpp 2021-08-03 20:35:10 +03:00