Граф коммитов

67 Коммитов

Автор SHA1 Сообщение Дата
Nicholas Nethercote f4dd5e2636 Bug 1414096 (attempt 2) - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.

This patch finishes the job.

- It removes the nsISupportsString support.

- It converts existing code that relied on the nsISupportsString.

- It removes the lint that was set up to detect such uses of nsISupportsString.

--HG--
extra : rebase_source : b885ee784704819e181430200af5ef762e269d14
2017-11-10 09:07:48 +11:00
Narcis Beleuzu 57d9eb5fb1 Backed out 1 changesets (bug 1414096) for dt1 failures "devtools/client/commandline/test/browser_cmd_pref3.js" r=backout on a CLOSED TREE
Backed out changeset e843de356b7e (bug 1414096)
2017-11-08 18:04:01 +02:00
Nicholas Nethercote 8b3d03c666 Bug 1414096 - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.

This patch finishes the job.

- It removes the nsISupportsString support.

- It converts existing code that relied on the nsISupportsString.

- It removes the lint that was set up to detect such uses of nsISupportsString.

--HG--
extra : rebase_source : fb7af066adfa0491a79fae6282a62b08661553c8
2017-10-31 16:34:35 +11:00
Nicholas Nethercote 9252435548 Bug 1410794 (attempt 2) - Change some |string| occurrences in nsIPrefBranch.idl to |ACString|. r=erahm.
This makes the code nicer. In particular, it removes many getter_Copies()
calls. The patch also converts a lot of nsCStrings to nsAutoCString, which will
avoid heap allocation in the common case.

The patch also renames PREF_CopyCharPref() as PREF_GetCStringPref(), because
it's actually getting a string, not a char, and that matches the existing
GetCString() and GetDefaultCString() methods. Correspondingly, it also renames
PREF_SetCharPref() as PREF_SetCStringPref().

The |aPrefName| arguments in nsIPrefBranch.idl remain as |string| because they
almost always involve passing in C string literals, and passing "foo" is much
nicer than passing NS_LITERAL_CSTRING("foo").

It's worth noting that early versions of this patch used |AUTF8String| instead
of |ACString|. But it turns out that libpref stores prefs internally as Latin1.
And |ACString| is compatible with Latin1 but |AUTF8String| isn't, because
non-ASCII Latin1 strings are not valid UTF-8!

MozReview-Commit-ID: D3f7a1Vl1oE

--HG--
extra : rebase_source : e6e4b15d6d210cfd93686f96400281f02bd1d06b
2017-10-27 10:30:33 +11:00
Jonathan Kew 290894f3c9 Bug 1408782 - Force punycode display for IDNs with a <dotless-i, combining mark above> sequence. r=valentin 2017-10-16 10:19:52 +01:00
Jonathan Kew 597f9d1021 Bug 1404349 - Extend check from bug 1370497 to apply to marks with a specific Script property, as well as those with Script=Inherited. r=valentin 2017-10-09 13:23:18 +01:00
Jonathan Kew cb611a9aff Bug 1370497 - Check ScriptExtensions property of combining marks when available. r=valentin 2017-09-27 11:16:35 +01:00
Chris Peterson c4dff4f83d Bug 1402666 - Part 3: Replace Replace(NS_LITERAL_STRING("")) with ReplaceLiteral(u""). r=erahm
MozReview-Commit-ID: Ji6UdG32RF4

--HG--
extra : rebase_source : 1565a1e99f40785dad0d0d7652e42222dcdf8881
extra : source : c57e906ba75fda4745134ef8307589e28f4c8d70
2017-09-15 19:32:55 -07:00
Jonathan Kew 78a3e1848f Bug 1402048 - Remove the legacy non-IDNA2008 code path from nsIDNService, now that we always require ICU to build. r=valentin 2017-09-22 19:25:50 +01:00
Jonathan Kew eddd7a4f4e Bug 1399540 - patch 2 - Handle invalid punycode better in stringPrep to avoid mangling display of fake-punycode labels. r=valentin 2017-09-16 11:49:56 +01:00
Jonathan Kew 99ad73e474 Bug 1399540 - patch 1 - Failure to decode an individual label within the IDN should not block decoding of other valid punycode labels. r=valentin 2017-09-16 11:49:47 +01:00
Nicholas Nethercote 025461bde7 Bug 1390428 (part 1) - Remove many nsXPIDLCString local variables. r=erahm.
These are all easy cases where an nsXPIDLCString local variable is set via
getter_Copies() and then is only used in ways that nsCStrings can also be used
(i.e. no null checks or implicit conversions to |char*|).

In every case the patch trivially replaces the nsXPIDLCString with an
nsCString. (Also, there are a couple of unused nsXPIDLCString variables that
the patch simply removes.)
2017-08-16 13:58:35 +10:00
Catalin Badea bd7f60e72e Bug 1344751 - Make nsStandardURL and nsIDNService available on worker threads. r=valentin 2017-07-13 12:17:19 +01:00
Wes Kocher b43f3b0d25 Backed out 2 changesets (bug 1344751) for frequent android crashes in test_fetch_cors_sw_reroute.html a=backout
Backed out changeset ec02a5ecb2b4 (bug 1344751)
Backed out changeset 10c975d4a8f9 (bug 1344751)

MozReview-Commit-ID: GauB18HNj15
2017-07-10 14:17:35 -07:00
Catalin Badea f23d657af0 Bug 1344751 - Make nsStandardURL and nsIDNService available on worker threads. r=valentin 2017-07-10 13:09:52 +01:00
Sylvestre Ledru 4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Jonathan Kew 7be1139537 Bug 1376834 - Update data tables to Unicode 10.0 release. r=m_kato 2017-06-30 14:16:02 -07:00
Sebastian Hengst 344e75f556 Backed out changeset 976a4789deea (bug 1344751) 2017-06-28 00:00:30 +02:00
Catalin Badea 5edb1cc81a Bug 1344751 - Make nsStandardURL and nsIDNService available on worker threads. r=valentin 2017-06-27 14:45:09 -07:00
Nicholas Nethercote fe9268c4cd Bug 1374580 (part 2) - Remove nsAFlat{,C}String typedefs. r=froydnj.
All the instances are converted as follows.

- nsAFlatString  --> nsString
- nsAFlatCString --> nsCString

--HG--
extra : rebase_source : b37350642c58a85a08363df2e7c610873faa6e41
2017-06-20 19:19:05 +10:00
Jonathan Kew d74c8673ea Bug 1364283 - Treat Aspirational scripts the same as Restricted, in anticipation of UAX#31 update. r=valentin 2017-05-23 23:33:46 +01:00
Jonathan Kew ed530ec201 Bug 1353000 - Preparatory patch, explicitly make the Script enum a 16-bit type, so we can add a field to gfxShapedWord without making it bigger. r=jrmuizel 2017-04-12 14:55:10 +01:00
Jonathan Kew b809e13f8d Bug 1281448 - part 1+2 - Update character property table generator script for Unicode 9 (in particular, security/xidmodifications.txt is replaced by security/IdentifierStatus.txt and IdentifierType.txt), and adjust APIs to fit the new identifier-type property model; update the generated data files. r=m_kato 2016-11-14 09:23:49 +00:00
Sebastian Hengst 4f23e5acc2 Backed out changeset 5d9a785a37c4 (bug 1281448) for Android bustage. r=backout 2016-11-14 10:45:52 +01:00
Jonathan Kew 51e4a42011 Bug 1281448 - part 1+2 - Update character property table generator script for Unicode 9 (in particular, security/xidmodifications.txt is replaced by security/IdentifierStatus.txt and IdentifierType.txt), and adjust APIs to fit the new identifier-type property model; update the generated data files. r=m_kato 2016-11-14 09:23:49 +00:00
Andi-Bogdan Postelnicu 5ca687e238 Bug 1311669 - use auto type specifier for variable declarations to improve code readability and maintainability. r=valentin
MozReview-Commit-ID: F5YO9pVK5O8

--HG--
extra : rebase_source : 7c8d22df9ec2ade3421d5f34229827f9c419b4d2
2016-11-01 14:44:09 +02:00
Nathan Froyd 92e64e1b8c Bug 1305422 - part 4 - don't call size_forward in nsIDNService.cpp; r=erahm
We don't need to bother with iterators here at all; we can just ask the
string for its data and length directly.
2016-09-29 22:33:58 -04:00
Jonathan Kew c60f6a1ae4 Bug 1266391 - Introduce an enum class mozilla::unicode::Script, and use this instead of bare integers to specify script codes for better type checking. r=masayuki 2016-04-21 18:58:59 +01:00
Paul Bignier 1d1fd489f5 Bug 1245106 - necko compilation warnings r=mcmanus
--HG--
extra : rebase_source : 6f4adf253af73a58d3ff5561e33e34eed94e456b
2016-02-26 11:29:28 -05:00
Andrea Marchesini fa67ed1ccd Bug 1245866 - A better buffer size check in nsIDNService::IDNA2008ToUnicode, r=jfkthame 2016-02-16 17:53:44 +00:00
Andrea Marchesini caa2f9b456 Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 18:16:59 +00:00
Carsten "Tomcat" Book 3589aeeb8a Backed out changeset d6b0ffe1a7b3 (bug 1231378) 2016-01-12 15:48:54 +01:00
Andrea Marchesini 2609a149da Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 13:57:37 +00:00
Valentin Gosu f86b01846d Bug 1233610 - IDN service should return NS_ERROR_MALFORMED_URI instead of NS_ERROR_FAILURE r=mcmanus
--HG--
extra : rebase_source : ed7923a472a3da8c1dcc4161daf4836c8565629c
2016-01-07 14:31:22 +01:00
Simon Montagu 6ca8e09bc1 Bug 1218179: move from transitional to non-transitional IDNA2008 processing, r=jfkthame 2015-10-25 23:53:21 -07:00
Simon Montagu b24d492d72 Bug 479520: Implement IDNA2008 standard for International Domain Names, patch 1: build system changes, r=ted; code changes, r=jfkthame 2015-10-28 07:05:15 -07:00
Carsten "Tomcat" Book b4bb8871b5 Backed out changeset 533f3277cdbb (bug 479520) for bustage on a CLOSED TREE 2015-10-28 12:29:27 +01:00
Simon Montagu 89109c7aa9 Bug 479520: Implement IDNA2008 standard for International Domain Names, patch 1: build system changes, r=ted; code changes, r=jfkthame 2015-10-28 03:46:44 -07:00
Simon Montagu e5b15415e7 Bug 321491: Refactor error handling in nsIDNService, r=mcmanus 2015-10-02 01:27:34 -07:00
Simon Montagu 1fa581c489 Bug 319030: remove fossil support for RACE encoding and multilingual test bed from IDN code, r=jfkthame 2015-09-26 23:28:33 -07:00
Birunthan Mohanathas 7315345693 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Simon Montagu 04f33e7cf4 Bug 1183209 patch 3: update generated data files to Unicode 8, and adapt internal XIDMOD types to the new types in Unicode's xidmodifications.txt, r=jfkthame 2015-07-15 05:55:24 -07:00
Birunthan Mohanathas 189593520f Bug 869836 - Part 4: Use EqualsLiteral instead of `Equals(NS_LITERAL_STRING(...))`. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas 5f1fde8824 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Ehsan Akhgari 1b83407ce9 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Birunthan Mohanathas 8975ae03b9 Bug 784739 - Switch from NULL to nullptr in netwerk/ (1/2); r=ehsan 2013-09-19 15:28:26 -04:00
Birunthan Mohanathas f9445f6542 Bug 884332 - Part 1: Check and handle buffer truncation without asserting when converting UTF-16 to UCS-4 in nsIDNService.cpp. r=bsmith 2013-08-30 08:13:19 -04:00
Simon Montagu ca2df3f279 Only test IDN nodes against kMaxDNSNodeLen on string-prepped IDNs that we're going to send to DNS, not the Unicode form for display only. Bug 892370, r=honzab
--HG--
rename : netwerk/test/unit/test_bug722299.js => netwerk/test/unit/test_idn_urls.js
2013-07-29 22:32:37 -07:00
Joshua Cranmer 37465bc6bd Bug 884061 - Part 3q: Use NS_DECL_THREADSAFE_ISUPPORTS in netwerk/, r=macmanus
--HG--
extra : rebase_source : d029f73a1f27896c142f76dce263dd3542763b18
2013-07-18 21:24:13 -05:00
Simon Montagu 26d038858d Exclude U+30FB KATAKANA MIDDLE DOT from the non-recommended characters that force IDN labels to be displayed as punycode. Bug 857490, r=jfkthame 2013-04-09 05:47:03 -07:00