eab549fd19
Bug 1519636 - Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre
...
clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)
Differential Revision: https://phabricator.services.mozilla.com/D114211
2021-05-10 07:15:07 +00:00
a1f2f7329d
Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,valentin,sylvestre
...
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)
Differential Revision: https://phabricator.services.mozilla.com/D114618
2021-05-10 07:15:06 +00:00
e9c1a62d68
Bug 1709067 - QM: Remove the ability to define module specific QM_TRY macros; r=dom-storage-reviewers,asuth
...
Depends on D114083
Differential Revision: https://phabricator.services.mozilla.com/D114084
2021-05-03 19:44:40 +00:00
42a2a6727f
Bug 1709067 - IDB: Remove module specific QM_TRY macros; r=dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D114080
2021-05-03 19:44:38 +00:00
2372314fa1
Bug 1690025 - Move and rename DirectoryLock::Specialize to UniversalDirectoryLock::SpecializeForClient; r=dom-storage-reviewers,asuth
...
This patch also changes the only consumer to not depend on the lock passed to
OpenDirectoryListener::DirectoryLockAcquired because it uses the base type (
unsafe static_cast would have to be used).
Differential Revision: https://phabricator.services.mozilla.com/D104804
2021-05-02 09:57:15 +00:00
9c9f57574e
Bug 1700915: Change the max_delta heuristics to look at average time, sort stacks for hit count rather than clients and add aborted stacks to output. r=dom-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D113212
2021-04-29 07:04:33 +00:00
b6252c8c28
Bug 1701346 - QM: Revert QM_OR_ELSE_WARN to ordinary orElse in GetDirEntryKind; r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D113527
2021-04-28 07:33:55 +00:00
cf5e9e7c32
Bug 1690326 - Follow-up fix for the ERROR_FILE_CORRUPT to NS_ERROR_FILE_FS_CORRUPTED mapping; r=jstutte
...
The code which depends on the old generic NS_ERROR_MODULE_WIN32 mapping needs
to be updated too.
Depends on D113505
Differential Revision: https://phabricator.services.mozilla.com/D113518
2021-04-28 07:33:54 +00:00
d213540b73
Bug 1702422 - Add missing include to create_db.js in groupMismatch_profile.zip; r=dom-storage-reviewers,asuth
...
This patch also fixes the unset "accessed" flag in the origin table in
storage.sqlite.
Differential Revision: https://phabricator.services.mozilla.com/D113491
2021-04-28 07:33:53 +00:00
c9b2e50517
Bug 1702422 - Add missing include to create_db.js in removedOrigin_profile.zip; r=dom-storage-reviewers,asuth
...
An empty buffer was stored in SimpleDB because of the missing include.
Differential Revision: https://phabricator.services.mozilla.com/D113490
2021-04-28 07:33:53 +00:00
a43be2a21f
Bug 1702422 - Report failed LoadQuotaFromCache as a warning (instead of an error); r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D113370
2021-04-27 07:12:23 +00:00
4bd1418875
Bug 1702422 - Move tests intended for quota info caching into a standalone directory; r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D113369
2021-04-27 07:12:22 +00:00
8fd7eedb03
Bug 1701346 - QM: Add a comment for QM_OR_ELSE_WARN in CreateOrUpgradeDirectoryMetadataHelper::MaybeUpgradeOriginDirectory; r=asuth,dom-storage-reviewers,jstutte
...
Depends on D113066
Differential Revision: https://phabricator.services.mozilla.com/D113067
2021-04-24 08:58:31 +00:00
74252f6ada
Bug 1701346 - QM: Fix the comment in EnsureDirectory; r=asuth,dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D113066
2021-04-24 08:58:31 +00:00
4d52706661
Bug 1702415 - Fix relative path calculation of exported source files (like QuotaCommon.h); r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D112999
2021-04-23 13:59:42 +00:00
6a56d8311f
Bug 1702415 - Replace aSourceLine with aSourceFileLine; r=dom-storage-reviewers,jstutte,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D113077
2021-04-23 12:02:58 +00:00
3323c1e8c3
Bug 1702415 - Replace aSourceFile with aSourceFilePath; r=dom-storage-reviewers,jstutte,asuth
...
This patch adjusts other similar names as well:
MakeRelativeSourceFileName -> MakeSourceFileRelativePath
relativeSourceFile -> sourceFileRelativePath
thisFileRelativeSourceFileName -> thisSourceFileRelativePath
Differential Revision: https://phabricator.services.mozilla.com/D113076
2021-04-23 12:02:58 +00:00
c3a79c6d69
Backed out 3 changesets (bug 1702415) for causing quota related build bustages. CLOSED TREE
...
Backed out changeset d10768c1b3ae (bug 1702415)
Backed out changeset e00a02611cd4 (bug 1702415)
Backed out changeset 2d54750b9f34 (bug 1702415)
2021-04-23 13:27:42 +03:00
a10db98510
Bug 1702415 - Fix relative path calculation of exported source files (like QuotaCommon.h); r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D112999
2021-04-23 09:56:30 +00:00
192af47698
Bug 1702415 - Replace aSourceLine with aSourceFileLine; r=dom-storage-reviewers,jstutte,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D113077
2021-04-23 09:56:30 +00:00
c831b279f3
Bug 1702415 - Replace aSourceFile with aSourceFilePath; r=dom-storage-reviewers,jstutte,asuth
...
This patch adjusts other similar names as well:
MakeRelativeSourceFileName -> MakeSourceFileRelativePath
relativeSourceFile -> sourceFileRelativePath
thisFileRelativeSourceFileName -> thisSourceFileRelativePath
Differential Revision: https://phabricator.services.mozilla.com/D113076
2021-04-23 09:56:29 +00:00
d19d0c34c3
Bug 1706928: Ignore duplicate telemetry events and increase the maximum delay between consecutive propagation stack frames. r=dom-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D113106
2021-04-22 11:03:38 +00:00
e981a6fd53
Bug 1703310 - Enable LocalStorage NextGen (LSNG) when "network.cookie.lifetimePolicy" is set to ACCEPT_SESSION (2); r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D112326
2021-04-17 03:20:17 +00:00
be03b11109
Bug 1700676 - Unregister the lock itself before unblock other locks; r=dom-storage-reviewers,sg,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D109640
2021-04-16 01:09:11 +00:00
1631cf13b6
Bug 1647316 - Update expected file layout for test_originMismatch since the padding file will be removed if the caches.sqlite doesn't exist after initializing; r=dom-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D109639
2021-04-16 01:09:11 +00:00
c994e030b2
Bug 1647316 - Revert the change for test_initTemporaryStorage.js since we have test_originInit.js; r=dom-workers-and-storage-reviewers,janv
...
Depends on D80823
Differential Revision: https://phabricator.services.mozilla.com/D80824
2021-04-16 01:09:09 +00:00
9c2ff2bbbd
Bug 1704433: Promote AssertIsOnIOThread to DiagnosticAssertIsOnIOThread in QuotaManager::EnsureStorageIsInitialized r=dom-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D112202
2021-04-15 16:15:28 +00:00
9f7b34c24e
Bug 1700915: Python scripts that fetch and analyze QM_TRY errors. r=dom-storage-reviewers,janv
...
These scripts are not shipped with Firefox but serve to analyze the
telemetry data sent by the QM_TRY family of macros.
Differential Revision: https://phabricator.services.mozilla.com/D110277
2021-04-08 10:01:36 +00:00
1c19e643ec
Bug 1701346 - QM: Revert QM_OR_ELSE_WARN to ordinary orElse in EnsureDirectory; r=jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D109987
2021-03-26 22:55:18 +00:00
6c8c619e92
Bug 1687318 - Changed unscoped enum FileFlag to scoped enum class. r=sg
...
Differential Revision: https://phabricator.services.mozilla.com/D109462
2021-03-25 09:18:04 +00:00
7d3ef83b0f
Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers
...
This patch:
- adds QM_WARNONLY_TRY/QM_NOTEONLY_TRY macros
- adds QM_WARNONLY_TRY_UNWRAP/QM_NOTEONLY_TRY_UNWRAP macros
- adds QM_OR_ELSE_WARN/QM_OR_ELSE_NOTE sub macros
- replaces non-propagating uses of NS_WARNING with redundant messages by
QM_WARNONLY_TRY
- replaces uses of QM_TRY with orElse by QM_TRY(QM_OR_ELSE_WARN(...))
- replaces uses of QM_TRY inside an extra lambda with QM_WARNONLY_TRY
- replaces uses of QM_TRY with QM_VOID with QM_WARNONLY_TRY.
- replaces uses of QM_TRY with unwanted warnings with QM_NOTEONLY_TRY
- replaces uses of QM_TRY with additional Maybe wrapping for doing a
fallback with QM_TRY(QM_OR_ELSE_WARN(...))
Differential Revision: https://phabricator.services.mozilla.com/D108424
2021-03-24 12:27:53 +00:00
9fc0210ad3
Backed out changeset 2a3316bd2409 (bug 1686191) for causing bustages on QuotaCommon.h. CLOSED TREE
2021-03-24 07:12:55 +02:00
6edcf204fd
Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers
...
This patch:
- adds QM_WARNONLY_TRY/QM_NOTEONLY_TRY macros
- adds QM_WARNONLY_TRY_UNWRAP/QM_NOTEONLY_TRY_UNWRAP macros
- adds QM_OR_ELSE_WARN/QM_OR_ELSE_NOTE sub macros
- replaces non-propagating uses of NS_WARNING with redundant messages by
QM_WARNONLY_TRY
- replaces uses of QM_TRY with orElse by QM_TRY(QM_OR_ELSE_WARN(...))
- replaces uses of QM_TRY inside an extra lambda with QM_WARNONLY_TRY
- replaces uses of QM_TRY with QM_VOID with QM_WARNONLY_TRY.
- replaces uses of QM_TRY with unwanted warnings with QM_NOTEONLY_TRY
- replaces uses of QM_TRY with additional Maybe wrapping for doing a
fallback with QM_TRY(QM_OR_ELSE_WARN(...))
Differential Revision: https://phabricator.services.mozilla.com/D108424
2021-03-24 04:40:10 +00:00
1730e59e4a
Bug 708901 - Migrate to nsTHashSet in dom/quota. r=dom-storage-reviewers,janv
...
Depends on D108599
Differential Revision: https://phabricator.services.mozilla.com/D108600
2021-03-23 10:36:35 +00:00
c546aae9a0
Bug 1697115 - Rationalize QuotaManager::ResetUsageForClient arguments; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107616
2021-03-17 06:56:39 +00:00
b59182de8d
Bug 1697115 - Rationalize QuotaManager::DecreaseUsageForClient arguments; r=dom-storage-reviewers,sg
...
Note that the method DecreaseUsageForOrigin has been renamed to
DecreaseUsageForClient.
Differential Revision: https://phabricator.services.mozilla.com/D107615
2021-03-17 06:56:39 +00:00
de33fe2cf6
Bug 1697115 - Rationalize QuotaManager::NoteOriginDirectoryCreated arguments and return type; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107614
2021-03-17 06:56:39 +00:00
ebce7d3ac8
Bug 1697115 - Rationalize QuotaManager::EnsureQuotaForOrigin arguments; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107612
2021-03-17 06:56:38 +00:00
d45596dcf0
Bug 1697115 - Rationalize QuotaManager::InitQuotaForOrigin arguments; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107611
2021-03-17 06:56:38 +00:00
8a8706b797
Bug 1697115 - Use FullOriginMetadata instead of OriginMetadata in QuotaManager::LoadQuota::LoadQuotaFromCache; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107610
2021-03-17 06:56:38 +00:00
83de9af404
Bug 1697115 - Rename mTimestamp to mLastAccessTime in FullOriginMetadata; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107609
2021-03-17 06:56:37 +00:00
d2bc5eec44
Bug 1686191 - Add support for warnings integrated with QM_TRY. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D102770
2021-03-12 15:07:57 +00:00
fbf7a1dad4
Bug 1686191 - Remove module argument from LogError. r=dom-workers-and-storage-reviewers,janv
...
The module argument in LogError is redundant: the module information can
already be determined from the source file path. Indeed, reporting the module
separately in the telemetry events seems unnecessary. Instead, the relative
path is now reported. This is what the analysis of the telemetry data did
reconstruct anyway.
As a consequence, it's no longer necessary to define module-specific
HandleError functions, and therefore it's also unnecessary to define
module-specific TRY macros. These are retained as simple aliases for now,
but can be removed in a later patch entirely.
This also avoids misuses of a TRY macros in the wrong module, which were
happening a few times before, resulting in confusing output or telemetry
events.
Since Bug 1686191 will add some more TRY macro variants that warn, so
simplifying the module-specific aspects will simplify that task. Furthermore,
this is in preparation of moving the TRY macro extensions to MFBT.
Differential Revision: https://phabricator.services.mozilla.com/D102767
2021-03-12 15:01:21 +00:00
7d2448b7d5
Bug 1641178 - Add NSSCipherStrategy. r=dom-workers-and-storage-reviewers,jcj,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73290
2021-03-12 09:31:57 +00:00
1cc0ba995e
Bug 1686031 - Rename OriginMetadata.h to CommonMetadata.h; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107608
2021-03-11 05:53:17 +00:00
ad01a10a3b
Bug 1634281 - Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
...
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.
Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
28b36c6c8c
Bug 1686031 - Rename GetDirectoryMetadataWithOriginMetadata2 to LoadFullOriginMetadata and GetDirectoryMetadataWithOriginMetadata2WithRestore to LoadFullOriginMetadataWithRestore; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107607
2021-03-10 08:34:53 +00:00
591e53a104
Bug 1686031 - Replace GetDirectoryResultWithOriginMetadata with FullOriginMetadata; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D107605
2021-03-10 08:34:52 +00:00
69da5d658a
Bug 1695906 - Use NotNull for StorageOperationsBase::OriginProps::mDirectory; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D106908
2021-03-10 08:34:52 +00:00
c6a31f1fb9
Bug 1686031 - Fix storage upgrades and restoration of the metadata file to use proper persistence type internally; r=dom-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D106907
2021-03-10 05:53:03 +00:00
Andi-Bogdan Postelnicu
Jan Varga
Jens Stutte
imoraru
Tom Tung
Tom Tung
p1nk
Butkovits Atila
Simon Giesecke