Rust expect() is bad in C callbacks. Replace TryFrom() with
from_bits_truncate() to drop any unknown PulseAudio flags.
MozReview-Commit-ID: 4RWFB5iGW6Z
--HG--
extra : rebase_source : 3b05d52ae1295825b4857c41135ff08029ad280c
They can change from one SPS to the next, causing unecessary reconstruction of the decoder.
MozReview-Commit-ID: IhCnLuzGc2i
--HG--
extra : rebase_source : b292c658098c378b0a6774f0f559a7b55e4903f6
We now compare the decoded data rather than the raw data, otherwise as seen in video from bug 1372766, we keep draining the decoder. For some reasons the SPS NALs only differ by 1 byte at a time.
MozReview-Commit-ID: LdXinUZHjD4
--HG--
extra : rebase_source : 022e7a011e3929846f00d1be6590f3ea1c697e7c
All decoders appear capable of handling content change when just new PPS appears.
So we restrict the test to SPS changes.
MozReview-Commit-ID: LPSfMaTIj6C
--HG--
extra : rebase_source : 524316ba61ffff1549a0828685ac657abe687426
We will use them to simplify the parsing of the extradata.
MozReview-Commit-ID: 5M5uGXAkkFb
--HG--
extra : rebase_source : e83c8995ebbc60359029f15334e91baaeb098bbd
With some H264 streams, we find that the SPS/PPS NALs are duplicated on the stream. This caused us to treat it as if the content changed due to the discrepency between the extradata found in the MP4 metadata and what found inband.
When scanning for SPS NALs, we now attempt to detect duplicates, and if so ignore them.
MozReview-Commit-ID: D8OVOXSwEkY
--HG--
extra : rebase_source : e28a8230fce4c0f361c4747fce342667d84bff45
It was only used in one spot, and incorrectly at that.
MozReview-Commit-ID: EWkkrAlYT7W
--HG--
extra : rebase_source : 9c719bbf668eafaac0415580ffdfa0cea0942673
HasSPS, ExtractExtraData and CompareExtraData have nothing to do with the handling of annex B format. They are raw H264 related methods.
It will also prevent in the following change to have cycling references between two headers.
MozReview-Commit-ID: FCs5aU4GcTU
--HG--
extra : rebase_source : b204723cdbb599d4f0a227871ed28f5da39e9cff
The configuration object is spelled with capitals. We didn't
try to build this code on Windows previously, so short-circuit
evaluation saved us from hitting the mistake.
MozReview-Commit-ID: FCGtHW8Dzlw
--HG--
extra : rebase_source : 70676bd436211aa65c7ea447b4aab4bbab61c27a
All the instances are converted as follows.
- nsSubstring --> nsAString
- nsCSubstring --> nsACString
--HG--
extra : rebase_source : cfd2238c52e3cb4d13e3bd5ddb80ba6584ab6d91
Also moving RID (StreamID) storage to the stack to clear up the TODO item
and simplify the code.
When unset the StreamID is stored as an empty string.
Added missing GUARDED_BY on rid_
Added a check to shortcut checking strlen on the StreamId when it is an empty string (which is most of the time).
MozReview-Commit-ID: EPUlPNBXYsQ
--HG--
extra : rebase_source : 08e1b9ea796c991d141164424014d2311ff9341c
New upstream release with only minor cleanup after 1.2-rc1.
- Speech quality improvements especially in the 12-24 kbit/s range
- Improved VBR encoding for hybrid mode
- More aggressive use of wider speech bandwidth, including fullband speech
starting at 14 kbit/s
- Music quality improvements in the 32-48 kb/s range
- More optimizations for x86 (SSEx) and ARM Neon
- Support for directly encoding packets up to 120 ms
- DTX support for CELT mode
- SILK CBR improvements
- Support for all of the fixes in draft-ietf-codec-opus-update-04 (the mono
downmix and the folding fixes need --enable-update-draft)
- Many bug fixes, including integer overflows discovered through fuzzing
(no security implications)
MozReview-Commit-ID: CDVdiu3R4qT
--HG--
extra : rebase_source : df73c8f7b86043237af16947d0fde12d81c122f4
media/mtransport/test/ice_unittest.cpp:353:12 [-Wunused-member-function] unused member function 'Stream'
media/mtransport/test/ice_unittest.cpp:1394:7 [-Wunused-member-function] unused member function 'trickled'
media/mtransport/test/ice_unittest.cpp:1867:8 [-Wunused-member-function] unused member function 'SetExpectedTypes'
media/mtransport/test/transport_unittests.cpp:917:8 [-Wunused-member-function] unused member function 'InitIce'
MozReview-Commit-ID: 70PNtdc92mg
--HG--
extra : source : 5dc220c3efd5bd2f8f844eb85887a4bcfabb3990
extra : intermediate-source : 0751fb1b9b19a8451c5aba7e021bcb386962ce5d
media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:181:3 [-Wunused-member-function] unused member function 'operator (anonymous namespace)::JSErrorResult &'
And suppress -Wcomma warnings in upstream webrtc code:
media/webrtc/trunk/webrtc/modules/audio_coding/neteq/background_noise.h:98:22: warning: possible misuse of comma operator here [-Wcomma]
media/webrtc/trunk/webrtc/modules/desktop_capture/differ_unittest.cc:187:22: warning: possible misuse of comma operator here [-Wcomma]
MozReview-Commit-ID: FVecnczsWk7
--HG--
extra : source : a651d94c9adcd64690a6acba4629cf7e1b299e3c
extra : intermediate-source : d5cdb25590475e306cdb8b9766a237e22940f7fa
Remove left-over panic! from this function and return default values
of F32NE, just as cubeb_pulse.c does.
MozReview-Commit-ID: 5MgIOSaexF2
--HG--
extra : rebase_source : b1159b09c97df8a41811a85cb0f1674062d5cd92
Update to the latest upstream master of libvorbis (v1.3.5-48-ge5b1378)
to pick up various fixes.
MozReview-Commit-ID: KTXAtrbtWW6
--HG--
extra : rebase_source : e36f22ce74cad13851979722c40f3742dba45f8c
Opus now has SSE, SSE2 and SSE 4.1 optimizations. Enable these
in our build by adding the extra source files and defines.
MozReview-Commit-ID: BKMATikknBU
--HG--
extra : rebase_source : 4eea2529150fe5f4f374127968843e6aa29fecaf
Apply patch from upstream fixing duplicate symbol issue
with the unified build.
MozReview-Commit-ID: 54yOXWanTkm
--HG--
extra : rebase_source : e03f024409bb7e225b456dc747f692ef9e755103
Update our in-tree implementation of the opus audio codec
to the 1.2 release candidiate. This gives us some wider
testing before making the first stable release of the
new series.
This release improves the quality and compactness of encoded
audio, and optimizes performance on ARM NEON platforms.
MozReview-Commit-ID: 30bM6iVBamd
--HG--
extra : rebase_source : 7a679a4ea419dbfb242aeebf220518e2f9397977
Update patch listing files which need to be built separately.
MozReview-Commit-ID: DTTQFGI8LyJ
--HG--
extra : rebase_source : 0eeaba1de3792f1d80d6dfddb4efe2f3ae59f0ae
Handle numbers for SIMD extension versions and variant
spacing in the source file listings.
MozReview-Commit-ID: pbYwDyk2cL
--HG--
extra : rebase_source : e0ab07fc7e80de4a16ec2f93b8e97d25d2a0af53
We were including opus_sources_float even in fixed_point builds
so webrtc could call the audio classifier. Now that that's been
removed in bug 1372622, we can drop the extra sources.
This applies only to Android arm builds.
MozReview-Commit-ID: FiOxRrCGBYm
--HG--
extra : rebase_source : 248f8ba6773dcb03369dc2f47b50fbe31dec8567
Propagate the libvpx AVX flag changes from bug 1279593.
This flag tells the compiler to generate AVX code
in these modules intead of using normal SSE instructions
which can trigger expensive state-switching.
NB: This should only be set for AVX-specific implementation
files; setting this flag for general code will invalidate
our runtime simd support checks.
MozReview-Commit-ID: 5BVeCTsNlup
--HG--
extra : rebase_source : 219b5912a220e960e45ec43a532f407fe18eb41b
Our minimum-supported version of gcc is not 4.9, so we can
remove the work-around patch for the Internal Compiler Error
we encountered with the opus library and 4.8.
MozReview-Commit-ID: IS5zhU2z7fT
--HG--
extra : rebase_source : c9e183a3503ebd672a7b3e82c016147f61662cdc
This is no longer called from anywhere, and because it calls
into private libopus APIs it needs regular changes. Remove
to reduce the maintenance effort.
It was removed upstream per
https://bugs.chromium.org/p/webrtc/issues/detail?id=5676
MozReview-Commit-ID: 3N5wL7iAwkH
--HG--
extra : rebase_source : e04c4272019bf09cae6ebedde77f8d75fe082d31
Propagate the libvpx AVX flag changes from bug 1279593.
This flag tells the compiler to generate AVX code
in these modules intead of using normal SSE instructions
which can trigger expensive state-switching.
NB: This should only be set for AVX-specific implementation
files; setting this flag for general code will invalidate
our runtime simd support checks.
MozReview-Commit-ID: 5BVeCTsNlup
--HG--
extra : rebase_source : 219b5912a220e960e45ec43a532f407fe18eb41b
To avoid a double freeing of pa_context and pa_threaded_mainloop on
error, null out pointers once the object is freed.
Added assertions that pointer are null after destroy()'ing.
MozReview-Commit-ID: 1Ycmkrc2kWe
--HG--
extra : rebase_source : 1074ba307a45f9714b07c66d112a1b4b190c4540
Prefer the vs14 targets since we build for Windows
with cl instead of cygwin's gcc. This corresponds
to Visual Studio 2015.
In practice there is little difference, other the
upstream build system assuming a Visual Studio style
output directory, but this should help pick up any
compiler-specific work-arounds.
MozReview-Commit-ID: 4etKKIEJWws
--HG--
extra : rebase_source : 5d03abdda718ed7811dc5d22cc56586d84d207d9
Update our in-tree copy of the aom reference implementation
of the av1 video codec to upstream git commit id
aadbb0251996c8ebb8310567bea330ab7ae9abe4.
This picks up recent changes and addresses a build issue on win64.
MozReview-Commit-ID: 34LXXzFtEFN
--HG--
extra : rebase_source : 0face926928de6bd1c6a1726df912bd20e363e60