530a6c8ee6
Bug 1631608 - P6: Log error message when `PropertiesChanged` signal fails being emitted r=alwu
...
- Log error messages when `PropertiesChanged` signal fails being emitted
- Add some missing `':'` in error messages
Differential Revision: https://phabricator.services.mozilla.com/D72195
2020-04-24 22:39:20 +00:00
ec57fa6d2a
Bug 1631608 - P5: Define `mpris:trackid` r=alwu
...
The `"mpris:trackid"` [1] is an unique dbus path identifying the track.
It's better to use a more specific path for `"mpria:trackid"` instead of
using a `"/valid/path"` that can appear on any example code. The
rythembox [2,3] and vlc [4,5] also uses their own special path for their
`"mpris:trackid"` so Firefox should do the same.
On the other hand, Chrome doesn't use `"mpris:trackid"` at all. That
indeed works but the spec [1] explicitly states `"mpris:trackid"` must
be defined if there is a current track.
Thus, to make sure the implementation meets the spec [1], the
`"mpris:trackid"` must be defined in MPRIS's `"Metadata"` field by an
unique path value that belongs to Firefox only.
[1] https://specifications.freedesktop.org/mpris-spec/2.2/Player_Interface.html#Property:Metadata
[2] 7542759eda/plugins/mpris/rb-mpris-plugin.c (L547)7542759eda/plugins/mpris/rb-mpris-plugin.c (L55)9ddf27caa7/modules/control/dbus/dbus.c (L1300)9ddf27caa7/modules/control/dbus/dbus_common.h (L90)https://phabricator.services.mozilla.com/D71869
2020-04-24 22:39:12 +00:00
c9eafeca3c
Bug 1631608 - P4: Define "org.mpris.MediaPlayer2.Player" in macro r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D71868
2020-04-24 22:39:10 +00:00
e3b7390390
Bug 1631608 - P3: Use `%d` for `int` r=alwu
...
Align the policy to get the dbus name in `MPRISServiceHandler::Open`
with the one in `MPRISServiceHandler::Close()`
Differential Revision: https://phabricator.services.mozilla.com/D71865
2020-04-24 22:39:08 +00:00
cff082955d
Bug 1631608 - P2: Emit DBus signal once MPRIS `Metadata` is set r=alwu
...
According to spec [1], when the `Metadata` is changed, a signal with the
new `Metadata` value should be emitted.
[1] https://specifications.freedesktop.org/mpris-spec/2.2/Player_Interface.html#Property:Metadata
Differential Revision: https://phabricator.services.mozilla.com/D71864
2020-04-24 22:39:00 +00:00
9236093c78
Bug 1631608 - P1: Log messages when getting or setting metadata r=alwu
...
By monitoring the added logs, any access to the metadata can be watched.
Differential Revision: https://phabricator.services.mozilla.com/D71863
2020-04-24 22:38:58 +00:00
42d551312e
Bug 1628583 [Wayland] Use mutex to access mozcontainer wayland internals, r=jhorak
...
Mozcontainer is accessed from various threads - Main/Compositor/Renderer - which causes races
when wayland surfaces are created/deleted/updated so we need to control it.
Differential Revision: https://phabricator.services.mozilla.com/D71737
2020-04-24 17:19:15 +00:00
7abdca1793
Bug 1631196 - Implement MPRIS Raise event by focusing the window playing media. r=alwu
...
Implement MPRIS Raise event by focusing the window playing media.
Differential Revision: https://phabricator.services.mozilla.com/D71450
2020-04-23 19:32:34 +00:00
42e680a4ef
Merge mozilla-central to autoland on a CLOSED TREE
2020-04-24 00:44:23 +03:00
295d851672
Merge autoland to mozilla-central. a=merge
2020-04-24 00:42:24 +03:00
71ad949346
Backed out changeset 779722364805 (bug 1628583) per request a=backout
2020-04-23 17:54:42 +03:00
59c99a1b8c
Bug 1632059 [Wayland] Use wayland display directly for va-api, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D72122
2020-04-23 16:06:54 +00:00
7112c02038
Bug 1603839 [Linux] Explicitly set Wayland/X11 backend for GtkCompositorWidget, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D71888
2020-04-23 17:26:17 +00:00
bff4088157
Bug 1632100 [Wayland] Emulate window focus change by window hide/show when running in testsuite, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D71926
2020-04-22 15:54:06 +00:00
f5dbae2f0c
Bug 1628583 [Wayland] Use mutex to access mozcontainer wayland internals, r=jhorak
...
Mozcontainer is accessed from various threads - Main/Compositor/Renderer - which causes races
when wayland surfaces are created/deleted/updated so we need to control it.
Differential Revision: https://phabricator.services.mozilla.com/D71737
2020-04-22 15:53:49 +00:00
2cc879bea5
Bug 1623974 [wayland] Attach popups to anchor rects; r=stransky
...
If we want correct popup placement we need to use the right anchor rect
for gdk_window_move_to_rect under Wayland. Patch exports the anchor rect from the
nsMenuPopupFrame to be used in nsWindow.
This patch also fixes popup overflowing the screen by using the size returned from
gdk_window_move_to_rect for the nsMenuPopupFrame.
Differential Revision: https://phabricator.services.mozilla.com/D67810
2020-04-21 19:19:30 +00:00
a000f064be
Bug 1629140 - Enable frame callback based VsyncSource by default. r=stransky
...
Differential Revision: https://phabricator.services.mozilla.com/D70551
2020-04-21 11:34:14 +00:00
33a2dc2141
Backed out changeset 339795d0a51e (bug 1574746) for causing browser_startup_syncIPC.js failures CLOSED TREE
2020-04-21 04:32:44 +03:00
66fa9f31db
Bug 1574746 - Remove AllowWebRenderForThisWindow() r=nical
...
nsBaseWidget::AllowWebRenderForThisWindow() limits WebRender usage to some type of windows. It was added by Bug 1377321, because initialization of WebRender was heavy weight in the past. It is not necessary anymore.
Differential Revision: https://phabricator.services.mozilla.com/D71440
2020-04-20 14:15:08 +00:00
d0d3827cd2
Backed out changeset 880f56e1656b (bug 1603839) for causing build bustages on GtkCompositorWidget.h
...
CLOSED TREE
2020-04-23 12:28:10 +03:00
f9d7f39b74
Bug 1631458 Account font scale factor for the popup placement under wayland; r=stransky
...
The font scale factor needs to be accounted for the popup anchor rect under
Wayland.
Differential Revision: https://phabricator.services.mozilla.com/D72100
2020-04-23 08:43:52 +00:00
4d6599f102
Bug 1603839 [Linux] Explicitly set Wayland/X11 backend for GtkCompositorWidget, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D71888
2020-04-23 08:19:07 +00:00
25a1d0163b
Backed out changeset 86630db403c1 (bug 1623974) for causing failures in browser_toolbox_zoom_popup.js and in wpt.
...
CLOSED TREE
2020-04-20 18:07:23 +03:00
5664a8f139
Bug 1623974 [wayland] Attach popups to anchor rects; r=stransky
...
If we want correct popup placement we need to use the right anchor rect
for gdk_window_move_to_rect under Wayland. Patch exports the anchor rect from the
nsMenuPopupFrame to be used in nsWindow.
This patch also fixes popup overflowing the screen by using the size returned from
gdk_window_move_to_rect for the nsMenuPopupFrame.
Differential Revision: https://phabricator.services.mozilla.com/D67810
2020-04-20 12:50:25 +00:00
c64e7f13d2
Bug 1611372 - Invalidate WebRender frame on nsWindow::OnExposeEvent() r=nical
...
Differential Revision: https://phabricator.services.mozilla.com/D71139
2020-04-17 17:27:37 +00:00
6cfd5ed10f
Bug 1629526 [Wayland] Add gWaylandThreadLoopMutex to guard thread loop shutdown, r=jhorak
...
- Add gWaylandThreadLoopMutex to guard thread loop shutdown
- Rename gWaylandDisplaysMutex to gWaylandDisplayArrayMutex to clarify it's mutex for gWaylandDisplays array access
- Add gWaylandDisplayArrayMutex lock at ReleaseDisplaysAtExit()
- Rename DispatcherThreadLoop names to ThreadLoop
Differential Revision: https://phabricator.services.mozilla.com/D71106
--HG--
extra : moz-landing-system : lando
2020-04-16 06:07:06 +00:00
d6aeea13b9
Bug 1626762 Removed the else statement to improve readability and better meet guidelines as per http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html r=sylvestre
...
Added braces around statements as per code review bot.
Differential Revision: https://phabricator.services.mozilla.com/D70998
--HG--
extra : moz-landing-system : lando
2020-04-15 11:07:44 +00:00
c53091bec7
Bug 1629526 - Fix whitespace lint on nsWaylandDisplay.cpp CLOSED TREE
2020-04-14 17:42:03 +03:00
37e2e6954d
Bug 1629526 [Wayland] Use mutex when clear mDispatcherThreadLoop, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D70848
--HG--
extra : moz-landing-system : lando
2020-04-14 13:25:12 +00:00
1536f639a8
Bug 1628711 Remove #ifdef MOZ_WIDGET_GTK from widget/gtk, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D70391
--HG--
extra : moz-landing-system : lando
2020-04-14 12:35:34 +00:00
91abb34d31
Bug 1333162 - Only call gdk_set_program_name in the parent process. r=karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D70640
--HG--
extra : moz-landing-system : lando
2020-04-14 01:48:37 +00:00
162b8c8490
Bug 1624786 - Replace MOZ_MUST_USE with [[nodiscard]] in widget/gtk. r=karlt
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D68149
--HG--
extra : moz-landing-system : lando
2020-04-08 16:41:43 +00:00
cbd149f1b6
Bug 1527976 [Wayland] Don't cancel Drag and Drop on MOZ_GTK_DRAG_RESULT_ERROR for application/x-moz-tabbrowser-tab (tab move), r=jhorak
...
- X11 uses MOZ_GTK_DRAG_RESULT_NO_TARGET to state 'no place' for drop. Wayland does not have protocol for it and always return MOZ_GTK_DRAG_RESULT_ERROR.
To emulate X11 behaviour for tab D&D (application/x-moz-tabbrowser-tab mime) don't cancel D&D operation on Wayland for MOZ_GTK_DRAG_RESULT_ERROR
to allow to create a new tab when user drops tab outside the tab bar.
- Provide some additional loging to D&D code.
Differential Revision: https://phabricator.services.mozilla.com/D70333
--HG--
extra : moz-landing-system : lando
2020-04-09 14:18:41 +00:00
8ae896a132
Bug 1622075 - Fix a memory leak in MakePrintTarget(). r=jld,karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D69748
--HG--
extra : moz-landing-system : lando
2020-04-09 15:11:02 +00:00
b16dee417b
Bug 1626765 - delete 'else' after 'return'. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D70145
--HG--
extra : moz-landing-system : lando
2020-04-08 16:55:00 +00:00
3490db967d
Bug 890125 - Part 3 - Convert the Linux virtual desktop handling to accept string-type workspace IDs. r=stransky,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D67824
--HG--
extra : moz-landing-system : lando
2020-04-07 20:21:14 +00:00
36eaf82163
Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika
...
Depends on D67631
Differential Revision: https://phabricator.services.mozilla.com/D67632
--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:33 +00:00
5c60242230
Backed out 6 changesets (bug 1350875) for causing failures in test.util.UiThreadUtils$TimeoutException
...
CLOSED TREE
Backed out changeset c65f2c0b6332 (bug 1350875)
Backed out changeset 5084623c0f83 (bug 1350875)
Backed out changeset 4eda0d89d8a2 (bug 1350875)
Backed out changeset 149058087816 (bug 1350875)
Backed out changeset 71ba43d7b2df (bug 1350875)
Backed out changeset e65ead196f4b (bug 1350875)
2020-04-07 16:13:53 +03:00
2dcd9a0339
Bug 1350875 part 3 - Have GTK notify fullscreen will change. r=karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D68680
--HG--
extra : moz-landing-system : lando
2020-04-02 21:42:41 +00:00
86041bd513
Backed out 4 changesets (bug 890125) for central bustages complaining about nsWindow.cpp
...
Backed out changeset 68475f12d4f1 (bug 890125)
Backed out changeset 6e2c1facb7e0 (bug 890125)
Backed out changeset 17b15e227d3b (bug 890125)
Backed out changeset 6e71761c1018 (bug 890125)
2020-04-07 01:31:47 +03:00
c1863e1f34
Bug 890125 - Part 3 - Convert the Linux virtual desktop handling to accept string-type workspace IDs. r=stransky,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D67824
--HG--
extra : moz-landing-system : lando
2020-04-06 12:56:51 +00:00
bf0f8f24a0
Bug 1627469 [Wayland] [Wayland] Don't use oversized wl_surface sizes, r=jhorak
...
- Calculate size of wl_buffer as an intersection of widget size and nsWindow bound size.
We can't use wl_buffer bigger than nsWindow bound as it leads to rendering artifacts.
Differential Revision: https://phabricator.services.mozilla.com/D69716
--HG--
extra : moz-landing-system : lando
2020-04-06 07:01:33 +00:00
0aa6f03cf3
Bug 1519636 - Reformat recent changes to the Google coding style r=jgilbert
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D67574
--HG--
extra : moz-landing-system : lando
2020-04-05 13:34:58 +00:00
715930ff5b
Backed out 4 changesets (bug 890125) for Windows MinGW build bustages failures. on a CLOSED TREE
...
Backed out changeset 1c8115a9a684 (bug 890125)
Backed out changeset eceeef4fc062 (bug 890125)
Backed out changeset cd850f6d0b0b (bug 890125)
Backed out changeset 08359730557d (bug 890125)
2020-04-03 22:44:14 +03:00
95217fe3b5
Bug 1606554 - Remove accidently introduced stub gdk_window_get_visible_region. r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D69508
--HG--
extra : moz-landing-system : lando
2020-04-03 11:09:12 +00:00
2c14753eb4
Bug 890125 - Part 3 - Convert the Linux virtual desktop handling to accept string-type workspace IDs. r=stransky,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D67824
--HG--
extra : moz-landing-system : lando
2020-04-03 10:20:57 +00:00
3c3825bf9d
Bug 1627098 [Linux] Provide more clipboard logging, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D69452
--HG--
extra : moz-landing-system : lando
2020-04-03 07:53:43 +00:00
1c00ea0aa0
Bug 1625296 [Wayland] Enable basic compositor smooth drawing by widget.wayland-smooth-rendering pref, r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D68457
--HG--
extra : moz-landing-system : lando
2020-03-30 21:12:37 +00:00
e93ba090b8
Backed out changeset 2a1b5f29d43d (bug 1625296) for bustages complaining about WindowSurfaceWayland.cpp CLOSED TREE
2020-03-30 17:26:10 +03:00
09fa9dbc7c
Backed out changeset 61cc7740daa3 (bug 1623974) for bustages related to nsWindow.cpp CLOSED TREE
2020-03-30 17:23:10 +03:00
Chun-Min Chang
Martin Stransky
Tom Schuster
Brindusan Cristian
Noemi Erli
Jan Horak
Robert Mader
Ciure Andrei
sotaro
Arthur Iakab
Mihai Alexandru Michis
Ryan Pauls
Bogdan Tara
Cameron McCormack
Chris Peterson
Emilio Cobos Álvarez
nicolaspacheco
Mike de Boer
Andreas Farre
Xidorn Quan
Sylvestre Ledru
Oana Pop Rus
jayati