Граф коммитов

37 Коммитов

Автор SHA1 Сообщение Дата
Razvan Caliman 39477782f7 Bug 1536237 - Add support for letter spacing in Font Editor. r=gl
- Reads the value for the letter-spacing CSS property and shows it in the Font Editor. When it is default, show the "normal" identifier. As soon as the user tries to edit it using the value slider, switch to an em-based value.

- Tweaks the unit conversion method to support letter-spacing: using correct reference node for em units, returning high-precision results even for pixels (allow sub-pixel precision)

Differential Revision: https://phabricator.services.mozilla.com/D25087

--HG--
extra : moz-landing-system : lando
2019-04-02 17:51:50 +00:00
shindli ebbe440e94 Backed out changeset e78a1f8b81db (bug 1536237) for ES lint failure in /builds/worker/checkouts/gecko/devtools/client/inspector/fonts/fonts.js CLOSED TREE 2019-04-01 14:38:48 +03:00
Razvan Caliman bc55f8ae1c Bug 1536237 - Add support for letter spacing in Font Editor. r=gl
- Reads the value for the letter-spacing CSS property and shows it in the Font Editor. When it is default, show the "normal" identifier. As soon as the user tries to edit it using the value slider, switch to an em-based value.

- Tweaks the unit conversion method to support letter-spacing: using correct reference node for em units, returning high-precision results even for pixels (allow sub-pixel precision)

Differential Revision: https://phabricator.services.mozilla.com/D25087

--HG--
extra : moz-landing-system : lando
2019-04-01 09:45:11 +00:00
Razvan Caliman b82d1224bf Bug 1523305 - Show Font Editor in read-only mode for pseudo-elements. r=gl
Adds a new `disabled` property to the Font Editor Redux store applicable to all input fields.
When inspecting a pseudo-element, this `disabled` property is set to true.
This allows the pseudo-element to be inspected, but prevents editing font property values because it's currently not possible to write them back to CSS rules other than element inline styles.

Differential Revision: https://phabricator.services.mozilla.com/D18364

--HG--
extra : moz-landing-system : lando
2019-02-04 12:05:23 +00:00
Razvan Caliman d5f2881bd2 Bug 1485324 - (Part 1) Remove pref for Font Editor and obsolete conditionals; r=gl
This patch removes the `devtools.inspector.fonteditor.enabled` pref and all its uses in the Fonts panel.
Obsolete actions for the case when the pref was off are also removed. This is mostly old Font Inspector code.

One test is temporarily disabled because it tests the old Font Inspector. It will be removed along with other
pieces on the next part of this commit series.

Differential Revision: https://phabricator.services.mozilla.com/D11505

--HG--
extra : moz-landing-system : lando
2018-11-13 18:55:30 +00:00
Razvan Caliman b44224fb5f Bug 1493961 - Font editor: replace capitalization via CSS text-transform with manual capitalization where needed. r=gl
Localization means words in other languages that shouldn't be capitalized will be if using CSS text-transform.

Differential Revision: https://phabricator.services.mozilla.com/D7190

--HG--
extra : moz-landing-system : lando
2018-09-29 21:42:18 +00:00
Razvan Caliman 07b71aa68f Bug 1488157 - Tweak the font editor warning message shown when no fonts were used. r=gl
MozReview-Commit-ID: 5dFEkTvbIKm

Differential Revision: https://phabricator.services.mozilla.com/D4843

--HG--
extra : moz-landing-system : lando
2018-09-03 14:12:24 +00:00
Gabriel Luong 35bc03d5b4 Bug 1486891 - (Part 2) Remove old font preview functionality from font editor. r=gl 2018-08-30 11:11:22 -04:00
Gabriel Luong e5d60e1198 Bug 1486891 - (Part 1) Add dedicated input for font preview in font editor. r=gl 2018-08-30 11:10:35 -04:00
Razvan Caliman 21da703f8d Bug 1483929 - (Part 4) Group used fonts by family name. r=gl
This changes the structure of the used fonts list. It groups fonts by family name and removes URL and copy capabilities.

Depends on D3805

Differential Revision: https://phabricator.services.mozilla.com/D3894

--HG--
extra : moz-landing-system : lando
2018-08-22 09:09:41 +00:00
Razvan Caliman 825c0fdf0c Bug 1483929 - (Part 3) Revert to showing all used fontsfonts used on the selected element. r=gl
Removes logic pertaining to filtering by members of CSS font-family declaration.

Differential Revision: https://phabricator.services.mozilla.com/D3805

--HG--
extra : moz-landing-system : lando
2018-08-21 18:20:45 +00:00
Razvan Caliman b20600a9d1 Bug 1483929 - (Part 1) Remove Rendered Fonts accordion; Add All Fonts accordion for Font Editor. r=gl
This patch replaces the Other Fonts and Rendered Fonts accordions with a single All Fonts accordion while the Font Editor pref is on.
When thhe pref for the Font Editor is off, the Element Fonts and Other Fonts accordions are kept until we deprecate the old Font Inspector code.

Differential Revision: https://phabricator.services.mozilla.com/D3797

--HG--
extra : moz-landing-system : lando
2018-08-21 18:20:50 +00:00
Razvan Caliman 4bc089e80f Bug 1483575 - (Part 2) Add LineHeight component to font editor. r=gl
MozReview-Commit-ID: JiMBI3QMKML

Depends on D3498

Differential Revision: https://phabricator.services.mozilla.com/D3499

--HG--
extra : moz-landing-system : lando
2018-08-16 14:48:51 +00:00
Razvan Caliman 4746abbb8a Bug 1474836 - (Part 2) Show editor empty state with custom warning for pseudo-elements. r=gl
MozReview-Commit-ID: 5Zq7R7fzMID

--HG--
extra : rebase_source : 73bc0a60d8a5a77b3d548c8e45e713a4e42a79b3
2018-07-10 19:52:08 +02:00
Razvan Caliman 3ec682d724 Bug 1473496 - Font editor: replace string IDs for localizable strings that changed value. r=flod
MozReview-Commit-ID: H9bQuOsoZkP

--HG--
extra : rebase_source : 87a6558f72fdaf388a18c78bb8edb74188b11db8
2018-07-05 10:38:48 +02:00
Razvan Caliman 8baecde7e2 Bug 1472966 - Limit list of used fonts to 3 and put others in a collapsed list. r=gl
MozReview-Commit-ID: AYKkU7MsMWD

--HG--
extra : rebase_source : e87991efa58d8c28afd82a58c95fd9777d4388fd
2018-07-03 20:05:40 +02:00
Razvan Caliman e82f93418a Bug 1472966 - Replace label for list of unused font families. r=gl
MozReview-Commit-ID: J5X2BT3YQY3

--HG--
extra : rebase_source : 74b9dfcfbd994c3f301464026b1afb222122b064
2018-07-03 17:21:10 +02:00
Patrick Brosset 91d8af86bd Bug 1472116 - Show the font overview in a collapsible section in the font editor; r=rcaliman
MozReview-Commit-ID: AcA1jkGKCW9

--HG--
extra : rebase_source : 70fcaf0f7cfcb65ac0cd142610ec2b48306c9ac9
2018-07-02 14:29:34 +02:00
Razvan Caliman 03a8f4c93f Bug 1465500 - Show list of font families declared but not used. r=gl
MozReview-Commit-ID: 4GfpV8RmK0N

--HG--
extra : rebase_source : 525b030ed67eebb6ff036a92d426a95d51b12ba4
2018-06-06 14:06:47 +02:00
arthur.iakab 9a3f8590f8 Backed out changeset 82f89fcfaa82 (bug 1465500) For failing L10N by request of flod a=backout 2018-06-23 16:25:51 +03:00
Razvan Caliman 334a9f2575 Bug 1465500 - Show list of font families declared but not used. r=gl
MozReview-Commit-ID: 4GfpV8RmK0N

--HG--
extra : rebase_source : eefd06c99c11a4be59804b5745a7567a32ca5677
2018-06-06 14:06:47 +02:00
Razvan Caliman ea708528bd Bug 1450695: Add support for editing CSS font properties for non-variable fonts. r=gl
MozReview-Commit-ID: 6WWJEaSBbzm

--HG--
extra : rebase_source : 07eea241fefdd88b55b017dd0f3a6a069a942511
2018-05-09 17:04:18 +02:00
Razvan Caliman 1c17bec4b8 Bug 1455335 - Extract font name and origin into reusable component. r=gl
- Extract font name and origin (URL + copy URL) into FontMeta component.
- Reuse FontMeta in font overview and font editor.
- Tweak CSS for improved spacing and flex-grow behaviour.

MozReview-Commit-ID: 4W2E48r8Yps

--HG--
extra : rebase_source : 5159468f943cb505fd1ca9aeb50954fbb690af07
2018-04-20 17:52:08 +02:00
Razvan Caliman 751e8102a2 Bug 1449893 - Redux setup for managing font variation instances. r=gl
MozReview-Commit-ID: G4xrAHypsyJ
2018-04-20 05:12:00 +03:00
Patrick Brosset 14a179db40 Bug 1444327 - Bring back ability to see and copy font URLs; r=jdescottes
In the fonts panel UI prior to Firefox 60, remote font URLs used to be
displayed in full in a text input field. It made it easy to copy them.
With the redesign that happened in 60 (bug 1437548 and 1442001), getting
the URL became harder. The URL isn't visible anymore easily. There's a link
that can be clicked to load the URL in the browser, or it can also be copied
from the @font-face CSS rule code section. But that's harder.

This change adds the beginning of the URL back (with an ellipsis) and a
simple button that copies the link.

Note that the new test failed intermittently on non e10s (took too long).
This was because of a react middleware which was logging all actions, which,
in non-e10s, ended up logging StyleRuleActors, which got serialized and caused
way too much logs to be printed, slowing the test down. So the test was
disabled on non-e10s.

MozReview-Commit-ID: 2oSMoWKYhTk

--HG--
extra : rebase_source : ac406d91c78e5222854b53f245ad2d93428bfc4d
2018-03-14 16:16:55 +01:00
Noemi Erli d2dbc4de71 Backed out changeset 12a46d4d860a (bug 1444327) for frequently failing devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js (bug 1446595) a=backout 2018-03-18 00:07:13 +02:00
Patrick Brosset 5e66dc3a92 Bug 1444327 - Bring back ability to see and copy font URLs; r=jdescottes
In the fonts panel UI prior to Firefox 60, remote font URLs used to be
displayed in full in a text input field. It made it easy to copy them.
With the redesign that happened in 60 (bug 1437548 and 1442001), getting
the URL became harder. The URL isn't visible anymore easily. There's a link
that can be clicked to load the URL in the browser, or it can also be copied
from the @font-face CSS rule code section. But that's harder.

This change adds the beginning of the URL back (with an ellipsis) and a
simple button that copies the link.

MozReview-Commit-ID: 2oSMoWKYhTk

--HG--
extra : rebase_source : 1af901f4a343f392b65309fde34411313606b824
2018-03-14 16:16:55 +01:00
Dorel Luca d007a5cc25 Backed out changeset 7a4f85c76c7c (bug 1444327) for Cl failurs on devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js 2018-03-14 19:38:17 +02:00
Patrick Brosset 0ab5560cb0 Bug 1444327 - Bring back ability to copy font URL by adding context menu; r=jdescottes
In the fonts panel UI prior to Firefox 60, remote font URLs used to be
displayed in full in a text input field. It made it easy to copy them.
With the redesign that happened in 60 (bug 1437548 and 1442001), getting
the URL became harder. The URL isn't visible anymore easily. There's a link
that can be clicked to load the URL in the browser, or it can also be copied
from the @font-face CSS rule code section. But that's harder.

This change adds a simple right-click context menu to the link that has
one item only: copy link.

MozReview-Commit-ID: 2oSMoWKYhTk

--HG--
extra : rebase_source : da21c405fd6d2d395de66c0de23a2739c71931bc
2018-03-14 16:16:55 +01:00
Coroiu Cristina 3c699ccb2c Backed out changeset a88235c19594 (bug 1444327) for ESlint failure at devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js 2018-03-14 17:01:11 +02:00
Patrick Brosset dde580f2a6 Bug 1444327 - Bring back ability to copy font URL by adding context menu; r=jdescottes
In the fonts panel UI prior to Firefox 60, remote font URLs used to be
displayed in full in a text input field. It made it easy to copy them.
With the redesign that happened in 60 (bug 1437548 and 1442001), getting
the URL became harder. The URL isn't visible anymore easily. There's a link
that can be clicked to load the URL in the browser, or it can also be copied
from the @font-face CSS rule code section. But that's harder.

This change adds a simple right-click context menu to the link that has
one item only: copy link.

MozReview-Commit-ID: 2oSMoWKYhTk

--HG--
extra : rebase_source : 0fa26ea6846924a270f14c1e0258dbf21e122e6f
2018-03-12 14:49:14 +01:00
Patrick Brosset e3ba763e10 Bug 1442001 - Remove the expander icon for fonts and the used-as info; r=jdescottes
MozReview-Commit-ID: Gf19Ybo74jc

--HG--
extra : rebase_source : eb0bd83dd4111d8fb3200d6f2e29a1b7f5ee5c67
2018-02-28 21:45:27 +01:00
Patrick Brosset 6d2d4b60d6 Bug 1437548 - 3 - Add a section that displays other fonts used in the page; r=gl
New accordion section in the fonts panel, that lists all fonts used elsewhere
than the currently selected node.
Collapsed by default.

MozReview-Commit-ID: IvgKbt9fH9w

--HG--
extra : rebase_source : 6c5c998b2de5f8e26be1ff3f72ed192fd6f72dd2
2018-02-13 10:32:04 +01:00
Patrick Brosset e2921bc0e3 Bug 1437548 - 1 - Simplified font inspector layout; r=gl
A lot of simplifications of the current fonts UI, and alignment
to Victoria's mockup here:
https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/278367863

MozReview-Commit-ID: EgcZDWyKafV

--HG--
extra : rebase_source : b2b7b3998055bf1f85f10264f4928c9980434e1c
2018-02-13 11:39:05 +01:00
Julian Descottes 7cbf0a6657 Bug 1425280 - Fix localization note mismatch in devtools files;r=pbro
MozReview-Commit-ID: FVJUjB25smI

--HG--
extra : rebase_source : acdf3b9dca3fede5c3b621f8f8064002bd77e978
extra : source : 9a75a20d6fba62635c6646af38cffabb5701a77a
2017-12-14 15:43:37 -06:00
Gabriel Luong b590541992 Bug 1390721 - Add a message when no fonts are found for the currently selected element. r=bgrins 2017-08-17 23:21:58 -07:00
Julian Descottes 6d5e17f451 Bug 1294186 - Migrate inspector.xul from DTDs to .properties files;r=pbro
MozReview-Commit-ID: 7YE3QzqiPoG

--HG--
extra : rebase_source : 5e8274100ca70661087dad13d7f73d31218b7f27
2016-09-21 12:15:30 +02:00