The two tests affected are now inconsistently passing (in opt builds on all trees) and failing the Tier 2 a11y-checks: `devtools/client/webconsole/test/browser/browser_webconsole_longstring_getter.js` and `devtools/client/inspector/rules/test/browser_rules_edit-property-computed.js`, thus we are replacing the `fail-if` expectations with `skip-if` while the investigation is ongoing.
Related bugs: bug 1849028, bug 1867062, bug 1868497
Differential Revision: https://phabricator.services.mozilla.com/D195468
For some reason, the debugger has a different behavior the second time it opens
compared to its very first opening. So that distinct React elements are instantiated
and are then reported as leaks...
Differential Revision: https://phabricator.services.mozilla.com/D196191
The popup manager is in the parent process and the parent process may store
the last mouse cursor position which is set by a preceding test, but the
test synthesizes mouse events only in the content process. Therefore, the
parent may have unexpected state.
For solving these issues, this patch makes the test synthesize the events via
the parent process with enabling the async event dispatcher.
Then, new issue appeared. When I run this test in the verify mode, it
high-frequently failed with no mouse event logs. Therefore, this patch makes
the content process waits first `mousemove` outside the target before starting
the test.
Differential Revision: https://phabricator.services.mozilla.com/D195637
`mouseover` should be fired by `EventStateManager` when it gets `mousemove`
events at that time, `PresShell` and `EventStateManager` update their member
to dispatch `mouseout` etc later correctly. So, the test should synthesize
`mousemove` instead.
Additionally, for making it easier to debug, this patch adds event logger
too. Number of logging events are just a few so that it's not problem from
the log size point of view.
Finally, this adds a clean up code to hide the tooltip which was shown by
this test. That may help to make it stable when continuously run the test.
Differential Revision: https://phabricator.services.mozilla.com/D195636
Add 2 options, `inputAriaLabel` and `inputAriaLabelledBy`, that when set will
respectively set aria-label/aria-labelledby attribute on the input.
Differential Revision: https://phabricator.services.mozilla.com/D195223
This handles the aria-pressed attribute on toggle pseudo class,
toggle class panel, light, dark and print mode simulation buttons
in the Rules view toolbar.
We remove the checked class that we were using to style the
button when they are pressed as we can use an attribute selector
with aria-pressed.
For the pseudo-class toggle and the class panel toggle, we also
add aria-controls attribute as they both control the display
of another element.
Tests are updated accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D194866
It was wrong to both:
* reuse disableBreaks options to add the useInnerBindings as it would prevent overrides for eager evaluation,
* use disableBreaks for eager evaluation.
It sounds safer to let the server control all the server side details and only pass eager attribute
when evaluating js via the console actor.
Differential Revision: https://phabricator.services.mozilla.com/D195097
For now, only console command values like $0, $_ and $x were allowed in eager evaluation,
only by luck as these commands were evaluated and cached *before* Frame.evalWithBinding and Object.executeInGlobalWithBindings
started running the console input string.
But methods were cancelled by onNativeCall. This new isSideEffectFree flag allows to identify these methods.
Differential Revision: https://phabricator.services.mozilla.com/D195022
The class does not provide much value, we can remove it and
use a constant instead for the main case, and add the specific
expandable class in the only place we need it.
Differential Revision: https://phabricator.services.mozilla.com/D194879
It appears after the D194403 landed and added an expectations that this test would fail a11y-checks, that the results of the a11y-checks for this test file are not consistent between opt and build in CI, thus we have to skip this test to resolve the perma failure until the issue is investigated and larger accessibility improvement work is done on Dev Tools under bug 1849028.
Differential Revision: https://phabricator.services.mozilla.com/D194889
Remove the specific callsites where we were making such assumption, and update
the calls to `InspectorUtils.isInheritedProperty` to pass a document, since it's
now required to check if custom properties inherit.
Differential Revision: https://phabricator.services.mozilla.com/D194630
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily fail-if'ed in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.
When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.
Differential Revision: https://phabricator.services.mozilla.com/D194403
Anna Yeddi
Alexandre Poirot
Joel Maher
Masayuki Nakano
Nicolas Chevobbe
Norisz Fay
Logan Rosen
Julien Wajsberg
Cristina Horotan
Cosmin Sabou
Iulian Moraru
Hubert Boma Manilla
Nazım Can Altınova
aaoblivion
Mark Banner
Daisuke Akatsuka
Emilio Cobos Álvarez
Tooru Fujisawa