Hubert Boma Manilla
34cef822f7
Bug 1849946 - [devtools] Switch to do strict inequality check r=devtools-reviewers,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D187102
2023-09-05 10:51:12 +00:00
Mark Banner
8219a5c503
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Tetsuharu Ohzeki
9348f8ae5e
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/shared/. r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D149483
2022-06-16 10:03:11 +00:00
Dickson Tan
d684f54703
Bug 1545727 - make the JSON tree viewer more accessible. r=Honza
...
Make the JSON tree view more accessible.
1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.
Differential Revision: https://phabricator.services.mozilla.com/D28274
--HG--
extra : moz-landing-system : lando
2020-03-29 09:32:58 +00:00
Jason Laster
5f29a6d696
Bug 1622996 - Refactor devtools codebase to use optional chaining (automated changes). r=jdescottes
...
Depends on D67084
Differential Revision: https://phabricator.services.mozilla.com/D67537
--HG--
extra : moz-landing-system : lando
2020-03-19 21:13:38 +00:00
Andreea Pavel
62b6d7d0b7
Backed out changeset a52a8f4ab189 (bug 1545727) for failing test_tree-view_01.html on a CLOSED TREE
...
--HG--
extra : histedit_source : c5dfef1c6a4bccf9f29b987d40dc4d318fa38306
2020-02-25 18:47:21 +02:00
Dickson Tan
987085894f
Bug 1545727 - make the JSON tree viewer more accessible. r=Honza
...
Make the JSON tree view more accessible.
1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.
Differential Revision: https://phabricator.services.mozilla.com/D28274
--HG--
extra : moz-landing-system : lando
2020-02-25 12:52:30 +00:00
Julian Descottes
1018577094
Bug 1596686 - Use absolute paths for require calls r=gl
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D58243
--HG--
extra : moz-landing-system : lando
2019-12-27 12:23:47 +00:00
Razvan Maries
b27235e522
Backed out changeset 14698fa06ab8 (bug 1596686) for causing perma fails on browser_json_refresh.js.
2019-12-27 14:01:24 +02:00
Julian Descottes
add2223cba
Bug 1596686 - Use absolute paths for require calls r=gl
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D58243
--HG--
extra : moz-landing-system : lando
2019-12-27 09:09:51 +00:00
Nicolas Chevobbe
925311bc77
Bug 1568779 - Remove editors settings comments in devtools files. r=pbro.
...
Differential Revision: https://phabricator.services.mozilla.com/D42300
--HG--
extra : moz-landing-system : lando
2019-08-19 12:48:16 +00:00
Jan Odvarko
8458d4bcc9
Bug 1572692 - Properly crop results in the Search panel; r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D41940
--HG--
extra : moz-landing-system : lando
2019-08-16 09:04:11 +00:00
lloan
352eaa7c22
Bug 1572367 - Warning: Failed prop type: TreeRow: prop type is invalid. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D41278
--HG--
extra : moz-landing-system : lando
2019-08-09 06:08:01 +00:00
Nicolas Chevobbe
fe2f310301
Bug 1564138 - Fix DevTools PropTypes errors when updating eslint. r=Ola.
...
Differential Revision: https://phabricator.services.mozilla.com/D38093
--HG--
extra : moz-landing-system : lando
2019-07-17 10:35:44 +00:00
Maliha Islam
8cfcbe667f
Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
...
Differential Revision: https://phabricator.services.mozilla.com/D33885
--HG--
extra : moz-landing-system : lando
2019-07-15 11:01:04 +00:00
Narcis Beleuzu
cb456cb27d
Backed out 6 changesets (bug 1478156) for dt failures on browser_html_tooltip_xul-wrapper.js . CLOSED TREE
...
Backed out changeset 5ca694230ffa (bug 1478156)
Backed out changeset fcc9123589fd (bug 1478156)
Backed out changeset 83a10c635fe9 (bug 1478156)
Backed out changeset a363971fffb0 (bug 1478156)
Backed out changeset 314855eab887 (bug 1478156)
Backed out changeset 041f51c9d4d1 (bug 1478156)
--HG--
rename : devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js => devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click.js
2019-07-14 05:32:45 +03:00
Maliha Islam
ff03e00a30
Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
...
Differential Revision: https://phabricator.services.mozilla.com/D33885
--HG--
extra : moz-landing-system : lando
2019-07-13 18:37:18 +00:00
Victor Porof
f6db0ee557
Bug 1561435 - Format devtools/client/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35884
--HG--
extra : source : 60e4496cf9699dc59f2f4738cb60f87cbdb01e67
2019-07-05 11:24:38 +02:00
Yura Zenevich
5006c3543f
Bug 1550542 - fix a number of issues around aria-level within the accessibility tree. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D30594
--HG--
extra : moz-landing-system : lando
2019-05-14 12:31:13 +00:00
Yura Zenevich
c087faa4dc
Bug 1544710 - ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D29342
--HG--
extra : moz-landing-system : lando
2019-05-03 04:05:36 +00:00
shindli
f58e49c03e
Backed out changeset 082c0dba73cb (bug 1544710) for causing dt permafailures in devtools/client/netmonitor/test/browser_net_propertiesview-copy.js CLOSED TREE
2019-05-02 15:33:01 +03:00
Yura Zenevich
3a6c1c6a49
Bug 1544710 - ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D29342
--HG--
extra : moz-landing-system : lando
2019-05-02 04:32:33 +00:00
Yura Zenevich
663f9a19bc
Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D24538
--HG--
extra : moz-landing-system : lando
2019-04-04 14:12:37 +00:00
Dorel Luca
1d1a8d9b10
Backed out changeset 29af6bb009d2 (bug 1538281) for Devtools failures in devtools/client/jsonview/test/browser_json_refresh.js. CLOSED TREE
2019-04-03 19:47:57 +03:00
Yura Zenevich
b0899e3156
Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D24538
--HG--
extra : moz-landing-system : lando
2019-04-03 14:36:42 +00:00
Coroiu Cristina
e77251af23
Backed out changeset d124ebd3b9eb (bug 1538281) for mochitest failures e.g. devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js on a CLOSED TREE
2019-04-03 14:32:00 +03:00
Yura Zenevich
177f4b2913
Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D24538
--HG--
extra : moz-landing-system : lando
2019-04-03 00:36:03 +00:00
Yura Zenevich
2b1ee77653
Bug 1507870 - add support for contextmenu extensibility of TreeRow. r=Honza
...
MozReview-Commit-ID: HhoNsCAiZAk
Differential Revision: https://phabricator.services.mozilla.com/D12501
--HG--
extra : moz-landing-system : lando
2018-11-30 14:54:59 +00:00
Mark Banner
ceaeb93550
Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D8389
--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Julian Descottes
640fe52298
Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
...
MozReview-Commit-ID: F6xUXCgdRE4
--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
J. Ryan Stinnett
23ff4cc75d
Bug 1443081 - Apply spacing via `eslint --fix` for DevTools. r=jdescottes
...
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
Michael Ratcliffe
13b7e232cc
Bug 1413860 - Shared components to use prop-types and react-dom-factories r=nchevobbe
...
@nchevobbe: Please wait for a green try before reviewing this.
MozReview-Commit-ID: 9SLEHAq0IQQ
--HG--
extra : rebase_source : f3864d13d36802914171581f9f60351cf71aad2f
2017-11-03 13:34:41 +00:00
Narcis Beleuzu
0a20dc62d7
Backed out changeset 9029ee56b1ad (bug 1413860) for mochitest clipboard failures on browser_jsterm_selfxss.js. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 905d4c8798d1e1947f716d350fd199ebd0d2ae79
2017-11-13 14:16:40 +02:00
Michael Ratcliffe
e2ba0b4bd2
Bug 1413860 - Shared components to use prop-types and react-dom-factories r=nchevobbe
...
@nchevobbe: Please wait for a green try before reviewing this.
MozReview-Commit-ID: 9SLEHAq0IQQ
--HG--
extra : rebase_source : b916d948f3712bf4f09e50436cbdd0cf0f12afb4
2017-11-03 13:34:41 +00:00
Michael Ratcliffe
1e9d21eb34
Bug 1412311
- DevTools Shared Components to ES6 classes r=nchevobbe
...
In devtools/client/shared/components/tree/TreeView.js I have had to leave defaultProps outside the getter as a temporary workaround for bug 1413167.
MozReview-Commit-ID: 1yaxqFnC92p
--HG--
extra : rebase_source : 64cae084e3edbb71e2b6948d69459bd82705c040
2017-10-27 15:33:10 +01:00
Dan Epstein
b9e816d060
Bug 1402394 CamelCase all React component files in \devtools\client\shared\components\. r=pbro
...
MozReview-Commit-ID: HH4mbqB6RTK
--HG--
rename : devtools/client/shared/components/autocomplete-popup.js => devtools/client/shared/components/AutoCompletePopup.js
rename : devtools/client/shared/components/frame.js => devtools/client/shared/components/Frame.js
rename : devtools/client/shared/components/h-split-box.js => devtools/client/shared/components/HSplitBox.js
rename : devtools/client/shared/components/notification-box.css => devtools/client/shared/components/NotificationBox.css
rename : devtools/client/shared/components/notification-box.js => devtools/client/shared/components/NotificationBox.js
rename : devtools/client/shared/components/search-box.js => devtools/client/shared/components/SearchBox.js
rename : devtools/client/shared/components/sidebar-toggle.css => devtools/client/shared/components/SidebarToggle.css
rename : devtools/client/shared/components/sidebar-toggle.js => devtools/client/shared/components/SidebarToggle.js
rename : devtools/client/shared/components/stack-trace.js => devtools/client/shared/components/StackTrace.js
rename : devtools/client/shared/components/tree.js => devtools/client/shared/components/Tree.js
rename : devtools/client/shared/components/splitter/draggable.js => devtools/client/shared/components/splitter/Draggable.js
rename : devtools/client/shared/components/splitter/split-box.css => devtools/client/shared/components/splitter/SplitBox.css
rename : devtools/client/shared/components/splitter/split-box.js => devtools/client/shared/components/splitter/SplitBox.js
rename : devtools/client/shared/components/tabs/tabbar.css => devtools/client/shared/components/tabs/TabBar.css
rename : devtools/client/shared/components/tabs/tabbar.js => devtools/client/shared/components/tabs/TabBar.js
rename : devtools/client/shared/components/tabs/tabs.css => devtools/client/shared/components/tabs/Tabs.css
rename : devtools/client/shared/components/tabs/tabs.js => devtools/client/shared/components/tabs/Tabs.js
rename : devtools/client/shared/components/tree/label-cell.js => devtools/client/shared/components/tree/LabelCell.js
rename : devtools/client/shared/components/tree/object-provider.js => devtools/client/shared/components/tree/ObjectProvider.js
rename : devtools/client/shared/components/tree/tree-cell.js => devtools/client/shared/components/tree/TreeCell.js
rename : devtools/client/shared/components/tree/tree-header.js => devtools/client/shared/components/tree/TreeHeader.js
rename : devtools/client/shared/components/tree/tree-row.js => devtools/client/shared/components/tree/TreeRow.js
rename : devtools/client/shared/components/tree/tree-view.css => devtools/client/shared/components/tree/TreeView.css
rename : devtools/client/shared/components/tree/tree-view.js => devtools/client/shared/components/tree/TreeView.js
extra : rebase_source : 5ef89b4169dda156a8160d4d21655147f4d9da11
2017-09-27 01:12:13 -04:00