Currently dot files (e.g. .eslintrc.js) are not checked in the full run on CI.
Also ignores .gradle/ directory as that it a cache.
Differential Revision: https://phabricator.services.mozilla.com/D177261
Enables Prettier for (these don't need to be excluded):
- extensions/pref/autoconfig/test/unit/autoconfig.js
- services/sync/tests/unit/prefs_test_prefs_store.js
Removes duplications where the files are already ignored in the .eslintignore section.
Re-organises the structure of the remaining parts to make it clearer why they are being excluded.
Differential Revision: https://phabricator.services.mozilla.com/D176636
Unfortunately Prettier does not currently support multiple ignore files (see bug 1825508). Therefore we have to duplicate the entries from .eslintignore/Generated.txt/ThirdPartyPaths.txt for the time being.
Differential Revision: https://phabricator.services.mozilla.com/D174762
Unfortunately Prettier does not currently support multiple ignore files (see bug 1825508). Therefore we have to duplicate the entries from .eslintignore/Generated.txt/ThirdPartyPaths.txt for the time being.
Differential Revision: https://phabricator.services.mozilla.com/D174762
The shell module loader was rewritten to C++ in bug 1637529.
"jsrtfuzzing-example.js" was changed to appease prettier, now that it's enabled.
Differential Revision: https://phabricator.services.mozilla.com/D153151
There are some complications here to handle unpackaged and packaged
builds. In addition, there could be a difference between App prefs
and GRE prefs. Since the underlying backgroundtasks code is built as
part of Gecko (i.e., `toolkit/...` rather than `browser/...`) I have
favoured GRE prefs. I think, however, that what is written will work
for App-specific prefs, but I'm not concerned with that detail at this
time.
This also add tests for backgroundtask-specific prefs, which are
structured as both xpcshell and mochitest-chrome tests because
locally, the former tests unpackaged builds and the latter can
accommodate testing packaged builds. We could use mochitest-chrome
for both, but this has been pleasant to work with locally.
Differential Revision: https://phabricator.services.mozilla.com/D97510
There are some complications here to handle unpackaged and packaged
builds. In addition, there could be a difference between App prefs
and GRE prefs. Since the underlying backgroundtasks code is built as
part of Gecko (i.e., `toolkit/...` rather than `browser/...`) I have
favoured GRE prefs. I think, however, that what is written will work
for App-specific prefs, but I'm not concerned with that detail at this
time.
This also add tests for backgroundtask-specific prefs, which are
structured as both xpcshell and mochitest-chrome tests because
locally, the former tests unpackaged builds and the latter can
accommodate testing packaged builds. We could use mochitest-chrome
for both, but this has been pleasant to work with locally.
Differential Revision: https://phabricator.services.mozilla.com/D97510
There are some complications here to handle unpackaged and packaged
builds. In addition, there could be a difference between App prefs
and GRE prefs. Since the underlying backgroundtasks code is built as
part of Gecko (i.e., `toolkit/...` rather than `browser/...`) I have
favoured GRE prefs. I think, however, that what is written will work
for App-specific prefs, but I'm not concerned with that detail at this
time.
This also add tests for backgroundtask-specific prefs, which are
structured as both xpcshell and mochitest-chrome tests because
locally, the former tests unpackaged builds and the latter can
accommodate testing packaged builds. We could use mochitest-chrome
for both, but this has been pleasant to work with locally.
Differential Revision: https://phabricator.services.mozilla.com/D97510
It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.
However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.
This can lead to unexpected formatting changes for developers using VSCode.
Differential Revision: https://phabricator.services.mozilla.com/D58593
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41145
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41324
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
The patch also changes the form of the "not Android" condition to one used more
widely in all.js.
Differential Revision: https://phabricator.services.mozilla.com/D41299
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41298
--HG--
extra : moz-landing-system : lando
This patch removes two entries:
- devtools/client/netmonitor/launchpad.js: this file no longer exists.
- devtools/client/webconsole/test/mocha-test-setup.js: this file is a proper JS
file, not a prefs file.
The patch also reformats mocha-test-setup.js.
Differential Revision: https://phabricator.services.mozilla.com/D41150
--HG--
extra : moz-landing-system : lando
security-prefs.js is #included into greprefs.js, but there's no good reason for
it to be separate from all.js. Having it separate makes it easier to overlook,
and all.js has a bunch of `security.*` prefs in it anyway.
This patch inlines it into all.js. It inlines it at the start of the file to
minimize the risk of the change, so that the prefs end up in greprefs.js in the
same order as before.
Differential Revision: https://phabricator.services.mozilla.com/D40919
--HG--
extra : moz-landing-system : lando
Mathieu Leplatre
Florian Quèze
Valentin Gosu
Natalia Csoregi
Barret Rennie
Mark Banner
Dimi
Issam Mani
Bilal
Cristian Tuns
Cosmin Sabou
André Bargull
Nick Alexander
Butkovits Atila
Luca Greco
Julian Descottes
Nicholas Nethercote
Victor Porof