Emilio Cobos Álvarez
bbc6f5b7f2
Bug 1476054: Fixes and cleanups for Servo PR #21139 . r=me
...
Logical floats don't appear in the computed style objects, so there's no need to
check for them.
MozReview-Commit-ID: 3ocJrRB3jeO
2018-07-17 10:15:46 +02:00
Gurzau Raul
c05f725b1e
Backed out 6 changesets (bug 1476054) for failing on servo/ports/geckolib/glue.rs on a CLOSED TREE
...
Backed out changeset f4941fe345ad (bug 1476054)
Backed out changeset cc571c618e4c (bug 1476054)
Backed out changeset 0a712d7bcb66 (bug 1476054)
Backed out changeset 62293a989ed2 (bug 1476054)
Backed out changeset ef2a43e3fc6c (bug 1476054)
Backed out changeset a2bb0089cf1d (bug 1476054)
2018-07-16 23:56:23 +03:00
Emilio Cobos Álvarez
cd116a52c4
Bug 1476054: Fixes and cleanups for Servo PR #21139 . r=me
...
Logical floats don't appear in the computed style objects, so there's no need to
check for them.
MozReview-Commit-ID: 3ocJrRB3jeO
2018-07-16 21:38:44 +02:00
Andi-Bogdan Postelnicu
5e3e0d4498
Bug 1453795 - Layout - Initialize member fields in classes/ structures. r=dbaron
2018-07-12 09:42:14 +03:00
Daniel Holbert
465698a70d
Bug 1468663 part 2: Add missing #includes, forward-decls, and 'using' statements in layout/generic to fix bustage in non-unified builds. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D1650
2018-06-15 18:00:36 +00:00
Ting-Yu Lin
da355c78c8
Bug 1455453 - Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor. r=dholbert
...
MozReview-Commit-ID: 2tdsttkO6ig
--HG--
extra : rebase_source : c504042615466bfa5b93aa25fad098ed3dcd1b9b
2018-06-11 22:46:35 +08:00
Brad Werth
5cb7ed31be
Bug 1463745 Part 2: Change nsFlowAreaRect to also track whether it may widen in the block direction. r=dbaron
...
MozReview-Commit-ID: FWKQEFDBFgr
--HG--
extra : rebase_source : d08e5b466dd6a7f0a61b5a3142eb756e17446473
2018-05-30 11:07:18 -07:00
Brad Werth
87348ed21e
Bug 1463745 Part 1: Add methods to FloatInfo and ShapeInfo to report whether or not they could narrow in the block direction. r=dbaron
...
MozReview-Commit-ID: 38TMjcoaeAe
--HG--
extra : rebase_source : b48a30330c397cddc16e583cfd22cfec405613bc
2018-05-30 10:03:45 -07:00
Brad Werth
84a01ca307
Bug 1461046 Part 4: Change PolygonShapeInfo to tolerate polygons with only 1 or 2 vertices. r=dholbert
...
MozReview-Commit-ID: ICcIUulgSCW
--HG--
extra : rebase_source : 27cd61f9e3e6d109258c64bda81888f931a67193
2018-05-22 15:54:21 -07:00
Brad Werth
8e6d3f8c97
Bug 1461046 Part 3: Change RoundedBoxShapeInfo to tolerate empty rects. r=dholbert
...
MozReview-Commit-ID: FNQwXdeqfua
--HG--
extra : rebase_source : 31b9a1174f1d2203b98e0b11dd9e0863863b63f5
2018-05-18 17:38:41 -07:00
Brad Werth
16c93065dd
Bug 1461046 Part 1: Change EllipseShapeInfo to tolerate empty circles/ellipses and treat them as singular points/lines (possibly expanded by shape-margin). r=dholbert
...
MozReview-Commit-ID: 69VQiRjhtqA
--HG--
extra : rebase_source : 21e2d1ede48758c664749c725c531f1e64aa6d18
2018-05-18 17:13:22 -07:00
Gurzau Raul
b36972ff91
Backed out 7 changesets (bug 1461046) for permafailing reftest on /reftests/css-invalid/select/select-disabled-fieldset-1.html a=backout
...
Backed out changeset f5990eb1eb0d (bug 1461046)
Backed out changeset 8e0c340b9700 (bug 1461046)
Backed out changeset fbfe1d5b94e1 (bug 1461046)
Backed out changeset 48057a6ba3d6 (bug 1461046)
Backed out changeset 5c8648bcf6bb (bug 1461046)
Backed out changeset 157bbc74460a (bug 1461046)
Backed out changeset e990d4d07b0e (bug 1461046)
2018-06-02 05:07:03 +03:00
Cosmin Sabou
1bc774a842
Merge mozilla-central to inbound. a=merge CLOSED TREE
2018-06-01 12:44:57 +03:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Brad Werth
4c4f010732
Bug 1461046 Part 4: Change PolygonShapeInfo to tolerate polygons with only 1 or 2 vertices. r=dholbert
...
MozReview-Commit-ID: ICcIUulgSCW
--HG--
extra : rebase_source : b92a51a5298d4821c2ab86f9745867ea6dbdd387
2018-05-22 15:54:21 -07:00
Brad Werth
73efe1c012
Bug 1461046 Part 3: Change RoundedBoxShapeInfo to tolerate empty rects. r=dholbert
...
MozReview-Commit-ID: FNQwXdeqfua
--HG--
extra : rebase_source : bc9b97d5aef5bbece169ef1931523fb4f4a2e64f
2018-05-18 17:38:41 -07:00
Brad Werth
39839d2bd4
Bug 1461046 Part 1: Change EllipseShapeInfo to tolerate empty circles/ellipses and treat them as singular points/lines (possibly expanded by shape-margin). r=dholbert
...
MozReview-Commit-ID: 69VQiRjhtqA
--HG--
extra : rebase_source : 73fe14510971000890f2e2764f9c81cf505e6644
2018-05-18 17:13:22 -07:00
Brad Werth
e0834100e1
Bug 1464113 Part 1: Make ImageShapeInfo tolerate shapes that are shifted left or above their margin rects. r=dholbert
...
MozReview-Commit-ID: 9NuHsjQfLxP
--HG--
extra : rebase_source : 37c7524daa268bb8321b9904ead9ca643f0641db
2018-05-25 15:12:02 -07:00
Brad Werth
140f9cb9f9
Bug 1460041 Part 1: Correct PolygonShapeInfo constructor to measure its start and end block extents in margin rect space. r=jfkthame
...
MozReview-Commit-ID: 5pxiK1oH7sn
--HG--
extra : rebase_source : f6ad9f0e66a0ce5fe7c487a0cd9a05e74bbd201f
2018-05-08 15:56:49 -07:00
Coroiu Cristina
8d9a2fdf05
Backed out 2 changesets (bug 1460041) for lint failure at /builds/worker/checkouts/gecko/tools/lint/wpt.yml on a CLOSED TREE
...
Backed out changeset 25c0ace5ecb4 (bug 1460041)
Backed out changeset 8f13ab5de9be (bug 1460041)
2018-05-11 01:25:08 +03:00
Brad Werth
0e6a1cf4aa
Bug 1460041 Part 1: Correct PolygonShapeInfo constructor to measure its start and end block extents in margin rect space. r=jfkthame
...
MozReview-Commit-ID: 5pxiK1oH7sn
--HG--
extra : rebase_source : f6ad9f0e66a0ce5fe7c487a0cd9a05e74bbd201f
2018-05-08 15:56:49 -07:00
Coroiu Cristina
404bf48e99
Backed out 2 changesets (bug 1460041) for linting failure at css/vendor-imports/mozilla/mozilla-central-reftests/shapes1 e.g. shape-outside-circle-056-ref.html on a CLOSED TREE
...
Backed out changeset b19f3977715c (bug 1460041)
Backed out changeset a1dbfe37baf3 (bug 1460041)
2018-05-10 20:15:58 +03:00
Brad Werth
0caddebf1a
Bug 1460041 Part 1: Correct PolygonShapeInfo constructor to measure its start and end block extents in margin rect space. r=jfkthame
...
MozReview-Commit-ID: 5pxiK1oH7sn
--HG--
extra : rebase_source : 8ac9cc0d3af446489c6c5a6d1c72650540c3c465
2018-05-08 15:56:49 -07:00
Brad Werth
1ac1d8fd0d
Bug 1459697 Part 2: Account for the possibility that EllipseShapeInfo may not generate an interval for the entire BStart() to BEnd() range, due to rounding error in the distance field calculation. r=dbaron
...
MozReview-Commit-ID: CYeBKhDYD1F
The distance field does not calculate a true Euclidean distance, so it is
unreasonable to require that the intervals span all of the BStart() to BEnd()
float area. The final block pixel may not generate an interval at all due to
rounding errors. This change makes accomodation for the rounding errors and
adds asserts to ensure we aren't tolerating errors outside the area of the
last block pixel.
--HG--
extra : rebase_source : 114c1667861c90a055295f9bd40a3991cbb5dc88
2018-05-07 14:02:03 -07:00
Brad Werth
4624dc95ff
Bug 1459697 Part 1: In EllipseShapeInfo distance field calculation, remove a warning that might trigger due to rounding error, and shorten the iteration of each block pixel row, when possible. r=dbaron
...
MozReview-Commit-ID: 6itpj3HBSRy
--HG--
extra : rebase_source : 2285e1b0c136f6fe8c057f7bdb0a8566146cd443
2018-05-08 11:11:47 -07:00
Brad Werth
e70fdc35ef
Bug 1457602 Part 2: Correct shape-outside: image interval creation to correctly handle sideways-lr (with or without positive shape-margin.) r=jfkthame
...
MozReview-Commit-ID: F4fsRPajJfR
--HG--
extra : rebase_source : 217c18eee3b5ea1ba145752ed39d27ef80d208e4
2018-05-03 15:51:06 -07:00
Brad Werth
8eda60256e
Bug 1457602 Part 1: Correct shape-outside: image shape-margin calculation for vertical writing modes. r=jfkthame
...
MozReview-Commit-ID: ChUL66vUkHu
--HG--
extra : rebase_source : beadd474d6022b1f8672c39cb841da8590ffde51
2018-04-30 17:01:24 -07:00
Chris Peterson
71422dcaa9
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Brad Werth
edc885a2e3
Bug 1451499 Part 3: Implement polygon for shape-margin > 0. r=jfkthame
...
MozReview-Commit-ID: BJtGaJBQMQr
--HG--
extra : rebase_source : 28673e9758b15647dd8603f87d997566f257c62c
2018-04-19 11:47:04 -07:00
Brad Werth
51417a7fcd
Bug 1451499 Part 2: Stub in support for polygon with shape-margin == 0. r=jfkthame
...
MozReview-Commit-ID: 2biFnthoWin
--HG--
extra : rebase_source : a3bb7051555e1b19be1864de777dc2b7c96b24ed
2018-04-19 11:27:28 -07:00
Brad Werth
c3368afe4a
Bug 1451499 Part 1: Uplift some interval methods from ImageShapeInfo to ShapeInfo. r=jfkthame
...
MozReview-Commit-ID: AMwujPuTeOm
--HG--
extra : rebase_source : 8872b15c63d39473aa39c9e58a70fd363c0fc031
2018-04-19 12:17:44 -07:00
Brad Werth
99b2977f75
Bug 1457288 - Part 3: Change distance field sizes and indexes to be unsigned ints, avoiding undefined behavior with potential int overflows. r=mats
2018-04-30 12:25:13 -07:00
Brad Werth
bed36b14d5
Bug 1457288 - Part 2: Clamp shape-margin distance field operands to prevent int multiplication overflow when allocating. r=mats
2018-04-27 18:10:51 -07:00
Brad Werth
914c3f1d6c
Bug 1457288 - Part 1: Clamp EllipseShapeInfo distance field operands to the maximum shape-margin we are willing to compute. r=mats
...
MozReview-Commit-ID: IXAV0uaxB0R
2018-04-27 13:10:08 -07:00
Brad Werth
9b1031c464
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
...
MozReview-Commit-ID: 67vq9Gcr8qJ
--HG--
extra : rebase_source : afea3fab0bfd0ad538ddc902f9a8ffedd4a65862
2018-02-26 14:47:31 -08:00
Brad Werth
8511677375
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: 4pjALPSIBhI
--HG--
extra : rebase_source : b8c065173e04033795baa67c4fcf8222103182cb
2018-04-17 11:39:50 -07:00
Brad Werth
c8f1b46489
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: AEOksiuM0GJ
--HG--
extra : rebase_source : edc6f6040760d3facb3a7f6bcdc39f1d8fa208f0
2018-04-13 11:29:14 -07:00
Brad Werth
b935ad1265
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
...
MozReview-Commit-ID: G8qdPlnh8kY
--HG--
extra : rebase_source : 2917054937f488c601394f1d244151c9c3df7596
2018-04-17 11:59:11 -07:00
Brad Werth
eb8a0661ae
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: CpuWWaLh1CX
--HG--
extra : rebase_source : 6db8ba9191f1211d8ea2435b23dc13caae39955c
2018-04-20 13:43:36 -07:00
Brad Werth
6c6be70823
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: CovCfk5ryEn
--HG--
extra : rebase_source : 4691876fd2afb2833ddf416821988f59abd4c019
2018-04-11 15:18:32 -07:00
Brad Werth
6c5a82a38c
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
...
MozReview-Commit-ID: HeipoUTkqUE
--HG--
extra : rebase_source : 21de8ff25a10ea8007a310e91254cf17346cdd3f
2018-02-26 13:13:03 -08:00
Brad Werth
104fcf3ad7
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: 1C9vB14Qhyj
--HG--
extra : rebase_source : 1f5d912deb27c4f1e2a65e609d6ebc825ab34790
2018-04-20 14:04:15 -07:00
Brad Werth
314184fbb8
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: 4xqfqWB78Oh
--HG--
extra : rebase_source : 5ca9e80eb25b9100f7bcbc5a7936b3ec5ce3f1cd
2018-02-22 11:11:03 -08:00
Brad Werth
e53f7f51ac
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
...
MozReview-Commit-ID: 2gVRyQtd7Io
--HG--
extra : rebase_source : 1e3cd2e71d7dbb89db74c5ce8ac88695c70843a1
2018-03-12 17:04:34 -07:00
Brad Werth
eeb34f4713
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
...
MozReview-Commit-ID: LnzQPsSBVqY
--HG--
extra : rebase_source : 20ff59b099ae7e7f0f3e5207b017f919d5b6f661
2018-02-28 10:43:43 -08:00
Brad Werth
405f362460
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
...
MozReview-Commit-ID: BxJxIU0RVAo
--HG--
extra : rebase_source : c822c3fd56fe8fc11aeb7aab10afa440a2a53931
2018-04-11 14:05:06 -07:00
Narcis Beleuzu
a07765b336
Backed out 20 changesets (bug 1265342) for mochitest-plain-headless failures on layout/style/test/test_first_letter_restrictions.html. CLOSED TREE
...
Backed out changeset 6c80ec2d0398 (bug 1265342)
Backed out changeset 62d571916086 (bug 1265342)
Backed out changeset fd247f38f8a7 (bug 1265342)
Backed out changeset 83aee3dafe4b (bug 1265342)
Backed out changeset 9b200122014e (bug 1265342)
Backed out changeset a90aa063b2fd (bug 1265342)
Backed out changeset 0791ff3d9194 (bug 1265342)
Backed out changeset 7109288f10b3 (bug 1265342)
Backed out changeset 048cce2fb99f (bug 1265342)
Backed out changeset c8e3dbc6c729 (bug 1265342)
Backed out changeset 09da0968333a (bug 1265342)
Backed out changeset d16f7ff85677 (bug 1265342)
Backed out changeset 53eb7f14463d (bug 1265342)
Backed out changeset 64fc631ef122 (bug 1265342)
Backed out changeset 332382c708e1 (bug 1265342)
Backed out changeset a8695981eec0 (bug 1265342)
Backed out changeset ce473fa5f1f4 (bug 1265342)
Backed out changeset 5ee470e75a53 (bug 1265342)
Backed out changeset 802aa95a52d9 (bug 1265342)
Backed out changeset 5da0c34c9600 (bug 1265342)
2018-04-24 22:31:15 +03:00
Brad Werth
9dcd875e5a
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
...
MozReview-Commit-ID: 67vq9Gcr8qJ
--HG--
extra : rebase_source : 9bb27215f51bb914b1e9e185419b605b3ae29167
2018-02-26 14:47:31 -08:00
Brad Werth
24f86cb132
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: 4pjALPSIBhI
--HG--
extra : rebase_source : 017c887e4f8d6f2ca0c2293fcb910b0daec1e06d
2018-04-17 11:39:50 -07:00
Brad Werth
df2128a244
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: AEOksiuM0GJ
--HG--
extra : rebase_source : f12a98ebfc393d97dc2fba352427486f2a75feda
2018-04-13 11:29:14 -07:00