Nicolas Chevobbe
269c35eaac
Bug 1648875 - Fix stacktrace parsing when frame has multiple "@". r=loganfsmyth.
...
When parsing frames, we only need to retrieve the first "@" index to split
the frame string and get the function name on one side, and the location on the
other side.
This patch removes the regex-based search we were doing for a simpler character
search. A test is added to ensure this works as expected, and snapshots that were
highlighting the issue are updated.
Differential Revision: https://phabricator.services.mozilla.com/D81519
2020-06-29 15:05:31 +00:00
Nicolas Chevobbe
b4e71553af
Bug 1648017 - Disable console text-selection only evaluation in in-line mode. r=Honza.
...
This feature is great in editor mode, but can be confusing in in-line mode.
In inline mode, the input is cleared when you evaluate, so if you wrongfully
evaluated only a text selection, you may lose the whole input, and have to
type it again.
This patch disable the feature in inline mode, and modifies the existing test
so we make sure that this work as expected in both editor and inline mode.
Differential Revision: https://phabricator.services.mozilla.com/D81333
2020-06-29 11:49:29 +00:00
Daisuke Akatsuka
de90f65570
Bug 1646974: Add a test for the stylesheet which is loaded as internal. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D80807
2020-06-26 09:21:58 +00:00
Daisuke Akatsuka
14e2eb6c29
Bug 1646974: Introduce and use isInDevToolsContext flag. r=Honza,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80623
2020-06-29 09:34:54 +00:00
Razvan Maries
4b75bbe39d
Bug 1618059 - Disabled test_extension_storage_actor.js on Windows. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D81406
2020-06-29 08:17:39 +00:00
Nicolas Chevobbe
0398ff5ec9
Bug 1648795 - Fix devtools/shared/resources/tests/browser_resources_several_resources.js. r=jdescottes.
...
We were only checking a number of received resources, and as we're listening to
the parent process, any error messages emitted by the platform would hinder the
test. This patch changes the test to expect specific resources instead.
Differential Revision: https://phabricator.services.mozilla.com/D81354
2020-06-29 05:18:17 +00:00
Razvan Maries
69fe4f3c2f
Bug 1645563 - Disabled browser_dbg-scopes-duplicated.js on Windows. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D81399
2020-06-26 20:38:30 +00:00
Logan Smyth
48aeb2fe30
Bug 1644075 - Make sure that injected scripts have no URL. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D81376
2020-06-27 05:19:51 +00:00
Julian Descottes
6169f8ceee
Bug 1637793 - Catch updateWorkers errors occurring after app panel destroy r=ladybenko
...
Differential Revision: https://phabricator.services.mozilla.com/D78633
2020-06-26 12:39:47 +00:00
Marco Zehe
5dfb4493c4
Bug 1648011 - Give the All Tabs overflow button a tooltip, r=nchevobbe,flod,Honza
...
This pertains to both the inspector side bar as well as the net monitor tabs.
Differential Revision: https://phabricator.services.mozilla.com/D80829
2020-06-26 07:50:29 +00:00
Nicolas Chevobbe
90123a987c
Bug 1648458 - Add a test to assert resource watcher destruction when associated target actor is destroyed. r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D81034
2020-06-26 06:58:55 +00:00
Marco Zehe
0e1ed3a46b
Bug 1648069 - Make the Changes view a document for screen readers, r=yzen
...
Also make it focusable so screen readers will pick up even the "no changes yet" scenario and won't skip over it.
Differential Revision: https://phabricator.services.mozilla.com/D80865
2020-06-26 00:15:21 +00:00
Zibi Braniecki
8ce6deaff2
Bug 1641719 - Don`t set 0 state in TreeView on first click. r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D79322
2020-06-26 00:14:23 +00:00
Sebastian Zartner
63db1cbfbc
Bug 1635970 - Extended support for XPath expressions in Inspector search. r=jdescottes
...
The limitation to expressions starting with a slash was lifted in order to allow searching via other possible XPath expressions like `id("foo")` or `(//div)[2]`.
Differential Revision: https://phabricator.services.mozilla.com/D80963
2020-06-25 18:32:40 +00:00
Razvan Caliman
1c03261951
Bug 1644789 - Wait for Rule view to update before interacting with Flexbox toggle r=gl
...
By the looks of the [screenshot of the failing test](https://firefoxci.taskcluster-artifacts.net/QIl2Xbs1T5CfvCoUtWkK5w/0/public/test_info//mozilla-test-fail-screenshot_g8P5sS.png ), the Rules view isn't updated to reflect the styles for the flex container. Looks like a race condition.
This patch ensures that the test waits for the [Rules view to update](https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/devtools/client/inspector/rules/rules.js#980 ) before attempting to click on the swatch to toggle the Flexbox highlighter.
Differential Revision: https://phabricator.services.mozilla.com/D81035
2020-06-25 16:36:44 +00:00
Belén Albeza
f08228b977
Bug 1642947 - Enable application panel in all channels r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D81112
2020-06-25 15:02:52 +00:00
Razvan Caliman
59990429a0
Bug 1647989
- Add default reducer to avoid error when creating a Redux store with no reducers. r=gl
...
We can't create a Redux store without reducers. Redux throws an error.
It's benign and doesn't impact anything (panels load reducers on-demand before accessing them), but it's annoying to see the error in the console and in tests.
Differential Revision: https://phabricator.services.mozilla.com/D81047
2020-06-25 14:20:41 +00:00
Nicolas Chevobbe
7089e9987d
Bug 1646678 - Allow resource watcher tests to force server side support. r=ochameau.
...
This is done by getting the value of the `devtools.testing.enableServerWatcherSupport`
preference on the WatcherActor, and using its result to enable the traits or not.
On the browser_resources_* test that have both legacy and server listener, we
run the tests twice, without and with the pref to have some decent coverage.
Differential Revision: https://phabricator.services.mozilla.com/D79983
2020-06-25 08:59:58 +00:00
Nicolas Chevobbe
05d83bc5f9
Bug 1648022 - Unwatch resources on target destruction. r=ochameau.
...
This removes the unpopulated _resourceWatchers attributes from
the browsing context, and instead uses a new function on the
Resource module (`unwatchAllTargetResources`)
Differential Revision: https://phabricator.services.mozilla.com/D80834
2020-06-25 08:59:04 +00:00
Jan Odvarko
6799964058
Bug 1646960 - imported patch ignore-blocked-preloads.diff r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D80856
2020-06-25 10:54:15 +00:00
Nihanth Subramanya
0b44a1b2ab
Bug 1645896 - Add a console log origins that have their cookies partitioned by dFPI. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D80675
2020-06-25 05:51:29 +00:00
Matt Woodrow
b351d48f0c
Bug 1646582 - Pull the inner window id from the WindowGlobalParent, rather than passing it across PBrowser for updateForLocationChange. r=nika,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80131
2020-06-24 19:59:32 +00:00
Matt Woodrow
ea21b3dd8e
Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-24 19:59:04 +00:00
Hubert Boma Manilla
21ef456a07
Bug 1647625 - Undo check for id or reason for block requests r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D80679
2020-06-24 12:01:27 +00:00
Hubert Boma Manilla
bc56a33f92
Bug 1645748 - Add the MDN link for status code r=Honza
...
- Added the MDN link for status codes
- Fixed tooltip for the enhanced protection tracking MDN link
Differential Revision: https://phabricator.services.mozilla.com/D80831
2020-06-24 15:51:51 +00:00
Daisuke Akatsuka
94dc1583db
Bug 1647603: Update MDN compat data. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D80770
2020-06-24 13:35:14 +00:00
Yura Zenevich
064b6f0847
Bug 1598016 - make sure that remote frame highlighting works in browser toolbox. r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D79404
2020-06-24 13:21:30 +00:00
Yura Zenevich
c5c241588f
Bug 1598016 - ensure that only one accessible object is highlighted at all times. r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D79403
2020-06-24 13:29:28 +00:00
Razvan Maries
592b80d333
Backed out changeset 7ff5210dae5e (bug 1645896) for build bustages. CLOSED TREE
2020-06-24 13:39:43 +03:00
Nihanth Subramanya
6be693b933
Bug 1645896 - Add a console log origins that have their cookies partitioned by dFPI. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D80675
2020-06-24 10:11:45 +00:00
Nicolas Chevobbe
efe9743fe7
Bug 1495728 - Remove unused ActorPool class. r=ochameau.
...
This class isn't used anymore, and it's safe to remove it.
We take this as an opportunity to remove Pool#cleanup and
Pool#isEmpty, which each only had one callsite.
Some comments are updated to not mention ActorPool.
Differential Revision: https://phabricator.services.mozilla.com/D80602
2020-06-24 07:39:06 +00:00
Nicolas Chevobbe
a67f596fa2
Bug 1621713 - Don't create extra ActorPools in devtools/server. r=jdescottes.
...
Remove pools and make target actors manage themselves.
devtools/server/tests/browser/browser_navigateEvents.js was modified
since the targetActor can't be retrieved with `searchAllConnectionsForActor`
anymore.
Differential Revision: https://phabricator.services.mozilla.com/D67510
2020-06-24 07:38:09 +00:00
Dorel Luca
90a64f0da1
Backed out 4 changesets (bug 1646582) for Browser-chrome failures on nsIWebProgress.addProgressListener. CLOSED TREE
...
Backed out changeset 2111dd0d6dc0 (bug 1646582)
Backed out changeset e6c496c5a4b1 (bug 1646582)
Backed out changeset 49b4ae8c8be0 (bug 1646582)
Backed out changeset 9d42ec89240c (bug 1646582)
2020-06-24 07:50:07 +03:00
Matt Woodrow
f430dac707
Bug 1646582 - Pull the inner window id from the WindowGlobalParent, rather than passing it across PBrowser for updateForLocationChange. r=nika,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80131
2020-06-24 03:25:35 +00:00
Matt Woodrow
acd97f7b2c
Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-24 03:25:09 +00:00
Daisuke Akatsuka
762d6b5b85
Bug 1591307: Localize Settings component. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D79809
2020-06-19 10:56:59 +00:00
Daisuke Akatsuka
f913d2c879
Bug 1591307: Localize Footer component. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D79808
2020-06-18 07:28:50 +00:00
Daisuke Akatsuka
629864cbae
Bug 1591307: Localize NodePane component. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D79807
2020-06-19 10:58:08 +00:00
Daisuke Akatsuka
cb287a6307
Bug 1591307: Localize IssueItem component. r=jdescottes,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D79806
2020-06-19 11:00:22 +00:00
Daisuke Akatsuka
4268b89051
Bug 1591307: Localize IssuePane component. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D79805
2020-06-18 07:28:03 +00:00
Daisuke Akatsuka
1c09f71859
Bug 1591307: Localize CompatibilityApp component. r=jdescottes,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D79804
2020-06-18 07:27:50 +00:00
Daisuke Akatsuka
1e1c4fc175
Bug 1591307: Introduce basic localization mechanism. r=jdescottes,stas
...
Differential Revision: https://phabricator.services.mozilla.com/D79803
2020-06-23 23:26:42 +00:00
Brad Werth
5c0d68416b
Bug 1498336: Modify test browser_toolbox_rule_view_reload.js to await reflow of the Rule View, not just that its "refreshed". r=mtigley
...
This change forces a reflow + repaint of the Rule View before checking its
contents. Ideally, this will remove the intermittent behavior of this test.
Differential Revision: https://phabricator.services.mozilla.com/D66671
2020-06-23 15:36:58 +00:00
Julien Wajsberg
dcc454abe5
Bug 1647650 - Reference the new profiler server instead of the old one r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D80613
2020-06-23 12:12:09 +00:00
Julian Descottes
426d07f236
Bug 1646636 - Disable devtools.contenttoolbox.fission in inspector tests for frames + context menu r=ochameau,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D80503
2020-06-23 13:26:06 +00:00
Julian Descottes
87467dc091
Bug 1644357 - Remove unused WebExtensionDescriptor properties isAPIExtension & type r=daisuke
...
Depends on D78009
Differential Revision: https://phabricator.services.mozilla.com/D78868
2020-06-09 10:09:09 +00:00
Julian Descottes
d412953eea
Bug 1646456 - Only call destroy on top level pools from connection onClosed r=ochameau,nchevobbe
...
Depends on D80060
Differential Revision: https://phabricator.services.mozilla.com/D80064
2020-06-23 11:08:30 +00:00
Julian Descottes
4006b42e26
Bug 1646456 - Remove unused noCleanup argument from removeActorPool r=nchevobbe
...
Depends on D80059
removeActorPool is only called from one spot, which always passes the second optional argument as true.
Differential Revision: https://phabricator.services.mozilla.com/D80060
2020-06-22 12:54:26 +00:00
Julian Descottes
b1578fe35a
Bug 1646456 - Add xpcshell test to check pool destruction when connection closes r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D80059
2020-06-23 10:13:59 +00:00
Coroiu Cristina
8126633a9c
Bug 1644044 - disable browser_dbg-old-breakpoint.js on linux and mac for frequesnt failures r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D80388
2020-06-23 10:23:15 +00:00