Seth Fowler
e8aa76cc0d
Bug 1285867 (Part 3b) - Replace the series of |if| statements in the Decode() loop with a |switch|. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
f5b3f999dd
Bug 1285867 (Part 3a) - Don't attempt to keep decoding if we're already done. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
0872ad00cb
Bug 1285867 (Part 2) - Don't call Decoder::PostDataError() from Decoder subclasses. r=edwin
2016-07-15 16:41:11 -07:00
Seth Fowler
3c38000891
Bug 1285867 (Part 1) - Remove Decoder's notion of decoder errors. r=edwin
2016-07-15 16:41:11 -07:00
Chris H-C
c12eb572dd
Bug 1285006 - Remove IMAGE_MAX_DECODE_COUNT Telemetry r=gfritzsche, seth
...
It clears a histogram on the child process which is no longer allowed
(see bug 1218576)
MozReview-Commit-ID: GXWN7qpalAc
2016-07-13 11:53:00 +02:00
Lee Salzman
16ca3223d9
Bug 1286317 - part 1 - remove Qt widget usage from gfx. r=jrmuizel
2016-07-12 20:27:57 -04:00
Seth Fowler
ddf805118b
No bug - Add an NS_WARNING to report when we hit the SurfaceCache-size heuristic limit for SourceBuffer. r=me DONTBUILD
2016-07-12 00:31:59 -07:00
Seth Fowler
bd9732ac1b
Bug 1285865 (Part 6) - Pass a SourceBufferIterator to Decoder::DoDecode(). r=edwin
2016-07-11 12:13:13 -07:00
Seth Fowler
e80fff4085
Bug 1285865 (Part 5) - Return a Maybe<TerminalState> from Decoder::DoDecode(). r=edwin
2016-07-11 12:13:11 -07:00
Seth Fowler
a9f24e8308
Bug 1285865 (Part 4) - Rename Decoder::WriteInternal() to Decoder::DoDecode() and fix its argument types. r=edwin
2016-07-11 12:13:09 -07:00
Seth Fowler
9ef391acb2
Bug 1285865 (Part 3) - Inline Decoder::Write() into Decoder::Decode(). r=edwin
2016-07-11 12:13:07 -07:00
Seth Fowler
b9c1cec011
Bug 1285865 (Part 2) - Add a RAII class to record decoder telemetry. r=edwin
2016-07-11 12:13:05 -07:00
Seth Fowler
a50b8d5f3e
Bug 1285865 (Part 1) - Remove Decoder::Write() checks that are redundant with Decoder::Decode(). r=edwin
2016-07-11 12:13:02 -07:00
Seth Fowler
e4439cf3bc
Bug 1185799 (Part 3) - Make nsICODecoder use only the public Decoder interface for writing to its contained decoder. r=edwin
2016-07-07 15:50:49 -07:00
Seth Fowler
d6de2d01f5
Bug 1185799 (Part 2) - Make nsBMPDecoder and nsPNGDecoder no longer friends with nsICODecoder. r=edwin
2016-07-07 15:50:46 -07:00
Seth Fowler
6361b2adb8
Bug 1185799 (Part 1) - Use DecoderFactory to construct nsICODecoder's contained decoder. r=edwin
2016-07-07 15:50:44 -07:00
Seth Fowler
b06ccacbf4
Bug 1284032 - Fix an assertion in SourceBuffer::Compact() when we have non-zero capacity but zero length. r=edwin
2016-07-07 15:50:42 -07:00
Benjamin Smedberg
bf05496a83
Bug 1282866 - remove widget/qt and other supporting QT code, r=dougt. This patch does not remove all of the checks for MOZ_WIDGET_QT (which are dead code), but that will be a followup mentored bug.
...
MozReview-Commit-ID: EGqHHhCD7vD
--HG--
extra : rebase_source : a4b9593959dd3ba80189db47eabb056ea207490f
extra : amend_source : a744d833693f0fe7adbea961c00bb5fb55a91580
2016-07-07 12:14:25 -04:00
Kevin Chen
f90480e301
Bug 1264809 - (Part 2) Preserve scale ratio if SVG dosen't have viewport size and viewBox. r=dholbert
2016-07-01 02:27:00 +02:00
Seth Fowler
8220b27059
Bug 1282354 - Move code for SurfaceCache placeholder insertion from RasterImage to DecoderFactory. r=dholbert
2016-07-02 18:47:49 -06:00
Seth Fowler
d7bb652cf1
Bug 1283967 - Remove unused function SurfaceCache::RemoveEntry(). r=dholbert
2016-07-02 18:47:47 -06:00
Seth Fowler
86430c09c8
Bug 1282327 (Part 2) - Update SurfaceCache documentation and method names to reflect the fact that cache entries are now ISurfaceProviders. r=dholbert
2016-07-02 18:47:45 -06:00
Seth Fowler
f9272b3af2
Bug 1282327 (Part 1) - Store ISurfaceProviders in the ImageLib SurfaceCache. r=dholbert
2016-07-02 18:47:44 -06:00
Seth Fowler
471a49b72c
Bug 1277979
(Followup) - Unfortunately still more fuzz is needed for downscale-during-decode GTests on OS X 10.10. r=me
2016-07-01 23:15:48 -06:00
Seth Fowler
c40d87a382
Bug 1283359 - Use StreamingLexer in the JPEG decoder. r=edwin
2016-07-01 20:50:00 -06:00
Mason Chang
02f263e5b9
Bug 1282496 - memset unoptimized images with RGBX surface format to 0xFF. r=seth
2016-06-30 18:59:29 -07:00
Daniel Holbert
3996555d1a
Bug 1282670, part 3: Make several imagelib .cpp files #inclue their corresponding .h file as their very first #include, per Gecko convention. r=seth
...
(In some cases, I've left "ImageLogging.h" being included before the corresponding .h file, because I ran across a warning comment saying that it needs to be included before any IPDL-generated files & anything that includes prlog.h; and it seems possible that Foo.cpp's corresponding Foo.h file could include such headers now or in the future.)
MozReview-Commit-ID: HPvUVj8YuKc
2016-06-30 10:27:03 -07:00
Daniel Holbert
17deb8bb7c
Bug 1282670, part 2: Remove unnecessary/redundant string-related #include & "using" declarations in imagelib. r=seth
...
MozReview-Commit-ID: 1hgnUosiOFU
2016-06-30 10:25:35 -07:00
Daniel Holbert
c1e322c6c5
Bug 1282670, part 1: Add missing #include & "using" declarations in imagelib. r=seth
...
I found these issues locally by moving all of imagelib's .cpp files to SOURCES instead of UNIFIED_SOURCES. (That change isn't part of this patch, though.)
MozReview-Commit-ID: 97Xpfu8eFE6
2016-06-30 10:24:27 -07:00
Seth Fowler
43c4cb86a4
Revert "Bug 1282327 - Store ISurfaceProviders in the ImageLib SurfaceCache. r=dholbert"; it was accidentally pushed.
...
This reverts commit 57147126cc04361268e606ac9e94c65e2bd4c886.
2016-06-29 18:36:34 -07:00
Seth Fowler
f6528fc852
Bug 1282352 - Make DecoderFactory use NotNull where possible. r=edwin
2016-06-29 18:33:22 -07:00
Seth Fowler
d35c501ce3
Bug 1282327 - Store ISurfaceProviders in the ImageLib SurfaceCache. r=dholbert
2016-06-29 18:33:20 -07:00
Seth Fowler
287efbde21
Bug 1282275 - Return IDecodingTask objects instead of Decoder objects from most DecoderFactory functions. r=dholbert
2016-06-29 18:33:18 -07:00
Seth Fowler
9b38306626
Bug 1282273 - Replace the Runnable used for registering DecodePool threads with the Nuwa process with a lambda. r=edwin
2016-06-29 18:33:15 -07:00
Seth Fowler
41627d474f
Bug 1282259 - Run IDecodingTasks instead of Decoders directly in image::DecodePool. r=dholbert
2016-06-29 13:46:27 -07:00
Seth Fowler
a54d2d7a22
Bug 1282566 (Part 3) - Use StreamingLexer in the PNG decoder. r=edwin
2016-06-29 12:12:36 -07:00
Seth Fowler
e75a45eb03
Bug 1282566 (Part 2) - Remove some unused fields from nsPNGDecoder. r=edwin
2016-06-29 12:12:34 -07:00
Seth Fowler
a0645af1a6
Bug 1282566 (Part 1) - Use png_process_data_pause for early exits in nsPNGDecoder. r=edwin
2016-06-29 12:12:32 -07:00
Seth Fowler
4d8829da21
Bug 935888 - Set FLAG_IS_ANIMATED progress bit for VectorImages when appropriate. r=dholbert
2016-06-29 12:00:18 -07:00
Aidin Gharibnavaz
523608513b
Bug 1247972 - specialize NS_ProxyRelease for nsISupports to be out-of-line; r=erahm
...
NS_ProxyRelease's current implementation requires a lot of code. We can
reduce the impact of this by providing an out-of-line implementation for
classes based on nsISupports. This change reduces codesize by ~60K on
a Linux x86-64 build.
2016-06-29 18:56:41 -04:00
Phil Ringnalda
10f146a52a
Back out 269a48e67579 (bug 1282496) for Windows gfx crashes and assertion failures
...
CLOSED TREE
2016-06-27 19:13:12 -07:00
Mason Chang
dbf96fa749
Bug 1282496 - memset unoptimized images with RGBX surface format to 0xFF when using the skia backend. r=seth
2016-06-27 17:45:55 -07:00
Seth Fowler
1dd3328bab
Bug 1256981 - Make ShutdownTracker observe xpcom-will-shutdown instead of xpcom-shutdown. r=dholbert
2016-06-26 13:30:37 -07:00
Seth Fowler
5bb4252ff6
Bug 1281680 - Add telemetry for image optimizations that may no longer be useful. r=edwin
2016-06-25 15:41:16 -07:00
Seth Fowler
c92db2d7ab
Bug 1255107 (Followup) - Add an explicit cast to a usage of DebugOnly to work around MSVC. r=me
2016-06-25 14:36:47 -07:00
Seth Fowler
17074a1b49
Bug 1255107 (Part 3) - Use SurfacePipe in the PNG decoder. r=njn
2016-06-25 14:04:05 -07:00
Seth Fowler
7ecbb3a6bf
Bug 1255107 (Part 2) - Add a SurfaceFilter for bilinear interpolation for ADAM7 interlaced images. f=glennrp,r=njn
2016-06-25 14:04:03 -07:00
Seth Fowler
e9ae1e161e
Bug 1255107 (Part 1) - Add a RowHasPixels() utility function to allow tests to compare rows to an arbitrary sequence of BGRAColor values. r=njn
2016-06-25 14:04:01 -07:00
Seth Fowler
f3f1ed4efa
Bug 1262549 - Refuse to allocate huge deinterlacing buffers. r=edwin
2016-06-23 18:59:58 -07:00
Lee Salzman
1a695a53a7
Bug 1281419 - ignore negative icon size in URI. r=seth
2016-06-23 10:47:36 -04:00
Seth Fowler
020ad7a755
Bug 1279117 - Add SurfacePipe::WritePixelsToRow(). r=njn
2016-06-23 01:42:07 -07:00
Seth Fowler
a2712d4b0e
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-22 16:32:40 -07:00
Carsten "Tomcat" Book
c46c20b362
Backed out changeset 7b03f23fdde5 (bug 1255632) for bustage on a CLOSED TREE
2016-06-22 08:48:25 +02:00
Seth Fowler
358b410aaa
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-21 22:15:27 -07:00
Seth Fowler
172d673bcc
Bug 1277979
- Add even more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10. r=me DONTBUILD
2016-06-21 21:33:56 -07:00
Seth Fowler
3983e48e1d
Bug 1280712 - Remove redundant memset() of GIF frame data. r=edwin
2016-06-21 20:19:19 -07:00
Seth Fowler
82666db699
Bug 1249578 (Part 2) - Add a test that decoding ICOs with a size mismatch between the BIH header and the ICO directory entry fails. r=njn
2016-06-21 19:48:33 -07:00
Seth Fowler
1d5c203221
Bug 1249578 (Part 1) - Verify that the size in the BIH header matches the ICO directory entry instead of fixing it. r=njn
2016-06-21 19:48:31 -07:00
Wes Kocher
7e180fa924
Backed out 2 changesets (bug 1249578) for build bustage
...
Backed out changeset caddb604d934 (bug 1249578)
Backed out changeset a2a645bf7ccf (bug 1249578)
2016-06-21 18:38:46 -07:00
Seth Fowler
20dbc568f3
Bug 1249578 (Part 2) - Add a test that decoding ICOs with a size mismatch between the BIH header and the ICO directory entry fails. r=njn
2016-06-21 18:06:30 -07:00
Seth Fowler
79d8677d76
Bug 1249578 (Part 1) - Verify that the size in the BIH header matches the ICO directory entry instead of fixing it. r=njn
2016-06-21 18:06:28 -07:00
Christoph Kerschbaumer
19ac7d31c1
Bug 1274170 - Remove unnecessary includes of nsCorsListenerProxy. r=jkingston
...
--HG--
extra : rebase_source : 488864e497a7e6c127a98e05efd17d1d0580e000
2016-06-21 12:54:03 +02:00
Seth Fowler
bc967b6b86
Bug 1279859 - Correctly skip over extra image sub blocks in the GIF decoder. r=njn
2016-06-20 21:09:29 -07:00
Julian Seward
5b033cd6c7
Bug 1278927 - TSan: data race image/imgFrame.cpp on hasCheckedOptimize. r=seth.
2016-06-20 15:46:00 +02:00
Seth Fowler
72f2253f92
Bug 1279617 - When SurfacePipe::WritePixels() finishes early, zero out the rest of the surface. r=njn
2016-06-17 15:05:00 -07:00
Seth Fowler
bf26782297
Bug 1279611 - Document and test the fact that SurfacePipe::WriteEmptyRow() overwrites the entire row. r=njn
2016-06-17 15:05:00 -07:00
Thomas Nguyen
4b7ad0e2c5
Bug 1223838 - Fix wrong policy associated with empty string. r=fkiefer,hsivonen
...
MozReview-Commit-ID: 7kFH39cegmH
2016-05-30 15:17:45 +08:00
Mason Chang
b912ea2340
Bug 1279064 - Skia reftest fuzzing for skia content on windows. r=lsalzman
2016-06-08 10:51:27 -07:00
Jonathan Hao
a1a0a9bd7d
Bug 1280006 - Backout "Bug 1270680 - Part 1: Double-key the image cache by origin attribute." r=tanvi
...
This reverts commit bb0482fe09fbfad9be89384ec5cb8b6518187379.
2016-06-14 12:43:21 +01:00
Jonathan Hao
e255200c24
Bug 1280006 - Backout "Bug 1270680 - Part 3 - Get origin attributes from loadInfo in LoadImageWithChannel()." r=tanvi
...
This reverts commit 8ef7edb6a790df9128558e6eb520701f4fc600a0.
2016-06-14 12:43:14 +01:00
Blake Kaplan
e6e116bff5
Bug 1274516 - Add a helper to iterate over all ContentParents and use it to clear the image cache in both the parent and child processes. r=billm r=seth
2016-06-10 16:00:22 -07:00
Ralph Giles
5f548c968f
Bug 1275744 - Reference MOZ_LOG in graphics comments. r=erahm
...
NSPR_LOG_MODULES is deprecated.
MozReview-Commit-ID: HZzskDYsTo9
--HG--
extra : rebase_source : 21d4c4a94d80ad962ef56fceb8d6fbabc017d2ea
2016-05-26 11:41:29 -07:00
Seth Fowler
112f55ea0c
Bug 1204392 - Use StreamingLexer in the GIF decoder. r=njn,seth
2016-06-08 12:17:17 -07:00
Nicholas Nethercote
a02611e830
Bug 1276824 (part 1) - Rename gfxContext::ForDrawTarget{,WithTransform}(). r=milan.
...
The new names Create{,PreservingTransform}OrNull() better communicate that
these functions (a) do object creation, and (b) are fallible.
--HG--
extra : rebase_source : a36bd9a2bcdfae281868959403f811f2bc690ad4
2016-06-07 09:39:56 +10:00
Jonathan Hao
61e05c234f
Bug 1270680 - Part 3 - Get origin attributes from loadInfo in LoadImageWithChannel(). r=tanvi
2016-06-02 20:50:00 +02:00
Jonathan Hao
b7c57a3da1
Bug 1270680 - Part 1: Double-key the image cache by origin attribute. r=jdm,seth
2016-06-01 23:07:00 +02:00
Nicholas Nethercote
56570415b3
Bug 1278157 - Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions. r=tnikkel.
...
--HG--
extra : rebase_source : 97b83ca4389d75920e878f3912e04f326bf84132
2016-06-02 06:43:41 +10:00
Seth Fowler
01cb7efe41
(No bug) - Remove unnecessary include in nsGIFDecoder2.cpp. r=me DONTBUILD
2016-06-04 15:28:27 -07:00
Seth Fowler
13254eb215
Bug 1277979
- Add more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10. r=me
2016-06-04 00:32:17 -07:00
Jonathan Watt
2eb705bb3f
Bug 1277862, part 3 - Rename Moz2D's Filter to SamplingFilter in the rest of the tree. r=Bas
2016-05-25 17:01:18 +01:00
Seth Fowler
2e1d5487fb
Bug 1276061
(Part 4) - Add GTests for WriteBuffer() and WriteEmptyRow(). r=njn
...
--HG--
extra : rebase_source : 32628df4518af1fad89c69fa7aa5a87e3c325dc4
2016-06-01 23:01:50 -07:00
Seth Fowler
dfd4e97c3d
Bug 1276061
(Part 3) - Add ImageLib GTest utility functions for checking paletted image output. r=njn
...
--HG--
extra : rebase_source : ee6f81899fa7f77b557bc13214d454cf33b122a2
2016-06-01 23:01:50 -07:00
Seth Fowler
b65d22bc5c
Bug 1276061
(Part 2) - Remove SurfaceFilter::WriteRows(). r=njn
...
--HG--
extra : rebase_source : f7d65f2cb1398c49f10a5b2849672661c74f1163
2016-06-01 23:01:50 -07:00
Seth Fowler
28eebc3a4a
Bug 1276061
(Part 1) - Add SurfaceFilter::WriteBuffer() and SurfaceFilter::WriteEmptyRow(). r=njn
...
--HG--
extra : rebase_source : bbb366a108c9cc79e250aee00dd61c31aca54108
2016-06-01 23:01:49 -07:00
Nicholas Nethercote
9ec20a644f
Bug 1277122 - Add missing null checks for pixman_image_create_bits(). r=seth,lsalzman.
...
--HG--
extra : rebase_source : dec917d2efd9a262bd06816dcbb541acd3892340
2016-06-01 14:27:30 +10:00
Seth Fowler
5c4d63539e
Bug 1276413 (Part 2) - Add tests for expected state when initializing a SurfaceSink. r=njn
2016-06-01 11:59:47 -07:00
Seth Fowler
cf4a581f11
Bug 1276413 (Part 1) - Clear paletted image frames when they're allocated. r=edwin
2016-06-01 11:59:47 -07:00
Chris Peterson
11ef78ae89
Bug 1275016 - Rename Endian.h to EndianUtils.h to avoid #include confusion with Android's endian.h stdlib header. r=froydnj
...
--HG--
rename : mfbt/Endian.h => mfbt/EndianUtils.h
2016-05-22 13:31:11 -07:00
Daniel Holbert
d33debd3c7
Bug 1261964 part 4: Bump fuzzy threshold for new reftest, to accommodate extra fuzziness on WinXP. DONTBUILD
...
MozReview-Commit-ID: 2RrNqbXU0hN
2016-05-27 16:34:16 -07:00
Daniel Holbert
0fbfe8b401
Bug 1261964 part 3: Bump fuzzy threshold for new reftest, to accommodate extra fuzziness on Win8.
...
MozReview-Commit-ID: 56zDzUoILme
2016-05-27 16:18:43 -07:00
Seth Fowler
be521de253
Bug 1207830 (Part 3) - Add a test that downscaling ICOs with AND mask transparency doesn't cause disaster. r=njn
...
--HG--
extra : rebase_source : aa8948270b33767eb38a16d8ecc0cb5e9b16d214
2016-05-27 12:59:19 -07:00
Seth Fowler
31a74a2ae6
Bug 1207830 (Part 2) - Add downscale-during-decode GTests for all image formats. r=njn
...
--HG--
extra : rebase_source : 115942a7d303ee0f9a3e57c5de045fc927a04e0e
2016-05-27 12:59:19 -07:00
Seth Fowler
db8c62a32b
Bug 1207830 (Part 1) - Make it possible to create an anonymous decoder that downscales. r=njn
...
--HG--
extra : rebase_source : 620e0380750c8b4fd8752b69320d450067ce385a
2016-05-27 12:59:19 -07:00
Daniel Holbert
53e62d6130
Bug 1261964 part 2: Add reftest for downscaling a moz-icon image. r=seth
...
MozReview-Commit-ID: 61m5k5mYSWN
2016-05-27 14:03:35 -07:00
Carsten "Tomcat" Book
52d84ab482
Backed out changeset 1bc7102718a9 (bug 1207830) for test failures in ImageDecoders.JPGDownscaleDuringDecode
2016-05-27 09:05:25 +02:00
Carsten "Tomcat" Book
1a05e03bf8
Backed out changeset acbbb2038fdd (bug 1207830)
2016-05-27 09:04:48 +02:00
Carsten "Tomcat" Book
2f5ff9300f
Backed out changeset f10f4b5ce594 (bug 1207830)
2016-05-27 09:04:46 +02:00
Seth Fowler
9b08bf373b
Bug 1207830 (Part 3) - Add a test that downscaling ICOs with AND mask transparency doesn't cause disaster. r=njn
2016-05-26 22:57:10 -07:00
Seth Fowler
4638631ed9
Bug 1207830 (Part 2) - Add downscale-during-decode GTests for all image formats. r=njn
2016-05-26 22:57:10 -07:00
Seth Fowler
7cac8ebbfd
Bug 1207830 (Part 1) - Make it possible to create an anonymous decoder that downscales. r=njn
2016-05-26 22:57:09 -07:00