This methods is then used in Netmonitor and Animation
panel, where we already had similar functions.
Differential Revision: https://phabricator.services.mozilla.com/D56167
--HG--
extra : moz-landing-system : lando
This revision removes false positives for absolutely-positioned elements using grid item properties. It doesn’t solve identifying an absolutely positioned element in a grid container since this issue would require more consideration when finding the element’s containing block to make it work. For now, inactive CSS will invalidate a grid item property if the element is not a grid item and is not absolutely positioned.
Differential Revision: https://phabricator.services.mozilla.com/D55400
--HG--
extra : moz-landing-system : lando
Accidentally missed to use the fallback value "closest-side closest-side" when needed. Fixed now.
Differential Revision: https://phabricator.services.mozilla.com/D55982
--HG--
extra : moz-landing-system : lando
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.
find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
if [ -n "$interfaces" ]; then
if [[ "$interfaces" == *$'\n'* ]]; then
regexp="\("
for i in $interfaces; do regexp="$regexp$i\|"; done
regexp="${regexp%%\\\|}\)"
else
regexp="$interfaces"
fi
interface=$(basename "$path")
rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
if [ $hits -eq 0 ]; then
echo "Removing ${interface} from ${path2}"
grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
mv -f "$path2".tmp "$path2"
fi
done
fi
done
Differential Revision: https://phabricator.services.mozilla.com/D55443
--HG--
extra : moz-landing-system : lando
Due to the caching mechanism we had, running tests more than
once would fail because the Fronts of the first run were released,
which means the actorID of the cached object was set to null.
We simply remove this cache mechanism as it doesn't appear to
be needed at all for the test to pass.
We also freeze the console once we have all the packets
we need, so there won't be any further communication with
the server.
Finally we add test-console-api.html to the support files so
we don't get a 404 anymore.
Differential Revision: https://phabricator.services.mozilla.com/D55938
--HG--
extra : moz-landing-system : lando
This method was directly using the main target console front
to evaluate something, which could cause issue in a fission
world.
The function is moved to the WebConsole class, and calls commands
evaluateJSAsync, in which we retrieve the appropriate front
given the given options object (e.g. if there's a selecteObjectActor,
we'll talk to the target that hold the actor).
Differential Revision: https://phabricator.services.mozilla.com/D55986
--HG--
extra : moz-landing-system : lando
This patch adds a new context for the performance-new components. It's
eventually the only place where the settings will live, but for now
the components share the settings between the popup, the devtools panel,
and the about:profiling page.
This page uses the base styling that the preferences page uses. The styles
should obey the theming for the browser, and ignore the devtools theming
colors.
Differential Revision: https://phabricator.services.mozilla.com/D55010
--HG--
extra : moz-landing-system : lando
This is probably the biggest change to the existing components, as it makes the
summary dropdowns conditional based on the page context. This keeps the old
workflow working, but allows for the new about:profiling page's design. Most
of the diff here is creating the new _renderSection method which consolidates
this logic, and also handles the summary div structure.
Differential Revision: https://phabricator.services.mozilla.com/D55009
--HG--
extra : moz-landing-system : lando
The new about:profiling page creates some more complexity around what
the page context is. It is simpler to handle the different cases with
a union, rather than booleans.
Differential Revision: https://phabricator.services.mozilla.com/D55008
--HG--
extra : moz-landing-system : lando
This commit is fairly trivial, but creates the about:profiler page to
start the new about:profiler work.
Differential Revision: https://phabricator.services.mozilla.com/D53729
--HG--
extra : moz-landing-system : lando
Overall, the new RDM is using dark theme styling as before. The only exception is the text in the actual toolbar React component, which seems to default to using light theme colors. This revision applies a CSS variable `theme-body-color` to the toolbar's document body to toggle between dark/light theme colors for text.
Differential Revision: https://phabricator.services.mozilla.com/D55706
--HG--
extra : moz-landing-system : lando
This patch adds a new context for the performance-new components. It's
eventually the only place where the settings will live, but for now
the components share the settings between the popup, the devtools panel,
and the about:profiling page.
This page uses the base styling that the preferences page uses. The styles
should obey the theming for the browser, and ignore the devtools theming
colors.
Differential Revision: https://phabricator.services.mozilla.com/D55010
--HG--
extra : moz-landing-system : lando
This is probably the biggest change to the existing components, as it makes the
summary dropdowns conditional based on the page context. This keeps the old
workflow working, but allows for the new about:profiling page's design. Most
of the diff here is creating the new _renderSection method which consolidates
this logic, and also handles the summary div structure.
Differential Revision: https://phabricator.services.mozilla.com/D55009
--HG--
extra : moz-landing-system : lando
The new about:profiling page creates some more complexity around what
the page context is. It is simpler to handle the different cases with
a union, rather than booleans.
Differential Revision: https://phabricator.services.mozilla.com/D55008
--HG--
extra : moz-landing-system : lando
This commit is fairly trivial, but creates the about:profiler page to
start the new about:profiler work.
Differential Revision: https://phabricator.services.mozilla.com/D53729
--HG--
extra : moz-landing-system : lando
It looks like we left out some places in the inspector when we made it fission-compatible.
The color-picker, in particular, needs access to the selected node's computed style for its
color contrast logic.
We used to access this on the top-level target PageStyleFront. We just need to change this so
it uses the one contextual to the selected node.
Differential Revision: https://phabricator.services.mozilla.com/D55962
--HG--
extra : moz-landing-system : lando
Mellina Y.
Daniel Varga
Brian Hackett
Nicolas Chevobbe
Micah Tigley
Daisuke Akatsuka
Sebastian Hengst
Razvan Caliman
Gabriele Svelto
Julian Descottes
Jason Laster
Harald Kirschner
Michael Ratcliffe
Greg Tatum
Yura Zenevich
Noemi Erli
Patrick Brosset
Logan Smyth
Jonathan Kew
Ciure Andrei
Coroiu Cristina
Neil Deakin