Граф коммитов

202 Коммитов

Автор SHA1 Сообщение Дата
Haik Aftandilian 10a487cd99 Bug 1614983 - Create a new sandbox profile for the socket process r=spohl
Add, but don't enable, a sandbox policy to be used with the socket process.
A follow-up fix (bug 1611288) will change the socket process code to use the
sandbox. The macOS socket sandbox is similar to the utility sandbox (only
used for the RDD process), with additions to allow networking I/O, access to
files for DNS resolution, access to certificate stores, and notifications about
network configuration changes.

Differential Revision: https://phabricator.services.mozilla.com/D64682

--HG--
extra : moz-landing-system : lando
2020-03-11 22:20:13 +00:00
Haik Aftandilian cda6189054 Bug 1599809 - Parenthesis bug in Mac content sandbox policy for com.apple.universalaccess.plist r=handyman
Move closing pathenthesis to the correct line.

Differential Revision: https://phabricator.services.mozilla.com/D54979

--HG--
extra : moz-landing-system : lando
2019-11-27 17:53:25 +00:00
Haik Aftandilian 43ab4ea7a3 Bug 1587962 - [10.15] "Use keyboard navigation" and "jump to spot" scrolling preferences do not work r=spohl
Update sandbox rules to allow services and files needed for global UI system preferences.

Update tests now that stat() calls on the filesystem are permitted.

Differential Revision: https://phabricator.services.mozilla.com/D50298

--HG--
extra : moz-landing-system : lando
2019-10-23 19:56:56 +00:00
Haik Aftandilian c0f7925547 Bug 1578907 - MacOS 10.15 Beta - Flash File Picker broken r=spohl
Allow access to extra services needed to open file pickers from the Flash process on 10.15.

Differential Revision: https://phabricator.services.mozilla.com/D48145

--HG--
extra : moz-landing-system : lando
2019-10-04 15:38:07 +00:00
Haik Aftandilian ecc3193420 Bug 1564434 - MT_safe_localtime generates incorrect value in sandboxed content process r=handyman
Allow access to timezone data files from the content/flash/GMP/utility sandbox.

Remove unneeded regex providing access to ^/private/tmp/KSInstallAction\. files.

Differential Revision: https://phabricator.services.mozilla.com/D41455

--HG--
extra : moz-landing-system : lando
2019-08-12 21:36:03 +00:00
Haik Aftandilian a19efece81 Bug 1566540 - [10.15] Crash in [@ CrashReporter::TerminateHandler] r=spohl
To avoid crashing in macOS 10.15, allow access to the proc_info PROC_INFO_CALL_SETCONTROL syscall variant in the GMP and RDD sandboxes.

Differential Revision: https://phabricator.services.mozilla.com/D39079

--HG--
extra : moz-landing-system : lando
2019-07-24 14:48:41 +00:00
Paul Adenot 6d321304a4 Bug 1565575 - Allow access to AudioComponentRegistrar when doing audio remoting on OSX to be able to use system decoders. r=haik
When audio remoting is enabled, we can remove most of the sandbox exceptions,
except one, that allows using system calls to do decoding of audio and video
using system decoders (h264 and aac). Not doing that results in most mp4 files
to be unplayable, erroring out when doing calls like this:

https://searchfox.org/mozilla-central/rev/da855d65d1fbdd714190cab2c46130f7422f3699/dom/media/platforms/apple/AppleATDecoder.cpp:336
https://searchfox.org/mozilla-central/rev/da855d65d1fbdd714190cab2c46130f7422f3699/dom/media/platforms/apple/AppleATDecoder.cpp:545

We'll be able to remove it again when we'll use the RDD for everything, but in
the meantime, this exception is needed.

Differential Revision: https://phabricator.services.mozilla.com/D38465

--HG--
extra : moz-landing-system : lando
2019-07-22 08:22:40 +00:00
Haik Aftandilian 7105b782dc Bug 1556846 - [10.15] Crash in [@ mozilla::plugins::PluginUtilsOSX::SetProcessName] r=spohl
Allow limited access to the proc_pidinfo() syscall from the Mac utility process sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D37533

--HG--
extra : moz-landing-system : lando
2019-07-10 15:00:05 +00:00
Haik Aftandilian a218f608fc Bug 1558924 - [10.15] Widevine crashes on macOS Catalina Beta r=handyman
Allow limited access to the proc_pidinfo() syscall from the GMP sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D36810

--HG--
extra : moz-landing-system : lando
2019-07-03 18:17:55 +00:00
Haik Aftandilian d302444d67 Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier.

Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted.

Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start.

Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false.

Differential Revision: https://phabricator.services.mozilla.com/D34085

--HG--
extra : moz-landing-system : lando
2019-06-14 22:55:27 +00:00
Dorel Luca fb616d00a6 Backed out 2 changesets (bug 1498742) for OSX build bustages. CLOSED TREE
Backed out changeset f6da94d90350 (bug 1498742)
Backed out changeset 4f3e83d8de59 (bug 1498742)
2019-06-15 00:13:05 +03:00
Haik Aftandilian c0874f2dba Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier.

Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted.

Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start.

Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false.

Differential Revision: https://phabricator.services.mozilla.com/D34085

--HG--
extra : moz-landing-system : lando
2019-06-14 20:12:01 +00:00
Bogdan Tara d62176d3d7 Backed out 2 changesets (bug 1498742) for nsMacUtilsImpl.cpp related build bustage a=backout
Backed out changeset 6729dc168afd (bug 1498742)
Backed out changeset e5eed57a9111 (bug 1498742)
2019-06-14 12:50:04 +03:00
Haik Aftandilian f87e72036e Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier.

Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted.

Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start.

Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false.

Differential Revision: https://phabricator.services.mozilla.com/D34085

--HG--
extra : moz-landing-system : lando
2019-06-13 06:32:37 +00:00
Andreea Pavel 307e3f181b Backed out 2 changesets (bug 1498742) for build bustages at GMPProcessParent.cpp on a CLOSED TREE
Backed out changeset 5f9d32e26c71 (bug 1498742)
Backed out changeset ffc8d151cf3a (bug 1498742)
2019-06-13 04:38:56 +03:00
Haik Aftandilian 0f858863b6 Bug 1498742 - Part 2 - Start the GMP sandbox earlier during process startup r=jya,cpearce
Change the Mac GMP process launch to include sandboxing params on the command line to allow the sandbox to be started earlier during GMP process launch. Content, extension, and RDD processes have already been changed to start the sandbox earlier.

Update GMPProcessParent to override GeckoChildProcessHost methods used to construct sandboxing parameters. Pass the plugin path as a sandbox parameter so that the sandbox rules can whitelist the plugin directory which is now read after the sandbox is enabled in the plugin process. On development builds, pass "testingReadPath" params so directories needed during automated tests can be whitelisted.

Update Mac sandboxing code to detect GMP sandbox params on the command line and enable the sandbox with additional arguments needed for early sandbox start.

Allow reverting to the old implementation by setting security.sandbox.gmp.mac.earlyinit to false.

Differential Revision: https://phabricator.services.mozilla.com/D34085

--HG--
extra : moz-landing-system : lando
2019-06-12 23:41:53 +00:00
Haik Aftandilian 45bb7b8823 Bug 1546544 - Enable TCSM r=asuth,spohl,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D29046

--HG--
extra : moz-landing-system : lando
2019-05-07 22:16:14 +00:00
arthur.iakab 62df572c1c Backed out 2 changesets (bug 1546544) for causing mochitest-chrome test failures on automation.py CLOSED TREE
Backed out changeset d4b67960c0f9 (bug 1546544)
Backed out changeset fda45db5f8e9 (bug 1546544)
2019-05-07 05:38:37 +03:00
Haik Aftandilian cd1c25bb79 Bug 1546544 - Enable TCSM r=asuth,spohl,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D29046

--HG--
extra : moz-landing-system : lando
2019-05-06 06:09:10 +00:00
Haik Aftandilian b59a99943d Bug 1548406 - Part 2 - Conditionally include WindowServer access in the GMP sandbox r=handyman
Conditionally include WindowServer access in the GMP sandbox so that it is only allowed for the Widevine CDM plugin, and not OpenH264.

Differential Revision: https://phabricator.services.mozilla.com/D29586

--HG--
extra : moz-landing-system : lando
2019-05-02 07:04:58 +00:00
Haik Aftandilian 58067ff840 Bug 1548406 - Part 1 - Simplify MacSandboxInfo and sandbox type enums r=handyman
Replace the MacSandboxType_Plugin sandbox type with MacSandboxType_Flash and MacSandboxType_GMP so that there is a 1:1 association between MacSandboxType values and sandbox policies.

Remove the MacSandboxPluginType enum. Instead of having different MacSandboxPluginTypes, we will just have MacSandboxType_GMP. We only use GMP for two plugin types, Widevine and OpenH264, and they only differ in that Widevine requires accss to the WindowServer.

Remove the MacSandboxPluginInfo struct and move the two needed fields pluginPath and pluginBinaryPath to MacSandboxInfo.

Differential Revision: https://phabricator.services.mozilla.com/D29585

--HG--
extra : moz-landing-system : lando
2019-05-02 07:04:44 +00:00
Sylvestre Ledru e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Haik Aftandilian 59576e83d0 Bug 1546836 - Video Playback and Form Rendering Issues on macOS Version 10.14.5 Beta r=jmathies
Allow access to Apple's Metal shader language compiler in our content process sandbox. Limit the sandbox policy change to 10.14 and newer OS versions to reduce risk given that problems have only been reported on 10.14.5.

Differential Revision: https://phabricator.services.mozilla.com/D28904

--HG--
extra : moz-landing-system : lando
2019-04-26 16:28:06 +00:00
Haik Aftandilian 2abd1f81a6 Bug 1541230 - Part 2 - Add /System/Library read access to the utility sandbox r=Alex_Gaynor
Allow read access to /System/Library for accessing system libraries.

Depends on D26397

Differential Revision: https://phabricator.services.mozilla.com/D26626

--HG--
extra : moz-landing-system : lando
2019-04-09 12:51:18 +00:00
Sylvestre Ledru 03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu 24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru 399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Haik Aftandilian f357396a1e Bug 1541272 - Mac Utility sandbox profile missing crash reporter port allow rule r=Alex_Gaynor
Add the crash reporter port to the utility process sandbox so that crash reports can be saved for processes using the utility sandbox with early sandbox init.

At this time, the RDD process is the only process using the utility sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D26228

--HG--
extra : moz-landing-system : lando
2019-04-04 19:59:25 +00:00
Haik Aftandilian f7082591a7 Bug 1540892 - [Mac] Don't #include policy definition headers in mac/Sandbox.h r=Alex_Gaynor
Move sandbox policy includes to Sandbox.mm.

Differential Revision: https://phabricator.services.mozilla.com/D25691

--HG--
extra : moz-landing-system : lando
2019-04-02 12:59:46 +00:00
Haik Aftandilian a8b3df5de0 Bug 1525086 - Part 6 - Use AssertMacSandboxEnabled() for the RDD process, change the assert to use sandbox_check() r=Alex_Gaynor
When the RDD process sandbox is started at launch, assert the sandbox has been enabled in the Init message.

Change AssertMacSandboxEnabled() to use the undocumented sandbox_check() function instead of sandbox_init().

Differential Revision: https://phabricator.services.mozilla.com/D22414

--HG--
extra : moz-landing-system : lando
2019-03-27 20:29:08 +00:00
Haik Aftandilian ae8b138790 Bug 1525086 - Part 3a - Move sandbox param logic to GeckoChildProcessHost and MacSandboxInfo to be more reusable r=Alex_Gaynor
Move sandbox early start logic to GeckoChildProcessHost.

Move sandbox CLI param logic into MacSandboxInfo.

Differential Revision: https://phabricator.services.mozilla.com/D22409

--HG--
extra : moz-landing-system : lando
2019-03-28 02:25:52 +00:00
Haik Aftandilian a6d4dd5d34 Bug 1525086 - Part 2 - Remove unneeded params and permissions from the utility sandbox r=Alex_Gaynor
Remove the unused plugin binary path and app binary path parameters and cleanup file path permissions.

Explicitly allow access to launchservicesd to allow SetProcessName() to work when the sandbox is started during startup.

Differential Revision: https://phabricator.services.mozilla.com/D22408

--HG--
extra : moz-landing-system : lando
2019-03-27 20:27:32 +00:00
Haik Aftandilian 40e8968bd5 Bug 1525086 - Part 1 - Split up sandbox policies, create utility policy for the RDD process r=Alex_Gaynor
Move sandbox policies for different process types into their own files.

Create a new "utility" policy cloned from the GMP policy to be used for basic utility-type processes.

Use the utility policy for the RDD process.

Differential Revision: https://phabricator.services.mozilla.com/D22405

--HG--
extra : moz-landing-system : lando
2019-03-27 20:27:09 +00:00
Haik Aftandilian 9b822034f6 Bug 1525625 - [Mac] Flash plugin can not save settings r=Alex_Gaynor
Allow file-write-unlink in ~/Library/Preferences/Macromedia/Flash Player to allow changes made in the Flash Global Settings panel to persist.

Differential Revision: https://phabricator.services.mozilla.com/D19217

--HG--
extra : moz-landing-system : lando
2019-02-08 20:42:10 +00:00
Haik Aftandilian a5c9d467ea Bug 1506495 - Whitelist /Library and ~/Library ColorSync Profile directories r=Alex_Gaynor
Whitelist the /Library and ~/Library ColorSync profile directories allowing gfx.color_management.display_profile to be used to load color profiles from those locations.

Differential Revision: https://phabricator.services.mozilla.com/D18390

--HG--
extra : moz-landing-system : lando
2019-02-01 22:09:24 +00:00
Haik Aftandilian 10146305a7 Bug 1520764 - Disable logging for iokit-get-properties and other extra deny types in sandbox profiles r=Alex_Gaynor
Add "(with no-log)" to the iokit-get-properties and other extra deny types in the content and GMP sandbox profiles.

Differential Revision: https://phabricator.services.mozilla.com/D17285

--HG--
extra : moz-landing-system : lando
2019-01-23 14:06:51 +00:00
Gurzau Raul 136dc5e8bc Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-23 02:05:32 +02:00
Sylvestre Ledru 0b4021fcad Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D17139

--HG--
extra : histedit_source : 084f340503d2e1a2d9e1753c38b2c4ee9c7819f3
2019-01-21 18:18:16 +01:00
Haik Aftandilian f6ee38ea4d Bug 1521167 [Mac] Sandbox violation logging is always enabled with early startup r=Alex_Gaynor
For sandbox early startup, ensure violation logging is only enabled when the parent passes the -sbLogging flag.

Differential Revision: https://phabricator.services.mozilla.com/D17013

--HG--
extra : moz-landing-system : lando
2019-01-22 14:00:27 +00:00
Haik Aftandilian 179fb3b0a4 Bug 1508277 - Crash in mozilla::gl::SurfaceFactory_IOSurface::CreateShared r=Alex_Gaynor
Allow access to device-id and vendor-id IOKit properties needed for AppleIntelHD3000GraphicsGLDriver.

Fixes a crash in the AppleIntelHD3000GraphicsGLDriver userland driver which is used in some 2011-era Macs.

Differential Revision: https://phabricator.services.mozilla.com/D15528

--HG--
extra : moz-landing-system : lando
2018-12-31 17:23:35 +00:00
Sylvestre Ledru 265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Haik Aftandilian b890a6606e Bug 1506776 - 17.78% Base Content Resident Unique Memory regression r=Alex_Gaynor
Until more analysis is done, add back access to com.apple.CoreServices.coreservicesd to avoid extra allocations that are triggered when the service is blocked.

Differential Revision: https://phabricator.services.mozilla.com/D12479

--HG--
extra : moz-landing-system : lando
2018-11-20 22:06:06 +00:00
Alex Gaynor bef9ade569 Bug 1428361 - remove some 'on by default' permissions from the macOS plugin sandbox; r=haik
Differential Revision: https://phabricator.services.mozilla.com/D11892

--HG--
extra : moz-landing-system : lando
2018-11-14 16:46:05 +00:00
Haik Aftandilian b1a4ba8dff Bug 1505445 - [Mac] With sandbox early startup, start the sandbox after the port exchange r=Alex_Gaynor
Don't start the sandbox until after the port exchange so the parent process does not have to wait longer in ContentParent::LaunchSubprocess() for the (expensive) sandbox_init_with_parameters call to complete in the child. Remove the policy rule allowing access to the parent port now that it is already open when the sandbox is initialized and therefore not needed.

Differential Revision: https://phabricator.services.mozilla.com/D11186

--HG--
extra : moz-landing-system : lando
2018-11-08 21:04:19 +00:00
Haik Aftandilian 2ca07b2f4a Bug 1502228 - [Mac] With sandbox early startup enabled, some form elements are not rendered r=Alex_Gaynor
Add the /private/var directory to the list of file-read-metadata paths to avoid rendering issues on macOS 10.14 when sandbox early startup is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D9933

--HG--
extra : moz-landing-system : lando
2018-10-26 18:51:37 +00:00
Haik Aftandilian 49e56fe77b Bug 1431441 - Part 5 - Parameterize access to the windowserver in the Mac content sandbox policy r=Alex_Gaynor
Only allow access to "com.apple.windowserver.active" when the pref
"security.sandbox.content.mac.disconnect-windowserver" is set to true.

Depends on D6721

Differential Revision: https://phabricator.services.mozilla.com/D7357

--HG--
extra : moz-landing-system : lando
2018-10-18 20:49:51 +00:00
Haik Aftandilian cf8dfa28d7 Bug 1431441 - Part 4 - ASSERT the sandbox is already enabled r=Alex_Gaynor
When early initialization of the sandbox is enabled, assert that the sandbox has already been enabled in ContentProcess::Init().

Depends on D6720

Differential Revision: https://phabricator.services.mozilla.com/D6721

--HG--
extra : moz-landing-system : lando
2018-10-18 20:47:43 +00:00
Haik Aftandilian 81b56d13a8 Bug 1431441 - Part 3 - Start the Mac content sandbox earlier r=Alex_Gaynor
Pass sandbox parameters to content processes on the command line allowing for early sandbox startup.

Pref'd off behind "security.sandbox.content.mac.earlyinit" until it's ready to be enabled by default.

Once early startup is enabled by default and considered stable, the original sandbox startup code can be removed.

Depends on D6719

Differential Revision: https://phabricator.services.mozilla.com/D6720

--HG--
extra : moz-landing-system : lando
2018-10-19 18:23:16 +00:00