Depends on D40995
I get a 10% failure rate on try for those two tests, but I haven't managed to get
a single failure locally so I couldn't identify the root cause yet. I would like
to fix them in a follow up.
Differential Revision: https://phabricator.services.mozilla.com/D40997
--HG--
extra : moz-landing-system : lando
Depends on D40994
Switching hosts (especially going from docked to window) seems more async than before.
I would like to work on fixing those in a follow up.
Differential Revision: https://phabricator.services.mozilla.com/D40995
--HG--
extra : moz-landing-system : lando
Depends on D40993
I don't fully understand the failures in this test on Linux.
The only way I could get it to pass for now was to force a window focus when the test runs in a window host.
Other OSes are fine, but without this, Linux is permafailing this.
I don't have a good linux env right now, so I would like to proceed with this and
fix it in a follow up.
Differential Revision: https://phabricator.services.mozilla.com/D40994
--HG--
extra : moz-landing-system : lando
Depends on D40992
In general, using `click()` seems less reliable when using a frame with type=content. I am not entirely sure why since the context menu is supposed to be created in the top window anyway
Differential Revision: https://phabricator.services.mozilla.com/D40993
--HG--
extra : moz-landing-system : lando
Depends on D40991
This test had some suspicious calls to async methods without await. Properly waiting on them avoids frequent intermittents when running in a content frame.
Differential Revision: https://phabricator.services.mozilla.com/D40992
--HG--
extra : moz-landing-system : lando
Depends on D40989
I though I fixed this a few months ago, but there are still timing issues with the current test when using a frame with type=content.
Differential Revision: https://phabricator.services.mozilla.com/D40990
--HG--
extra : moz-landing-system : lando
Depends on D40988
This is not explicitly needed in this queue but I noticed this issue
while working on eyedropper test issues.
The top window might change when switching from docked to window hosts
so we should rather attach shortcut events to the regular window.
Differential Revision: https://phabricator.services.mozilla.com/D40989
--HG--
extra : moz-landing-system : lando
This introduces a preference to load the DevTools toolbox
in a frame with type=content instead of type=chrome.
Having a preference will allow to keep the previous behavior in a
few intermittent tests, while we collect feedback on Nightly.
Differential Revision: https://phabricator.services.mozilla.com/D40988
--HG--
extra : moz-landing-system : lando
When the console parent actor is a ContentProcessTargetActor, we don't have
a reference to a `nsIDOMWindow`, but only to a Sandbox.
The code in `hasNativeConsoleAPI` would then silently fail when trying to
access `window.wrappedJSObject`, and keep `isNative` as `false`.
For now, we work around this by always returning true if we don't have
access to a `nsIDOMWindow`.
Differential Revision: https://phabricator.services.mozilla.com/D42506
--HG--
extra : moz-landing-system : lando
Sadly the badge title wasn't localized at all, so we add a new
l10n string and use it in the component.
Differential Revision: https://phabricator.services.mozilla.com/D42517
--HG--
extra : moz-landing-system : lando
* Add a new extensionStorage actor to enable inspection of data stored by an extension using the WebExtension storage.local API in the Storage panel client.
* The actor is only listed when the developer toolbox is targeting an extension process. For multi-process Firefox (e10s), this applies to only the toolbox accessed in about:debugging.
* The actor is gated behind a preference: devtools.storage.extensionStorage.enabled. This preference is set to false by default.
* The Storage panel displays storage item values as strings. If a storage item value is not JSON-stringifiable, it will be displayed in the table as "Object".
* It should be noted that extension storage.local’s storage backend is in the process of migrating from a JSON file to IndexedDB as of Firefox 66 for performance reasons. This actor only works for extensions that have migrated to the IndexedDB storage backend.
* In-line comments referencing Bugs 1542038 and 1542039 indicate places where the implementation may differ for local storage versus the other storage areas in the actor.
Differential Revision: https://phabricator.services.mozilla.com/D34415
--HG--
extra : moz-landing-system : lando
The `MockSecurityInfo` instances in the patched devtools tests are not actually
being used as `nsITransportSecurityInfo` instances; while `QueryInterface`
methods were generated for the them, these were never called. Additionally, the
methods they are being passed to are not XPCOM-defined and therefore do not
strictly require `nsITransportSecurityInfo`.
In addition `NetworkHelper#parseSecurityInfo` now requires its `securityInfo`
to be `QueryInterface`d to a `nsITransportSecurityInfo` before calling the
function (except in the case of `MockSecurityInfo`, which is structurally
similar).
Differential Revision: https://phabricator.services.mozilla.com/D40521
--HG--
extra : moz-landing-system : lando
The DataProvider is what allows us to use the Netmonitor
components. The way it was created before was non optimal,
as it were inside an enhancer, and was then attached to
a proxy.
As we may now have multiple proxies, this could cause
some issue.
So we take this as an opportunity to create the DataProvider
in the WebConsoleWrapper (where live the actions we need for
the provider), and remove the now unused function on the
WebConsoleConnectionProxy.
Differential Revision: https://phabricator.services.mozilla.com/D41354
--HG--
extra : moz-landing-system : lando
Since we're having a setTimeout in which we call
the Promise resolve function with a local variable
for a script we're paused in, it might occur that
when resuming, the setTimeout delay would be big
enough for the local variable to not be available
anymore.
So here, we compute the results directly in the
Promise callback body so we're sure the local
variable still exists.
Differential Revision: https://phabricator.services.mozilla.com/D42320
--HG--
extra : moz-landing-system : lando