Otherwise, the parent style context doesn't have some inherited structs in the
cache, so it avoids comparing them entirely.
For example, the following example:
<p>Hey</p>
p { color: blue }
p:hover { color: red }
Wouldn't work as intended, because when calculating the change hint the
nsStyleColor struct in the element hasn't been accessed by layout (only the
child text frame's has), so it will report a change hint of 0 when hovering over
the paragraph, and we would ignore the nsChangeHint_ReconstructFrame generated
by the text node.
MozReview-Commit-ID: FW7Thhuh7LG
This patch makes the following changes on many in-class methods.
- NS_METHOD F() override; --> NS_IMETHOD F() override;
- NS_METHOD F() override {...} --> NS_IMETHOD F() override {...}
- NS_METHOD F() final; --> NS_IMETHOD F() final;
- NS_METHOD F() final {...} --> NS_IMETHOD F() final {...}
Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.
--HG--
extra : rebase_source : 3010fade82a170eab7f13d81bf61b02cd693f3cf
This patch makes the following changes on many in-class methods.
- NS_IMETHODIMP F() override; --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final; --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...} --> NS_IMETHOD F() final {...}
Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.
--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
Casting the scale components to integers before multiplying meant that
nsDisplayTransform::ShouldPrerenderTransformedContent was incorrectly
calculating the scaled frame size. This was especially bad when scale <
(1.0, 1.0), as it would calculate a size of (0, 0), leading us to
prerender the frame even if it was too large.
Calculate the frame's size using floating point scale components so as
to avoid this problem.
MozReview-Commit-ID: KhbP8tJ8qYx
--HG--
extra : transplant_source : %E6%BD%80l%D9O%CE%B0%12%D8%94R%AB%C0%13%A0%E7%B9%01E
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
The current setup here tries to "save" an entry in the list by checking
for the "None" namespace everywhere and special-casing it. We can simplify
this a lot by just adding the empty atom to the beginning of the array,
which is the value that servo uses to represent "namespace none" anyway.
Michael Layzell
cku
Neil Deakin
Jonathan Kew
Timothy Nikkel
Benoit Girard
Emilio Cobos Álvarez
Nicholas Nethercote
Wes Kocher
Carsten "Tomcat" Book
Sebastian Hengst
Ravi Shankar
Sylvestre Ledru
Andrew Magdy
Jamie Nicol
Matt Woodrow
Bobby Holley
Lee Salzman
Ting-Yu Lin
Ting-Yu Lin
Edwin Flores