We're currently determining whether a node is a media element by checking if the node's classname is HTMLMediaElement; but that's an abstract class and thus the condition is never satisfied. This checks against the concrete HTMLVideoElement and HTMLAudioElement classes instead.
Function queryExists added to StringUtils to check
if a given URL allows for arguments.
Tests for said function added to TestStringUtils.
Function loadUrlOrKeywordSearch in BrowserApp.java updated to also pass
the entire entered string along regardless of whether or not the first
words are keyword bookmarks iff there is additional text after the
keyword bookmark, and the keyword bookmark does not accept any input arguments
MozReview-Commit-ID: 2eyi5Botd3F
--HG--
extra : rebase_source : a08dd11a1595051a2dc727cc361cebecc14fa8c8
Display a message on startup when the APK is corrupt. Right now the
"wrong SDK" message is displayed. I think we can potentially reuse that
message for Beta, but we need a different message for Nightly.
MozReview-Commit-ID: 9NEw252Ytkc
On the second pass after failing the first time to load libraries,
enable CRC verification and detect if the APK is corrupt. In that case,
instead of crashing, we send out an event to the application.
MozReview-Commit-ID: 4b97Z8EUHZe
To reliably detect corrupt APK, this patch adds a GeckoLoader.verifyCRC
call to enable verification of CRC before extracting libs.
MozReview-Commit-ID: 5EpIfwREGIv
We had some issues with tabs closed shortly before backgrounding Firefox re-
appearing during session restore, however in hindsight bug 1282830 (closing a
zombie tab didn't trigger a session store file write) seems a more likely cause
for that than my initial theory from bug 1256277 comment 6 (tab events
dispatched *just* before backgrounding might be processed only after our
application-background handling), because as far as I can tell the latter theory
actually requires really split-second timing.
With that in mind, the differing, smaller minimum file write interval while in
background can be removed again.
MozReview-Commit-ID: GSQZYKeYME6
--HG--
extra : rebase_source : 598f49df98b7a09d63cd7e0aad6ad079916fad99
Add ACCESS_COARSE_LOCATION to the Fennec and GeckoView list of
permissions. For completeness, also add ACCESS_COARSE_LOCATION to JS
modules that handle runtime permissions.
MozReview-Commit-ID: 8UHaiJcRnq
--HG--
extra : rebase_source : 5a74d4138d6d7b4bf6cf70724f695ff06201c38c
This removes the need for the content process to have permissions to create new
files on macOS, allowing more aggressive sandboxing.
MozReview-Commit-ID: 8agL5jwxDSL
--HG--
extra : rebase_source : 17ebcef3e9d24f3d4e7515e3fae95e65cef76a79
We currently initialize PushService on delayed startup, which only
happens when Fennec is launched. This patch makes us also initialize
PushService if needed by web content from custom tabs / PWA, by
listening for the push initialization event in GeckoApplication.
MozReview-Commit-ID: 9CTOEZmOqls
--HG--
extra : rebase_source : ccd7d8e61e1de5de8ded1f6793234eb885c92672
Right now we create FormAssistPopup in WebAppActivity based on whether
the manifest is successfully loaded. We should always create it because
we always try to destroy it in onDestroy().
MozReview-Commit-ID: KskEZmYrDS1
--HG--
extra : rebase_source : bef84833438aa425a154bdf89cfa61dda7d8651d
Apparently a toolbar element can be zero-sized when we try to draw it to
the bitmap. We should just skip drawing in that case.
MozReview-Commit-ID: LlFQX5uN20h
--HG--
extra : rebase_source : cc3ba0cce8157274ef758530888629d4d372d0c0
Guard against OOM errors when getting toolbar pixels, and send a failure
message back to compositor when OOM happens.
MozReview-Commit-ID: FooZlE979DD
--HG--
extra : rebase_source : 98104304d20c26f4764c14e07c1edbb1e52b649f
Add a unit test for GeckoBundle, which tests GeckoBundle more thoroughly
than testEventDispatcher. This also lets us remove the Parcelable test
from testEventDispatcher.
MozReview-Commit-ID: Gn48Zw4Rvx5
Run unit tests under geckoview/ when running 'mach android test'. This
also lets us run those tests on Taskcluster.
The test report parser for 'mach android test' had a bug where the input
directory was wrong. As a result, we weren't producing test output at
all. This patch fixes the input directory, and outputs an error if no
reports are found at all to avoid this bug in the future.
MozReview-Commit-ID: IiswQaSPCr0
These tests involve GeckoView classes, so move them to under geckoview/.
We use a custom test runner for Fennec unit tests, but I didn't notice
any problems when using standard test runners (e.g. MockitoJUnitRunner),
so I changed these tests to use standard runners.
MozReview-Commit-ID: 7JMhqJqahTC
--HG--
rename : mobile/android/app/src/test/java/org/mozilla/gecko/permissions/TestPermissions.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/permissions/TestPermissions.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/NetworkUtilsTest.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/NetworkUtilsTest.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestContextUtils.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestContextUtils.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestDateUtil.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestDateUtil.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestFileUtils.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestFileUtils.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestFloatUtils.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestFloatUtils.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestIntentUtils.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestIntentUtils.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestStringUtils.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestStringUtils.java
rename : mobile/android/app/src/test/java/org/mozilla/gecko/util/TestUUIDUtil.java => mobile/android/geckoview/src/test/java/org/mozilla/gecko/util/TestUUIDUtil.java
The publicsuffix utils are not used in GeckoView and more importantly,
their accompanying asset is only included in Fennec and not GeckoView.
Therefore, it makes sense to move the utils to Fennec.
MozReview-Commit-ID: A5jhiqURUdB
--HG--
rename : mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/publicsuffix/PublicSuffix.java => mobile/android/base/java/org/mozilla/gecko/util/publicsuffix/PublicSuffix.java
rename : mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/publicsuffix/PublicSuffixPatterns.java => mobile/android/base/java/org/mozilla/gecko/util/publicsuffix/PublicSuffixPatterns.java
Thomas Wisniewski
Timothy Guan-tin Chien
Narcis Beleuzu
Dylan Roeh
Margareta Eliza Balazs
Andreea Pavel
Snowrries
Dorel Luca
Jim Chen
L10n Bumper Bot
Jan Henning
Eugen Sawin
Adrian Wielgosik
Nick Alexander
Alex Gaynor
Suhail Alkowaileet
Bogdan Tara
Tim Nguyen
Sebastian Hengst
Csoregi Natalia
arthur.iakab
Cosmin Sabou
Andrew McCreight
Noemi Erli
shindli
Ciure Andrei