When clearing all snapshots, if currently displaying a diff, dispatch the
diffing.toggleDiffing action.
MozReview-Commit-ID: 1DyPZ7tHC1X
--HG--
extra : rebase_source : 595d182023567c01fc14b7fb25fc65406296466d
Effectively, this moves `inverted` from a global and per-census state, to a
per-`breakdownModel` state. Additionally, a `breakdownModel` is not just a
breakdown spec anymore, but also some extra associated metadata. As such, it has
been split in two and renamed to "censusDisplayModel" and
"dominatorTreeDisplayModel".
--HG--
rename : devtools/client/memory/reducers/breakdown.js => devtools/client/memory/reducers/census-display.js
rename : devtools/client/memory/reducers/dominatorTreeBreakdown.js => devtools/client/memory/reducers/dominator-tree-display.js
rename : devtools/client/memory/test/browser/browser_memory_allocationStackBreakdown_01.js => devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js
rename : devtools/client/memory/test/browser/browser_memory_breakdowns_01.js => devtools/client/memory/test/browser/browser_memory_displays_01.js
rename : devtools/client/memory/test/unit/test_action-set-breakdown-and-refresh-02.js => devtools/client/memory/test/unit/test_action-set-display-and-refresh-02.js
This commit extends the devtools' memory panel's dominators view with a sidebar
that displays the 5 shortest retaining paths from the GC roots for the selected
node in the dominator tree.
This commit does the following:
- Rename "Group By: {Allocation => Call} Stack" in memory tool
- Rename "Label By: {Allocation => Call} Stack" in memory tool
- Get rid of "Internal Type" for labeling and grouping nodes
- Get rid of group by "Object Class" in memory tool
- Rename group/label by "Coarse Type" to plain "Type" in memory tool
Adds a keydown listener on the memory panel window. Select previous/next snapshot
when user presses UP/DOWN with the accelKey modifier (metaKey on OSX, ctrlKey on
windows).
Keydown events with modifiers are no longer listened to by the tree node elements.
Updated tree node test.
Added new mochitest to test the new keyboard navigation on the census view. )
Adds a keydown listener on the memory panel window. Select previous/next snapshot
when user presses UP/DOWN with the accelKey modifier (metaKey on OSX, ctrlKey on
windows).
Keydown events with modifiers are no longer listened to by the tree node elements.
Updated tree node test.
Added new mochitest to test the new keyboard navigation on the census view. )
--HG--
extra : commitid : 20wu80BaRXB
Unfortunately, this test is frequently reporting the doc_steady_allocation.html
test tab window as leaking. Let's disable it for now, and re-enable it along
with the other leaky tests in bug 1219554.
This commit removes the assignment expression in a return statement thing that
was going on. It is easy to misread and we don't usually use this idiom anywhere
else in the codebase. Additionally, it makes the destroy method clean up some
more members set when opening the tool.
In DominatorTreeItem check props.expanded in shouldComponentUpdate.
Added integration/sanity test to check that a node can be collapsed
and expanded using mouse events.
Added a DominatorTree component unit test to check the expanded nodes
are correctly updated.
--HG--
extra : rebase_source : 35eeca14296f81b6c8deec1d375b2a98467a460f
This commit fixes the prop name used when creating the Toolbar component
from app.js : Toolbar expects fitlerString, app was providing filter.
Extended browser_memory_filter_01.js to check the filter value is preserved
after switching views.
Before this patch, we used the underlying root list's C++ type as the label of
the GC roots node in the dominator tree. This patch changes that label to "GC
Roots", which does not require knowing our implementation of heap snapshots to
understand.
Jordan Santell
Lin Clark
Julian Descottes
J. Ryan Stinnett
Nick Fitzgerald
Oussama Ben Guirat
Alexandre Poirot
Brian Grinstead
Phil Ringnalda
Sebastian Hengst
Carsten "Tomcat" Book
Fabien Casters
Wes Kocher