2b89c1ef9d
Bug 1896973 - Part 3: Add a write barrier for JS::Heap<T> r=sfink
...
This reverses the changes to remove this in bug 1581574.
Differential Revision: https://phabricator.services.mozilla.com/D212262
2024-06-13 07:33:55 +00:00
25753781a7
Bug 1783397 - Part 10: Add {JSString,JS::Symbol,JS::PropertyKey}::dumpStringContent methods. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D199825
2024-01-31 08:54:45 +00:00
f2aef3b087
Bug 1783397 - Part 9: Add {JSString,JS::Symbol,JS::PropertyKey}::dumpPropertyName. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D199824
2024-01-31 08:54:45 +00:00
05e4b02975
Bug 1783397 - Part 8: Add JS::PropertyKey::dump. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D199823
2024-01-31 08:54:44 +00:00
a99e1075a5
Backed out 19 changesets (bug 1783397) for causing spidermonkey bustages in Id.cpp and Value.cpp CLOSED TREE
...
Backed out changeset b4429209f9f8 (bug 1783397)
Backed out changeset d9615c8d21a0 (bug 1783397)
Backed out changeset 8bfa6cc84377 (bug 1783397)
Backed out changeset b784c637b023 (bug 1783397)
Backed out changeset 97e72d850c26 (bug 1783397)
Backed out changeset 3e370ef627cf (bug 1783397)
Backed out changeset 2bc5e87ff79f (bug 1783397)
Backed out changeset 7e51d514e0a0 (bug 1783397)
Backed out changeset 38477162dadf (bug 1783397)
Backed out changeset 08fd66807078 (bug 1783397)
Backed out changeset 7453c0e7c345 (bug 1783397)
Backed out changeset 0514e2038baa (bug 1783397)
Backed out changeset 997dd2cbe1bf (bug 1783397)
Backed out changeset 10e81e8b31a6 (bug 1783397)
Backed out changeset da88bfbf8dd5 (bug 1783397)
Backed out changeset 7cfd9198841d (bug 1783397)
Backed out changeset 0a99182792eb (bug 1783397)
Backed out changeset 47e30f0625fc (bug 1783397)
Backed out changeset 67cda330103c (bug 1783397)
2024-01-30 15:46:47 -05:00
936098a5c4
Bug 1783397 - Part 10: Add {JSString,JS::Symbol,JS::PropertyKey}::dumpStringContent methods. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D199825
2024-01-30 20:14:07 +00:00
e10663f7f2
Bug 1783397 - Part 9: Add {JSString,JS::Symbol,JS::PropertyKey}::dumpPropertyName. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D199824
2024-01-30 20:14:07 +00:00
eef9673bb1
Bug 1783397 - Part 8: Add JS::PropertyKey::dump. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D199823
2024-01-30 20:14:06 +00:00
bbd6a64a49
Bug 1812540 - Part 1: Add JS::ToGetterId and JS::ToSetterId. r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D168512
2023-02-07 07:36:17 +00:00
4fcb729dc9
Backed out 11 changesets (bug 1806598, bug 1812905, bug 1812540) for causing dt failures in devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js CLOSED TREE
...
Backed out changeset 3b0e28b20def (bug 1812540)
Backed out changeset 810ed5832764 (bug 1812540)
Backed out changeset 9e042da8472f (bug 1806598)
Backed out changeset ab04e3122f20 (bug 1806598)
Backed out changeset f97c01add0a5 (bug 1806598)
Backed out changeset de9d04dc5014 (bug 1806598)
Backed out changeset 3808fc5bf528 (bug 1806598)
Backed out changeset 9be2509e8540 (bug 1806598)
Backed out changeset 3fc6c5d9d620 (bug 1806598)
Backed out changeset 297a91be123b (bug 1806598)
Backed out changeset 24cc5069faf3 (bug 1812905)
2023-02-06 07:19:51 +02:00
bcfe88c55b
Bug 1812540 - Part 1: Add JS::ToGetterId and JS::ToSetterId. r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D168512
2023-02-06 03:42:37 +00:00
28e6a9a093
Bug 1754405 part 14 - Rename PropertyKey::fromNonIntAtom to PropertyKey::NonIntAtom. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138423
2022-02-13 12:01:49 +00:00
9f57c47f87
Bug 1754405 part 13 - Move min/max int constants into PropertyKey. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138284
2022-02-13 12:01:48 +00:00
099623963c
Bug 1754405 part 12 - Move type tag constants into PropertyKey. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138283
2022-02-13 12:01:48 +00:00
d2620fa7b4
Bug 1754405 part 11 - Make PropertyKey bits field private. r=evilpie
...
Also change from size_t to uintptr_t.
Differential Revision: https://phabricator.services.mozilla.com/D138282
2022-02-13 12:01:48 +00:00
5d33ca65a5
Bug 1754405 part 10 - Remove JSID_BITS. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138281
2022-02-13 12:01:47 +00:00
a0657a3b82
Bug 1754405 part 9 - Add PropertyKey::asRawBits. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138280
2022-02-13 12:01:47 +00:00
4249b631d8
Bug 1754405 part 8 - Rename JSID_VOID to PropertyKey::Void(). r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138279
2022-02-13 12:01:46 +00:00
dec8bffeb2
Bug 1754405 part 7 - Remove SYMBOL_TO_JSID. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138278
2022-02-13 12:01:46 +00:00
126599c237
Bug 1754405 part 6 - Add JS::GetWellKnownSymbolKey. r=evilpie
...
It's very common to call JS::GetWellKnownSymbol and then creating a PropertyKey.
We can make this a bit more ergonomic with this API.
Differential Revision: https://phabricator.services.mozilla.com/D138277
2022-02-13 12:01:45 +00:00
e508008806
Bug 1754405 part 5 - Remove INT_FITS_IN_JSID/INT_TO_JSID. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138276
2022-02-13 12:01:45 +00:00
cfb6ae7bb7
Bug 1754405 part 4 - Remove JSID_TO_LINEAR_STRING. r=evilpie
...
Depends on D138274
Differential Revision: https://phabricator.services.mozilla.com/D138275
2022-02-10 09:13:18 +00:00
db8d81dc20
Bug 1754405 part 3 - Remove JSID_IS_VOID. r=evilpie
...
Depends on D138273
Differential Revision: https://phabricator.services.mozilla.com/D138274
2022-02-10 09:13:18 +00:00
20fd280e6d
Bug 1754405 part 2 - Remove JSID_IS_INT/JSID_TO_INT. r=evilpie
...
Depends on D138272
Differential Revision: https://phabricator.services.mozilla.com/D138273
2022-02-10 09:13:17 +00:00
32fccb425b
Bug 1754405 part 1 - Remove JSID_IS_STRING/JSID_TO_STRING. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D138272
2022-02-10 09:13:17 +00:00
6488ea1184
Bug 1744059 - Rename UnsafeTraceRoot to TraceRoot as it is not unsafe to use r=sfink,mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D132969
2021-12-07 09:02:36 +00:00
8e4f381606
Bug 1734392 - Part 2: Add a read barrier on JS::Heap<T> construction r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D127673
2021-10-08 14:00:04 +00:00
03c4091654
Backed out 5 changesets (bug 1734392, bug 1734362) for bustages on TestJSHolderMap.cpp. CLOSED TREE
...
Backed out changeset 53f7d8f6758a (bug 1734392)
Backed out changeset c55d9ca8c869 (bug 1734392)
Backed out changeset cd61ff016587 (bug 1734392)
Backed out changeset 211f5803783a (bug 1734362)
Backed out changeset 5f118a3deafc (bug 1734362)
2021-10-08 14:45:33 +03:00
0fdd3c7dbe
Bug 1734392 - Part 2: Add a read barrier on JS::Heap<T> construction r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D127673
2021-10-08 08:53:29 +00:00
6a95011637
Backed out changeset fbae5c0c9322 (bug 1731432) for causing crashes on nightly. CLOSED TREE
2021-09-23 16:09:28 +03:00
894498420b
Bug 1731432 - Re-add the pre-write barrier on Heap<T> r=sfink
...
This is a backout of the patch in bug 1581574 in the hope that it will fix the
crashes in bug 1731432.
Previously this write barrier was not required and we relied on the read
barrier, but it seems that may not be sufficient to allow us to mark gray roots
after the first GC slice. There are few ways that the value of a Heap<T> can be
observed without triggering the read barrier, and that could explain what's
happening here.
The contents of JS holders are cleared when they are removed from the holder
map, so that will also trigger the write barrier.
Differential Revision: https://phabricator.services.mozilla.com/D126253
2021-09-22 12:15:09 +00:00
7104ccdf17
Backed out changeset c0b5f3efa4d4 (bug 1731432) for causing reftest failures. CLOSED TREE
2021-09-21 22:13:33 +03:00
aaf83658bf
Bug 1731432 - Re-add the pre-write barrier on Heap<T> r=sfink
...
This is a backout of the patch in bug 1581574 in the hope that it will fix the
crashes in bug 1731432.
Previously this write barrier was not required and we relied on the read
barrier, but it seems that may not be sufficient to allow us to mark gray roots
after the first GC slice. There are few ways that the value of a Heap<T> can be
observed without triggering the read barrier, and that could explain what's
happening here.
The contents of JS holders are cleared when they are removed from the holder
map, so that will also trigger the write barrier.
Differential Revision: https://phabricator.services.mozilla.com/D126253
2021-09-21 17:19:01 +00:00
97c02dd3e3
Bug 1724234 - Remove APIs to pin unicode strings r=tcampbell
...
Depends on D121885
Differential Revision: https://phabricator.services.mozilla.com/D121886
2021-08-06 08:44:14 +00:00
67961ba46a
Bug 1717279 - Remove JSID_IS_SYMBOL and JSID_TO_SYMBOL. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D118287
2021-06-21 20:56:10 +00:00
3cc60aaa15
Bug 1715512 part 19 - Remove now-unused JSID_EMPTY. r=jonco
...
Differential Revision: https://phabricator.services.mozilla.com/D117319
2021-06-18 12:02:16 +00:00
531b5e0b77
Bug 1715512 part 7 - Add PropertyKey::isVoid. r=jonco
...
Differential Revision: https://phabricator.services.mozilla.com/D117307
2021-06-17 16:51:42 +00:00
951cfd1012
Bug 1678374 - Fix includes in js/public. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D97615
2021-03-12 10:42:21 +00:00
962e598d8f
Bug 1695736 - Atom API for PropertyKey. r=jandem
...
Might as well add some nicer APIs to make the following patch nicer to read.
Differential Revision: https://phabricator.services.mozilla.com/D106992
2021-03-03 10:12:55 +00:00
0bbf0e853e
Bug 1666853 - Part 4: Remove use of ApplyGCThingTyped from Value barriers as this doesn't generate good code r=sfink
...
Differential Revision: https://phabricator.services.mozilla.com/D91311
2020-09-26 10:40:48 +00:00
287b183550
Bug 1662366 part 6 - Trace cloned CacheIR stub data. r=iain
...
Initially the plan was to reuse TraceCacheIRStub but this patch adds the tracing
code for Warp separately because:
* CacheIR stub data in Warp contains nursery indexes. It's nice to keep that out of the IC-tracing code.
* We can use WarpGCPtr similar to other snapshotted GC pointers. It asserts GC things are not moved.
Differential Revision: https://phabricator.services.mozilla.com/D88965
2020-09-02 07:35:15 +00:00
a7ebf0a72f
Bug 1655110 added isPrivateName method to replace JSID manipulations r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D88404
2020-08-27 19:51:32 +00:00
16e34d88a9
Bug 1633145 - Replace NON_INTEGER_ATOM_TO_JSID. r=jandem
...
This also allows us to remove JSID_FROM_BITS and gives us stronger assertions everywhere for the whack integer-string case.
Differential Revision: https://phabricator.services.mozilla.com/D72564
2020-04-30 18:18:35 +00:00
bd161088e3
Bug 1633145 - Replace INTERNED_STRING_TO_JSID. r=jandem
...
I am honstely still not convinced that this function should actually exists.
It seems like a convulted way of saying AtomToId, while also asserting that the atom is pinned.
Differential Revision: https://phabricator.services.mozilla.com/D72563
2020-04-30 18:18:12 +00:00
f1e35cb3f7
Bug 1633145 - Add JS::PropertyKey::toGCCellPtr. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D72540
2020-04-26 17:02:30 +00:00
f420e22143
Bug 1633145 - Replace JSID_IS_GCTHING. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D72538
2020-04-26 17:03:01 +00:00
037471de0d
Bug 1633145 - Add PropertyKey::isWellKnownSymbol. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D72537
2020-04-26 17:01:57 +00:00
d30d4f7476
Bug 1633145 - Add more methods to JS::PropertyKey. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D72536
2020-04-26 17:01:39 +00:00
18f27b4376
Bug 1622326: Remove no longer needed 'id' redefine. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D66794
--HG--
extra : moz-landing-system : lando
2020-03-13 18:27:09 +00:00
a1ba26166a
Bug 1596603 - Add [SMDOC] to jsid comment r=tcampbell DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D53106
--HG--
extra : moz-landing-system : lando
2019-11-15 16:49:08 +00:00
Jon Coppeard
Tooru Fujisawa
Cristian Tuns
Sandor Molnar
Jan de Mooij
Csoregi Natalia
Marian-Vasile Laza
Tom Schuster
Simon Giesecke
yohaan
André Bargull
Matthew Gaudet