830c777ab4
Bug 735898. Part 5: Simple tweaks to avoid wrapping empty lists and to reorder boolean tests. r=mattwoodrow
2012-04-16 17:43:47 +12:00
bf5a330929
Bug 735898. Part 3: In DisplayBorderBackgroundOutline, when we have created an nsDisplayBackground item and it's themed, don't bother checking to create an nsDisplayBorder item. r=mattwoodrow
...
It turns out that calling HasBorder() is especially expensive for themed frames since we call into the theme engine to compute the border, so avoiding it is a nice win.
2012-04-13 23:44:06 +12:00
4e3da44c46
Backing out changesets ef599d7f3f11, 70ef464f50e3 and 1a204c38918e (bug 735898) due to test failures.
2012-04-12 00:34:23 +12:00
5e8bcd0f82
Bug 735898. Part 3: In DisplayBorderBackgroundOutline, when we have created an nsDisplayBackground item and it's themed, don't bother checking to create an nsDisplayBorder item. r=mattwoodrow
...
It turns out that calling HasBorder() is especially expensive for themed frames since we call into the theme engine to compute the border, so avoiding it is a nice win.
2012-04-11 16:49:34 +12:00
98b0d12882
Bug 732610 - Make nsIFrame::ComputeSize take a bitfield 'aFlags' instead of a bool 'aShrinkWrap'. r=dbaron
2012-03-16 11:01:05 -07:00
39a7d31397
Bug 728906 - Make nsIFrame::GetChildList return const nsFrameList&. r=bz
2012-03-08 02:57:37 +01:00
72f481f48f
Bug 700240 - Print display lists to a file. r=roc,bjacob
2012-03-01 21:26:09 +13:00
bf3a5c2649
Bug 721082 - Constify nsIFrame::GetParentStyleContextFrame. r=roc
2012-02-15 22:28:21 +13:00
d33bf8f71c
Bug 524925 - Consolidate overflow clipping checks to nsFrame::ApplyOverflowClipping(); and fix some code style nits. part=5/6 r=roc
2012-01-18 21:04:51 +01:00
dc9cd57308
Bug 524925 - Recompute overflow without reflowing for transforms. part=1/6 r=dbaron
...
Add an extra change hint, UpdateOverflow, that can be used to specify that
a frame's overflow areas may have changed and that they need to be recalculated.
When a transform on a frame changes, instead of marking it for reflow, set this
hint instead.
There is an added virtual function on nsIFrame, UpdateOverflow, which is called
recursively on a frame when the corresponding hint is set, to allow it to
update its overflow areas.
2011-06-15 14:03:49 -07:00
498185f3f0
Bug 619273 - Move the selection state bit from frames to content nodes. r=smaug
2011-12-20 10:15:41 +01:00
76656ee23d
Bug 700240 - Make display list debugging independent of DEBUG. r=khuey,roc
2011-11-17 16:44:16 +13:00
92064e6d3f
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
2b29cd6201
Bug 10209 - Part 6: Implement the CSS "containing block" concept correctly as a binary relation, as opposed to a unary relation; r=bzbarsky
2011-05-12 00:04:30 -04:00
461fab9117
Bug 10209 - Part 2: Implement the absolute positioning support for all frames; r=roc
2011-04-29 19:02:33 -04:00
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
2c59e05b59
bug 591249 - event dragleave not properly dispatched if drag-and-drop aborted with ESC within iframe. r=smaug
2011-09-26 15:55:04 -05:00
37e14b15b9
Bug 685154 - Cleanup nsIFrame::GetParentStyleContextFrame and related code. r=roc
...
Make nsIFrame::GetParentStyleContextFrame return the frame directly
instead of indirectly through an out parameter. Remove the unused
nsPresContext parameter.
2011-09-12 09:08:07 -07:00
5a40560039
Bug 505115 - Part 14b - Layout support for -moz-transform-style. r=roc
2011-08-27 12:01:46 +12:00
f1c56f2e22
Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc
...
Remove the nsIAtom* child list names and use child list ID enum instead.
2011-08-24 22:54:30 +02:00
605a290f3b
Bug 653649 - New way of getting child lists from frames. (part 2/5) r=roc sr=dbaron
...
Implement GetChildList(ChildListID) and GetChildLists(nsTArray<ChildList>*)
for various frame classes. Remove GetAdditionalChildListName(PRInt32)
methods and associated macros and list index constants.
2011-08-24 22:54:29 +02:00
bfc72b90bf
Bug 675865 backout new dragginf for selection handling code from Mozilla8 r=smaug (backed out patches are: bug 552707, bug 644621, bug 670058, bug 670508, bug 671319)
2011-08-03 12:39:02 +09:00
35028f63a8
Bug 552707 While we're expanding selection by dragging, the selection root element should capture mouse events and all scrollable elements should be scrollable r=roc+smaug, ui=faaborg
2011-07-06 11:16:18 +09:00
2a3dbb4205
Back out bug 10209 and bug 656875 (its regression fix) from Aurora because the work on this bug has not been finished yet
...
--HG--
extra : transplant_source : t%9F%EB%2Aa%A4%C0%9Ab%A5%DDQ%3EMD%5E%01h%E7%2A
2011-06-01 16:18:15 -04:00
e66b9024c8
Bug 10209 - Part 2: Implement the absolute positioning support for all frames; r=roc
2011-04-29 19:02:33 -04:00
c510bc3046
Bug 266236 part 3: Mechanical rename of nsIRenderingContext and nsThebesRenderingContext to nsRenderingContext. Mechanical substitution of nsRefPtr<nsRenderingContext> for nsCOMPtr<nsRenderingContext>.
...
--HG--
rename : gfx/src/nsThebesRenderingContext.cpp => gfx/src/nsRenderingContext.cpp
extra : rebase_source : 34884bfcafd885feaf73300bc7246cd192062a48
2011-04-07 18:04:40 -07:00
414c08eb55
Bug 626395. Make sure that when we're clipping our kids we don't create overflow containers for their overflow. Force the kids to lay out within our size instead. Also don't include overflowing kids in our overflow area if we're clipping them. r=roc, a=blocker
2011-01-19 17:39:31 -05:00
4793ae3bb5
Report incomplete reflow status as appropriate when frame tree is too deep. (Bug 619021) r=roc a2.0=blocking
2011-01-11 17:09:22 -08:00
e79e7e7398
bug 332636 - fix editor's handling of surrogate-pair combining marks with backspace. r=ehsan a=roc
2010-12-16 14:17:41 -08:00
63186a7fc6
Backed out changeset 1958ebae93cc for causing mochitest orange. a=backout
2010-12-16 15:15:35 -08:00
ff27ba6ff2
bug 332636 - fix editor's handling of surrogate-pair combining marks with backspace. r=ehsan a=roc
2010-12-16 14:17:41 -08:00
4c92be5947
Convert nsIFrame APIs from having a single overflow rect to having two distinct overflow rects. (Bug 542595, patch 1) r=roc sr=bzbarsky a2.0=blocking2.0:beta8
2010-10-06 21:25:45 -07:00
977bd2e2c8
Make nsIFrame::DisplaySelectionOverlay take an nsDisplayList* instead of nsDisplayListSet&. (Bug 485501) r=roc a2.0=blocking:beta6
2010-09-09 08:21:46 -07:00
5023daae20
Bug 579323. Part 1: Add FrameLayerBuilder::InvalidateThebesLayersInSubtree, and call it from InvalidateOverflowRect. r=tnikkel,sr=dbaron
...
--HG--
extra : rebase_source : c1dbc5b625e23d55ba030709f5cd429122977685
2010-08-31 12:46:26 +12:00
e5ff8517e3
Bug 564991. Part 25: Introduce a 'has active layers' flag on frames, which times out, and use it for 'opacity'. r=mats,sr=dbaron
2010-07-16 09:08:06 +12:00
65c355c8a7
Bug 573706 - make frame based accessible creation more pellucid, r=davidb, sr=roc
2010-06-28 21:02:03 +09:00
ac5aa203f5
Bug 562093: Add reflow tracing for InitConstraints, InitOffsets, InitFrameType. r=dbaron
2010-05-01 14:40:16 -07:00
3027a2127b
Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc
2009-12-24 00:21:15 -05:00
5c87a2d633
Bug 530686. Only create an nsDisplayTableBorderBackground when it's going to have something to paint, since having one can disable some scrolling optimizations. r=dbaron
2009-12-12 10:50:30 -08:00
adeb8f5a6b
Bug 497495 (frame poisoning) part 4: Change nsPresArena to maintain separate free lists for every frame class, based on its FrameIID. Pass the necessary information in from AllocateFrame and FreeFrame. r=roc sr=dbaron
2009-09-16 10:00:04 +12:00
4a4ac8be36
Backed out changeset a3f33def2dca (bug 497495 part 4)
2009-09-14 17:26:08 -07:00
3ded15f4d3
Bug 497495 (frame poisoning) part 4: Change nsPresArena to maintain separate free lists for every frame class, based on its FrameIID. Pass the necessary information in from AllocateFrame and FreeFrame. r=roc sr=dbaron
2009-09-14 17:29:56 -04:00
51b0e867e6
Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug
2009-09-13 09:13:16 -04:00
d47e0f433b
Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc
2009-09-12 17:49:24 +01:00
cef5702d08
Bug 503943, back out mouse capture patch, CLOSED TREE
2009-09-10 12:11:41 -04:00
6d007b6255
Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug
2009-09-10 08:51:36 -04:00
430c5ceb95
Bug 510651: Fold nsIFrameDebug into nsFrame. r=dbaron sr=mrbkap
2009-08-20 14:52:48 -07:00
c50a2c3b1f
Bug 497495 (frame poisoning) part 2: Introduce nsIPresShell::AllocateMisc/FreeMisc functions; add an as-yet-unused "code" parameter to AllocateFrame/FreeFrame; fix up nsFrame to match; use AllocateMisc/FreeMisc for all non-frame pres arena objects; move clearing of frame objects from nsFrame::operator new to AllocateFrame. r=roc sr=dbaron
2009-08-17 20:21:06 -07:00
2496b1ab4e
Bug 504524. Change signature of nsIFrame: of nsIFrame::CharacterDataChanged to support passing of the full CharacterDataChangeInfo struct. r=bz
...
--HG--
extra : rebase_source : cdab9444f579d6b93e142ad8681152ecd180f818
2009-08-05 13:38:10 +12:00
811394b5da
Bug 281387. Make nsIFrame::Append/InsertFrames use nsFrameList. r=bernd,roc, sr=dbaron
2009-07-30 13:23:32 -04:00
1ef12b64a7
Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc
2009-07-28 08:53:20 -04:00
cf7d0b6141
Bug 504221 part 5. Switch from GetFirstChild to GetChildList (returning an nsFrameList). For now, keep a GetFirstChild shim so callers don't have to be updated. r=fantasai, r+sr=roc
2009-07-28 08:51:09 -04:00
0489e01337
Bug 371839. Remove ParentDisablesSelection, which is effectively unused. r=bzbarsky
...
--HG--
extra : rebase_source : 920c501f033e026709ec15792cadbb2f24462a0a
2009-07-27 10:06:30 +12:00
8bab94a96a
Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky
...
--HG--
extra : rebase_source : 18c390e3ebd09de82b1a23699c56b741f928ca37
2009-07-27 10:05:41 +12:00
53a0bb6bba
Bug 505184. Expose nsFrame::DisplayBackgroundUnconditional so we can easily create an nsDisplayBackground elsewhere. r=dbaron
2009-07-22 12:44:51 +12:00
42f2f94d22
Bug 490909: Remove old layout debugging code, patch #2 : remove 'VerifyTree' & related code. r+sr=dbaron
2009-05-12 12:03:09 -07:00
f7364826e2
Bug 487831: Remove nsBox::(Get|Set)WasCollapsed, which are totally unused. r+sr=dbaron
2009-04-10 13:29:50 -07:00
2adc05bc07
Reorder functions in nsFrame.h to wallpaper over a dehydra bug (probably GC timing somewhere in the static analysis stack). rs=bz (bug 481454 covers finding and fixing the dehydra bug)
2009-03-05 10:01:04 -05:00
cb6012ec82
Remove nsStyleContext::DumpRegressionData, code that uses it, and code that exists only for it. (Bug 477522) r+sr=bzbarsky
2009-02-09 20:36:54 -08:00
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
ae14b3d6aa
Relanding bug 461410 - nsILineIterator is never used outside of layout - set nsresults to replicate the existing code more correctly, which fixes the mochitest failures, r+sr=roc with nits noted by Mats Palmgren
2008-10-30 12:17:59 -07:00
292d44b1a8
Backed out changeset d4c9a0776667 (deCOM nsILineEnumerator) due to regression from it or bug 461212
2008-10-28 02:49:14 -04:00
87c2e7ef23
Bug 461410 - nsILineIterator is never used outside of layout, and doesn't need to be refcounted: the callers can just destroy it when they're done with it. We can't do this with a virtual destructor, however, because nsTableRowGroupFrame implements the interface directly, while nsLineIterator is a separately-allocated class. So clients are expected to call DisposeLineIterator when they're done with it.
...
Instead of accessing nsILineIterator using QueryInterface, we add a nsIFrame::GetLineIterator API, which is cleaner and more efficient all at the same time!
r+sr=roc
2008-10-28 00:47:19 -04:00
867fdf2cb0
bug 258377, make border collapsed tables to listen for dynamic border style changes r/sr=bzbarsky
2008-10-26 11:11:34 +01:00
269b19b637
Bug 415707 - multiple text selection improvement doesn't work with double-click "word-by-word" or triple-click "paragraph" modes. r+sr=roc.
2008-10-17 21:46:33 +02:00
da3721ca17
Make sure DidSetStyleContext methods call the base class DidSetStyleContext, and change the signature to return void. (Bug 459649) r+sr=bzbarsky
2008-10-13 18:03:28 -04:00
385520e48e
Bug 449076: hang with 100% CPU on keyboard arrow trough text field. r+sr=roc.
2008-10-09 12:22:30 +02:00
bc94c13609
Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc
2008-09-07 16:12:50 +02:00
c04d96c610
Bug 376662. Convert nsIFrame::GetOffsetTo to not use views. We need to ensure that for popups and scrollframes, views and frames are kept in sync at *all* times. Also fixes bugs in tests for NS_FRAME_NO_MOVE_FRAME. r+sr=bzbarsky
2008-09-06 20:52:56 +12:00
8d8390a5b5
Backing out changeset 1bdd5da49865 (for bug 376662) due to regression bug 453661
2008-09-05 15:40:06 +12:00
82aa805186
Bug 376662. Make nsIFrame::GetOffsetTo not explicitly use views. r+sr=bzbarsky
2008-09-04 09:35:52 +12:00
bd67eb6f6f
Bug 449362 - "Table border is rendered incorrectly when the table cell size changes due to javascript." [r+sr=roc]
2008-08-20 01:45:29 -05:00
f270904496
Bug 392809. Fix word-based caret movement around punctuation and whitespace. r=smontagu,a=beltzner
2008-03-03 00:37:34 -08:00
48cd9701f5
Relanding bug 412679. r+sr=dbaron
2008-01-27 12:24:06 -08:00
7d62e26ef5
backing out fix for bug 412679 because it regressed a reftest
2008-01-25 15:02:23 -08:00
697beca453
Make leaf frames follow the CSS2.1 rules on height sizing for abs-pos replaced elements. Bug 412679, r+sr=dbaron, a=schrep
2008-01-25 13:34:12 -08:00
7e454eebf6
get rid of nsStyleStruct base type. b=408933, r+sr=dbaron, a=beltzner
2008-01-10 12:56:49 -08:00
350892fb62
Bug 407155. Backing out 392809 to fix regressions. a=schrep
2007-12-07 01:35:44 -08:00
fed73e9f6a
Bug 392809. Break between whitespace and following punctuation even when stop_at_punctuation is false. Don't stop between punctuation and following non-punctuatino if the preceding punctuation follows white-space. r=smontagu
2007-12-04 18:11:17 -08:00
efa3189859
Bug 399531. Rework TrimTrailingWhitespace so that we recompute the overflow area for trimmed textframes and so that soft hyphens in otherwise-empty textframes are activated. r+sr=dbaron
2007-12-01 01:24:24 -08:00
a0a74f16e7
Bug 368760, r=mats, sr=roc, a=blocking1.9+
2007-11-22 12:47:33 -08:00
d308285bb4
Fixing bug 294086. <svg> should be a replaced element. r+sr=dbaron@mozilla.com blocking1.9=tor@acm.org
2007-11-18 04:09:03 -08:00
036806699a
Bug 397518. Wrap inline non-MathML children of MathML frames in anonymous blocks. r+sr=bzbarsky
2007-10-12 01:30:54 -07:00
bbc848d48f
Bug 389421. Rework word selection, in particular so that layout.word_select.stop_at_punctuation is applied to boundaries between punctuation and non-punctuation, and all Unicode punctuation is treated as punctuation.
2007-08-29 20:10:19 -07:00
42675246db
Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron
2007-08-16 20:43:00 -07:00
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
c8e15fecde
Back out patch to make mousethrough attribute apply to all elements. b=380094 a=roc
2007-06-18 16:22:46 -07:00
0235059d11
Implement correct intrinsic width calculation (for container) for elements with specified height properties and an intrinsic ratio. b=364066 r+sr=bzbarsky
2007-06-12 11:27:09 -07:00
9c28a8c384
Bug 380094 - make mousethrough more generally usefulp=toshok@hungry.comr+sr=roc
2007-05-13 09:00:00 -07:00
073d7a78a6
Make computed style handle eStyleUnit_Chars. Bug 371043, r+sr=dbaron
2007-05-04 23:09:50 -07:00
baab01ada6
Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me
2007-04-23 07:21:53 -07:00
b82e527dc9
Change the way we determine the style context parent frame to skip css anonboxes unless we're determining the style context parent for something that isitself a css anon box (and is not a non-element frame). Fixes bug 323656(which is where the patch is), bug 85872, bug 280610. As far as I can tell,also fixes bug 317876, bug 372376, bug 374297. r+sr=dbaron
2007-04-15 16:14:26 -07:00
b3361bf8f9
Bug 243370, deCOMtaminate parts of nsIFrame that come from nsIBox, part 2, p=anlan@lange.cx, r+sr=roc
2007-01-31 16:02:42 +00:00
f6245f0ed9
Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc
2007-01-23 04:06:56 +00:00
5bb5b8f623
deCOMtaminate nsIFrame::GetMinSize/GetPrefSize/GetMaxSize. Bug 243370, patch
...
by Andreas Lange <anlan@lange.cx>, r+sr=roc
2007-01-08 02:57:59 +00:00
79090c0f4b
Rename IsSplittable() to GetSplittableType(). b=349973 r+sr=bzbarsky
2006-12-20 03:52:34 +00:00
6ee857d0b7
Make the CSS 'ch' length unit work in most cases. b=363573 r+sr=dbaron
2006-12-17 14:06:42 +00:00
d5af630c22
Better API for used padding/border/margin: remove deprecated Calc*For on nsStyleStructs and add GetUsed* to nsIFrame. b=332922 r+sr=roc
2006-12-13 23:04:57 +00:00
Robert O'Callahan
Daniel Holbert
Mats Palmgren
Matt Woodrow
Benjamin Stover
Ehsan Akhgari
Michael Wu
Adam Dane [:hobophobe]
Masayuki Nakano
Jan Küchler
Boris Zbarsky
L. David Baron
Jonathan Kew
Alexander Surkov
Zack Weinberg
fantasai
Robert O'Callahan
Justin Dolske
Neil Deakin
Benjamin Smedberg
Bernd
Uri Bernstein
Graeme McCutcheon
roc+@cs.cmu.edu
myk@mozilla.org
dwitte@stanford.edu
Olli.Pettay@helsinki.fi
jwatt@jwatt.org
philringnalda@gmail.com
jwalden@mit.edu
asqueella@gmail.com
Olli.Pettay%helsinki.fi
dbaron%dbaron.org
bzbarsky%mit.edu
mats.palmgren%bredband.net