Emilio Cobos Álvarez
198c331213
Bug 1910698 - Add a struct to represent JS caller location and more general warning source location. r=smaug,necko-reviewers,anti-tracking-reviewers,dom-storage-reviewers,pbz,kershaw,janv
...
Use it liberally across the tree. This could be cleaned up even more in the future.
Differential Revision: https://phabricator.services.mozilla.com/D218114
2024-08-01 17:12:48 +00:00
Jari Jalkanen
f45b83a18e
Bug 1878143 - Add durability hint to IDB transaction properties. r=dom-storage-reviewers,webidl,saschanaz,janv,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D202732
2024-03-27 17:34:01 +00:00
Jan Varga
0afea45648
Bug 1799374 - Add initial support for tracking request ids; r=dom-storage-reviewers,asuth
...
This patch adds only new member variables, actual support for sending ids will
be added in individual patches (all ids are set to zero for now). The idea is
to have only one source of truth, so an id used in the parent and child is
always the same.
Differential Revision: https://phabricator.services.mozilla.com/D204025
2024-03-23 08:42:39 +00:00
Kagami Sascha Rosylight
38896528d7
Bug 1767989 - Apply readability-make-member-function-const on dom/indexedDB r=dom-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D145624
2022-05-05 18:11:55 +00:00
Jari Jalkanen
bf6553c969
Bug 1708705 - Check new requests are rejected during structured cloning. r=dom-storage-reviewers,janv
...
The check is restored from the previous implementation.
Differential Revision: https://phabricator.services.mozilla.com/D137031
2022-02-02 12:42:10 +00:00
Jari Jalkanen
a60d89964e
Bug 1708705 - Handle transaction abort during value clone. r=dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D125509
2022-01-26 09:18:24 +00:00
Simon Giesecke
b45e1e2a1a
Bug 1682536 - Use references/NotNull with IDBCursor. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D99785
2021-01-21 11:58:29 +00:00
Simon Giesecke
68059713d9
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 15:50:23 +00:00
Razvan Maries
1bebc65e70
Backed out 2 changesets (bug 1660800, bug 1660816) as per Simon's request. CLOSED TREE
...
Backed out changeset 55d2e05d2e0b (bug 1660800)
Backed out changeset 7b9687fb7d41 (bug 1660816)
2020-08-28 18:45:54 +03:00
Simon Giesecke
881d526f83
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 14:43:51 +00:00
Simon Giesecke
85c8c0062e
Bug 1648454 - Use NotNull with IDBRequest where applicable. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D81078
2020-07-01 20:14:23 +00:00
Chris Peterson
843c954b43
Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-23 01:49:16 +00:00
Dorel Luca
41c3ea3ee8
acked out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE
2020-04-22 08:41:47 +03:00
Chris Peterson
0aeb2db4f6
Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-22 05:22:44 +00:00
Simon Giesecke
18c7f261c4
Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Simon Giesecke
da859a31b2
Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D66972
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:43 +00:00
Simon Giesecke
92b7ccc53b
Bug 1613340 - Remove const_cast relating to DatabaseSpec. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61668
--HG--
extra : moz-landing-system : lando
2020-03-03 13:44:25 +00:00
Simon Giesecke
37b6637a59
Bug 1497007 - Replace CanAcceptRequests by the now equivalent IsActive. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D59834
--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:09 +00:00
Simon Giesecke
2181db6537
Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55673
--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:17 +00:00
Simon Giesecke
0bcde245c0
Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
...
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.
Differential Revision: https://phabricator.services.mozilla.com/D59713
--HG--
extra : moz-landing-system : lando
2020-01-17 10:11:58 +00:00
Csoregi Natalia
8ee62c60e1
Backed out 3 changesets (bug 1497007) for assertion failures on IDBTransaction.cpp. CLOSED TREE
...
Backed out changeset 72bc4f39b659 (bug 1497007)
Backed out changeset 99fc4eedacc7 (bug 1497007)
Backed out changeset 787c340dd3d0 (bug 1497007)
2020-01-14 15:22:26 +02:00
Simon Giesecke
25cbe0ce57
Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55673
--HG--
extra : moz-landing-system : lando
2020-01-14 11:14:29 +00:00
Simon Giesecke
378b2a112d
Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
...
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.
Differential Revision: https://phabricator.services.mozilla.com/D59713
--HG--
extra : moz-landing-system : lando
2020-01-14 11:14:52 +00:00
Simon Giesecke
a5e45033f2
Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
...
This also simplifies delegating calls that are dependent on the cursor type.
Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h
Differential Revision: https://phabricator.services.mozilla.com/D57993
--HG--
extra : moz-landing-system : lando
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8c7b4f143a
Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
...
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
a48be584a9
Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
...
This also simplifies delegating calls that are dependent on the cursor type.
Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h
Differential Revision: https://phabricator.services.mozilla.com/D57993
--HG--
extra : moz-landing-system : lando
2020-01-10 14:21:18 +00:00
Simon Giesecke
44cadc4359
Bug 1608115 - Use CheckedUnsafePtr for IDBCursor::mTransaction to improve safety r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D51411
--HG--
extra : moz-landing-system : lando
2020-01-10 14:10:00 +00:00
Simon Giesecke
9f35b34d2d
Bug 1600283 - Removed unused include directives. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55516
--HG--
extra : moz-landing-system : lando
2019-12-19 09:57:40 +00:00
Simon Giesecke
6033119f9a
Bug 1497007 - Added IDBTransaction.commit method, with a minimal implementation. r=ttung,hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D46277
--HG--
extra : moz-landing-system : lando
2019-12-10 10:24:18 +00:00
Simon Giesecke
b727e2abc1
Bug 1598164 - Implement transaction inactive state according to spec. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55142
--HG--
extra : moz-landing-system : lando
2019-12-04 12:59:09 +00:00
Simon Giesecke
5e243f8d78
Bug 1598164 - Made some boolean flags in IDBTransaction FlippedOnce to reduce statefulness. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55081
--HG--
extra : moz-landing-system : lando
2019-12-03 15:32:18 +00:00
Simon Giesecke
6c42eb0661
Bug 1598164 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
...
Depends on D54322
Differential Revision: https://phabricator.services.mozilla.com/D55079
--HG--
extra : moz-landing-system : lando
2019-11-28 15:05:28 +00:00
Simon Giesecke
90427d7da3
Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D54322
--HG--
extra : moz-landing-system : lando
2019-11-28 16:00:29 +00:00
Simon Giesecke
55a2f652bc
Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D54321
--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke
f7864022f8
Bug 1598164 - Fix structured-clone-transaction-state.any.js test case. r=dom-workers-and-storage-reviewers,janv
...
Also removed obsolete dom/indexedDB/test/test_clone_before_key_evaluation.html test case,
which tested for the opposite behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D54267
--HG--
extra : moz-landing-system : lando
2019-11-26 13:18:09 +00:00
Simon Giesecke
4389ce6ebe
Bug 1497007 - Mark group of methods exposed via webidl. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D47232
--HG--
extra : moz-landing-system : lando
2019-11-11 08:25:33 +00:00
Simon Giesecke
19128f8aae
Bug 1497007 - Added explaining comments. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D47231
--HG--
extra : moz-landing-system : lando
2019-11-11 08:25:20 +00:00
Simon Giesecke
cd8018b798
Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46946
--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:32 +00:00
Simon Giesecke
35990e4306
Bug 1497007 - Use const where easily possible. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46945
--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:25 +00:00
Simon Giesecke
deb959c93c
Bug 1168606 - Resolved clang-tidy warnings. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D49274
--HG--
extra : moz-landing-system : lando
2019-11-08 13:22:28 +00:00
shindli
7c774ed0a3
Backed out 8 changesets (bug 1497007) for causing build bustages in /builds/worker/workspace/build/src/dom/indexedDB/IDBTransaction.cpp CLOSED TREE
...
Backed out changeset 15de0d72f1c4 (bug 1497007)
Backed out changeset 7056932f6422 (bug 1497007)
Backed out changeset 7304fae8c436 (bug 1497007)
Backed out changeset be22a95de04b (bug 1497007)
Backed out changeset 98ac48b5f1ef (bug 1497007)
Backed out changeset 562d3cda9fa3 (bug 1497007)
Backed out changeset 3f96e71be2e3 (bug 1497007)
Backed out changeset 3d9e86698c9f (bug 1497007)
2019-11-08 16:28:53 +02:00
Simon Giesecke
365b8934ac
Bug 1497007 - Mark group of methods exposed via webidl. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D47232
--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:56 +00:00
Simon Giesecke
67ff3f2964
Bug 1497007 - Added explaining comments. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D47231
--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:45 +00:00
Simon Giesecke
d905508bee
Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46946
--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:46 +00:00
Simon Giesecke
df38d08c1d
Bug 1497007 - Use const where easily possible. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46945
--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:39 +00:00
Simon Giesecke
9804c8f159
Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1211bbc800
Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
...
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
1db45a09bf
Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:36 +00:00
Oana Pop Rus
cb31d323be
Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
...
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
3feb8e1ebe
Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00