Changes:
- implement exnref type and try_table opcode.
- fix text representation of some ref and relaxed_simd ops
Tests are provided in the upstream repository.
Differential Revision: https://phabricator.services.mozilla.com/D204785
With this patch
- The line gutter context menu will get displayed on right click of the gutter
- Clicking line gutter should set breakpoints
Note not covered in this patch:-
- Context menu feaures might not work
- Line breakpoints are not showing yet ( this is coming in a future patch)
Differential Revision: https://phabricator.services.mozilla.com/D203210
These mouseover/mouseout events are for showing & hiding the code fold gutter.
This does not actually work, and not seem to useful.
Differential Revision: https://phabricator.services.mozilla.com/D203251
This patch updates the size of the button (above the editor gutter) which toogles the sidebar for codemirror 6.
Note this was broken with the current codemirror as wel so fixed both.
Also adding the ability to attach an updateListener to the editor we can listen for editor changes.
Differential Revision: https://phabricator.services.mozilla.com/D202398
Since we're at the end of the cycle, let's fix the regression
by reverting getRuleText to use the JS lexer again.
A test case is added to prevent future regression when we'll
try to move this to an InspectorUtils method again.
Differential Revision: https://phabricator.services.mozilla.com/D204621
We were returning the whole list of rules for a given stylesheet, and then
picking the at-rules we wanted in JS.
This patch make it so that the InspectorUtils method will only return the
at-rules we want directly, so we're building a smaller array of rule in the end.
Since `getStyleSheetRuleCountAndAtRules` also need to return the total number
of rules, this adds a simple `InspectorUtils.getStyleSheetRulesCount` method that
does that.
Differential Revision: https://phabricator.services.mozilla.com/D203878
Since the bug 1879447 enabled AccessibilityUtils to exclude intervening generics from tab-in-tablist accessibility checks, there are 3 tests in Debugger devtools that are now passing the a11y-checks, thus we could remove the `fail-if` notations from their test manifest.
Differential Revision: https://phabricator.services.mozilla.com/D204463
We were returning the whole list of rules for a given stylesheet, and then
picking the at-rules we wanted in JS.
This patch make it so that the InspectorUtils method will only return the
at-rules we want directly, so we're building a smaller array of rule in the end.
Since `getStyleSheetRuleCountAndAtRules` also need to return the total number
of rules, this adds a simple `InspectorUtils.getStyleSheetRulesCount` method that
does that.
Differential Revision: https://phabricator.services.mozilla.com/D203878
waitForSource wasn't fully reliable to retrieve the source object.
Now that it is, we can remove a few useless usages of findSource following it.
Differential Revision: https://phabricator.services.mozilla.com/D203447
This code was only used for workers targets, which weren't passing breakpoints
from the server side via "sessionData" concept.
Instead, we were still relying on the frontend to pass them and only after that
manually requesting the thread to resume its execution.
Now, there is still a notion of "attach" around the thread actor.
While all the targets are immediately instantiating their related thread actor,
the thread actor isn't active by default.
It becomes active as soon as:
* SOURCE or THREAD_STATE resource is watched
* breakpoints are set via session data (breakpoint list actor)
* thread configuration are set via session data (thread configuration actor)
I had to do one of these things in order to keep test from working.
In the production code, we do most of these things by default on the toolbox startup.
We could revise this behavior by:
* always attaching the thread actor, but it may start pausing unexpectedly in some tests.
* decouple sources from breakpoints within the thread actor, so that watching for sources doesn't necessarily "attach" the thread actor and activate breakpoints/debugger statements.
* have a new thread configuration to explicitly enable the thread actor pausing features.
I'm often using thread configuration to enable pausing in tests.
This required to improve xpcshell test helpers to be able to use Watcher/Commands.
About browser_target_command_bfcache.js, the DevTools code is now so quick that the
back/forward requests at done too quickly one after the other and fail actually moving to
the other document.
Differential Revision: https://phabricator.services.mozilla.com/D166321
The new DevToolsProcess JS Actor will read the `sharedData` during its instantiation.
We should rather flush/persist sharedData *before* the JS Process Actor registration.
(this also fixes test failure when applying the next changeset)
Differential Revision: https://phabricator.services.mozilla.com/D203102
We were only processing the first one being registered.
Luckily we weren't testing session data enough in xpcshell to have trouble because of this.
(this changeset fixes test failure when applying the next one)
Differential Revision: https://phabricator.services.mozilla.com/D203101
When loading the tab, an about:blank document is loaded first.
The top level target front may refer to that document instead of the test page.
Ensure waiting for that test page's target front before running the assertions.
Differential Revision: https://phabricator.services.mozilla.com/D203100
We used to wait for the thread actor to be attached before resuming
the execution of the worker. But now that breakpoints are now
always available on the server side, we can automatically resume
once we processed the Session Data and so, registered all the breakpoints.
In this changeset, we also merge the legacy WorkerTargetActor's attach
method into its constructor, so that the ThreadActor is always ready.
browser_dbg-windowless-service-workers.js fails because `sessionData`
isn't passed to worker-connector's `connectToWorker`.
That's because service workers are still instantiated from the client.
We still instantiate a WorkerDescriptor which is unrelated to the Watcher
and can't have easy access to its SessionData (which is keyed per Watcher and
not per DevToolsServerConnection).
Differential Revision: https://phabricator.services.mozilla.com/D166318
Yury Delendik
Hubert Boma Manilla
Emilio Cobos Álvarez
Nicolas Chevobbe
Anna Yeddi
Butkovits Atila
dylan
Florian Quèze
Alexandre Poirot
artem manushenkov
Cristian Tuns
Mark Banner
Tom Schuster
pstanciu
Cosmin Sabou
Gregory Pappas
Dave Townsend
Joel Maher
Sean Feng
Tooru Fujisawa