A command button like ruler has keydown event handler, this patch will
add same event handler to tab button.
--HG--
extra : rebase_source : eef8467b15bb99b8e8a22798e83c8a968ac24f7f
The onclick handler of the toolbox close button looked like this... spot the deliberate mistake:
```
onClick: () => {
closeToolbox();
focusButton(closeButtonId);
},
```
So we were closing the toolbox and then trying to focus the toolbox's close button.
There is also an obvious race condition with setState inside the toolbox controller not using a callback even though the next line calls a function that uses this.state, which could cause intermittent issues.
MozReview-Commit-ID: 9VRcZw4RvE5
--HG--
extra : rebase_source : 17c21aafe5a72042c23472342c53fd730784a5ae
I believe this fixes all warnings except for one. This warning appears the first time the memory panel is selected:
"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
in MemoryApp (created by Connect(MemoryApp))
in Connect(MemoryApp) (created by bound createElementWithValidation)
in bound createElementWithValidation
in Provider"
This appears to be an issue with `devtools/client/memory/app.js` but I will log a new bug for this.
MozReview-Commit-ID: 341zdQyfgrN
--HG--
extra : rebase_source : ce25569407b89a7547e4db688373b202d17d2475
To accomplish this, the added aria-pressed attribute turns the buttons into toggle buttons, and the one that is visually selected, gets the "true" attribute value, others are "false". That way, the screen reader and other assistive technologies will indicate that this is the selected or pressed button.
MozReview-Commit-ID: L2lcw2wOyYw
--HG--
extra : rebase_source : 1c0ad241319f50c34c120ce05b85e795e9a5b080
Using fill instead of filter we don't need to define each icon as
invertable or not. If the icon is a SVG and supports fill="context-fill"
then it will be inverted/highlighted etc... as expected.
If not then it won't be impacted by DevTools themes.
MozReview-Commit-ID: CLFprKMuCt9
--HG--
extra : rebase_source : 391f3567c2bdf319dcfd0a3b0c87f0479f85eabd
Instead of duplicating SVGs to apply a different fill color, we
can use fill from css + fill="context-fill" to achieve the same
effect. This applies to all tools that have a highlighted state
for their icon: debugger, memory and performance tools.
MozReview-Commit-ID: GmqeTKS3PC
--HG--
extra : rebase_source : c613fc38ce7fedcfe111bed74216c1c38b511b9d
Also fixes a slight issue in firebug theme that made the text slide of
1 px down when selecting a tab.
MozReview-Commit-ID: KNm9Xf21p2D
--HG--
extra : rebase_source : 98728735c36446a116a5a2cb2306f39e5a72f21c
extra : source : c342d199c1397fbb66c3c6f70cfe42b5d3817cc2
Brian Birtles
Mantaroh Yoshinaga
Michael Ratcliffe
Marco Zehe
Yura Zenevich
Eitan Isaacson
Julian Descottes
Alexandre Poirot
abhinav
Gabriel Luong
Greg Tatum