Sometimes, when cells have display:block, and a different cell in the same row has a column span, our index methods did not take these into account. Also, when regular tables encounter such a cell, index calculation failed.
Differential Revision: https://phabricator.services.mozilla.com/D7867
--HG--
extra : moz-landing-system : lando
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.
Differential Revision: https://phabricator.services.mozilla.com/D8778
--HG--
extra : moz-landing-system : lando
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.
Differential Revision: https://phabricator.services.mozilla.com/D8778
--HG--
extra : moz-landing-system : lando
This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:
> All <angle> units are compatible, and deg is their canonical unit.
And https://drafts.csswg.org/css-values/#compat, which says:
>When serializing computed values [...], compatible units [...] are converted into a single canonical unit.
And also other implementations (Blink always serializes angles as degrees in
computed style for example).
Also allows us to get rid of quite a bit of code, and makes computed angle value
representation just a number, which is nice.
Differential Revision: https://phabricator.services.mozilla.com/D8619
--HG--
extra : moz-landing-system : lando
Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.
Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.
Depends on D6681
Differential Revision: https://phabricator.services.mozilla.com/D6682
--HG--
extra : moz-landing-system : lando
This is preparation of the last patch. Even if no editor is clicked with
middle button, we need to do:
- collapse Selection at the clicked point.
- dispatch "paste" event.
Therefore, HandleMiddleClickPaste() should dispatch ePaste event by itself
and each editor methods should have a bool argument which the caller wants
ePaste event automatically.
Note that Chromium dispatches "paste" event and pastes clipboard content
into clicked editor even if preceding "auxclick" event is consumed.
However, our traditional behavior is not dispatching "paste" event nor
pasting clipboard content. Unless Chromium developer keeps their odd
behavior, we should keep our traditional behavior since our behavior is
conforming to DOM event model.
Differential Revision: https://phabricator.services.mozilla.com/D7854
--HG--
extra : moz-landing-system : lando
Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.
Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.
Depends on D6681
Differential Revision: https://phabricator.services.mozilla.com/D6682
--HG--
extra : moz-landing-system : lando
When checking for an accessible if it is a table row instead of a table cell, when retrieving the actual row at the given index, null check it to make sure we don't pass an invalid accessible to the TableAccessible::CellInRowAt method. I accidentally omitted that null check in the updated patch for bug 1486668.
Differential Revision: https://phabricator.services.mozilla.com/D7162
--HG--
extra : moz-landing-system : lando
Make LayerViewSupport, NPZCSupport, GeckoEditableSupport, and
SessionAccessibility use the new disposal mechanism to ensure the
disposal is performed safely.
Differential Revision: https://phabricator.services.mozilla.com/D7110
--HG--
extra : moz-landing-system : lando
The code does check for the case where a container has no children.
However, before it does so, it tries to check whether it needs to skip a text leaf child.
This check previously assumed there was a child to check, which crashed for a container with no children.
Differential Revision: https://phabricator.services.mozilla.com/D6588
--HG--
extra : moz-landing-system : lando
Mark Banner
Marco Zehe
arthur.iakab
Eitan Isaacson
Dorel Luca
Jonathan Kingston
Emilio Cobos Álvarez
Sylvestre Ledru
Daniel Varga
Masayuki Nakano
Tim Nguyen
Narcis Beleuzu
Alexander Surkov
Jim Chen
Nicholas Nethercote
Ehsan Akhgari
Noemi Erli
shindli
Tiberius Oros
Coroiu Cristina
James Teh
Chris Peterson
Neil Deakin