Граф коммитов

1048 Коммитов

Автор SHA1 Сообщение Дата
Xidorn Quan 0adbbea38f Bug 1297049 - Include tests with query string and hash string when specifying test path. r=dbaron
MozReview-Commit-ID: 27x0vTs1aDa

--HG--
extra : rebase_source : a426489c01260df302f790b0a28b262cbbe723fc
extra : source : 61c7ab9bea3f154aef14f425875100b0ac824674
2016-08-23 10:32:43 +10:00
Ryan VanderMeulen 01c4e8cc1b Merge inbound to m-c. a=merge 2016-08-19 09:52:53 -04:00
Andrew McCreight 5f12e5d1fd Bug 1292218 - Run collectors more in reftests. r=jmaher
MozReview-Commit-ID: E7TQpBMeiVB

--HG--
extra : rebase_source : cd1dffff886567ad74c621d27a9628c7ff6eccb1
2016-08-04 08:03:25 -07:00
Mason Chang b9665be6df Bug 1296360 - Add a dwrite enabled check to the reftest sandbox. r=lsalzman 2016-08-18 16:06:51 -07:00
James Graham 8bdb6331c6 Bug 1293250 - Make reftest log generation less magical, r=ahal
Ensure that the first line of the log for failing tests is identical to
one that would be produced by the tbplformatter from mozlog. This means
that treeherder will be able to sucessfully cross-match error lines.

Also make the data structures used for storing screenshots identical
between reftests and web-platform-tests so that we can start to move
toward removing the reftest-specific codepath here.

MozReview-Commit-ID: FZQXLjj9Ejv

--HG--
extra : rebase_source : 3e9bf70ff7915817b8c02032c8da0d0a659e4661
2016-08-08 17:48:39 +01:00
Andrew Halberstadt 16c7acfe05 Bug 1292660 - Fix |mach mochitest| kwargs['app'] is None error on android, r=gbrown
This fixes a regression from bug 1288827. It happened because I moved the logic that finds
the application path a little later on in the test harness. But there was an instance where
it was being used in the android mach command before that point.

As it turned out, we don't really *need* that value there. This patch grabs the same value
from build_obj.substs which is already an argument to the function.

MozReview-Commit-ID: 3IsI4VzEIIF

--HG--
extra : rebase_source : ceb718b265c7886b831e0378436baebf2b4e7598
2016-08-05 16:40:08 -04:00
Seth Fowler c379e3a8ce Bug 1290681 (Part 3) - Remove the single color optimization pref. r=edwin 2016-08-01 17:51:15 -07:00
Tom Tromey 5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Andrew Halberstadt da291f0301 Bug 1278890 - Add reftest support to test package mach environment, r=armenzg
This adds reftest support to the test package mach environment. It will allow
developers to easily run reftests after checking out an interactive worker.

MozReview-Commit-ID: fBAbfuG5XQ

--HG--
extra : rebase_source : 84b4a9fff7f2f27a325ffad4af1de7726bad296e
2016-07-13 10:57:22 -04:00
Benjamin Smedberg be3857f963 Bug 1277905 - Remove in-product links to plugincheck. Also remove support for startup prompting about outdated plugins, since that's annoying to users. r=Gijs r=mconley
MozReview-Commit-ID: 69tMivPVxuW

--HG--
extra : rebase_source : bd4d2979beff0f460a20156b0f954e2f1a2a5e85
2016-07-01 11:01:07 -04:00
Matt Woodrow a871a80e98 Bug 1263092 - Improve error logging when reftests fail due to the screen resolution being too low. r=dholbert 2016-07-11 13:11:08 +12:00
Brad Werth e3bcca28e9 Bug 1285062 - Change an improper warning in reftests into an info message. r=dbaron 2016-07-06 18:14:24 -07:00
Krishna ae19df0488 Bug 1276560 - Package hyphenation-dictionaries separately for reftests. r=sebastian
MozReview-Commit-ID: IRvIqGEfc1m

--HG--
extra : transplant_source : c%CD%7F%D8%89%E4q%1D%A2%FF%10%94y%A0l%99%C0%98%F4p
2016-07-05 01:00:15 +08:00
Thomas Nguyen ffba687a20 Bug 1025965 - Rename browser.safebrowsing.enabled to browser.safebrowsing.phishing.enabled. r=francios
MozReview-Commit-ID: 3TMs6MPtWsC
2016-05-09 14:44:08 +08:00
James Graham bc68fdaad1 Bug 1278577 - Use simple strings as reftest test ids, r=ahal
The idea of mozlog ids being tuples unfortunately didn't work so well
with external systems that found the tuple|string datatype difficult to
work with. Convert reftests to use simple ids of the form "<test url>
<comparison> <refurl>" e.g. "about:blank == data:text/html," instead of
tuples.

MozReview-Commit-ID: 18jufbssn4A

--HG--
extra : rebase_source : 542888186fecf3671847d1fca307770c7a989ad3
2016-06-06 16:28:22 +01:00
Jonathan Hao 525c086187 Bug 1259871 - Replace getSimpleCodebasePrincipal with createCodebasePrincipal. r=sicking
MozReview-Commit-ID: Frx0CjBzuve

--HG--
extra : histedit_source : 036eb321d9ccb20e0e071ba588b0a1249eb34bdd
2016-05-24 18:01:34 +08:00
Geoff Brown dd65ba7f12 Bug 1274395 - Delete pending crash reports before running tests; r=jmaher 2016-05-25 14:48:42 -06:00
Gijs Kruitbosch a41e908395 Bug 1270144 - use error() rather than warning() in order to ensure this shows up on the treeherder summary, rs=emorley-over-irc
MozReview-Commit-ID: COtfpoU14vg

--HG--
extra : rebase_source : 0bfd093b6dc762498a5a737cab3b6c85fe186ec0
2016-05-25 15:14:56 +01:00
Chris Peterson 8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Gijs Kruitbosch 40ea68f72f Bug 1270144 - fix message from timed out tests to indicate the following crash is caused by us terminating the browser process, r=ahal,RyanVM
MozReview-Commit-ID: Hyr7xkZdbqc

--HG--
extra : rebase_source : 013339bec54f1ecb0123fa1388dbb350258790df
extra : amend_source : 26e6c904d7031e700560ca32057edba65ad1632d
2016-05-10 22:53:17 +01:00
Andrew Halberstadt aea682d7a3 Bug 1271448 - Stop saving reftest.log for |mach reftest| perf improvements, r=jgraham
In bug 1271035 gps identified disk I/O as a major cause for reftest slowness.
He was able to fix most of it, but the new highest source of I/O in reftest is
reftest.log.

To note, we were only saving reftest.log when running via mach, so this won't
impact automation in any way:
https://hg.mozilla.org/mozilla-central/file/043082cb7bd8/layout/tools/reftest/mach_commands.py#l204

I don't know why we are doing this given that the same output goes to stdout.
And as dholbert pointed out, since bug 1034290 landed, that log contains raw
structured logs, which are not at all useful for debugging. Given that it is
no longer useful and causes slowness, we should stop saving it.

If anyone wishes to keep saving to a log, they can use:
./mach reftest --log-tbpl reftest.log

If they wish this to be the default behaviour they can make a machrc (or
.machrc) in either topsrcdir, ~/.mozbuild or $MACHRC. Then add:
[alias]
reftest = reftest --log-tbpl reftest.log

MozReview-Commit-ID: A3e2X7qF90H

--HG--
extra : rebase_source : 9286e3061c068c6fef55b503017b3f4a9588be46
2016-05-09 17:53:04 -04:00
Andreas Tolfsen 90edca9757 Bug 1123506 - Update references to __webDriverArguments; r=automatedtester
__marionetteParams was renamed to __webDriverArguments.

MozReview-Commit-ID: 9t1skl5MESf
2016-05-09 16:08:27 +01:00
Gregory Szorc e13542b72f Bug 1271035 - Disable Places during reftests, preventing 50 GB of I/O; r=dholbert
It was a cold Friday night in San Francisco. Earlier in the day, I
informed Chris AtLee that I was going to start focusing on improving
the efficiency of Firefox automation and asked him where the biggest
capacity issues were. He said "we're hurting most on Windows tests."

As I was casually drinking a barleywine (note to reader: barleywines
are serious beers - there's nothing casual about them), I found myself
tediously clicking through Treeherder looking at logs for Windows jobs,
looking for patterns and other oddities. As I was clicking through,
something stood out to me: the sheer number of reftest jobs. I
recalled a random project I started a few years ago. Its aim was to
analyze buildbot job metadata so we could better understand where time
was spent in automation. I had mostly written off the side project as
a failure and a near complete waste of my time. Not even a stray
random thought of this project had entered my mind in the past year.
But clicking through Treeherder after a few glasses of barleywine
somehow reminded me of one of the few useful findings of that project:
reftest jobs consumed a seemingly disproportiate amount of machine time,
something like 35 or 40% IIRC of the time spent on all jobs.

Now, this finding was several years ago and almost certainly no longer
relevant. But, again, I had a few glasses of barleywine in me and was
bothered by the amount of reftest jobs and their duration, so I thought
"hey, why don't I run reftests and see why they take so long." So I
built Firefox on Windows - the platform Chris AtLee said we're "hurting
most on."

I decided to start my very casual profiling session by recording a
`mach reftest` run using Sysinternals Process Monitor. To my surprise,
it yielded a very obvious and unexpected result: the Places SQLite
database was incurring a lot of I/O. On my i7-6700K Windows 10 desktop
with a high performance SSD, `mach reftest` yielded the following:

File Time  #Events  #Reads   #Writes  RBytes        WBytes          Path
198s       980,872  243,270  669,231  7,971,471,360 20,667,084,080  places.sqlite-wal
165s       645,853  222,407  367,775  7,287,701,820 14.071,529,472  places.sqlite
  2s       377,121        1        0         32,768              0  places.sqlite-shm

The Places SQLite database accounts for 2,003,846 of the total of
3,547,527 system calls (56.49%) recorded by procmon during `mach
reftest` execution. This represents a staggering 49,997,786,732 of the
50,307,660,589 (99.38%) bytes of I/O recorded! Yes, that's 50 GB.

I reckon the reason the Places database accumulates so much I/O load
during reftests is because the reftest suite essentially loads thousands
of pages as quickly as possible. This effectively performs a stress
test against the Places history recording service.

As effective as reftests are at stress-testing Places, it adds no value
to reftests because reftests are testing the layout features, not the
performance of history recording. So these 2M system calls and 50 GB
of I/O are overhead.

This commit disables Places when executing reftests and prevents
the overhead.

After this commit, `mach reftest` has significantly reduced interaction
with the Places SQLite database:

File Time  #Events  #Reads   #Writes  RBytes        WBytes         Path
0.09s          502     138       302     4,521,984      8,961,528  places.sqlite-wal
0.07s          254      20       140       524,604      8,126,464  places.sqlite
0.01s        3,289       1         0        32,768              0  places.sqlite-shm

Of the 948,033 system calls recorded with this change (26.7% of
original), 691,322 were related to I/O. The Places SQLite database
only consumed ~22MB of I/O, <0.01% of original. It's worth noting that
~half of the remaining I/O system calls are related to reftest.log,
which now accounts for the largest percentage of write I/O (only
~53 MB, however). It's worth noting that reftest.log appears to be
using unbuffered writes and is requiring an excessive amount of
system calls for writing. But that's for another bug and commit.

In terms of wall time, the drastic I/O reduction during `mach reftest`
appears to have minimal impact on my machine: maybe 30s shaved from a
~900s execution, or ~3%. But my machine with its modern SSD doesn't
struggle with I/O.

In automation, it is a different story.

I pushed this change to Try along with the base revision and triggered
4 runs of most reftest jobs. The runtime improvements in automation
are impressive. Here are the fastest reported times for various jobs:

Job                     Before      After     Delta
Linux Opt R1               31m        34m       +3m
Linux Opt R2               43m        35m       -8m
Linux Opt Ru1              40m        34m       -6m
Linux Opt Ru2              43m        37m       -6m
Linux Opt R E10s           89m        72m      -17m
Linux Debug R1             52m        40m      -12m
Linux Debug R2             49m        42m       -7m
Linux Debug R3             60m        51m       -9m
Linux Debug R4             42m        37m       -5m
Linux Debug R1 E10s        84m        72m      -12m
Linux Debug R2 E10s        97m        85m      -12m
Linux64 Opt R1             35m        24m      -11m
Linux64 Opt R2             37m        26m      -11m
Linux64 Opt Ru1            32m        29m       -3m
Linux64 Opt Ru2            37m        26m      -12m
Linux64 Opt TC R1          12m        10m       -2m
Linux64 Opt TC R2          10m         7m       -3m
Linux64 Opt TC R3          11m         9m       -2m
Linux64 Opt TC R4          11m         9m       -2m
Linux64 Opt TC R5          13m        11m       -2m
Linux64 Opt TC R6          11m         9m       -2m
Linux64 Opt TC R7           9m         8m       -1m
Linux64 Opt TC R8          11m        10m       -1m
Linux64 Opt TC Ru1         30m        25m       -5m
Linux64 Opt TC Ru2         36m        27m      -11m
OS X 10.10 Opt             31m        27m       -4m
OS X 10.10 Opt E10s        26m        25m       -1m
OS X 10.10 Debug           68m        55m      -13m
Win7 Opt R                 30m        28m       -2m
Win7 Opt Ru                28m        26m       -2m
Win7 Opt R E10S            29m        27m       -2m
Win7 Debug R               85m        76m       -9m
Win7 Debug R E10S          75m        65m      -10m
Win8 x64 Opt R             29m        26m       -3m
Win8 x64 Opt Ru            27m        25m       -2m
Win8 x64 Debug R           90m        71m      -19m
Android 4.3 API15 Opt R1   89m        71m      -18m
Android 4.3 API15 Opt R2   78m        64m      -14m
Android 4.3 API15 Opt R3   75m        64m      -11m
Android 4.3 API15 Opt R4   74m        68m       -6m
Android 4.3 API15 Opt R5   75m        69m       -6m
Android 4.3 API15 Opt R6   91m        86m       -5m
Android 4.3 API15 Opt R7   87m        66m      -21m
Android 4.3 API15 Opt R8   87m        82m       -5m
Android 4.3 API15 Opt R9   80m        66m      -14m
Android 4.3 API15 Opt R10  80m        67m      -13m
Android 4.3 API15 Opt R11  73m        66m       -7m
Android 4.3 API15 Opt R12 105m        91m      -14m
Android 4.3 API15 Opt R13  72m        59m      -13m
Android 4.3 API15 Opt R14  82m        61m      -21m
Android 4.3 API15 Opt R15  73m        62m      -11m
Android 4.3 API15 Opt R16  79m        78m       -1m

The savings total 6+ *hours* or ~15% when running all reftests. I'd
say this isn't bad for a one-line code change!

MozReview-Commit-ID: H1LkACgSpVn

--HG--
extra : rebase_source : 891a5ce8e1f6c3d70fc646f116c2f49f897ad735
2016-05-07 02:53:14 -07:00
Andrew Halberstadt 48a50c124b Bug 1265124 - [reftest] Make sure marionette waits long enough when attaching a debugger, r=chmanchester
As of bug 1245092, reftest depends on marionette. Normally marionette client has an internal timeout of around
60 seconds where it waits for the server to become available. But when using debuggers (and especially valgrind),
it can take much much longer than a minute for Firefox to start. This patch adds a couple hidden command line
args to reftest to tweak the marionette timeouts.

MozReview-Commit-ID: 3xF0InBJNEf

--HG--
extra : rebase_source : f18092bc90a7d8aab34b527a15bd3b1dc6afc997
2016-04-29 15:41:23 -04:00
Mike Shal 8689f72e8b Bug 1266875 - Remove custom install rules; r=chmanchester
MozReview-Commit-ID: CoWdHidlDrV
2016-04-18 10:36:07 -04:00
Daniel Holbert b199fea9a7 Bug 1268588: Add missing space to "assertion count[...] is less than expected" reftest log message. r=gbrown
MozReview-Commit-ID: GA2mvt4WyqU

--HG--
extra : rebase_source : ed194ccc7f1e116b7d8b01ea15b2281ba08bfd47
2016-04-28 10:52:42 -07:00
Hiroyuki Ikezoe a4b111280b Bug 1267908 - Don't call flushApzRepaints if reftest-no-flush is specified. r=kats
flushApzRepaints leads flush paint.

MozReview-Commit-ID: 5pt7Gq5zHTx

--HG--
extra : rebase_source : 90416872d2e271654767bfc7bd73ecbc451c65d6
2016-04-28 06:16:30 +09:00
Geoff Brown 71f1e3bc75 Bug 1267020 - Dump reftest assertion count mismatches to log file on Android; r=jmaher 2016-04-27 14:56:09 -06:00
Sebastian Hengst b4020b78c0 Backed out changeset e786ecce31b2 (bug 1266875) for pgo build bustage in xpcshell/xpcom/tests/unit/nsIFileEnumerator. r=backout on a CLOSED TREE 2016-04-27 18:35:41 +02:00
Mike Shal a204083dd1 Bug 1266875 - Remove custom install rules; r=chmanchester
MozReview-Commit-ID: CoWdHidlDrV
2016-04-18 10:36:07 -04:00
Andrew Halberstadt 018bb9b783 Bug 1255565 - Close extraneous browser window when running reftests, r=dholbert
This extra window was initially left open because closing it was causing memory leaks
on debug e10s crashtests. There was pressure to get the regressing patch landed due
to addon signing, so it got landed with this extra window hanging around (as it didn't
impact test results).

But it is a UX wart for several reasons. Upon testing it again recently, the leaks all
seem to have vanished. I'm not sure why, possibly it was a bug fixed in e10s.

MozReview-Commit-ID: CEI2enKAOyv

--HG--
extra : rebase_source : da0e8889f67d57aa61670105c14c2235607d79a7
2016-04-13 10:23:47 -04:00
Joel Maher 585b69b5f8 Bug 1262954 - Explicitly set the 'layers.acceleration.disabled' pref to true on Windows XP e10s test runs. r=ahal
MozReview-Commit-ID: 2KsBZDNvsdU

--HG--
extra : rebase_source : 0869acfae1af0ab92ae142797b9e4b1a4e452781
2016-04-08 14:46:25 -04:00
Andrew Halberstadt 273f8a751c Bug 1243083 - Enable e10s by default when running reftests, r=jmaher
MozReview-Commit-ID: NlTGwdQ2nw

--HG--
extra : rebase_source : 524578da02c2c84487bfe497783a6ea9de594ed9
2016-04-01 11:00:37 -04:00
Ting-Yu Lin 219e330768 Bug 1259889 Part 1 - Add @supports -moz-bool-pref for internal-only style sheets. r=heycam
This is a internal-only syntax for guarding rules from a boolean
preference. Nothing causes @supports rules to be re-evaluated except
html.css registered in Part 2.

This is needed for rendering the disclosure triangle of the
summary element by using "display: list-item".

Usage example:
@supports -moz-bool-pref("dom.details_element.enabled") {
  /* css rules */
}

MozReview-Commit-ID: HDCa8zHxYTA

--HG--
extra : rebase_source : b7a72a48166edf1d486014ff37363ed8be9127d9
2016-04-01 21:11:11 +08:00
Andrew Halberstadt eaf4ca74c0 Bug 1245092 - Fix beta-only non-local network bustage on reftest, r=me, a=test-only
MozReview-Commit-ID: 1N6lsrbMNyI

--HG--
extra : commitid : MnX4BePWDx
extra : source : f902121e4d1b1c612b6a270743bf4830c8c8dcbf
extra : amend_source : 035d59b83e35cd72256ae079cdea5212273c7b82
2016-03-14 17:00:40 -04:00
Tobias Schneider 9dd3cff0b6 Bug 1237198 - Block SWFs on the content blocking list hosted on the Shavar service. r=francois 2016-03-29 00:37:44 -07:00
Francois Marier 63c2afbc28 Bug 1259288 - Safe Browsing should be fully disabled in our test suites. r=gcp
MozReview-Commit-ID: 2og99Gl9w9n

--HG--
extra : rebase_source : 33961d97454e71e5b7fc3ad5f9eb145099c0fc6e
2016-03-23 17:59:55 -07:00
Xidorn Quan b377ad08c2 Bug 1257099 - Normalize the path of extensions for reftest. r=jmaher
MozReview-Commit-ID: 7nTx3uniJik

--HG--
extra : rebase_source : 4d757211c4fda9953a5817ad5e037b4b70994636
2016-03-16 14:26:27 +08:00
Xidorn Quan 0fb001761f Bug 1256257 - Clear Win10 intro page url for reftest. r=jmaher
MozReview-Commit-ID: 3iJ8QVSNaKx

--HG--
extra : rebase_source : af532bdaf1c9fa66fff5dd530cf9639ed9bab63d
2016-03-16 14:27:25 +08:00
Andrew Halberstadt 6e6c1c8aae Bug 1245092 - Install reftest and specialpowers extensions at runtime via AddonManager.installTemporaryAddon, r=jgriffin
MozReview-Commit-ID: 5HSa3nFVTeF

--HG--
rename : layout/tools/reftest/reftest.js => layout/tools/reftest/reftest.jsm
extra : rebase_source : 924a3e937b47cac03674acdb56334882a2373f50
2016-03-09 14:38:13 -05:00
Stanley Mwangi ecaaff970b Bug 1243083 - Added --disable-e10s to mochitest_options.py and reftestcommandline.py. r=ahal
MozReview-Commit-ID: I3UIS8eEZ8D

--HG--
extra : rebase_source : cad52821f891915b2d174f60c250fb80ec307525
extra : amend_source : fe1a47030662a58c409e3cf2b42dc0ace452178d
2016-03-02 16:33:13 -05:00
Felipe Gomes 0fcf346707 Bug 1250744 - Disable e10s add-ons blocking on testing profiles. r=jmaher 2016-03-02 13:50:55 -03:00
Milan Sreckovic 65bcdb7519 Bug 1249640: Part 2 gfxPlatform simplification when it comes to accelerated canvas, using the new blocking. r=gw280 2016-02-22 14:23:00 +01:00
Sebastian Hengst 00a63ca413 Backed out changeset 303b759e886e (bug 1249640) 2016-02-24 19:02:00 +01:00
Milan Sreckovic 1498964285 Bug 1249640: Part 2 gfxPlatform simplification when it comes to accelerated canvas, using the new blocking. r=gw280 2016-02-22 14:23:00 +01:00
Geoff Brown 763998cf8c Bug 1249681 - Set utilityPath for Android mach reftests; r=bdahl 2016-02-19 16:10:22 -07:00
chaithanya 1cea93e0d5 Bug 1243435 Remove unused prefs toolkit.telemetry.prompted / toolkit.telemetry.notifiedOptOut from test suites r=Dexter
MozReview-Commit-ID: 83IOB4Xvf8I
2016-02-18 10:51:24 -08:00
Carsten "Tomcat" Book 3a87a933e7 Backed out changeset 53b0b5b29776 (bug 1243435)
--HG--
extra : rebase_source : faf90230fecdfe1f0150015c039800828723a576
2016-02-17 15:00:51 +01:00
chaithanya 458420bbd7 Bug 1243435 - Remove unused prefs toolkit.telemetry.prompted / toolkit.telemetry.notifiedOptOut from test suite. r=Dexter 2016-02-16 05:11:00 +01:00
Edwin Flores 7d1d94d936 Bug 1229250 - Auto-extend the reftest timeout - r=kats 2016-02-16 14:46:56 +00:00