These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
Normally this sort of change could be filed under "needless churn",
but by appending new files to this list we end up with constant
merge conflicts.
MozReview-Commit-ID: HnaIN2d5fOa
--HG--
extra : rebase_source : b6661417d4e7afeb8e73abe5c2ea15714b4f7dbd
In addition to the way symbols are exposed, this patch makes a few
changes to what is exposed. Unexposing currentOverride and the
error override bitmasks should not cause any problems.
MozReview-Commit-ID: 9CWZHVyAKbg
--HG--
extra : rebase_source : 6411f842c1eec26661cbe6f4d9e821904ffc4811
This does not really functionally change anything, but it prevents
us from polluting the global space in testing/marionette/driver.js.
MozReview-Commit-ID: Guwt3g0lS8q
--HG--
extra : rebase_source : ad2c38e51d54b7c4ead6b8d6a49d05a0dfef7c6c
addon.uninstall would return immediately, not waiting for the
onUninstalled listener event to fire. We can eliminate this race
condition by using a promise that resolves when it fires.
MozReview-Commit-ID: E4Mh797X9n8
--HG--
extra : rebase_source : 473e60cc393553302dcf1a2f7a18d2a45091652f
The error descriptions are rather vague and may obfuscate the
real problem. This changes the messages to be more in line with
the underlying error, and also ensures the original error is propagated.
MozReview-Commit-ID: EjctkgeUgNH
--HG--
extra : rebase_source : be10efb18f581d4643e5f52a982b888a72ef27be
Marionette has quite a complicated system in
testing/marionette/components/marionette.js for support fallback
preferences for earlier Firefoxen. Since Firefox 55 shipped
quite some time ago it is time to remove the fallbacks. This will
significantly simplify the overall complexity of this file.
MozReview-Commit-ID: 5lfstTBVF3N
--HG--
extra : rebase_source : 7e4b68d12c7e7bd33474acb3fcf6f6001fd81341
This introduces a new testing/marionette/prefs.js module with shorthands
for all of Marionette's preferences. Getters are provided for all
preferences, but setters are only offered for preference we expect
to mutate at runtime.
The new module additionally provides a preference abstraction on
top of nsIPrefService instead of Preferences.jsm. We cannot use
Preferences.jsm during startup in Marionette because Marionette
gets loaded unconditionally.
Finally an EnvironmentPrefs class is provided for reading and iterating
over preferences stored in JSON Objects in environment variables.
MozReview-Commit-ID: FbgdBEkf5A
--HG--
extra : rebase_source : 0d5b2f11dc94a74aff3f742ef191b72b159b5ee7
The MarionetteMainProcess#enabled getter returns the value of the
preference so it is more appropriate to use the correct API than
to fetch the preference directly.
MozReview-Commit-ID: 16rpk7rrves
--HG--
extra : rebase_source : d4a4a817ca20f24a99e86aad9fc3d98f12fc05aa
marionette.contentListener is being used for silly purposes in
Marionette to tell us when it is "safe" to reuse a content frame.
It will be removed with https://bugzil.la/marionette-window-tracking
but we should nonetheless keep track of which preferences are used.
MozReview-Commit-ID: 5gMCMuYfLBa
--HG--
extra : rebase_source : 884b9e546dd8dd8786fb9b6a984642ff3cb3dcc2
Marionette has quite a complicated system in
testing/marionette/components/marionette.js for support fallback
preferences for earlier Firefoxen. Since Firefox 55 shipped
quite some time ago it is time to remove the fallbacks. This will
significantly simplify the overall complexity of this file.
MozReview-Commit-ID: 5lfstTBVF3N
--HG--
extra : rebase_source : aee88f5741f624355c4c32eecc18940571d1b8cc
This introduces a new testing/marionette/prefs.js module with shorthands
for all of Marionette's preferences. Getters are provided for all
preferences, but setters are only offered for preference we expect
to mutate at runtime.
The new module additionally provides a preference abstraction on
top of nsIPrefService instead of Preferences.jsm. We cannot use
Preferences.jsm during startup in Marionette because Marionette
gets loaded unconditionally.
Finally an EnvironmentPrefs class is provided for reading and iterating
over preferences stored in JSON Objects in environment variables.
MozReview-Commit-ID: FbgdBEkf5A
--HG--
extra : rebase_source : c3666ff19f4bf8092d9976bbf5e98cd45438e586
The MarionetteMainProcess#enabled getter returns the value of the
preference so it is more appropriate to use the correct API than
to fetch the preference directly.
MozReview-Commit-ID: 16rpk7rrves
--HG--
extra : rebase_source : d4a4a817ca20f24a99e86aad9fc3d98f12fc05aa
marionette.contentListener is being used for silly purposes in
Marionette to tell us when it is "safe" to reuse a content frame.
It will be removed with https://bugzil.la/marionette-window-tracking
but we should nonetheless keep track of which preferences are used.
MozReview-Commit-ID: 5gMCMuYfLBa
--HG--
extra : rebase_source : 884b9e546dd8dd8786fb9b6a984642ff3cb3dcc2
The documentation for the marionette.enabled preference is wrong: it
claims that it is used for disabling the Marionette XPCOM component,
but in reality it starts and stops the TCP server.
MozReview-Commit-ID: 8oQz8HjPnii
--HG--
extra : rebase_source : 7771f02e18457bc5e567553ca921995d95c40bdd
This duplicates documentation under testing/marionette/doc, but
can be useful when inspecting the directory.
MozReview-Commit-ID: 7vuUze1SFib
--HG--
extra : rebase_source : 94f2f4de916e576deffe1b3a23beff392b7bb594
This patch is partly machine generated and partly massaged by hand
to achieve a satisfactory result.
MozReview-Commit-ID: IG46e93KoOb
--HG--
extra : rebase_source : 02f8fa6ec28a737a4151a757f75cf7ae36427e30
There are currently two exceptions from the normal linting rules
that applies to Marionette xpcshell unit tests:
- We use camel-casing for our test names.
- We have many lines longer than 78 characters.
MozReview-Commit-ID: 4MykQujk9lR
--HG--
extra : rebase_source : f73e1a8d205eb34d1463f4805ba0fa806f150081
Now that we test collections upstream in WPT, the overlapping tests
can be removed from the Mn test suite.
MozReview-Commit-ID: DJZHeKs8FDo
--HG--
extra : rebase_source : 3170081c4054141ab6e39d69865f44a3d55f0385
Geoff Brown
Kris Maglione
Maja Frydrychowicz
Brindusan Cristian
Andreas Tolfsen
Andrew Swan
Ciure Andrei
Margareta Eliza Balazs
Andreea Pavel
Boris Zbarsky
Mike de Boer
James Graham
Emilio Cobos Álvarez