Since we've decoupled the writing of the StartupCache from the freeing
of the StartupCache's tables (which takes nontrivial time), this patch
moves the StartupCache's destructor later in shutdown so it will be
skipped in the early _exit(0) efforts. There is a remaining
WaitOnWriteThread in the StartupCache's destructor, but this is a
minor sanity check to avoid use-after-frees in the write thread during
shutdown. In general it won't matter as we already wait for the write
thread in the xpcom-shutdown observer, and if we shut down during write,
the system is set up to be okay with that (because it already happens).
Differential Revision: https://phabricator.services.mozilla.com/D62295
--HG--
extra : moz-landing-system : lando
The initial thought for getting the StartupCache out of the shutdown
path was to simply not write it during shutdown, as it should write
60 seconds after startup, and the theory was that if the user shut
down within the first 60 seconds of use, they were likely updating or
something and it shouldn't matter. However, considering how many of
our users only ever open one tab, I think it's rather likely that
users are starting up firefox to go to a web site, then closing it
when done with that website, and then maybe opening up a new instance
in order to go to a different website. Accordingly it still makes
sense to continue writing it. However, we may as well leverage a
background thread for this and get it kicked off earlier during
shutdown, so we don't sit there blocking in the destructor late
during shutdown.
Differential Revision: https://phabricator.services.mozilla.com/D62294
--HG--
extra : moz-landing-system : lando
2020-02-10 Robert Relyea <rrelyea@redhat.com>
* lib/freebl/cmac.c:
Bug 1610687 - Crash on unaligned CMACContext.aes.keySchedule when
using AES-NI intrinsics r=kjacobs
[046a6f5bfb27]
* lib/util/pkcs11t.h:
Bug 1611209 - Value of CKM_AES_CMAC and CKM_AES_CMAC_GENERAL are
swapped r=rrelyea
[df142975f4f6]
2020-02-11 Victor Tapia <victor.tapia@canonical.com>
* lib/pk11wrap/pk11util.c, lib/sysinit/nsssysinit.c:
Bug 1582169 - Disable reading /proc/sys/crypto/fips_enabled if FIPS
is not enabled on build r=jcj,rrelyea
[55ba54adfcae]
2020-02-11 J.C. Jones <jjones@mozilla.com>
* lib/sysinit/nsssysinit.c:
Bug 1614786 - Fixup for ‘getFIPSEnv’ being unused r=kjacobs
Fixes a regression from Bug 1582169
../../lib/sysinit/nsssysinit.c:153:1: error: ‘getFIPSEnv’ defined
but not used [-Werror=unused-function]
[06925efe306b]
2020-02-11 Dana Keeler <dkeeler@mozilla.com>
* cmd/lib/secutil.c,
lib/libpkix/pkix_pl_nss/module/pkix_pl_colcertstore.c:
bug 1538980 - null-terminate ascii input in SECU_ReadDERFromFile so
strstr is safe to call r=jcj,kjacobs
[735ed2e47040] [tip]
Differential Revision: https://phabricator.services.mozilla.com/D62451
--HG--
extra : moz-landing-system : lando
Same case as the other smooth-scrolling thingies, scroll anchoring is less
prioritary (and is disturbing) in that case.
Also fix the logging code (`WritingMode::DebugString` is no longer a thing).
Differential Revision: https://phabricator.services.mozilla.com/D62050
--HG--
extra : moz-landing-system : lando
GCE instances use Ubuntu 18.04, which is known to cause issues in
valgrind builds (Bug 1545094), while EC2 uses Ubuntu 14.04.
Move valgrind builds back to GCE to avoid perma fail of these jobs.
Differential Revision: https://phabricator.services.mozilla.com/D62552
--HG--
extra : moz-landing-system : lando
AsyncLogger creates a thread that the log messages are pushed and printed. This thread was not stopped and joined after it was used, which created a shutdown crash. This patch will stop the AsyncLogger thread when the capture session has finished.
Differential Revision: https://phabricator.services.mozilla.com/D60978
--HG--
extra : moz-landing-system : lando
Refactored CookiesPanel and PropertiesView to use the shared Accordion. Created request-details/ for the new files.
Removed the old CookiesPanel. Fixed one cookie failing test, by removing the headings which are no longer part of the tree.
Differential Revision: https://phabricator.services.mozilla.com/D62200
--HG--
extra : moz-landing-system : lando
When ToolbarKeyboardNavigator initializes, it sets aria-hidden and adds a focus listener on toolbartabstop elements.
This is necessary for proper functionality of toolbar keyboard navigation.
However, widgets can be dynamically added by CustomizableUI after ToolbarKeyboardNavigator initializes.
The search bar is one such widget and it does contain toolbartabstop elements.
We now watch for this and initialize any toolbartabstop elements inside added widgets.
Differential Revision: https://phabricator.services.mozilla.com/D62178
--HG--
extra : moz-landing-system : lando
Braces on switch statement cases so scopes are limited.
A missing semicolon.
A mixup with infoStrings/errorStrings return value for UpdateLayerTree message.
Differential Revision: https://phabricator.services.mozilla.com/D62406
--HG--
extra : moz-landing-system : lando
The existing code just clipped to a rect. We need to do the same clipping that the non-remote code path does which also handles border radius.
The existing code is the from initial implementation of nsDisplayRemote in https://hg.mozilla.org/mozilla-central/rev/85d06279c8358a8e1c883aa670a20212b1039a90 so I suspect that clipping to the inner view bounds instead of the frame content box is not an important difference.
Differential Revision: https://phabricator.services.mozilla.com/D62180
--HG--
extra : moz-landing-system : lando
* Behavior is behind a false-by-default pref signon.passwordEditCapture.enabled
* Responds to change events on the field (not input)
* New browser-chrome tests for doorhanger behavior when editing (non-generated) password field values
Differential Revision: https://phabricator.services.mozilla.com/D54264
--HG--
extra : moz-landing-system : lando
* No functional changes.
* Rename *GeneratedPasswordFilledOrEdited to *PasswordEditedOrGenerated and pass a 'generated' flag
Differential Revision: https://phabricator.services.mozilla.com/D54263
--HG--
rename : toolkit/components/passwordmgr/test/mochitest/test_LoginManagerContent_generatedPasswordFilledOrEdited.html => toolkit/components/passwordmgr/test/mochitest/test_LoginManagerContent_passwordEditedOrGenerated.html
rename : toolkit/components/passwordmgr/test/unit/test_LoginManagerParent_onGeneratedPasswordFilledOrEdited.js => toolkit/components/passwordmgr/test/unit/test_LoginManagerParent_onPasswordEditedOrGenerated.js
extra : moz-landing-system : lando
Unless editor needs to treat document node, all nodes are sub-class of
`nsIContent`. Therefore, we can make `HTMLEditor::CollectEditTargetNodes()`
return array of `nsIContent` instead of array of `nsINode`.
Differential Revision: https://phabricator.services.mozilla.com/D61970
--HG--
extra : moz-landing-system : lando
Christian Holler
Mike Conley
Jonathan Almeida [:jonalmeida]
Doug Thayer
J.C. Jones
Emilio Cobos Álvarez
Jonathan Kew
Julian Descottes
Mihai Alexandru Michis
Wander Lairson Costa
Simon Giesecke
Nicolas Chevobbe
Alex Chronopoulos
Hubert Boma Manilla
Michal Novotny
Eugen Sawin
Mirko Brodesser
James Teh
Paul Bone
Timothy Nikkel
Nathan Froyd
Sam Foster
Karl Tomlinson
Masayuki Nakano
shindli
Neil Deakin
Eitan Isaacson
Marc Streckfuss
Coroiu Cristina