Jason Laster
4d089aa543
Bug 1536116
- Highlights might not be shown when on the debug line. r=davidwalsh
...
Differential Revision: https://phabricator.services.mozilla.com/D28086
--HG--
extra : moz-landing-system : lando
2019-04-22 15:52:13 +00:00
Derek Li
bcdbd607cf
Bug 1545697 - Fixes right breakpoint pane toggle button r=davidwalsh
...
Reverts change to the Pane Toggle Button from another patch
Differential Revision: https://phabricator.services.mozilla.com/D28171
--HG--
extra : moz-landing-system : lando
2019-04-22 15:55:28 +00:00
Gurzau Raul
52b651e168
Merge inbound to mozilla-central. a=merge
2019-04-20 12:54:53 +03:00
Brian Hackett
9291c6b9cd
Bug 1544170 Part 5 - Add test for viewing styles while replaying.
...
--HG--
extra : rebase_source : 85e999c513a6cf43555412303e339a75a78d82a5
2019-04-19 11:27:14 -10:00
Coroiu Cristina
e687fbf549
Backed out changeset dedf066bfcfc (bug 1538054) for xpcshell failures at devtools/server/tests/unit/test_pause_exceptions-04.js on a CLOSED TREE
2019-04-20 00:09:05 +03:00
jaril
2e143cda16
Bug 1538054 - Toggle off 'Pause on Exception' immediately. r=loganfsmyth
...
After toggling off 'Pause on exceptions' in the debugger, exceptions were still being paused on once.
This was because the server's exception-pausing behavior was not toggled off until an exception was paused on. This patch makes it so that the behavior is changed immediately after unchecking the 'Pause on exceptions' checkbox in the debugger.
Differential Revision: https://phabricator.services.mozilla.com/D27453
--HG--
extra : moz-landing-system : lando
2019-04-19 15:35:53 +00:00
J. Ryan Stinnett
f6228d736f
Bug 1151368
- Add test for DevTools request blocking. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D26582
--HG--
extra : moz-landing-system : lando
2019-04-19 18:25:46 +00:00
J. Ryan Stinnett
4c41f2a87f
Bug 1151368
- Unblock requests by URL in DevTools. r=ochameau
...
This is nearly the same the first patch for blocking, but adds the unblock
option as well.
Differential Revision: https://phabricator.services.mozilla.com/D26581
--HG--
extra : moz-landing-system : lando
2019-04-19 18:25:38 +00:00
J. Ryan Stinnett
cc8110e6ff
Bug 1151368
- Display blocked requests in Network Monitor. r=ochameau,Honza
...
This updates the request list to indicate a request was blocked by marking the
entire request item and also replaces transferred size column with "blocked by
DevTools". In the future, we may show other reasons for blocking in this way,
such as CORS, etc.
Differential Revision: https://phabricator.services.mozilla.com/D26580
--HG--
extra : moz-landing-system : lando
2019-04-19 18:25:29 +00:00
J. Ryan Stinnett
d4c5593416
Bug 1151368
- Block requests by URL in DevTools. r=ochameau
...
This is a very basic form of request blocking for the Network Monitor. It only
supports blocking a request via right-click. This change adds the minimal UI and
server support to block the request.
There is no UI to indicate what happened to the request yet, so it will just
look like a "confused" request that never started. Future patches will improve
from here.
Differential Revision: https://phabricator.services.mozilla.com/D26579
--HG--
extra : moz-landing-system : lando
2019-04-19 18:25:19 +00:00
Jason Laster
bbdcbf072a
Bug 1545594 - Memoize md5. r=loganfsmyth
...
Differential Revision: https://phabricator.services.mozilla.com/D28147
--HG--
extra : moz-landing-system : lando
2019-04-19 16:03:23 +00:00
Logan Smyth
cde6e6feaa
Bug 1541629 - Part 3: Adopt new SourceActor types/actions throughout codebase. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D27958
--HG--
extra : moz-landing-system : lando
2019-04-19 16:07:39 +00:00
Logan Smyth
59376adc13
Bug 1541629 - Part 2: Add a new source-actor action/reducer root type. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D27957
--HG--
extra : moz-landing-system : lando
2019-04-19 16:07:37 +00:00
Logan Smyth
74f51f53d5
Bug 1541629 - Part 1: Create new Resource utility for common Redux state operations. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D27956
--HG--
extra : moz-landing-system : lando
2019-04-19 16:11:47 +00:00
Logan Smyth
502d99561a
Bug 1545796 - Invert emptyLines to breakableLines so we no longer need to rely on source text. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D28202
--HG--
rename : devtools/client/debugger/src/utils/empty-lines.js => devtools/client/debugger/src/utils/breakable-lines.js
rename : devtools/client/debugger/src/utils/tests/empty-lines.spec.js => devtools/client/debugger/src/utils/tests/breakable-lines.spec.js
extra : moz-landing-system : lando
2019-04-19 16:13:45 +00:00
Jason Laster
f2cd91cb30
Bug 1545103 - applyBreakpoint should no longer support fuzzy matches.
...
Differential Revision: https://phabricator.services.mozilla.com/D28203
--HG--
extra : moz-landing-system : lando
2019-04-19 16:07:24 +00:00
Noemi Erli
cf310dc4ad
Backed out changeset 3240b92c5566 (bug 1545103) for failures in test_setBreakpoint-at-the-beginning-of-a-minified-fn.js
2019-04-19 17:29:37 +03:00
Jason Laster
6828479873
Bug 1545103 - applyBreakpoint should no longer support fuzzy matches. r=loganfsmyth
...
Differential Revision: https://phabricator.services.mozilla.com/D27943
--HG--
extra : moz-landing-system : lando
2019-04-19 13:29:50 +00:00
Mrigank Krishan
f2d62fc237
Bug 1540054 - Create fetch request from selection. r=Honza
...
add "Copy as fetch" context menu item
Differential Revision: https://phabricator.services.mozilla.com/D25450
--HG--
extra : moz-landing-system : lando
2019-04-19 09:31:50 +00:00
Brian Hackett
18578fbd02
Bug 1544170 Part 4 - Don't infinitely recurse in newChannelForURL on failure, r=loganfsmyth.
...
Differential Revision: https://phabricator.services.mozilla.com/D27411
--HG--
extra : rebase_source : 658df8227afa78826ef32b63f87e7c0f9554bda2
2019-04-12 16:37:00 -10:00
Brian Hackett
ee403cec34
Bug 1544170 Part 3 - Inspector changes to fetch style sheets from replaying process, r=pbro.
...
Differential Revision: https://phabricator.services.mozilla.com/D27410
--HG--
extra : rebase_source : a70fc90d042f7b9d0fdec65aadff911c90f8edf7
2019-04-12 16:36:12 -10:00
Brian Hackett
a151fd40c6
Bug 1544170 Part 2 - ReplayInspector changes to support showing styles, r=loganfsmyth.
...
Differential Revision: https://phabricator.services.mozilla.com/D27409
--HG--
extra : rebase_source : fa3dde431c55e731c58297bb64dc405c3b8f7dd8
2019-04-12 16:35:18 -10:00
Dorel Luca
928f6e4b9f
Merge mozilla-central to inbound
...
--HG--
extra : rebase_source : 54aeee031a564bbb761eb853f092e26626dd7ee2
2019-04-20 00:46:59 +03:00
Brian Hackett
535c0317a3
Bug 1538781 - Use the right thread for console evaluations when paused in a worker thread's frame, r=nchevobbe.
...
Differential Revision: https://phabricator.services.mozilla.com/D27625
--HG--
extra : rebase_source : 40502542b215c47145deea98bbcf826d61e8bc62
2019-04-15 13:27:53 -10:00
Arpit
474e467436
Bug 1483077 - Replaced reference to getBrowser with gBrowser r=robwu,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D27418
--HG--
extra : moz-landing-system : lando
2019-04-17 00:04:54 +00:00
Cosmin Sabou
6a05dd870e
Backed out 3 changesets (bug 1541629) for devtools failures on browser_dbg-worker-scopes.js. CLOSED TREE
...
Backed out changeset 9fe6de0bfd86 (bug 1541629)
Backed out changeset 0652005f0370 (bug 1541629)
Backed out changeset 5a47374efaa0 (bug 1541629)
2019-04-19 08:53:21 +03:00
Logan Smyth
a7a0145ff2
Bug 1541629 - Part 3: Adopt new SourceActor types/actions throughout codebase. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D27958
--HG--
extra : moz-landing-system : lando
2019-04-18 20:37:14 +00:00
Logan Smyth
24e50f98dd
Bug 1541629 - Part 2: Add a new source-actor action/reducer root type. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D27957
--HG--
extra : moz-landing-system : lando
2019-04-18 20:37:29 +00:00
Logan Smyth
261222227f
Bug 1541629 - Part 1: Create new Resource utility for common Redux state operations. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D27956
--HG--
extra : moz-landing-system : lando
2019-04-18 20:39:09 +00:00
Andreea Pavel
69afeaabd9
Merge mozilla-central to autoland. on a CLOSED TREE
...
--HG--
extra : amend_source : fe25c64f152924b2a06dc54b745943b760b3552c
2019-04-19 06:56:17 +03:00
chujun
4885178299
Bug 1522858 Remove duplication of finding next/previous matching result for keyboard shortcuts
...
Cause of the bug:
In src/components/Editor/index.js, “sourceSearch.search.again.key2” (`CmdOrCtrl+G`) calls `onSearchAgain`, which then calls `this.props.traverseResults`.
In src/components/Editor/SearchBar.js, the same key calls `this.props.traverseResults` as well.
Thus, the same keyboard shortcut calls the same function twice. So does “sourceSearch.search.againPrev.key2” (`CmdOrCtrl+Shift+G`).
In pull request #1656 (https://github.com/firefox-devtools/debugger/pull/1656 ), a feature of double-clicking a text token to highlight it was added. Another feature of using `CmdorCtrl+G` to jump to the next matching result was also added.
The double-clicking feature is no longer here as I observe in the debugger, but the traversing to other matching results function has been kept.
Keyboard shortcuts related to the file search box are all in SearchBar.js. So I decided to keep the one in SearchBar.js, and remove the one in index.js.
Differential Revision: https://phabricator.services.mozilla.com/D27192
--HG--
extra : moz-landing-system : lando
2019-04-18 20:04:34 +00:00
Florens Verschelde
656ad346f2
Bug 1543324 - Part 4: Increase body-color contrast (Light) and apply to fonts.css; r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D27109
--HG--
extra : moz-landing-system : lando
2019-04-17 14:06:59 +00:00
Florens Verschelde
226bc28753
Bug 1543324 - Part 3: Remove --theme-comment-alt variable; r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D27108
--HG--
extra : moz-landing-system : lando
2019-04-18 19:17:03 +00:00
Florens Verschelde
7ae6bf37a2
Bug 1543324 - Part 2: Rename --theme-body-color-* variables to --theme-text-color-*; r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D27107
--HG--
extra : moz-landing-system : lando
2019-04-17 14:06:58 +00:00
Florens Verschelde
83d8ab904d
Bug 1543324 - Part 1: Replace --theme-content-color1,2,3 variables; r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D27106
--HG--
extra : moz-landing-system : lando
2019-04-18 19:18:43 +00:00
Brian Grinstead
9bda39c108
Bug 1519502 - Convert menu bindings to a Custom Element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D19593
--HG--
extra : moz-landing-system : lando
2019-04-18 16:41:46 +00:00
Andreea Pavel
eb0b5758ea
Merge mozilla-central to autoland. on a CLOSED TREE
2019-04-19 00:48:30 +03:00
Andreea Pavel
e5b695eefd
Merge mozilla-inbound to mozilla-central. a=merge
2019-04-19 00:36:23 +03:00
Brian Grinstead
381332c51e
Bug 1544051 - Part 3 - Scripted change to remove references to AddTask.js r=ahal
...
This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672
Differential Revision: https://phabricator.services.mozilla.com/D27761
--HG--
extra : moz-landing-system : lando
2019-04-18 16:51:01 +00:00
Julian Descottes
01f1b67f71
Bug 1544749 - Use toolbox.topWindow in devtools tests relying on toolbox.win.top/parent r=daisuke
...
Depends on D27677
Update tests directly referencing toolbox.win.top/parent.
Differential Revision: https://phabricator.services.mozilla.com/D27680
--HG--
extra : moz-landing-system : lando
2019-04-18 09:06:23 +00:00
Julian Descottes
d2e81fef8f
Bug 1544749 - Sidebar iframe onload callback should not rely on event.target r=daisuke
...
Depends on D27675
The target of the iframe load event is the content document when running in frame with type=chrome.
When running in frame with type=content, the target will be the iframe element itself.
Stop relying on event.target so that the Sidebar can work in both cases
Differential Revision: https://phabricator.services.mozilla.com/D27677
--HG--
extra : moz-landing-system : lando
2019-04-18 09:05:53 +00:00
Julian Descottes
83f2aa351a
Bug 1544749 - Animation inspector scrubber should use getTopWindow r=daisuke
...
Depends on D27672
Differential Revision: https://phabricator.services.mozilla.com/D27675
--HG--
extra : moz-landing-system : lando
2019-04-18 09:05:35 +00:00
Julian Descottes
bbcab0f303
Bug 1544749 - Add shared helper to retrieve the top window r=bgrins
...
Some classes in DevTools will not have an easy way to get access to the toolbox.
However they might still want to use the topmost chrome window.
Extract the logic from toolbox.js to a shared helper.
Differential Revision: https://phabricator.services.mozilla.com/D27672
--HG--
extra : moz-landing-system : lando
2019-04-18 09:06:32 +00:00
Dorel Luca
f5a2c905f4
Backed out 2 changesets (bug 1519502, bug 1528268) for Crashtest failures in toolkit/content/tests/chrome/test_popupincontent.xul. CLOSED TREE
...
Backed out changeset 904cc7903feb (bug 1519502)
Backed out changeset f8770d7eebd1 (bug 1528268)
2019-04-18 18:26:41 +03:00
Daisuke Akatsuka
7aa6ea07da
Bug 1540609: Add a test whether the status of connect button will be reverted after a certain period of time. r=jdescottes
...
Depends on D27645
Differential Revision: https://phabricator.services.mozilla.com/D27646
--HG--
extra : moz-landing-system : lando
2019-04-18 02:54:34 +00:00
Daisuke Akatsuka
fe65454bf0
Bug 1540609: Show the connection timeout message. r=jdescottes,flod
...
Depends on D27645
Differential Revision: https://phabricator.services.mozilla.com/D27845
--HG--
extra : moz-landing-system : lando
2019-04-18 01:33:06 +00:00
Daisuke Akatsuka
a0baec4bc5
Bug 1540609: Revert the status of connect button after a certain period of time. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D27645
--HG--
extra : moz-landing-system : lando
2019-04-18 02:54:36 +00:00
Daisuke Akatsuka
f145a56427
Bug 1539328: Introduce new unique id for service worker actor. r=jdescottes
...
Depends on D25771
Differential Revision: https://phabricator.services.mozilla.com/D25772
--HG--
extra : moz-landing-system : lando
2019-04-18 00:47:37 +00:00
Daisuke Akatsuka
6f3ba76797
Bug 1539328: Introduce new unique id for normal worker actor. r=jdescottes,bhackett
...
Depends on D25207
Differential Revision: https://phabricator.services.mozilla.com/D25771
--HG--
extra : moz-landing-system : lando
2019-04-18 00:47:24 +00:00
Daisuke Akatsuka
c21d56872c
Bug 1539328: Introduce getWorker(id) to RootFront to avoid re-using client debugger. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D25207
--HG--
extra : moz-landing-system : lando
2019-04-18 00:45:20 +00:00