`beforeinput` event was shipped and it won't be disabled for avoiding confusion
of web developers. So, we can drop the pref setting of
"dom.input_events.beforeinput.enabled" in our tests.
Depends on D119716
Differential Revision: https://phabricator.services.mozilla.com/D119729
It was enabled in bug 1712633 by mistake.
Because there wasn't a way to distinguish esr yet, we add one, and while
at it, expose it to the build system.
Differential Revision: https://phabricator.services.mozilla.com/D119682
Now, `nsIFrame::HandleEvent` moves selection at middle mouse button down. This
occurs before dispatching the event into the system event group. Therefore,
`AutoScrollChild` cannot prevent it.
On the other hand, Chrome does not start autoscroll when a modifier is pressed.
This means that our users may not be able to use middle click with modifiers
if web apps do not call `preventDefault()` as expected. So, this difference
is a potential risk of web-compat.
Therefore, this patch makes `AutoScrollChild` stop starting autoscroll if
`Shift` key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D119253
When the Mozilla PDF printer is selected, a new settings object was created without the value of isPrintSelectionRBEnabled computed.
Differential Revision: https://phabricator.services.mozilla.com/D119578
ServiceWorkerCleanUp's host based cleaning has not correctly been
checking whether the provided host is a root domain of the ServiceWorker
registration, instead performing an exact match (which is what
removeFromPrincipal does).
This check makes the logic consistent with other deleteByHost
implementations and is actually using the same check logic.
Differential Revision: https://phabricator.services.mozilla.com/D111992
Removing the following vars from common.inc.css
- `--in-content-button-border-radius`
- `--in-content-button-horizontal-padding`
- `--in-content-button-vertical-padding`
Differential Revision: https://phabricator.services.mozilla.com/D119190
UnifiedComplete must stick around to serve as an mozIPlacesAutoComplete implementation for XUL consumers like search.js and privacy.js.
Differential Revision: https://phabricator.services.mozilla.com/D119306
Apologies in advance for this review. It's the test I've had to rewrite the most. This is because the unifiedcomplete tests did not care about sorting, and urlbar tests do. Since this test does some complicated stuff with frecency, many of the expected matches had to be reordered in the test. The old test just listed all the uris in descending order in `matches`, paying no mind to frecency. As I've been doing with other tests, I reversed the order which with they are added to history/bookmarks, to reduce the number of changes required in the sets of expected matches.
That yielded this order, in descending order of frecency:
uri11
uri1
uri4
uri6
uri5
uri7
uri8
uri9
uri10
uri12
uri2
uri3
Differential Revision: https://phabricator.services.mozilla.com/D119113
browser_aboutPrefs_backgroundUpdateSetting.js was broken by the changes made in Bug 1712778. This patch brings the test up-to-date with that change.
Differential Revision: https://phabricator.services.mozilla.com/D119421
There are two substantive changes to test_protocol_swap worth pointing out:
1. Some subtests now search for <protocol>://sit instead of <protocol>://site. This is because the latter would make the heuristic result the same as the relevant history result and the history result would be deduped. We would thus lose test coverage for that history result.
2. Tests that expected allMatches no longer expect uri5. The muxer dedupes https://www. URLs in favour of https:// URLs.
Depends on D118636
Differential Revision: https://phabricator.services.mozilla.com/D118637
The last few subtests in test_tags_returnedInSearches.js got substantive changes. This is because urlbar tests reflect the results actually shown in the Urlbar and unifiedcomplete tests just tested what came out of UnifiedComplete. Those last few subtests tested that we show non-matching tags. While UnifiedComplete returns those non-matching tags, UrlbarProviderUnifiedComplete has filtered them out since bug 1522226.
Differential Revision: https://phabricator.services.mozilla.com/D118635
This implements Jamie's suggested fixes for a screenreader issue when the
skeleton UI is enabled. Most of the work here is just pulling out pieces from the
files we needed to include in mozglue so that any references to, say, nsString
or other pieces from libxul either no longer exist or are only included when
building libxul. In a few cases this meant creating whole files to house single
functions, which isn't so pretty, but it was the best I could come up with to
get the job done.
Differential Revision: https://phabricator.services.mozilla.com/D117663
This implements Jamie's suggested fixes for a screenreader issue when the
skeleton UI is enabled. Most of the work here is just pulling out pieces from the
files we needed to include in mozglue so that any references to, say, nsString
or other pieces from libxul either no longer exist or are only included when
building libxul. In a few cases this meant creating whole files to house single
functions, which isn't so pretty, but it was the best I could come up with to
get the job done.
Differential Revision: https://phabricator.services.mozilla.com/D117663
Without this change, Normandy migrations could take longer to run than the UI took to start up, and so the UI ready notification would be sent before the listener was set up. This caused Normandy to sometimes never initialize, especially right after an upgrade.
Differential Revision: https://phabricator.services.mozilla.com/D119236
unload listeners aren't reliable at the best of time, and for about: pages they
seem to never fire in my testing. There is no weakref-based listener setup for
prefs in JS and I don't want to build one, so this makes the prefs display in
about:telemetry only update on render, not live.
Differential Revision: https://phabricator.services.mozilla.com/D119285
This patch adds a timeout to make sure all the pending telemetry data
is aggregated in the parent process when we clear it.
Differential Revision: https://phabricator.services.mozilla.com/D118168
We need to first add the scrolling metrics (scrolling_time and scrolling_distance) to the DB so we can complete the capturing and tests for those metrics (see Bug 1717920)
Differential Revision: https://phabricator.services.mozilla.com/D119119
We need to clear the lists once the test is finished. This patch adds a
method in nsIURLQueryStrippingListService to do that.
Differential Revision: https://phabricator.services.mozilla.com/D117377
The URLQueryStrippingListService will get initialized too late in
Fission because the 'profile-after-change' won't be triggered for
content processes in Fission. So, it won't have a complete list when the
query stripping happens because it will be initalized by then.
To address this issue, we add a content process script which will run
during the creation of content processes and it will get the service to
initialize it early so that we will have a complete list when doing the
stripping.
Differential Revision: https://phabricator.services.mozilla.com/D117376
The patch adds additional checks for doing stripping in content
processes to verify that the lists will be updated even in the content
process.
Differential Revision: https://phabricator.services.mozilla.com/D117056
Because the remote setttings update would only happen in the parent
process, so we need to send the update result to the content process.
The parent-side URLQueryStrippingListService will broadcast the remote
setting lists once it get the update from the remote settings. The
serivce in content processes will listen to the message and update the
lists in the content processes.
Differential Revision: https://phabricator.services.mozilla.com/D117055
Because the URLQueryStringStripper will no longer access the pref
directly. We need to use the gTest and make it to wait the pref change
been set to the stripper to do the test properly.
Differential Revision: https://phabricator.services.mozilla.com/D116849
The URLQueryStrippingListService will handle the update of all lists
either from prefs or remote settings. So, URLQueryStringStripper no
longer needs to observe the change of the prefs. Instead, it will rely
on URLQueryStrippingListService to get the updated lists.
Differential Revision: https://phabricator.services.mozilla.com/D116599
This patch implements URLQueryStrippingListService which is responsible
for monitoring the list of query stripping on remote settings and prefs.
Differential Revision: https://phabricator.services.mozilla.com/D116598
Our Windows Error Reporting runtime module seems to be notified of all
sorts of non-fatal exceptions. Since there is no documentation clarifying
how to tell them apart from actual crashes we'll try using the bIsFatal
field in the WER_RUNTIME_EXCEPTION_INFORMATION structure for this
purpose. There is no documentation describing the contents of the field
so we can only assume that what its name implies is what we're looking
for.
Differential Revision: https://phabricator.services.mozilla.com/D118813
During a `TextControlState` alive, `PasswordMaskData` should be alive too.
Otherwise, we cannot keep unmasked range at reframing.
Depends on D118756
Differential Revision: https://phabricator.services.mozilla.com/D118757
We can't rely on the Children list since it may have been cleared on shutdown.
Since we don't clear parent edges, walking the parent chain and using
mChildOffset works.
Differential Revision: https://phabricator.services.mozilla.com/D118384
We can't rely on the Children list since it may have been cleared on shutdown.
Since we don't clear parent edges, walking the parent chain and using
mChildOffset works.
Differential Revision: https://phabricator.services.mozilla.com/D118384
Marco Bonardo
Tooru Fujisawa
Masayuki Nakano
Mike Hommey
Matthew Noorenberghe
Eden Chuang
Sam Foster
Marian-Vasile Laza
Paul Zuehlcke
Michael Cooper
Bernard Igiri
Johann Hofmann
Harry Twyford
Nika Layzell
Nicolas Chevobbe
Andrei Oprea
Ava Katushka ava8katushka
Neil Deakin
Butkovits Atila
Mike Kaply
Rob Wu
Alexandru Michis
Kirk Steuber
Dorel Luca
Adam Gashlin
Sandor Molnar
Emilio Cobos Álvarez
Mark Striemer
Doug Thayer
Michelle Goossens
Narcis Beleuzu
Nihanth Subramanya
Steve Fink
Itiel
Chris H-C
Kate Hudson
Dimi Lee
Andrew Creskey
Stefan Zabka
Csoregi Natalia
Tim Huang
Brendan Dahl
Gabriele Svelto
Sebastian Hengst
Niklas Goegge
Gijs Kruitbosch
Kashav Madan
Shane Caraveo