Граф коммитов

5852 Коммитов

Автор SHA1 Сообщение Дата
Eric Rahm 124379887c Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.

Differential Revision: https://phabricator.services.mozilla.com/D63745

--HG--
extra : moz-landing-system : lando
2020-02-24 19:26:40 +00:00
Cosmin Sabou 55035cb007 Bug 1617542 - Revert changes to ipc/mscom/Interceptor.cpp.
CLOSED TREE

--HG--
extra : amend_source : a8e95fac8fa4f351fd6c27398046cfd61b832f6c
2020-02-24 19:35:46 +02:00
Simon Giesecke df538d9a79 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
2020-02-24 17:08:30 +00:00
Sylvestre Ledru ca6530131a Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,kvark
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D63787

--HG--
extra : moz-landing-system : lando
2020-02-24 15:33:38 +00:00
Bob Owen 481aab9295 Bug 1598585 Part 1: Make CanvasTranslator the PCanvas parent actor. r=mattwoodrow
We want to be able to send IPC messages from the translation in the parent. So
the simplest thing it move the top level actor parts of CanvasParent into
CanvasTranslator.
This patch also moves the canvas thread management parts out into a new
CanvasThreadHolder class and hopefully makes the lifecycle management of these
much more robust. This includes the use of a TaskQueue per CanvasTranslator to
manage serial processing on the canvas workers, instead of a boolean.

Differential Revision: https://phabricator.services.mozilla.com/D60887

--HG--
rename : gfx/layers/ipc/CanvasParent.cpp => gfx/layers/ipc/CanvasThread.cpp
rename : gfx/layers/ipc/CanvasParent.h => gfx/layers/ipc/CanvasThread.h
rename : gfx/layers/CanvasTranslator.cpp => gfx/layers/ipc/CanvasTranslator.cpp
rename : gfx/layers/CanvasTranslator.h => gfx/layers/ipc/CanvasTranslator.h
extra : moz-landing-system : lando
2020-02-24 11:15:41 +00:00
Tom Ritter c660f80b38 Bug 1610017 - Actually taint data when tainted is specified for IPC methods r=nika
Differential Revision: https://phabricator.services.mozilla.com/D60532

--HG--
extra : moz-landing-system : lando
2020-02-21 17:24:17 +00:00
Michael Froman e5696f1486 Bug 1611290 - Windows sandbox for socket process. r=bobowen
Differential Revision: https://phabricator.services.mozilla.com/D62772

--HG--
extra : moz-landing-system : lando
2020-02-21 15:49:54 +00:00
Dave Townsend 6d32b7af50 Bug 1531475: Drop the greomni and appomni command line arguments. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D58851

--HG--
extra : moz-landing-system : lando
2020-01-07 14:29:50 +00:00
Simon Giesecke 9350e6b741 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Gabriele Svelto c2f8e56536 Bug 1616262 - Prevent the main process from crashing in response to an early GPU/VR/Socket/RDD process crash r=froydnj
Previously we passed a potentially NULL pointer to
CrashReporterHost::FinalizeOrphanedMinidump() which always assumed it to be
non-NULL. This patch solves the issue but preventing the pointer from being
NULL and making CrashReporterHost::GenerateCrashReport() infallible. In the
case we fail to take a minidump the only visible effect will be that the
minidump ID will be empty, and existing code already expects and handles this
scenario correctly.

Differential Revision: https://phabricator.services.mozilla.com/D63179

--HG--
extra : moz-landing-system : lando
2020-02-19 10:40:29 +00:00
Dorel Luca d5f9df8ee1 Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke 59b23375c0 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
David Teller f4fcc09d90 Bug 1605072 - Rewriting ContentParent::GetNewOrUsedBrowserProcess;r=nika
Differential Revision: https://phabricator.services.mozilla.com/D60499

--HG--
extra : moz-landing-system : lando
2020-02-18 18:53:17 +00:00
Jed Davis ee171b6406 Bug 1615155 - Don't generate default `Recv__delete__` if there are args. r=nika
The default method implementations cause problems when trying to
override them with different types in a direct call class.

For the `Recv__delete__` case there's a simple solution: omit it if
there are any arguments, because it doesn't make much sense to specify
arguments and then completely ignore them, and the no-arg case isn't a
problem for overriding.

Differential Revision: https://phabricator.services.mozilla.com/D62977

--HG--
extra : moz-landing-system : lando
2020-02-18 20:46:21 +00:00
Valentin Gosu 1ced192f38 Bug 1607460 - Align with Cross-Origin-Opener-Policy changes r=michal
See: https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e/f39cac7bf3a8a894059879f15c5b7b41f0195e29
The definition of the header is now:
Cross-Origin-Opener-Policy = %s"same-origin" / %s"same-origin-allow-popups" / %s"unsafe-none"; case-sensitive

Differential Revision: https://phabricator.services.mozilla.com/D60480

--HG--
extra : moz-landing-system : lando
2020-02-18 16:39:08 +00:00
Arthur Iakab d5dfd41c95 Backed out 2 changesets (bug 1605072) for causing reftest failures with splitText-normalize.html.
CLOSED TREE

Backed out changeset f9d038830cda (bug 1605072)
Backed out changeset 9431489d2688 (bug 1605072)
2020-02-18 17:58:31 +02:00
David Teller e5af5aaf62 Bug 1605072 - Rewriting ContentParent::GetNewOrUsedBrowserProcess;r=nika
Differential Revision: https://phabricator.services.mozilla.com/D60499

--HG--
extra : moz-landing-system : lando
2020-02-18 14:02:01 +00:00
shindli bc91508b05 Backed out 2 changesets (bug 1605072) for causing reftest failures in layout/reftests/selection/splitText-normalize-ref.html CLOSED TREE
Backed out changeset 973f1e5baebf (bug 1605072)
Backed out changeset 038b50303733 (bug 1605072)
2020-02-17 21:39:58 +02:00
David Teller 361a4f6284 Bug 1605072 - Rewriting ContentParent::GetNewOrUsedBrowserProcess;r=nika
Differential Revision: https://phabricator.services.mozilla.com/D60499

--HG--
extra : moz-landing-system : lando
2020-02-17 17:31:32 +00:00
Simon Giesecke ce6596707f Bug 1613854 - De-virtualize IPDL protocol methods in ActorsChild. r=dom-workers-and-storage-reviewers,janv,jld
Differential Revision: https://phabricator.services.mozilla.com/D61991

--HG--
extra : moz-landing-system : lando
2020-02-17 14:49:27 +00:00
Mihai Alexandru Michis 13d11ce14a Backed out changeset 98a47607bb61 (bug 1613854) for causing sm failures in PBackgroundIDBCursorChild.cpp
CLOSED TREE
2020-02-17 16:03:20 +02:00
Simon Giesecke 45e6ce251e Bug 1613985 - Use default for equivalent-to-default constructors/destructors in ipc. r=jld
Differential Revision: https://phabricator.services.mozilla.com/D62583

--HG--
extra : moz-landing-system : lando
2020-02-14 00:57:39 +00:00
Simon Giesecke 7e65d8de67 Bug 1613854 - De-virtualize IPDL protocol methods in ActorsChild. r=dom-workers-and-storage-reviewers,janv,jld
Differential Revision: https://phabricator.services.mozilla.com/D61991

--HG--
extra : moz-landing-system : lando
2020-02-14 00:58:53 +00:00
Thinker Li 754d3e61c7 Bug 1609881 - Part 2: Move fork server launcher to final-ui-startup. r=gsvelto
Accessing StaticPrefs at xpcom-startup is too early to cause the
initialization of it.  The preferences from user.js and profile are
not load yet.  So, later, it would cause error of changing the value
of static prefs that is marked as mirroring once.

Differential Revision: https://phabricator.services.mozilla.com/D62866

--HG--
extra : moz-landing-system : lando
2020-02-14 16:50:00 +00:00
Coroiu Cristina fc53596ca3 Backed out 2 changesets (bug 1598068) for build bustage at ShowSSEConfig on a CLOSED TREE
Backed out changeset 5fb8d24977eb (bug 1598068)
Backed out changeset eba60d849030 (bug 1598068)
2020-02-14 00:48:07 +02:00
James Willcox 5a405a1191 Bug 1598068 - Add ashmem abstraction to mozglue and use it everywhere r=glandium,jld
Apps targeting SDK 29 are not allowed to open /dev/ashmem directly, and
instead must use NDK functions. Those functions are only available in
SDK 26 and higher, so we need this shim to use the functions if they
are available, else fallback to opening /dev/ashmem directly.

Differential Revision: https://phabricator.services.mozilla.com/D61012

--HG--
extra : moz-landing-system : lando
2020-02-13 22:17:05 +00:00
Simon Giesecke b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
Chris Martin c7f4247786 Bug 1604412 - Enable remote backbuffer GDI compositing r=jmathies,jld
This change adds new "remote backbuffer" logic when compositing without
HW acceleration on Windows (IE compositing through Cairo using the Win32
GDI)

A new piece of shared memory is created between the GPU process and the UI
process, and the GPU process sends requests to the UI process to first "borrow"
a properly-sized buffer to draw into, and then sends a "present" request to
tell the UI process to actually blit the buffer to the Win32 window.

This is needed for the GPU sandbox to work, since Windows rightly doesn't
allow the untrusted GPU process to directly draw the contents of a window
owned by the trusted UI process.

Differential Revision: https://phabricator.services.mozilla.com/D61370

--HG--
extra : moz-landing-system : lando
2020-02-13 14:32:37 +00:00
Masatoshi Kimura aedbf36959 Bug 1614814 - Stop using fopen in ipc/chromium/src/base/process_util.h on Windows. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D62507

--HG--
extra : moz-landing-system : lando
2020-02-13 12:35:40 +00:00
Csoregi Natalia 9c0442f988 Backed out changeset 71e63781b38c (bug 1604412) for failures on /browser_startup_syncIPC.js -PCompositorWidget. CLOSED TREE 2020-02-13 12:13:06 +02:00
Chris Martin 90a7dd97e9 Bug 1604412 - Enable remote backbuffer GDI compositing r=jmathies,jld
This change adds new "remote backbuffer" logic when compositing without
HW acceleration on Windows (IE compositing through Cairo using the Win32
GDI)

A new piece of shared memory is created between the GPU process and the UI
process, and the GPU process sends requests to the UI process to first "borrow"
a properly-sized buffer to draw into, and then sends a "present" request to
tell the UI process to actually blit the buffer to the Win32 window.

This is needed for the GPU sandbox to work, since Windows rightly doesn't
allow the untrusted GPU process to directly draw the contents of a window
owned by the trusted UI process.

Differential Revision: https://phabricator.services.mozilla.com/D61370

--HG--
extra : moz-landing-system : lando
2020-02-13 03:59:13 +00:00
shindli 91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Thinker Li 47a47a3233 Bug 1609881 - Part 1: put the fork server behind a preference. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D61141

--HG--
extra : moz-landing-system : lando
2020-02-12 16:57:39 +00:00
Simon Giesecke f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
David Major c4e3b2d209 Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.

Differential Revision: https://phabricator.services.mozilla.com/D62327

--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
Nika Layzell c56289e054 Bug 1557739 - Be more consistent with IPC Transport APIs, r=jld
Differential Revision: https://phabricator.services.mozilla.com/D60285

--HG--
extra : moz-landing-system : lando
2020-02-06 22:41:56 +00:00
Jean-Yves Avenard 887d964fff Bug 1606901 - P2. Abort should we failed at creating IPCStreamSource. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D61367

--HG--
extra : moz-landing-system : lando
2020-02-04 21:58:50 +00:00
Jean-Yves Avenard ada26188cc Bug 1606901 - P1. Don't assume that nsIAsyncInputStream are always non-blocking. r=baku
From the documentation:
" While this interface is almost exclusively used with non-blocking streams, it is not necessary that nsIInputStream::isNonBlocking return true"

So we can't assume that a nsIAsyncInputStream is always non-blocking. Handle the case where it is.

Differential Revision: https://phabricator.services.mozilla.com/D61368

--HG--
extra : moz-landing-system : lando
2020-02-03 14:07:06 +00:00
Simon Giesecke b7632583c7 Bug 1539498 - Make SerializedStructuredCloneBuffer move-only. r=asuth,jld,baku
Replace all implicit copies by moves, or explicit clone operations.

Fixed a bug in /home/simon/work/ipdl/ipc/ipdl/ipdl/lower.py _cxxConstRefType,
which caused the const accessor to miss const on its return type for a moveonly
struct member.

Removed unused using directives for SerializedStructuredCloneBuffer in ipdl files.

Differential Revision: https://phabricator.services.mozilla.com/D59742

--HG--
extra : moz-landing-system : lando
2020-02-01 15:16:43 +00:00
Simon Giesecke f811929ab1 Bug 1545196 - Avoid copying large RequestParams sub-object in ObjectStoreAddOrPutRequestOp. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59726

--HG--
extra : moz-landing-system : lando
2020-02-01 15:26:37 +00:00
Oana Pop Rus 3e5b57f2d3 Backed out 3 changesets (bug 1539498, bug 1545196) for build bustages failures in DOMTypes.h on a CLOSED TREE
Backed out changeset 0f906da3634a (bug 1539498)
Backed out changeset ccc2f1aad57a (bug 1545196)
Backed out changeset 15e8d9547568 (bug 1545196)
2020-02-01 17:06:28 +02:00
Simon Giesecke 3c2df87890 Bug 1539498 - Make SerializedStructuredCloneBuffer move-only. r=asuth,jld,baku
Replace all implicit copies by moves, or explicit clone operations.

Fixed a bug in /home/simon/work/ipdl/ipc/ipdl/ipdl/lower.py _cxxConstRefType,
which caused the const accessor to miss const on its return type for a moveonly
struct member.

Removed unused using directives for SerializedStructuredCloneBuffer in ipdl files.

Differential Revision: https://phabricator.services.mozilla.com/D59742

--HG--
extra : moz-landing-system : lando
2020-02-01 14:31:56 +00:00
Simon Giesecke a5c085c1e1 Bug 1545196 - Avoid copying large RequestParams sub-object in ObjectStoreAddOrPutRequestOp. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59726

--HG--
extra : moz-landing-system : lando
2020-02-01 12:53:06 +00:00
shravanrn@gmail.com 77d72088ad Bug 1610994 - Update rlbox wasm library preload and paths to work on Mac r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D61079

--HG--
extra : moz-landing-system : lando
2020-02-01 10:38:29 +00:00
Doug Thayer 185e25fddf Bug 1606880 - Implement fast shutdown prefs r=froydnj
I originally had this as a few patches, but the work to fix test
failures and get the whole thing into a complete working state
quickly tangled them up. Apologies for that. To summarize what's
going on here, however:

- We introduce two prefs: shutdown.fastShutdownStage and
  shutdown.lateWriteChecksStage. The latter pref is set to 1, which
  will leave the existing late write checking behavior unchanged.
  However, we introduce this pref to make it simpler in the future
  to bump the late write checks window earlier in the shutdown cycle.
- We introduce an AppShutdown class, which will house static methods
  and a small amount of state for unifying some shutdown logic. Most
  importantly, it will now manage the state for app initiated restarts,
  as well as the logic for performing a safe fast shutdown.
- We refactored the existing restart code to call into the new
  AppShutdown file, so that if we are configured to actually perform
  a fast shutdown, we will be able to run the necessary restart logic
  immediately before doing so. Previously, the restart logic occurred
  later in the shutdown cycle than our late write checking, meaning
  if we were to simply exit the process at that point in time, we
  would never run the restart coe.
- Lastly, we updated two locations which called TerminateProcess and/or
  _exit(0) to call into the AppShutdown method (DoFastShutdown).

Differential Revision: https://phabricator.services.mozilla.com/D59196

--HG--
extra : moz-landing-system : lando
2020-01-29 12:29:43 +00:00
Jed Davis b622dd732e Bug 1607153 - Remove the incorrect extra close of IPC channel client_pipe_. r=froydnj
It's no longer safe to try closing client_pipe_ when the I/O thread is
woken up with data from the child process, because that can race with the
launch thread doing its own close, and it's also unnecessary because of
that other close.  See also bug 1607153 comment #2.

Differential Revision: https://phabricator.services.mozilla.com/D60627

--HG--
extra : moz-landing-system : lando
2020-01-25 04:13:22 +00:00
Jed Davis 5da5bf3e63 Bug 1611547 - Fix MacProcessLauncher to close the IPC client pipe. r=froydnj
MacProcessLauncher overrides DoFinishLaunch from PosixProcessLauncher,
but doesn't call the superclass method, so CloseClientFileDescriptor is
never called on the channel.

Currently this doesn't cause any obvious problems, because the channel
object redundantly closes the fd when it first reads data from the child
process; however, that extra close is thread-unsafe and being removed in
bug 1607153.

Trying to fix bug 1607153 without this patch caused a number of test
suites to fail by timing out, probably because the extra copy of the
client (child) end of the pipe causes the server (parent) end to never
get an end-of-file or broken pipe error during shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D61050

--HG--
extra : moz-landing-system : lando
2020-01-28 12:56:46 +00:00
Perry Jiang c2250891d2 Bug 1264175 - remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky
isReload is no longer a property defined by the FetchEvent specification.

Differential Revision: https://phabricator.services.mozilla.com/D60774

--HG--
extra : moz-landing-system : lando
2020-01-25 00:05:12 +00:00
Gabriele Svelto f40b611e19 Bug 1610566 - Prevent child processes crashing before the exception-handler is in place from triggering an assertion in the parent process r=froydnj
This also adds an explicit warning when this happens so that the child processes don't crash without leaving a trace.

Differential Revision: https://phabricator.services.mozilla.com/D60650

--HG--
extra : moz-landing-system : lando
2020-01-23 21:33:37 +00:00
Andrea Marchesini c4d5364f80 Bug 1610020 - BroadcastChannel + wasm - part 5 - RefMessageBody for BroadcastChannels, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D60321

--HG--
extra : moz-landing-system : lando
2020-01-24 08:00:08 +00:00