Changing the units roundTripTime is reported in from milliseconds to seconds
Differential Revision: https://phabricator.services.mozilla.com/D19544
--HG--
extra : moz-landing-system : lando
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
For some reason that I could not figure out, usage of any https host in these getUserMedia mochitests
on Android causes a network proxy error and will, in this particular case, lead to the iframe not
loading the test page. This causes our test to timeout.
I don't think testing https here is particularly important, and so I'd rather save some
effort for myself and just remove it.
Differential Revision: https://phabricator.services.mozilla.com/D16538
--HG--
extra : moz-landing-system : lando
Removes RTP stat field isRemote and adds the new types remote-inbound-rtp, and remote-outbound-rtp
Differential Revision: https://phabricator.services.mozilla.com/D15068
--HG--
extra : moz-landing-system : lando
Removes RTP stat field isRemote and adds the new types remote-inbound-rtp, and remote-outbound-rtp
Differential Revision: https://phabricator.services.mozilla.com/D15068
--HG--
extra : moz-landing-system : lando
This initializes a one of the stats that lost its default initialization when it was changed from an Atomic to a plain old int.
Differential Revision: https://phabricator.services.mozilla.com/D14978
--HG--
extra : moz-landing-system : lando
This patch moves all UA Widget calls to helper functions in Element.cpp. The helper function AttachAndSetUAShadowRoot sets the shadow root in a runnable, so that it is in the same order of NotifyUAWidget* runnables.
Differential Revision: https://phabricator.services.mozilla.com/D13479
--HG--
extra : moz-landing-system : lando
The RTCP timestamps have different timebases and reporting sources, this makes the source and timebase the same for all RTCP stats
Differential Revision: https://phabricator.services.mozilla.com/D7354
--HG--
extra : moz-landing-system : lando
This patch move the actual widget construction to a onsetup method, allow UAWidgetsChild to hold the reference of the widget instance even if the actual setup (happens in the onsetup call) throws. With the reference of the widget kept, UAWidgetsChild will finally able to call its destructor later on.
Depends on D13607
Differential Revision: https://phabricator.services.mozilla.com/D13608
--HG--
extra : moz-landing-system : lando
This does what's done in bug 1505547 but in a different way. For some reason, access
shadowRoot.host in the function can trigger an assertion.
this.video is a Proxy so it cannot be compared, but all its methods are proxied.
Differential Revision: https://phabricator.services.mozilla.com/D15767
--HG--
extra : moz-landing-system : lando
This can conceal real bugs. Tests should be fixed so they don't risk calling
getPixel in invalid states instead.
Differential Revision: https://phabricator.services.mozilla.com/D9100
--HG--
extra : moz-landing-system : lando
The fake H.264 GMP encoder creates dummy frames that can't be decoded by anything but the fake GMP decoder.
Differential Revision: https://phabricator.services.mozilla.com/D12537
--HG--
extra : moz-landing-system : lando
Bug 1489040 - P1 - Update WebRTC ICE candidate stats field ipAddress to new name, address
Bug 1489040 - P2 - adjust WebRTC stats mochitest for new stat name 'address'
Bug 1489040 - P3 - add test for legacy WebRTC stat names
Differential Revision: https://phabricator.services.mozilla.com/D5560
--HG--
extra : moz-landing-system : lando
1185191.html loads a URI on finishing the test, which can race with the
crashtest framework loading another URI on test finish. This patch fixes
that race.
Differential Revision: https://phabricator.services.mozilla.com/D11662
--HG--
extra : moz-landing-system : lando
The VP8SimulcastAdapter automatically handles cropping to accomodate
constraints on VP8 simulcast streams that each stream have exactly half the
width and height of the higher resolution stream before it.
This also adjusts min_bitrate_estimate in
test_peerConnection_simulcastOddResolution.html to compensate for changes in
the simulcast resolutions chosen by the webrtc.org code.
Differential Revision: https://phabricator.services.mozilla.com/D7482
--HG--
extra : rebase_source : b7ea403f7c9d6175a34eb11c7af17dd12ee55c31
This has never been specced and is unused appart from our tests.
Differential Revision: https://phabricator.services.mozilla.com/D10082
--HG--
extra : rebase_source : c044f11325ec630dcabb673c85531a2283ff6ad4
extra : source : db3c2a88f79cb28440f4e13bcf27c5165c6ee060
This has never been specced and is unused appart from our tests.
Differential Revision: https://phabricator.services.mozilla.com/D10082
--HG--
extra : rebase_source : 4c54d808fb69c0e403ff2e1775b97571889efca4
extra : histedit_source : bc568066b0684bb82b4f553b99f0dd48212aa633
The limit only applied within a child process.
However, within a child process we already share cubeb stream when requesting
the same device multiple times, and disallow capturing from more than one device
at a time.
This limit no longer has any effect.
Differential Revision: https://phabricator.services.mozilla.com/D10339
--HG--
extra : moz-landing-system : lando
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.
Differential Revision: https://phabricator.services.mozilla.com/D8739
--HG--
extra : moz-landing-system : lando
Android no longer seems to generate the mysterious 2085978496000 timestamps, so we can run these tests on Android again.
Differential Revision: https://phabricator.services.mozilla.com/D9356
--HG--
extra : rebase_source : 2571912ad85c5dfba2cf565f27836a8e26e3739d
extra : histedit_source : 22e4c18feb2e7a258b68b7df1b85582e7ed2e318
One of the commented-out test cases is failing (bug 1495446), so temporarily log an info() statement until bug 1495446 is fixed.
Differential Revision: https://phabricator.services.mozilla.com/D9355
--HG--
extra : rebase_source : afae17d6862536cffb9d08429af788a3aaae26c0
extra : histedit_source : 7700e1a3eaa21a62b0da0bd2f9ebe7877bb2b161
The Windows clock drift allowance was originally added for Windows XP (in bug 979649). I removed it in https://hg.mozilla.org/mozilla-central/rev/a1f769e90937 but it appears Windows 7 has the same clock drift problem that XP had.
Differential Revision: https://phabricator.services.mozilla.com/D9354
--HG--
extra : rebase_source : b3171b2fed1da141e62e0344527bba2dfef6e81a
extra : histedit_source : 273376a88d60c5bf820deb91f8c5f91e00aba292
Create a new mochitest that suspends enumerateDevice(). This can happen when the current window navigates away. This is achieved by using an iframe to enumerate devices and clearing the iframe window before the promise is resolved.
Differential Revision: https://phabricator.services.mozilla.com/D2709
--HG--
extra : moz-landing-system : lando
Adding local-candidate and remote-candidate tests to the test_peerConnection_stats
Differential Revision: https://phabricator.services.mozilla.com/D5123
--HG--
extra : moz-landing-system : lando
Increasing the threshold for 'sane' for the pliCount stat to account for mochi tests running on a burdened machine
Differential Revision: https://phabricator.services.mozilla.com/D5116
--HG--
extra : moz-landing-system : lando
In the case that cubeb is disabled we do not need to offer the dummy device on android because will leave gUM request thinking that everything is good, which will create other side effects. Also the special handling for android increases the complexity.
Differential Revision: https://phabricator.services.mozilla.com/D3026
--HG--
extra : moz-landing-system : lando
When a transceiver is stopped, its mid should not be reused by a new transceiver.
Differential Revision: https://phabricator.services.mozilla.com/D2518
--HG--
extra : moz-landing-system : lando
The PeerConnection mochitest wrapper had checks to make sure that the ssrc was reported as a string.
It is now an unsigned long and those tests needed to reflect that.
MozReview-Commit-ID: b7TzzG0I4J
--HG--
extra : rebase_source : 8c1665b1c8d8e2f0418a0be70d37c8ee10507c35
This test became permafail after the patch for bug 1270217 landed to update
the default value for MACOS_DEPLOYMENT_TARGET from 10.7 to 10.9. We need to
update that value since otherwise local builds are broken on Mac, halting all
Mac development. As the lesser of two evils I'm disabling this test for now.
Focusing a source during a test run can cause Firefox to lose focus and
subsequent tests to timeout. This adds a preference which defaults to true
that allows the source to be focused. It is then set to false for tests that
involve screen sharing.
MozReview-Commit-ID: CNq2c87y8Ho
--HG--
extra : rebase_source : 805e2cbf9c09af419419a64d074e020784185b1d
This creates a simulcast stream with an odd resolution. This previously would
have caused a runtime assertion failure and crash.
MozReview-Commit-ID: IsywVOu6UeV
--HG--
extra : rebase_source : 7ad1cbe7dd36ccdd7a05e0c0a83db98a36c8c416
Add two mochitests to provide coverage for getUserMedia when getting a cubeb
context fails.
- The first test checks that gUM fails with no audio devices returned. In normal
circumstances, without cubeb we do not expect devices to be available. Android
is a notable exception here, due to it having a number of different code paths
during enumaration, and the test attempts to accomodate this.
- The second test checks that if fake streams are enabled, gUM will still return
a stream and that this stream can be used.
MozReview-Commit-ID: Fn6rGi6W9hM
--HG--
extra : rebase_source : b22ccc11cb034242f1a8807cfcae05f5ac2daa05
Update head.js so that calls to the gUM helper will check the loopback and fake
device prefs and update the frequency output by test devices accordingly. This
should hopefully avoid issues where tests could change prefs, and the output
tone would no longer be correct for the new configuration.
No longer have audioDevice and videoDevice as globals, this way tests
explicitly fetch direct from prefs.
MozReview-Commit-ID: 9jhVScaBfTX
--HG--
extra : rebase_source : 64b17e44ef166983361f94cf7d287faed3c2cdc5
Update head.js so that logic for fake audio and fake video is more granular.
Now code handles fake audio and fake video separately, and will set the fake
pref is either is needed. This allows for a single loopback device to be set
and fake used for the other. Previously both devices needed to be loopback or
fakes would be used.
MozReview-Commit-ID: K4blmPrSVeh
--HG--
extra : rebase_source : 369ea7f788d29a02db68e517d324977f251c9a98
With changes giving loopback devices higher precedence in testing, various tests
in dom/media/tests/mochitest have been updated to accommodate this. Many tests
just worked, but some require tweaks, or to explicitly request fake devices.
Also update webaudio's test_mediaStreamAudioSourceNodeGC test to explicitly use
fake devices. This test does not have the loopback tone exposed to it in JS, so
is unabel to adjust the loopback tone to suit its needs.
Various tests are updated to set fake device prefs instead of requesting via
gUM to move away from non-standard behaviour per bug 1436424.
MozReview-Commit-ID: 5GAVZFzF2hq
--HG--
extra : rebase_source : 27f39e3573eda321025ce0739e1d5f4101fc5d12
There are a few different reasons why tests needed updating (not an exhaustive list):
- Tests assume that successive operations take place at different times.
- Tests assume that an operation took a minimum amount of time.
- Tests hardcodes a specific delay.
In most cases we hardcode the preference off. In some cases this is the best approach,
in others, we would like to improve. The bug for tracking those improvements is Bug 1429648
An improvement that is present in some tests is to hardcode a specific precision reduction
that is acceptable based on the confides of the test. (Obviously this needs to be a fix for
the test framework and not a requirement on the feature being tested.)
In a few places, the test itself can be fixed, for example to no longer require the end
time of an operation to be strictly greater than the start time, and allows it to be equal
to it.
MozReview-Commit-ID: J59c7xQtZZJ
--HG--
extra : rebase_source : df8a03e76eaf9cdc9524dbb3eb9035af237e534b
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <
Daniel Varga
Byron Campen [:bwc]
Dorel Luca
Jan-Ivar Bruaroey
Gurzau Raul
Brindusan Cristian
Nico Grunbaum
Kris Maglione
Johann Hofmann
Ryan VanderMeulen
Csoregi Natalia
Jeremy Lainé
Geoff Brown
James Willcox
Narcis Beleuzu
Timothy Guan-tin Chien
Mark Banner
Ciure Andrei
Paul Adenot
Andreas Pehrson
Jean-Yves Avenard
Kartikaya Gupta
Nils Ohlmeier [:drno]
Jim Chen
Cosmin Sabou
Margareta Eliza Balazs
Julian Descottes
Philipp Hancke
Chris Peterson
Bogdan Tara
Alex Chronopoulos
Coroiu Cristina
Andreas Pehrson
Andreas Pehrson
Dorel Luca
Bryce Van Dyk
Nico Grunbaum
Dale Harvey
Joel Maher
Dan Minor
Jonathan Watt
Noemi Erli
Andreea Pavel
Arthur Iakab
Tom Ritter
Andrew McCreight
Michael Froman
Florian Quèze
Sebastian Hengst
Tooru Fujisawa