This is a collaboration between clang-tidy and clang-format.
clang-tidy uses compiled code paths, so this patch is linux specific.
Differential Revision: https://phabricator.services.mozilla.com/D105669
Previously, we fired these for Accessibles, but this was never implemented for ProxyAccessibles (remote content documents).
Differential Revision: https://phabricator.services.mozilla.com/D67271
--HG--
extra : moz-landing-system : lando
This adds both the role as well as calculation of the posinset, setsize, and level calculation if not provided by the author.
Differential Revision: https://phabricator.services.mozilla.com/D64590
--HG--
extra : moz-landing-system : lando
The correct mapping for nsIAccessibleEvent::EVENT_TEXT_SELECTION_CHANGED
in ATK is text_selection_changed; not selection_changed. The latter is
meant for containers which support selection of child objects, such as
a menu or expanded select element.
Differential Revision: https://phabricator.services.mozilla.com/D34521
--HG--
extra : moz-landing-system : lando
The appropriate case is when placeholder is not used as the absolutely last fallback for the accessible name, and the input is not labeled by the same text as in the placeholder attribute itself. So a label and the placeholder text must be different for the object attribute to be exposed.
In addition, for ATK, placeholder is being renamed to placeholder-text to comply with the platform specification.
Differential Revision: https://phabricator.services.mozilla.com/D19808
--HG--
extra : moz-landing-system : lando
Move the object attribute exposure of states::HASPOPUP from the ATK wrapper
code to the shared accessibility code. Call UniversalStatesFor() rather than
State() for performance.
--HG--
extra : rebase_source : e31c2d00da302538a7f6962d8f4dfd148a7d877e
Use strcmp() instead of strncmp() when comparing the AtkObject name
before changing it. 9133117f410c06ad7fa25323a168bc97200043b9 changed
from Equals() to strncmp() to prevent issues related to embedded NUL
bytes, but the change lead to only checking if the AtkObject name has
the new value as prefix. Instead, use strcmp() to check the whole
C strings, but still stopping at the first NUL byte in the new name.
strcmp() has to be safe here, as NS_ConvertUTF16toUTF8::get() has to
return a NUL-terminated string or the code would crash a few lines
below when calling strdup() on it.
This is a pretty straight forward wrapper around the internal table cell
interface. However we need to be careful to only expose this interface if we
are dealing with a version of ATK new enough to understand it.
This is a pretty straight forward wrapper around the internal table cell
interface. However we need to be careful to only expose this interface if we
are dealing with a version of ATK new enough to understand it.
We can sometimes call ProxyDestroyed() on a proxy that never had a wrapper set
up so we should just bail out of ProxyDestroyed() in that case because there is
nothing to do.
For these events atk needs to know about the widget not the event target, and
the easiest way to support that is by adding a new event message that sends the
widget id.
Especially for hide events its better to use the parent stored in the event
than the parent of the object when the event is fired. However xul trees fire
show / hide events where the event's type is AccEvent not a subtype of
AccMutationEvent, and in that case we need to fall back to the objects parent.
Eitan Isaacson
Morgan Reschenberg
James Teh
Marco Zehe
Joanmarie Diggs
Dorel Luca
Sylvestre Ledru
Alexander Surkov
David Major
Colomban Wendling
Trevor Saunders
Sebastian Hengst
Igor
Jonathan Watt
Birunthan Mohanathas
Phil Ringnalda