15ff419df0
Bug 1694059 - Rename various nnt prefs. r=spohl,mstange
...
As per feedback in D105931.
Differential Revision: https://phabricator.services.mozilla.com/D105991
2021-02-22 20:05:35 +00:00
2703d6691b
Bug 1693895: Adjust default font size expectations in our accessibility tests on macOS with the non-native theme enabled. r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D105827
2021-02-22 13:08:43 +00:00
7c931c97c4
Bug 1689218 - Rename nsBaseHashtable::GetAndRemove to Extract. r=necko-reviewers,dragana
...
First, it should be called "Lookup" rather than "Get" because it returns
DataType (rather than UserDataType), but that would still be confusing,
since as opposed to other Lookup* methods, it does not return a DataType&
(and obviously, it can't). So "Extract" seems to be a better name, cf.
mozilla::Maybe::extract.
Differential Revision: https://phabricator.services.mozilla.com/D105471
2021-02-22 12:07:48 +00:00
c5f7800f35
Bug 1691913 - Rename nsClassHashtable::LookupOrAdd to GetOrInsertNew. r=xpcom-reviewers,nika
...
It should be called "Get" rather than "Lookup" because it returns
UserDataType. "Add" is called "Insert" in the other methods.
Differential Revision: https://phabricator.services.mozilla.com/D105470
2021-02-22 12:07:47 +00:00
6e8749d0da
Bug 1693597 - P2: Rename ProxyAccessible to RemoteAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105671
2021-02-19 23:14:33 +00:00
6e49732365
Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
f48f468cb7
Bug 1693607 - [Linux] Add braces around statements. r=morgan
...
This is a collaboration between clang-tidy and clang-format.
clang-tidy uses compiled code paths, so this patch is linux specific.
Differential Revision: https://phabricator.services.mozilla.com/D105669
2021-02-19 23:14:32 +00:00
e71c1fa4ff
Bug 1648813: Verify acc description when waiting for load/layout event r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D105373
2021-02-18 18:04:59 +00:00
07f2f659c6
Bug 1686616 - make StringBundle use Components instead of Services. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D105531
2021-02-18 13:26:32 +00:00
ade0725530
Bug 1686616 - make GfxInfo use Components instead of Services. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D105522
2021-02-18 13:26:29 +00:00
5d7295db79
Bug 1693429 - Fix some typos in a11y mochitests. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D105549
2021-02-18 04:23:40 +00:00
9343b6370d
Bug 1460378: Verify role, role description mapping for meter element on mac r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D104760
2021-02-17 15:58:31 +00:00
588e12696e
Bug 1460378: Introduce meter role and HTMLMeterAccessible class. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D104759
2021-02-17 15:58:31 +00:00
355baf5b39
Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK/NS_OBJC_BEGIN_TRY_IGNORE_BLOCK/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK/NS_OBJC_END_TRY_IGNORE_BLOCK/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104960
2021-02-16 22:55:21 +00:00
9bc888af4a
Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
56051da2d0
Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
...
This patch was generated with the commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
5257db6695
Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
...
This patch was generated automatically with the commands below:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
4fe9680965
no bug - Remove a pylint warning - variable 'text' is unused r=mstange DONTBUILD
...
Depends on D105299
Differential Revision: https://phabricator.services.mozilla.com/D105300
2021-02-16 21:10:33 +00:00
ff59e176e4
Bug 1692523 - P2: Prefix remote heirarchy functions with 'Remote'. r=Jamie
...
Parent -> RemoteParent
ChildAt -> RemoteChildAt
FirstChild -> RemoteFirstChild
LastChild -> RemoteLastChild
NextSibling -> RemoteNextSibling
PrevSibling -> RemotePrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105035
2021-02-16 20:05:11 +00:00
8c842a59e3
Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
...
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
338908171d
Bug 1692846 - Remove redundant nullptr checks of return value of infallible new in accessible/. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D105174
2021-02-16 08:43:57 +00:00
2416d881e2
Bug 1691589 - Reduce reliance on GeckoProfiler.h when only labels (and maybe markers) are needed - r=necko-reviewers,geckoview-reviewers,sg,agi,florian
...
There are no code changes, only #include changes.
It was a fairly mechanical process: Search for all "AUTO_PROFILER_LABEL", and in each file, if only labels are used, convert "GeckoProfiler.h" into "ProfilerLabels.h" (or just add that last one where needed).
In some files, there were also some marker calls but no other profiler-related calls, in these cases "GeckoProfiler.h" was replaced with both "ProfilerLabels.h" and "ProfilerMarkers.h", which still helps in reducing the use of the all-encompassing "GeckoProfiler.h".
Differential Revision: https://phabricator.services.mozilla.com/D104588
2021-02-16 04:44:19 +00:00
780a1636a9
Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 15:12:17 +00:00
1afbbe67e1
Backed out 5 changesets (bug 1691894) for causing hazard failures in nsXULPrototypeCache. CLOSED TREE
...
Backed out changeset 22dc870ee609 (bug 1691894)
Backed out changeset 58c31e9d6ae3 (bug 1691894)
Backed out changeset 7483e84149d8 (bug 1691894)
Backed out changeset f977d6cfa973 (bug 1691894)
Backed out changeset db4503476f34 (bug 1691894)
2021-02-15 16:43:23 +02:00
8973094ec1
Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 10:04:45 +00:00
a7a374a0cd
Bug 1652192: Enable event logging for accessible/tests/browser/states/browser_test_visibility.js. r=yzen
...
I can't reproduce this on try, so I'm landing this so I can get (hopefully) useful info next time it fails.
Differential Revision: https://phabricator.services.mozilla.com/D104942
2021-02-14 22:14:03 +00:00
16060f0cc4
Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
ed6880e281
Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE
2021-02-13 21:46:51 +02:00
8069ab6165
Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
263d555274
Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
5d2f41bc6e
Bug 1691623 - Wait for text attr change event that precedes misspelled attribute. r=morgan.
...
Differential Revision: https://phabricator.services.mozilla.com/D104727
2021-02-10 20:04:41 +00:00
1fe81c2358
Bug 1691502: Don't attempt to invalidate table cache on outlines r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D104432
2021-02-10 18:29:36 +00:00
8a85843ede
Bug 1648813: Wait for AXLoadComplete on spawned tab based on label r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D104553
2021-02-10 18:29:02 +00:00
b8ab9d0b57
Bug 1691345 - Check that focused child doc is a descendant of caller's doc. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D104546
2021-02-10 17:01:22 +00:00
49dfc2e434
Bug 1691831 - Clamp offsets to character count in HyperTextIterator. r=morgan
...
I tried to come up with a good test for this, that reproduces the issue in a demonstratable way, but couldn't.
Differential Revision: https://phabricator.services.mozilla.com/D104586
2021-02-10 06:58:40 +00:00
f4a86a8e84
Bug 1690924: Wait for focus event instead of selected children changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D104264
2021-02-09 17:57:04 +00:00
661b4db5f0
Bug 1689147 - Part 4: Switch nested and prio to extended attributes, r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D103369
2021-02-09 16:50:22 +00:00
c72349ac1a
Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-09 01:30:08 +00:00
f01ed6dea6
Bug 1646486: Move dom::Document::IsVisibleConsideringAncestors to a11y::nsCoreUtils::IsDocumentVisibleConsideringInProcessAncestors. r=emilio
...
Renaming the function makes it clear that it only deals with in-process ancestors, which is an important distinction for Fission.
A11y is the only consumer of this and it only cares about in-process ancestors in this case (OOP stuff is handled elsewhere), so the functionality doesn't need to change.
Since a11y is the only consumer, move this into the a11y code.
Differential Revision: https://phabricator.services.mozilla.com/D104341
2021-02-09 00:44:21 +00:00
0a92b9e380
Bug 1690342 - P5: Use AXTextArea for multiline aria text boxes. r=morgan DONTBUILD
...
Now that we have attribtued text we don't need to advertise rich text editables as AXTextField.
Differential Revision: https://phabricator.services.mozilla.com/D103803
2021-02-08 23:26:49 +00:00
cb03a1923c
Bug 1690342 - P4: Implement IPC attributed text getter. r=morgan DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D103802
2021-02-08 23:26:47 +00:00
b9559d486e
Bug 1690342 - P3: Add protocol stubs for mac attributed text. r=Jamie,mccr8,ipc-reviewers DONTBUILD
...
Created DocAccessibleTypes.ipdlh to put common types so they can be used in platform
extension protocols.
Differential Revision: https://phabricator.services.mozilla.com/D103801
2021-02-08 23:26:39 +00:00
e6912635e0
Bug 1690342 - P2: Populate NSAttributedText attributes with attributes. r=morgan DONTBUILD
...
A followup patch will make this work in e10s. This current implementation is non-ipc.
Differential Revision: https://phabricator.services.mozilla.com/D103800
2021-02-08 23:26:31 +00:00
84896a7a88
Bug 1690342 - P1: Introduce moxAncestorSearch for finding ancestors. r=morgan DONTBUILD
...
It looks like we need to do this often. Adding it to the protocol/base class allows
us to not have to worry each time about typing and traversing past MOX accessibles.
Differential Revision: https://phabricator.services.mozilla.com/D103799
2021-02-08 23:26:24 +00:00
cbda00d7e1
Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-02-05 13:40:42 +00:00
864f262237
Bug 1691077 - Remove obsolete Fennec special case for nsDeckFrame a11y code. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D104240
2021-02-07 23:03:40 +00:00
6da97a654e
Backed out 2 changesets (bug 1689445) for causing bc failures in browser_search.js
...
Backed out changeset 2b1ec882c4c1 (bug 1689445)
Backed out changeset bcb4ba398ee0 (bug 1689445)
2021-02-06 05:33:02 +02:00
d3beb62c1d
Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-05 21:26:54 +00:00
e81436a8a8
Bug 1689936: Move pending a11y content insertions into a temporary data structure before processing them. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103977
2021-02-05 00:01:59 +00:00
b6cdc22e2b
Bug 1680840: Introduce table style changed event to mac platform, update caching r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103698
2021-02-04 20:50:12 +00:00
1f72fbb6eb
Bug 1680840: Fire table styling changed event when style changes that may affect data/layout table classification r=emilio,eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103254
2021-02-04 20:50:05 +00:00
ced0045bea
Bug 1688490: Make GetNativeFromGeckoAccessible null-safe r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103813
2021-02-04 19:41:30 +00:00
6b8df6efbe
Bug 1686744: Fire AXMenuItemSelected notification when menu item is pressed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103954
2021-02-04 19:41:37 +00:00
1b4d4c6a32
Bug 1690456: Don't allow nsAccessibilityService to be shut down while a parent document is still shutting down. r=yzen
...
DocAccessible::Shutdown calls DocManager::NotifyOfDocumentShutdown, which can shut down nsAccessibilityService if there are no more consumers.
Previously, this could happen even when shutting down child documents.
Since shutting down the service shuts down all documents, this resulted in shutting down the parent document within an outer call to shut down that same document.
Even if that reentry were prevented, the service would have been gone when returning to the outer Shutdown call, which still needs the service to complete its cleanup.
To fix this, DocManager::NotifyOfDocumentShutdown takes an argument specifying whether to allow service shutdown.
This is set to false when shutting down child documents.
The service is thus allowed to shut down when returning to the parent document Shutdown.
In addition, mPresShell is cleared before shutting down child documents to prevent reentry like this.
While this should no longer happen, this should safeguard against similar pain in future.
Differential Revision: https://phabricator.services.mozilla.com/D103966
2021-02-04 01:10:52 +00:00
62aed9ef20
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-02 21:30:58 +00:00
67cee8a3e4
Bug 1688730: Fire relevant object attr changed events when layout table status may have changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102993
2021-02-02 21:10:26 +00:00
2af3edc6b9
Backed out 2 changesets (bug 1688730) for causing mochitest failures. CLOSED TREE
...
Backed out changeset 677c17ec48ea (bug 1688730)
Backed out changeset a7d0770117c8 (bug 1688730)
2021-02-02 02:04:28 +02:00
876affb062
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 20:23:23 +00:00
84efd51514
Bug 1688730: Fire relevant object attr changed events when layout table status may have changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102993
2021-02-01 20:23:17 +00:00
e13215fdec
Backed out 2 changesets (bug 1688730) for causing build bustage on mozTableAccessible.mm. CLOSED TREE
...
Backed out changeset bd6d78d36cee (bug 1688730)
Backed out changeset dd03939b850e (bug 1688730)
2021-02-01 21:44:02 +02:00
3b5f7255b1
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 17:54:13 +00:00
cdce5e2be5
Bug 1688730: Fire relevant object attr changed events when layout table status may have changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102993
2021-02-01 18:30:07 +00:00
d3876360b5
Bug 1688972 - Make FocusedChild work across document/process boundaries. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D103102
2021-02-01 17:54:23 +00:00
868935867c
Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
...
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
bbaf7fbc65
Bug 1682285 - Part 2: Track LOAD_FLAGS_FROM_EXTERNAL separately from LOAD_TYPE, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D103365
2021-01-29 22:06:36 +00:00
dc191572ea
Backed out changeset 4572c1ba670a (bug 1688972) for Browser-chrome failures in accessible/tests/browser/fission/browser_take_focus.js. CLOSED TREE
2021-01-30 01:17:00 +02:00
ba6174e679
Bug 1688972 - Make FocusedChild work across document/process boundaries. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D103102
2021-01-29 20:57:30 +00:00
3994678bd5
Bug 1689285 - Fix test_visibility.xhtml to not depend on theme values. r=eeejay
...
It's relying on the other menuitems being tall enough so that they
overflow 5em. When the non-native theme is enabled, this assumption
breaks because that theme doesn't add padding to XUL menuitems, and we
get the failure:
wrong state bits for 'mi_file1.2.4' !got '0', expected 'offscreen'
Get what we want to test more explicitly by setting the height of the
menuitems appropriately.
Differential Revision: https://phabricator.services.mozilla.com/D103267
2021-01-29 16:54:21 +00:00
3d476753eb
Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-01-29 16:11:08 +00:00
42351bc1af
Bug 1688532: Don't use the cached column header on a previous table cell if that cell starts in a different column. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103146
2021-01-28 17:21:47 +00:00
2cf7d8a32b
Backed out changeset 7b30dc27f552 (bug 1689285) for causing accessible failures in test_visibility.xhtml
...
CLOSED TREE
2021-01-29 00:58:11 +02:00
924021206c
Bug 1689285 - Fix test_visibility.xhtml to not depend on theme values. r=eeejay
...
It's relying on the other menuitems being tall enough so that they
overflow 5em. When the non-native theme is enabled, this assumption
breaks because that theme doesn't add padding to XUL menuitems, and we
get the failure:
wrong state bits for 'mi_file1.2.4' !got '0', expected 'offscreen'
Get what we want to test more explicitly by setting the height of the
menuitems appropriately.
Differential Revision: https://phabricator.services.mozilla.com/D103267
2021-01-28 17:19:16 +00:00
e117dc4695
Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
...
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00
bbdb4f3b7b
Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-01-28 12:14:43 +00:00
897cbb0e6e
Bug 1688490: Gather moxParent directly instead of querying the parent of our gecko accessible r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102965
2021-01-26 21:12:11 +00:00
38a46d893a
Bug 493683 part 5: When aria-labell/describedby is set, set HasName/DescriptionDependent on the target subtree. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102680
2021-01-25 17:31:19 +00:00
49597d49e1
Bug 493683 part 4: Add a PivotRule to match any local Accessible in the same document. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102679
2021-01-25 01:12:17 +00:00
c9893f0237
Bug 493683 part 3: When an Accessible mutates, fire description change events on an Accessible described by it (or an ancestor thereof) via a relation. r=eeejay
...
This uses a similar approach to HasNameDependent, introducing a new HasDescriptionDependent.
However, we don't fire events on ancestors, since a description is never computed from an Accessible's own subtree without an explicit described by relation.
Differential Revision: https://phabricator.services.mozilla.com/D102678
2021-01-27 00:39:08 +00:00
77fe9db976
Bug 493683 part 2: When an Accessible mutates, fire name change events on an Accessible labelled by it (or an ancestor thereof) via a relation. r=eeejay
...
HasNameDependent is now set on an Accessible (and thus its descendants) which has A LABEL_FOR relation.
When text mutations occur on such an Accessible, EventQueue::PushNameChange now queues a name change for the Accessible being labelled.
Differential Revision: https://phabricator.services.mozilla.com/D102677
2021-01-27 00:34:21 +00:00
1af2138c00
Bug 493683 part 1: Rename HasNameDependentParent to HasNameDependent due to upcoming broader usage. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102676
2021-01-25 00:39:39 +00:00
92f8f50dd8
Bug 1688680 - Don't include AXTextStateSync in read-only collapsed text selection events. r=morgan.
...
Differential Revision: https://phabricator.services.mozilla.com/D102948
2021-01-25 17:58:52 +00:00
0921a6cd36
Bug 1688938 - Uncomment state change tests. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D103076
2021-01-26 19:26:29 +00:00
81befd069d
Bug 1686832 - Cache MULTI_LINE in mozAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101842
2021-01-22 20:42:26 +00:00
079775e780
Bug 1656107 - remove FindContentForSubDocument use from NotificationController. r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D98613
2021-01-21 00:46:15 +00:00
b41a2b9d21
Bug 1687239 part 2 - Remove plugin support from layout/. r=emilio
...
Note that there's still a little plugin related code in
widget/ and gfx/ etc after this. That can be removed
once we remove plugin support from dom/ etc.
The removal from layout/ should be pretty complete though.
Differential Revision: https://phabricator.services.mozilla.com/D102140
2021-01-25 11:53:49 +00:00
334efb391e
Bug 1687239 part 1 - Remove plugin tests from layout/, dom/ and accessible/. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D102139
2021-01-25 11:53:31 +00:00
7dc8c1a190
Bug 1686238: Only attempt to traverse containers menu if containers are enabled and defined r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D102799
2021-01-22 21:02:50 +00:00
135c36619d
Bug 1686995 - Add AXTextSelectionDirection and AXTextSelectionGranularity to text selection events. r=morgan
...
.. and also add AXTextSelectionChangedFocus and AXTextStateSync when needed.
Differential Revision: https://phabricator.services.mozilla.com/D102509
2021-01-22 21:12:56 +00:00
09060aa168
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 19:58:13 +00:00
57732c3083
Bug 1687535: Give several LazyInstantiator functions fast paths that avoid a11y instantiation. r=Jamie
...
This prevents us from instantiating accessibility (and incurring a significant performance cost later in the runtime) when we already know the answers a caller will receive if a11y were instantiated.
Differential Revision: https://phabricator.services.mozilla.com/D102371
2021-01-21 17:19:47 +00:00
ff8e5cb389
Backed out changeset 2860943a09a3 (bug 1686164) for build bustages at mozSelectableElements.mm. CLOSED TREE
2021-01-21 10:58:18 +02:00
fdab0ce3d7
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 08:42:02 +00:00
9ed618367f
Bug 1667998 - skip some accessible related browser-chrome tests when running a11y-checks. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D100841
2021-01-15 21:51:50 +00:00
a6e8d4aaa9
Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 18:20:44 +00:00
477b1bc69a
Backed out changeset ea36fa2936a2 (bug 1686164) for causing failures on test_controls.html. CLOSED TREE
2021-01-20 08:43:35 +02:00
1baf91ec07
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-19 22:04:52 +00:00
03c0b5f0e4
Bug 1669748: Null check the document IAccessibles sent for OOP iframes. r=yzen
...
The COM proxy for a DocAccessibleParent at the top level in its content process really should never be null.
However, some systems seem to have a broken COM configuration which causes problems like this.
This does mean a11y is broken, but users who get a11y enabled because of something other than an AT (e.g. touch screen) probably aren't even aware.
Regardless, we shouldn't crash.
Instead, we assert (in debug builds) and null check.
Differential Revision: https://phabricator.services.mozilla.com/D102129
2021-01-19 19:30:57 +00:00
720902efa2
Bug 1686839 - Apply MustPrune dynamically and not at creation time. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101853
2021-01-19 17:15:05 +00:00
eede5be7ec
Bug 1687480 - Fire NSAccessibility notifications for expanding and collapsing rows, r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D102308
2021-01-19 16:53:38 +00:00
09c48de881
Bug 1686827 - GeckoTextMarker is lesser than if child's offset is greater or equal. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101835
2021-01-15 19:18:46 +00:00
a5ce58cf1a
Bug 1625953 - P2: Introduce support for aria-controls and aria-flowto in mac. r=morgan
...
This is via AXARIAControls and AXLinkedUIElements respectively.
Differential Revision: https://phabricator.services.mozilla.com/D101085
2021-01-15 17:22:56 +00:00
515ee847be
Bug 1625953 - P1: Introduce getRelationsByType for mozAccessible. r=morgan
...
A small refactor to make all of the relations getting easier.
Differential Revision: https://phabricator.services.mozilla.com/D101084
2021-01-15 17:22:49 +00:00
8ad2a18a79
Backed out 5 changesets (bug 1667998) for breaking a11y checks CLOSED TREE
...
Backed out changeset 633dda979b22 (bug 1667998)
Backed out changeset c9838cdb1303 (bug 1667998)
Backed out changeset 501c54cf59be (bug 1667998)
Backed out changeset 615b74c822ec (bug 1667998)
Backed out changeset 6d187c01fcb3 (bug 1667998)
2021-01-15 20:16:06 +02:00
3b3d85b83e
Bug 1667998 - skip some accessible related browser-chrome tests when running a11y-checks. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D100841
2021-01-15 16:54:20 +00:00
33ccace61e
Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 16:53:43 +00:00
9e9b090ec4
Backed out 2 changesets (bug 1625953) for Eslint failure
...
Backed out changeset 33fa80e826a8 (bug 1625953)
Backed out changeset 36da5d89bc8a (bug 1625953)
2021-01-15 06:37:54 +02:00
0c9ddcad81
Bug 1625953 - P2: Introduce support for aria-controls and aria-flowto in mac. r=morgan
...
This is via AXARIAControls and AXLinkedUIElements respectively.
Depends on D101084
Differential Revision: https://phabricator.services.mozilla.com/D101085
2021-01-08 00:22:25 +00:00
1dcdfb0a26
Bug 1625953 - P1: Introduce getRelationsByType for mozAccessible. r=morgan
...
A small refactor to make all of the relations getting easier.
Differential Revision: https://phabricator.services.mozilla.com/D101084
2021-01-08 00:19:04 +00:00
da5cf09b14
Bug 1623286: Fire offscreen state change a11y events when a XUL tab panel is switched. r=eeejay
...
Without this, the AT-SPI cache isn't updated and Orca mouse review fails after switching tabs.
Differential Revision: https://phabricator.services.mozilla.com/D101428
2021-01-14 17:56:59 +00:00
0646b214b4
Bug 1359482: Don't expose the editable state on ARIA grids and gridcells. r=eeejay
...
The editable state is about navigable text (with a caret), not editable as in "not read only".
ATs don't want this exposed for grids and it causes problems for them.
They can (and already do) distinguish between gridcell and cell using xml-roles.
Differential Revision: https://phabricator.services.mozilla.com/D101707
2021-01-15 01:32:13 +00:00
1b5b46ec79
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
e3097163dd
Bug 1597437 - Handle 'window.content' legacy getter better with Fission, r=farre,Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D100167
2020-12-21 12:08:08 +00:00
7742c03714
Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
...
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
06e7942185
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
c19d6d89b4
Bug 1682865: Map roles::EDITCOMBOBOX to mozTextAccessible r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101407
2021-01-11 22:04:13 +00:00
36e53a5e88
Bug 1685623: Account for search engine initialization race r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101098
2021-01-11 22:04:49 +00:00
c2f1413e6b
Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
...
This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:
* Instead of manually managing the image request, use the CSS image
loader, with the `REQUEST_REQUIRES_REFLOW` flag, to handle image
loads correctly. This didn't exist when this code was initially
implemented, but we can nicely use it now.
* Instead of re-implementing another WebRender command-builder thing,
we can just reuse the nsImageRenderer code.
Differential Revision: https://phabricator.services.mozilla.com/D100774
2021-01-08 09:44:24 +00:00
2bc463ad54
Bug 1681292: Ensure menu items correctly expose AXVisibleChildren and AXChildren r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D99949
2021-01-07 21:33:21 +00:00
29a8164b84
Bug 1680589: Make AXDisclosing settable on outline rows r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101053
2021-01-07 21:29:27 +00:00
18e3c81cf5
Bug 1684896 - For the static NSDictionary MacSelectorMap objects, use function-local statics rather than globals. r=morgan
...
This means that the NSDictionaries will be constructed the first time the
wrapper function is called, and not at C++ static initializer time.
This avoids false positive warnings when running with the environment variables
`OBJC_DEBUG_MISSING_POOLS=YES LIBDISPATCH_DEBUG_MISSING_POOLS=NO`.
Differential Revision: https://phabricator.services.mozilla.com/D100976
2021-01-07 17:53:39 +00:00
c21730a605
Bug 1682985 - Support aria-busy with AXElementBusy and AXElementBusyChanged. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D100838
2021-01-06 17:23:45 +00:00
7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
7d7078d54e
Backed out changeset 47c73e5e08a4 (bug 1685078) for multiple failures related to CSS. CLOSED TREE
2021-01-07 10:44:10 +02:00
b58ddc19df
Bug 1519636 - Reformat recent changes to the Google coding style r=andi
...
Updated with Debian clang-format version 11.0.1-1
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D100934
2021-01-06 17:17:23 +00:00
9fbf3695e7
Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
...
This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:
* Instead of manually managing the image request, use the CSS image
loader, with the `REQUEST_REQUIRES_REFLOW` flag, to handle image
loads correctly. This didn't exist when this code was initially
implemented, but we can nicely use it now.
* Instead of re-implementing another WebRender command-builder thing,
we can just reuse the nsImageRenderer code.
Differential Revision: https://phabricator.services.mozilla.com/D100774
2021-01-07 04:15:01 +00:00
5cd8830a74
Bug 1683723 - Replace deprecated Cocoa enum constants with their modern replacements. r=spohl
...
I ran the following command:
```
rg -l 'NSAlphaShiftKeyMask' . | xargs sed -i '' -e 's/NSAlphaShiftKeyMask/NSEventModifierFlagCapsLock/g'
rg -l 'NSAlternateKeyMask' . | xargs sed -i '' -e 's/NSAlternateKeyMask/NSEventModifierFlagOption/g'
rg -l 'NSAnyEventMask' . | xargs sed -i '' -e 's/NSAnyEventMask/NSEventMaskAny/g'
rg -l 'NSApplicationDefined' . | xargs sed -i '' -e 's/NSApplicationDefined/NSEventTypeApplicationDefined/g'
rg -l 'NSBorderlessWindowMask' . | xargs sed -i '' -e 's/NSBorderlessWindowMask/NSWindowStyleMaskBorderless/g'
rg -l 'NSCenterTextAlignment' . | xargs sed -i '' -e 's/NSCenterTextAlignment/NSTextAlignmentCenter/g'
rg -l 'NSClosableWindowMask' . | xargs sed -i '' -e 's/NSClosableWindowMask/NSWindowStyleMaskClosable/g'
rg -l 'NSCommandKeyMask' . | xargs sed -i '' -e 's/NSCommandKeyMask/NSEventModifierFlagCommand/g'
rg -l 'NSCompositeCopy' . | xargs sed -i '' -e 's/NSCompositeCopy/NSCompositingOperationCopy/g'
rg -l 'NSControlKeyMask' . | xargs sed -i '' -e 's/NSControlKeyMask/NSEventModifierFlagControl/g'
rg -l 'NSDeviceIndependentModifierFlagsMask' . | xargs sed -i '' -e 's/NSDeviceIndependentModifierFlagsMask/NSEventModifierFlagDeviceIndependentFlagsMask/g'
rg -l 'NSFlagsChanged' . | xargs sed -i '' -e 's/NSFlagsChanged/NSEventTypeFlagsChanged/g'
rg -l 'NSFullScreenWindowMask' . | xargs sed -i '' -e 's/NSFullScreenWindowMask/NSWindowStyleMaskFullScreen/g'
rg -l 'NSFullSizeContentViewWindowMask' . | xargs sed -i '' -e 's/NSFullSizeContentViewWindowMask/NSWindowStyleMaskFullSizeContentView/g'
rg -l 'NSFunctionKeyMask' . | xargs sed -i '' -e 's/NSFunctionKeyMask/NSEventModifierFlagFunction/g'
rg -l 'NSHelpKeyMask' . | xargs sed -i '' -e 's/NSHelpKeyMask/NSEventModifierFlagHelp/g'
rg -l 'NSKeyDown' . | xargs sed -i '' -e 's/NSKeyDown/NSEventTypeKeyDown/g'
rg -l 'NSKeyUp' . | xargs sed -i '' -e 's/NSKeyUp/NSEventTypeKeyUp/g'
rg -l 'NSLeftMouseDownMask' . | xargs sed -i '' -e 's/NSLeftMouseDownMask/NSEventMaskLeftMouseDown/g'
rg -l 'NSLeftMouseDown' . | xargs sed -i '' -e 's/NSLeftMouseDown/NSEventTypeLeftMouseDown/g'
rg -l 'NSLeftMouseDragged' . | xargs sed -i '' -e 's/NSLeftMouseDragged/NSEventTypeLeftMouseDragged/g'
rg -l 'NSLeftMouseUp' . | xargs sed -i '' -e 's/NSLeftMouseUp/NSEventTypeLeftMouseUp/g'
rg -l 'NSMiniaturizableWindowMask' . | xargs sed -i '' -e 's/NSMiniaturizableWindowMask/NSWindowStyleMaskMiniaturizable/g'
rg -l 'NSMiniControlSize' . | xargs sed -i '' -e 's/NSMiniControlSize/NSControlSizeMini/g'
rg -l 'NSMouseEntered' . | xargs sed -i '' -e 's/NSMouseEntered/NSEventTypeMouseEntered/g'
rg -l 'NSMouseExited' . | xargs sed -i '' -e 's/NSMouseExited/NSEventTypeMouseExited/g'
rg -l 'NSMouseMoved' . | xargs sed -i '' -e 's/NSMouseMoved/NSEventTypeMouseMoved/g'
rg -l 'NSNumericPadKeyMask' . | xargs sed -i '' -e 's/NSNumericPadKeyMask/NSEventModifierFlagNumericPad/g'
rg -l 'NSOtherMouseDownMask' . | xargs sed -i '' -e 's/NSOtherMouseDownMask/NSEventMaskOtherMouseDown/g'
rg -l 'NSOtherMouseDown' . | xargs sed -i '' -e 's/NSOtherMouseDown/NSEventTypeOtherMouseDown/g'
rg -l 'NSOtherMouseDragged' . | xargs sed -i '' -e 's/NSOtherMouseDragged/NSEventTypeOtherMouseDragged/g'
rg -l 'NSOtherMouseUp' . | xargs sed -i '' -e 's/NSOtherMouseUp/NSEventTypeOtherMouseUp/g'
rg -l 'NSRegularControlSize' . | xargs sed -i '' -e 's/NSRegularControlSize/NSControlSizeRegular/g'
rg -l 'NSResizableWindowMask' . | xargs sed -i '' -e 's/NSResizableWindowMask/NSWindowStyleMaskResizable/g'
rg -l 'NSRightMouseDown' . | xargs sed -i '' -e 's/NSRightMouseDown/NSEventTypeRightMouseDown/g'
rg -l 'NSRightMouseDragged' . | xargs sed -i '' -e 's/NSRightMouseDragged/NSEventTypeRightMouseDragged/g'
rg -l 'NSRightMouseUp' . | xargs sed -i '' -e 's/NSRightMouseUp/NSEventTypeRightMouseUp/g'
rg -l 'NSRightTextAlignment' . | xargs sed -i '' -e 's/NSRightTextAlignment/NSTextAlignmentRight/g'
rg -l 'NSScrollWheelMask' . | xargs sed -i '' -e 's/NSScrollWheelMask/NSEventMaskScrollWheel/g'
rg -l 'NSScrollWheel' . | xargs sed -i '' -e 's/NSScrollWheel/NSEventTypeScrollWheel/g'
rg -l 'NSShiftKeyMask' . | xargs sed -i '' -e 's/NSShiftKeyMask/NSEventModifierFlagShift/g'
rg -l 'NSSmallControlSize' . | xargs sed -i '' -e 's/NSSmallControlSize/NSControlSizeSmall/g'
rg -l 'NSTabletPointEventSubtype' . | xargs sed -i '' -e 's/NSTabletPointEventSubtype/NSEventSubtypeTabletPoint/g'
rg -l 'NSTitledWindowMask' . | xargs sed -i '' -e 's/NSTitledWindowMask/NSWindowStyleMaskTitled/g'
```
Then I removed changes to third-party webrtc code, removed a comment in accessible/mac/mozAccessible.mm,
and performed some manual replacements in native_mouse_mac_window.xhtml.
Differential Revision: https://phabricator.services.mozilla.com/D100260
2021-01-05 21:17:11 +00:00
9e19999a57
Bug 1681909 - P3: Implement e10s post search filter and test. r=morgan
...
The test adds fission testing as well.
Differential Revision: https://phabricator.services.mozilla.com/D100732
2021-01-05 20:35:37 +00:00
4537ab3655
Bug 1681909 - P2: Implement post filter for non-e10s case. r=morgan
...
Introducing this as a separate patch to simplify this changeset and first introduce a straightforward-ish implementation.
Differential Revision: https://phabricator.services.mozilla.com/D100731
2021-01-05 20:35:35 +00:00
ca8fda7434
Bug 1681909 - P1: Add IPC stubs for ApplyPostSearchFilter. r=morgan,ipc-reviewers,mccr8
...
Applying a bulk filter on accessibles in content process allows us to avoid a potentially large (and variable) number of IPC sync calls to retrieve the accessible names. I chose to implement this as a "post filter" and not to actually do the entire search in content because it would cause a lot of duplication of code for non-IPC searching, and we wouldn't have the flexibility to combine a text search with any arbitrary search key as the API requires.
I also generalized the RangeTypes.h header to PlatformExtTypes so it can be used to define filter types as well.
Differential Revision: https://phabricator.services.mozilla.com/D100730
2021-01-05 20:35:22 +00:00
8de41d8d26
Bug 1683561 - Make `accessibility` buildable outside of `unified-build` environment. r=sg
...
Differential Revision: https://phabricator.services.mozilla.com/D100212
2021-01-05 09:47:12 +00:00
c2532de498
Bug 1680329 - Add AXTextStateChangeType to selection events. r=morgan
...
It seems that VoiceOver depends on that property to know if a selection is be extended or moved. This manifests in several places in Slack when the user combines VO navigation with Slack's keyboard navigation.
Also changed where we retrieve the editable ancestor to simplify the notification dispatching block.
Differential Revision: https://phabricator.services.mozilla.com/D100452
2021-01-04 22:37:46 +00:00
3ad026b52e
Bug 1677934 - Check for null when getting leaf for text marker. r=morgan
...
This doesn't happen often. I can't find a reproducable case to test with. This happens with rapidly mutating content and is the result of some kind of race.
Differential Revision: https://phabricator.services.mozilla.com/D100174
2021-01-04 17:48:50 +00:00
2978aa00a3
Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD
2020-12-28 00:43:51 +02:00
775cdec032
Bug 1684173 - Add newline character at end of files when missing r=sylvestre
...
Depends on D100443
Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
7d03492002
Bug 1682988 - Use UTF8String for querySelector and similar OM methods. r=heycam
...
This has no observable behavior change because we were converting to
UTF-8 in ParseSelectorList.
Differential Revision: https://phabricator.services.mozilla.com/D99961
2020-12-23 05:42:00 +00:00
9dd1281942
Bug 1683330 - Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r=yzen
...
This change that was introduced in bug 1682692 was not actually tested
and is unrelated to the fix. I thought that this was more correct, and I
added it. But this change should be reverted.
Differential Revision: https://phabricator.services.mozilla.com/D100169
2020-12-18 22:19:18 +00:00
0e0311351e
Backed out 9 changesets (bug 1656107) for frequent assertion failures on layout/style/nsComputedDOMStyle.cpp CLOSED TREE
...
Backed out changeset 2d9843871809 (bug 1656107)
Backed out changeset 87031ccf6c8e (bug 1656107)
Backed out changeset 1e06017a213c (bug 1656107)
Backed out changeset b51bae240379 (bug 1656107)
Backed out changeset 8d98b76de39a (bug 1656107)
Backed out changeset 0f4ea8cdd34a (bug 1656107)
Backed out changeset 95eeff5318e5 (bug 1656107)
Backed out changeset 469fa7a429c2 (bug 1656107)
Backed out changeset ec3d7e825bc9 (bug 1656107)
2020-12-17 22:19:09 +02:00
473b3896ad
Bug 1656107 - remove FindContentForSubDocument use from NotificationController. r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D98613
2020-12-16 01:06:14 +00:00
039592f4d8
Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam
...
This lifts a bunch of string conversions higher up the stack, but allows
us to make the servo code use utf-8 unconditionally, and seemed faster
in my benchmarking (see comment 0).
It should also make a bunch of attribute setters faster too (like
setting .cssText), now that we use UTF8String for them (we couldn't
because we couldn't specify different string types for the getter and
setters).
Differential Revision: https://phabricator.services.mozilla.com/D99590
2020-12-17 14:04:35 +00:00
4364371432
Bug 1681072 - Don't recurse into link if it is in more than one offset. r=MarcoZ
...
This is a safeguard for endless recursion in HyperTextIterator::NormalizeForward. Will catch similar corruptions found in bug 1682692.
Differential Revision: https://phabricator.services.mozilla.com/D99926
2020-12-17 06:09:49 +00:00
2fcbbfc201
Bug 1681166 - Check selection is valid before cropping it in mozTextAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D99942
2020-12-16 21:36:12 +00:00
a8d528a678
Bug 1664894: Remove logging r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D99933
2020-12-16 20:10:13 +00:00
837de2aca3
Bug 1682692 - (re)insert child after previous sibling, not previous insertion candidate. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D99849
2020-12-16 09:48:29 +00:00
c191381e18
Bug 1682247 - Post an AXTitleChanged notification if the Mac layer is notified of a name change event, r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D99664
2020-12-16 06:49:57 +00:00
fe6597a730
Bug 1668658 - Switch annotations for tests failing with session history in parent from fission.autoStart to fission.sessionHistoryInParent. r=smaug,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D99667
2020-12-15 15:21:40 +00:00
ec5f7cebca
Bug 1639218 - Remove prompts.tab_modal.enabled pref. r=marionette-reviewers,johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D97598
2020-12-14 14:19:54 +00:00
edd1803ffc
Backed out changeset ca41e6b53c94 (bug 1639218) for mochitest failures at toolkit/components/prompts/test/test_bug619644.html on a CLOSED TREE
2020-12-14 13:20:14 +02:00
40d51245b4
Bug 1639218 - Remove prompts.tab_modal.enabled pref. r=marionette-reviewers,johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D97598
2020-12-11 13:48:40 +00:00
3987c781d0
Bug 1635914 - Move active flag handling explicitly to BrowsingContext. r=nika
...
And have it mirror in the parent process more automatically.
The docShellIsActive setter in the browser-custom-element side needs to
be there rather than in the usual DidSet() calls because the
AsyncTabSwitcher code relies on getting an exact amount of notifications
as response to that specific setter. Not pretty, but...
BrowserChild no longer sets IsActive() on the docshell itself for OOP
iframes. This fixes bug 1679521. PresShell activeness is used to
throttle rAF as well, which handles OOP iframes nicely as well.
Differential Revision: https://phabricator.services.mozilla.com/D96072
2020-12-11 15:43:19 +00:00
f248fdbd3a
Bug 1680277 - 3/3: Use AXTextArea for multiline and aria text boxes. r=morgan,MarcoZ
...
By spec, it would need to be an area for aria-multiline=true and a field for aria-multiline=false. Chrome seems to assign all aria text boxes to areas. For some reason this allows VO to recognize links when editing. Webkit doesn't need this, for some reason and can get links announces in AXTextField as well.
Depends on D99312
Differential Revision: https://phabricator.services.mozilla.com/D99313
2020-12-11 10:29:15 +00:00
Emilio Cobos Álvarez
Stephen A Pohl
Simon Giesecke
Eitan Isaacson
Morgan Reschenberg
Alexis Beingessner
Markus Stange
Sylvestre Ledru
Gerald Squelart
smolnar
James Teh
james
Narcis Beleuzu
Mark Banner
Nika Layzell
Yura Zenevich
Paul Zuehlcke
Tim Nguyen
Mihai Alexandru Michis
Butkovits Atila
Dorel Luca
Brindusan Cristian
Steven MacLeod
Mats Palmgren
Bas Schouten
Marco Zehe
Noemi Erli
Micah Tigley
Kartik Gautam
Andi-Bogdan Postelnicu
Cosmin Sabou
Bogdan Tara
Peter Van der Beken
Cristina Coroiu