Граф коммитов

313 Коммитов

Автор SHA1 Сообщение Дата
Mark Banner ce668e4afd Bug 1515942 - Enable ESLint for gfx/ (manual fixes). r=kats
Differential Revision: https://phabricator.services.mozilla.com/D15206

--HG--
extra : moz-landing-system : lando
2018-12-27 09:45:01 +00:00
Mark Banner 3414ce9b54 Bug 1515952 - Allow ESLint rule spaced-comment to accept source-map comments. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D15207

--HG--
extra : moz-landing-system : lando
2018-12-21 18:05:39 +00:00
Mark Banner 0304564ac7 Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13754

--HG--
extra : moz-landing-system : lando
2018-12-11 21:39:40 +00:00
Mark Banner e2234d6da6 Bug 1415483 - Extend reject-importGlobalProperties to reject any priviliged items already in scope. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13753

--HG--
extra : moz-landing-system : lando
2018-12-11 21:39:38 +00:00
Csoregi Natalia 9e970681f2 Backed out 2 changesets (bug 1415483) for multiple failures e.g. on test_message_manager_ipc.html. CLOSED TREE
Backed out changeset d00748de66fc (bug 1415483)
Backed out changeset 8dea94258f54 (bug 1415483)
2018-12-11 19:30:57 +02:00
Mark Banner 1abdc8687f Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13754

--HG--
extra : moz-landing-system : lando
2018-12-11 14:09:44 +00:00
Mark Banner 4d543888a6 Bug 1415483 - Extend reject-importGlobalProperties to reject any priviliged items already in scope. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13753

--HG--
extra : moz-landing-system : lando
2018-12-11 14:09:24 +00:00
Mark Banner ff9179a99e Bug 1507487 - Handling of importScripts by ESLint should fallback to the file name if there is no entry in modules.json. r=mossop
We already have a fallback for items that aren't in a worker scope, we should have the same for ones that are. This means we don't need single maps (foo.js -> foo) in modules.json, and also we can identify more as explicit variables, so that no-unused-vars can detect them.

Differential Revision: https://phabricator.services.mozilla.com/D13299

--HG--
extra : moz-landing-system : lando
2018-12-11 09:31:26 +00:00
Cosmin Sabou e3d5f2a521 Backed out changeset 6f69dc19ed7c (bug 1507487) for devtools failures on browser_scratchpad_pprint.js CLOSED TREE 2018-12-10 19:04:49 +02:00
Mark Banner d4cd673de5 Bug 1507487 - Handling of importScripts by ESLint should fallback to the file name if there is no entry in modules.json. r=mossop
We already have a fallback for items that aren't in a worker scope, we should have the same for ones that are. This means we don't need single maps (foo.js -> foo) in modules.json, and also we can identify more as explicit variables, so that no-unused-vars can detect them.

Differential Revision: https://phabricator.services.mozilla.com/D13299

--HG--
extra : moz-landing-system : lando
2018-12-06 17:27:56 +00:00
Dão Gottwald 859de3e25b Bug 1510579 - Load scripts in global-scripts.inc the same way browser.xul does. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D13237

--HG--
extra : moz-landing-system : lando
2018-11-28 16:13:16 +00:00
Dão Gottwald 0f23fd4558 Bug 1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D13064

--HG--
extra : moz-landing-system : lando
2018-11-27 21:55:21 +00:00
Mark Banner 235ab837b2 Bug 1509270 - Allow 'location' as a writeable global property for ESLint (previously read-only). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D12748

--HG--
extra : moz-landing-system : lando
2018-11-27 18:55:11 +00:00
Mark Banner 84c4aa45ce Bug 1502048 - Update the list of ESLint globals for recent JSM scope changes. r=nika,mossop
This patch creates a new list of privileged globals, based on the webidl bindings. The list of jsm globals is reduced to only the ones specially extended to that scope.

The privileged globals are enabled everywhere for the time being - although we likely could limit scopes, doing so is difficult with our current mozilla-central layout and configuration settings.

Differential Revision: https://phabricator.services.mozilla.com/D12302

--HG--
extra : moz-landing-system : lando
2018-11-22 16:46:19 +00:00
Mark Banner 8fb3e110a9 Bug 1508322 - Define 'importGlobalProperties' variables as explicit in ESLint to help identify unused variables. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D12327

--HG--
extra : moz-landing-system : lando
2018-11-19 18:23:16 +00:00
Andrea Marchesini e4c7d00316 Bug 1492036 - Reporting API - part 5 - tests, r=smaug 2018-11-14 20:02:33 +01:00
Junior Hsu 1dbcaab155 Bug 1504323 - P2 Enable ESLint for netwerk/test/httpserver/ (manual changes) r=Standard8,dragana
Differential Revision: https://phabricator.services.mozilla.com/D10986

--HG--
extra : moz-landing-system : lando
2018-11-09 11:28:32 +00:00
Mark Striemer 1f6ce6a3f9 Bug 1504890 - Restrict usage of event global r=Standard8,ahal
The event global is only available on Nightly so it should not be used.

Differential Revision: https://phabricator.services.mozilla.com/D10984
Differential Revision: https://phabricator.services.mozilla.com/D11125

--HG--
extra : rebase_source : 43d8c198a1eb9c633922d077a219f1cf17b811c1
2018-11-06 16:35:05 -06:00
Kris Maglione 288ea557d8 Bug 1482091: Part 1 - Add native TelemetryStopwatch implementation. r=chutten,mccr8
This implementation is considerably more memory efficient than the existing JS
implementation. Migrating to it fully saves us about 28K per base content
process.

Differential Revision: https://phabricator.services.mozilla.com/D9887

--HG--
extra : source : a19c6b3e0402d16a77185f82d9fedab83a7ca52e
extra : intermediate-source : 28a19b7290ab288a1cb2cbf6d49f905cecc9682b
2018-10-26 13:17:55 -07:00
arthur.iakab 0c81738411 Backed out 2 changesets (bug 1482091) for bc failures on browser_domFullscreen_fullscreenMode.js
Backed out changeset bc03f101937e (bug 1482091)
Backed out changeset 28a19b7290ab (bug 1482091)
2018-11-03 01:08:36 +02:00
Kris Maglione bee3f68fdc Bug 1482091: Part 1 - Add native TelemetryStopwatch implementation. r=chutten,mccr8
This implementation is considerably more memory efficient than the existing JS
implementation. Migrating to it fully saves us about 28K per base content
process.

Differential Revision: https://phabricator.services.mozilla.com/D9887

--HG--
extra : source : a19c6b3e0402d16a77185f82d9fedab83a7ca52e
2018-10-26 13:17:55 -07:00
arthur.iakab cf2aa54f83 Backed out 2 changesets (bug 1482091)for failing browser chrome failures on browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
Backed out changeset afd0a13bcfff (bug 1482091)
Backed out changeset a19c6b3e0402 (bug 1482091)
2018-11-02 23:01:15 +02:00
Kris Maglione 4bd1fb01dd Bug 1482091: Part 1 - Add native TelemetryStopwatch implementation. r=chutten,mccr8
This implementation is considerably more memory efficient than the existing JS
implementation. Migrating to it fully saves us about 28K per base content
process.

Differential Revision: https://phabricator.services.mozilla.com/D9887

--HG--
extra : rebase_source : f358f1f7097eaa8cd62ae916d048a58489e9f5ff
extra : histedit_source : c44c42de02750d71e23e70fdf22d3c3a40b91d3d
2018-10-26 13:17:55 -07:00
Julian Descottes 260b1e16a3 Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 13:50:27 +00:00
Csoregi Natalia faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes 8e101fd73a Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 11:12:37 +00:00
Mark Banner 0909ebdd11 Bug 1500483 - Clarify the type of window that should be passed to UrlbarController, and tidy usages of the window in the controller. r=mak
Depends on D9926

Differential Revision: https://phabricator.services.mozilla.com/D9927

--HG--
extra : moz-landing-system : lando
2018-10-29 10:23:31 +00:00
Nika Layzell 84828b5af3 Bug 1501124 - Switch BackstagePass to use WebIDLGlobalNameHash, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D9736
2018-10-25 10:24:36 -04:00
Mark Banner ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Gijs Kruitbosch 9048f58f8f Bug 1477669 - remove feed preview code and associated files/code, r=flod,mak,nika
Differential Revision: https://phabricator.services.mozilla.com/D8524

--HG--
extra : moz-landing-system : lando
2018-10-16 12:47:36 +00:00
Doug Thayer 218843ef6a Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak
See https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit#
for further info. This essentially follows the same philosophy as
the onVisits migration.

MozReview-Commit-ID: I4bOvFH0ZQR

Depends on D4605

Differential Revision: https://phabricator.services.mozilla.com/D4606

--HG--
extra : moz-landing-system : lando
2018-10-09 14:47:27 +00:00
Brian Grinstead eaaac5ca03 Bug 1460982 - Convert <searchbar> to a Custom Element;r=adw
Differential Revision: https://phabricator.services.mozilla.com/D5912

--HG--
rename : browser/components/search/content/search.xml => browser/components/search/content/searchbar.js
extra : moz-landing-system : lando
2018-09-27 23:09:55 +00:00
Mark Banner e749f1b196 Bug 1469384 - Allow no-useless-removeEventListener to not throw if only one argument is given to an addEventListener call. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D5882

--HG--
extra : moz-landing-system : lando
2018-09-14 17:05:09 +00:00
Robert Helmer 7d4c15f217 Bug 1465251 - use PrioEncoder to encode Telemetry values for pilot project r=kmag
Use PrioEncoder to encode a few already-included histograms, so we can compare results on the Telemetry server side.

Differential Revision: https://phabricator.services.mozilla.com/D5088

--HG--
extra : moz-landing-system : lando
2018-09-09 00:23:52 +00:00
Mark Banner c6885f5391 Bug 1488445 - Remove and replace obsolete ESLint rules. r=mossop
This removes a number of references to rules that are now deprecated or removed from ESLint.

- no-native-reassign is replaced with no-global-assign
- no-spaced-func is replaced with func-call-spacing (where enabled)

Depends on D4944

Differential Revision: https://phabricator.services.mozilla.com/D4946

--HG--
extra : moz-landing-system : lando
2018-09-04 18:08:43 +00:00
Mark Banner 56437d9aed Bug 1488445 - Change the ESLint configuration to extend from eslint:recommended. r=mossop
This enables the following extra rules over the current configuration:

- for-direction
- no-compare-neg-zero
- no-new-symbol
- no-this-before-super

Other rules that are in eslint:recommended but not in our configuration are turned off for now.

Differential Revision: https://phabricator.services.mozilla.com/D4944

--HG--
extra : moz-landing-system : lando
2018-09-04 18:08:41 +00:00
Coroiu Cristina 83cdfe7284 Merge mozilla-central to inbound a=merge on a CLOSED TREE 2018-08-31 19:35:06 +03:00
Mark Banner afb520e82a Bug 1486739 - Enable ESLint rule comma-dangle for browser/, services/, taskcluster/ and toolkit/ directories. r=mossop
Enable globally by default by blacklist directories outside of the ones we're enabling. Remove now unnecessary existing configurations.

Differential Revision: https://phabricator.services.mozilla.com/D4440

--HG--
extra : moz-landing-system : lando
2018-08-31 06:06:08 +00:00
Dave Townsend e63bb1c465 Bug 1487246: Enable the eslint no-sequences rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D4681

--HG--
extra : rebase_source : ae253571d7d47c4a113a98a8b7c29bf712a0d764
2018-08-29 16:15:33 -07:00
Mark Banner 226dbd7bdc Bug 1456078 - Upgrade ESLint to version 5.3.0, and eslint-plugin-html to 4.0.5. r=mossop
MozReview-Commit-ID: 7yvvXKxYodA

Differential Revision: https://phabricator.services.mozilla.com/D2834

--HG--
extra : moz-landing-system : lando
2018-08-07 14:46:19 +00:00
Mark Banner fa8ec6d453 Bug 1456078 - Enable eslint-plugin-mozilla's parsing of HTML files to understand script tags with type="module". r=mossop
MozReview-Commit-ID: LpmqJI5s4aX

Differential Revision: https://phabricator.services.mozilla.com/D2833

--HG--
extra : moz-landing-system : lando
2018-08-07 14:46:37 +00:00
Mark Banner 17b4516d3c Bug 1478305 - Update ESLint to treat ChromeUtils.import definitions as real variable definitions for single-export modules. r=mossop
One minor issue with this method, is that we are unable to support exported definitions without further work. This may cause false-positives if items are exported. However, this is already the case with the other import mechanisms, and the benefits seem to be larger than the disadvantages here.

MozReview-Commit-ID: 4fx2aLRBt7T

--HG--
extra : rebase_source : 1e24c8d9bc2773e80c37f47feca781be53321616
2018-07-25 08:50:54 +01:00
Mark Banner 3fa6f1c498 Bug 1478305 - For xpcshell-test head files, limit checking no-unused-vars to the local scope only. r=mossop
MozReview-Commit-ID: 2m37fyF6YwD

--HG--
extra : rebase_source : 523876c41599975199158700d7d53f096d25215c
2018-07-30 11:14:54 +01:00
Tim Nguyen 2ec98e736f Bug 1475978 - Add chromeOuterWindowID global to mozilla/frame-script ESLint environment. r=mconley
MozReview-Commit-ID: FYfTDDY2d8j

--HG--
extra : rebase_source : b225e887b279305043511d8d7be5b92f642e7420
2018-07-16 14:36:35 +01:00
Brian Grinstead e4a52ebc1f Bug 1445764 - Remove some Places special casing in eslint configurations;r=standard8
MozReview-Commit-ID: BKOTaZZxo1b

--HG--
extra : rebase_source : 2d59283291529ad174bf15bb712cb62e1cce1da1
2018-07-03 14:26:54 -07:00
Mark Banner 8e380d8bad Bug 1452706 - Remove the now redundant ESLint rule require-expected-throws-or-rejects. r=mikedeboer
MozReview-Commit-ID: 7CXrVV6x5I6

--HG--
extra : rebase_source : b909948af64007350e92ca75b7ff0ce602a9add9
2018-07-03 20:22:01 +01:00
Coroiu Cristina e631b8c1ea Backed out 3 changesets (bug 1452706) for xpcshell failures at devtools/server/tests/unit/test_format_command.js
Backed out changeset 6abc5dc6baaf (bug 1452706)
Backed out changeset 4fbd34b0807a (bug 1452706)
Backed out changeset 626c790eb6f3 (bug 1452706)
2018-07-04 21:20:21 +03:00
Mark Banner 7a479a6ef5 Bug 1452706 - Remove the now redundant ESLint rule require-expected-throws-or-rejects. r=mikedeboer
MozReview-Commit-ID: 7CXrVV6x5I6

--HG--
extra : rebase_source : ade528621c748547192e562a2fee2f6db9d009ef
2018-07-03 20:22:01 +01:00
Rok Garbas 2a544047c6 Bug 1471541 - switch to new tooltool url, r=jlund
--HG--
extra : rebase_source : 85cd6f1e78ec293d5c9fba8d41b31b5ca8bc521e
2018-07-03 15:35:58 -07:00
Doug Thayer ed2a0623d0 Bug 1340498 - Add new globals to lint config r=standard8
MozReview-Commit-ID: 360gup8cWvi

--HG--
extra : rebase_source : 0d5a0c4e867a0526e4e37b521dbf9d2965c1e5f6
2018-01-29 11:07:28 -08:00