Automatic update from web-platform-tests
[LayoutNG] HasBlockFragmentation() -> InvolvedInBlockFragmentation()
Similar to CL:2843465, update the checks from HasBlockFragmentation() to
InvolvedInBlockFragmentation() before calling FinishFragmentation()
in the fieldset and multicol layout algorithms.
Bug: 829028
Change-Id: I5f5e4601ae0db524b03d9e2cccad115cdc9c791e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3134312
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917312}
--
wpt-commits: 6df4ea72da452abcbc0075b81957bbc962a462e2
wpt-pr: 30278
Automatic update from web-platform-tests
[ResourceTiming]: Update iframe-failed-commit.html WPT
This change updates wpt/resource-timing/iframe-failed-commit.html to
conform to the new style guidelines in
wpt/resource-timing/CodingConventions.md.
GithubIssue: https://github.com/w3c/resource-timing/issues/254
Bug: 1171767
Change-Id: Ica54e4ea7fe9ae74bb1fa4274c803297577face8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3134283
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917277}
--
wpt-commits: f3d3029b18e579c83ee09a5dccb7adbba9cd47d8
wpt-pr: 30277
Automatic update from web-platform-tests
Add support for relative URLs in Subresource Loading from WebBundles.
When using a 'resources' attribute in the <link> element with WebBundles
we only use absolute URLs to said resources. This change makes it so we
can use relative URLs instead and resolve them with the page's base URL.
<base> element can cause a dynamic change in the base URL, which we
should support. This will be done in a follow-up CL.
Bug: 1213335, 1244483
Change-Id: I6a2169ba697c102208f7488eef2debc8674cba7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059820
Commit-Queue: Miras Myrzakerey <myrzakereyms@google.com>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917201}
--
wpt-commits: 539f10ded71c181492ebbea454d22162f5e85635
wpt-pr: 29834
Automatic update from web-platform-tests
Add manual WPT for file handling. (#30128)
Note that to test this in Chrome with run_blink_wptserve.py, Chrome
must be started with:
--ignore-certificate-errors --enable-features=FileHandlingAPI
Bug: 1240389
Change-Id: I9462a48fa8c69beb596c23ecec878c262fad3027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3114865
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915261}
Co-authored-by: Evan Stade <estade@chromium.org>
--
wpt-commits: 42a57900ee61b9b10d81952c8c6ff3d3d096eccf
wpt-pr: 30128
Automatic update from web-platform-tests
Increase bandwidth of fake video signal used for testing. (#30226)
This will increase the size of an encoded 640x480 video from
approximately 8 Kbits/second to approximately 64 Kbits/second, which
means that limiting the bandwidth will actually have an effect.
This is done in preparation for further tests that limit the bandwidth
and expect an observable result.
Bug: None
Change-Id: Ib3c63c4ae8c41fe7c608f1c06c8c61c2beecbe11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3128063
Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916377}
Co-authored-by: Harald Alvestrand <hta@chromium.org>
--
wpt-commits: ed9b278329b48455b62195b32be8aa0f40812de5
wpt-pr: 30226
Automatic update from web-platform-tests
Replace forced-break-in-nested-columns.html with a correct WPT test.
The old test was assuming a legacy engine implementation limitation,
where we're unable to push the first fragment of a multicol container to
the next outer fragmentainer if there was no room for its contents in
the current outer fragmentainer.
In the test, see the first DIV child of the inner .mc. The legacy engine
would just push the line inside that DIV to the next outer
fragmentainer, even if there's no valid breakpoint there. The correct
behavior is to push the first fragment of the inner multicol container
itself to the next outer fragmentainer (there's a perfect breakpoint
after the first DIV child of the outer .mc. LayoutNG block fragmentation
gets this right.
Bug: 829028
Change-Id: I55950c5aad3418b49dabe12debd43317cf578c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3135656
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917263}
--
wpt-commits: 48655d84e0d96d6bfe1ce0446a291f3379f1e5ff
wpt-pr: 30286
Automatic update from web-platform-tests
[webid] Expose WebID as an extension of the Credential Manager API.
Overloads FederatedCredential adding new attributes as well as static
methods to support the mediated of the Account Chooser for
FederatedCredentials.
Explainer: https://github.com/WICG/WebID
I2P https://groups.google.com/a/chromium.org/g/blink-dev/c/2B4TJ7j2U4M
Spec Draft: https://wicg.github.io/WebID
Change-Id: I2176ea4e687b9ac3fe7387e5658cf5c4adcfc6b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3123775
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917241}
--
wpt-commits: 04ffcc174898cbb842ebd4a9d8751ac40ae432a9
wpt-pr: 30248
The flags contain names of old contributers, which makes them inconvient
to use. Now it's also possible to simply enable logging for release
builds.
Differential Revision: https://phabricator.services.mozilla.com/D124445
The `tempfile.tempdir` cache value isn't always populated, but
`tempfile.gettempdir()` always is. They both provide the same result.
Differential Revision: https://phabricator.services.mozilla.com/D124261
Not hooked anywhere yet, so this doesn't change behavior, but adds the
basic data model etc.
Adding parsing support requires some changes to cssparser to allow the
same at rule to be block and statement-like at the same time, so better
done separately.
Differential Revision: https://phabricator.services.mozilla.com/D124079
Bug 1631193 / D71448 reenabled the X11 socket on Wayland and disabled
the Wayland socket as the Wayland backend is not the default yet.
While giving access to the X11 socket by default was right,
dropping the Wayland socket makes testing it unnecessarily
complicated and provides negligible security benefits - Wayland,
in contrast to X11, is designed to be save. This is also reflected
in Flatpak: while for X11 there is the `fallback-x11` option,
the same is not exposed for Wayland.
Thus lets enable the Wayland socket again, in order so make testing
easier, helping making the Wayland backend the default sooner, which
then is an actual security benefit.
Differential Revision: https://phabricator.services.mozilla.com/D124139
See the discussion here: https://twitter.com/Rich_Harris/status/1433153204678799365
This should make attribute selectors roughly as fast as class selectors.
I think it's worth trying and see if perf bots complain on
micro-benchmarks and stylebench and such.
I made attributes more specific than local names, but less specific than
classes, which I think makes sense. When doing something like
foo[data-bar], filtering by data-bar seems likely to yield less elements
than filtering by foo.
While at it, remove the bloom filter pref since we shipped it in
bug 1704551 for 87 and we haven't heard complaints.
Differential Revision: https://phabricator.services.mozilla.com/D124383
Also, more directly go from StyleImageRendering to wr::ImageRendering.
* image-rendering: smooth the non-deprecated version of
OptimizeQuality, which maps to SamplingFilter::LINEAR /
wr::ImageRendering::Auto (which uses gl::LINEAR).
* image-rendering: pixelated maps to wr::ImageRendering::Pixelated /
SamplingFilter::POINT which is the same crisp-edges does.
Note that this uncovers that we were mapping image-rendering:
crisp-edges to wr::ImageRendering::Pixelated.
I'm going to preserve behavior on this patch but we should consider
switching that to map to wr::ImageRendering::CrispEdges on a
follow-up (filed bug 1728831 for this).
Differential Revision: https://phabricator.services.mozilla.com/D124378
Not sure we even need this anymore but just doing this so I can finish the fission audit.
Added way back in bug 588407.
This shouldn't actually be any behaviour change: anything that is IsRootContentDocumentInProcess but not IsRootContentDocumentCrossProcess should be a oop if with fission (unless I'm missing a case), so we will never hit this code path, we'll hit the remote iframe path above.
Differential Revision: https://phabricator.services.mozilla.com/D124277
Fix a bug where the display item cache was not being reused from
frame to frame with retained display list builders.
At the same time, make the capacity recycling on the display list
serialization arrays a bit more realistic.
Differential Revision: https://phabricator.services.mozilla.com/D124412
This code was originally added in https://hg.mozilla.org/mozilla-central/rev/5a7de0eb94fe1e24f4fc292020d6ac57672cbe58
The ignoreViewportScrolling indicates it was for containerful scrolling.
Nowadays the only use of ignoreViewportScrolling is when this function is called via PresShell::RenderDocument, which means we aren't sending the results to the compositor in a structured form, and so scroll ids etc don't matter. We can remove this dead code.
It should we fine to go into the following "else if"s in all cases without having to be the else of the if we are removing here.
Differential Revision: https://phabricator.services.mozilla.com/D124306
This is odd code (that I probably wrote): it's appears to be designed to handle in process, zoomable, root content documents where the ancestor chrome document(s) can have non-1 resolution.
I think the important thing here is that the root scroll frame of the RootContentDocumentCrossProcess gets a resolution of 1, otherwise we use the cumulativeResolution of the current presshell.
Differential Revision: https://phabricator.services.mozilla.com/D124305
AFAICT these functions are interested in documents at the root of a tab, not ones that happen to be at the root of a process.
Differential Revision: https://phabricator.services.mozilla.com/D124274
While investigating an unexpected test failure triggered by a mochitest that was testing the identity WebExtensions API
(D121683 from Bug 1723852) I did notice that the actual underlying issue was triggered by a leak
(in particular the Extension API class in the initial draft of that D121683 patch was missing a RefPtr
in the NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE macro used for that class) but the issue was presenting
itself as an empty scriptURL in the ClientSource for the test case that was executed after the one that
triggered tha leak, and far enough from where it was actually triggered.
To make it easier to spot the issue nearer to the actual underlying issue, I think that it would be
reasonable to add a diagnostic assertion to ClientManager::GetOrCreateForCurrentThread that would
be triggered earlier if a leak was keeping the ClientManager instance alive in the idle DOM Worker
Thread.
Differential Revision: https://phabricator.services.mozilla.com/D123530
Also, more directly go from StyleImageRendering to wr::ImageRendering.
* image-rendering: smooth the non-deprecated version of
OptimizeQuality, which maps to SamplingFilter::LINEAR /
wr::ImageRendering::Auto (which uses gl::LINEAR).
* image-rendering: pixelated maps to wr::ImageRendering::Pixelated /
SamplingFilter::POINT which is the same crisp-edges does.
Note that this uncovers that we were mapping image-rendering:
crisp-edges to wr::ImageRendering::Pixelated.
I'm going to preserve behavior on this patch but we should consider
switching that to map to wr::ImageRendering::CrispEdges on a
follow-up (filed bug 1728831 for this).
Differential Revision: https://phabricator.services.mozilla.com/D124378
moz-wptsync-bot
Alison Maher
Tom McKee
Miras Myrzakerey
Blink WPT Bot
Morten Stenshorne
Sam Goto
Mirko Brodesser
Mitchell Hentges
Andrei Oprea
Andrew Osmond
Andreas Farre
Alex Finder
Emilio Cobos Álvarez
criss
Robert Mader
André Bargull
Timothy Nikkel
Noemi Erli
Glenn Watson
Alexandru Michis
Niklas Baumgardner
Dragana Damjanovic
Luca Greco
Aki Sasaki
Rob Wu
Steve Fink